From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 037D9A09E0;
Fri, 13 Nov 2020 14:16:58 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 7B74B4CA6;
Fri, 13 Nov 2020 14:16:56 +0100 (CET)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by dpdk.org (Postfix) with ESMTP id 8B3744C96
for <dev@dpdk.org>; Fri, 13 Nov 2020 14:16:54 +0100 (CET)
IronPort-SDR: QZ1KhGgzcwlGP22iws27oSwGLuyGUO9zYx6By2OP3Xaq6uV+rEOo5glQCglGUkoObvEgBGuZ/v
n/UTS041BSpw==
X-IronPort-AV: E=McAfee;i="6000,8403,9803"; a="149738828"
X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="149738828"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
13 Nov 2020 05:16:43 -0800
IronPort-SDR: +5ePSYipMSbqkc2xLYi2YvLqVSH7dZeT8dNejCXWlEDtGp2BDSNDP3vv+rkhCT6OwYXbchVnyb
414nDvyFz6nQ==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="323987406"
Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16])
by orsmga003.jf.intel.com with ESMTP; 13 Nov 2020 05:16:41 -0800
Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by
ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.1713.5; Fri, 13 Nov 2020 05:16:41 -0800
Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by
ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.1713.5; Fri, 13 Nov 2020 05:16:40 -0800
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5
via Frontend Transport; Fri, 13 Nov 2020 05:16:40 -0800
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172)
by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.1713.5; Fri, 13 Nov 2020 05:16:40 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=jQDEbiCPtZjRlHHvjaz/EcYx8Gl4tBwWiUH84nD80teBDB5COnmEQACI4un2bTNBas6+9skj3XYipelILKNlsg9da3x56//VIcWqXLOti9NnJcT09NvxKy6EdeaA7Vu9zIaxMtjAksHdpLSsLFr4jU210TrpXOiDP3vipi0uGFREbjB7T5CwmBGHu4PcGYwA1dhtbDX0yHVYebvCzwgxq2bfWCkfSC959L2T1aZnbUJl6vPVWLQ54e1HRygIX9iT5mN6aKfJSME95DZRRIM/FYrlfgqKoYcJiAnzn3zsK6qGimB7i6m5ln8VG7F7gi3mS4tdrlRtez6dhd//Eg8+KA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=jQUSoyLGIQn6wGLGMy4gol4iMD5tYXlp5hLDx0frG4A=;
b=evXg+ghzd+heRt7btFEcg7eaoCfvhbYMJayEfV9SFeOMajl2lmmktgNn6r3HQNUozZYV7Wj9az9IoEvLYWm1KvxtgqP4n52+O9pvFImEimv94EU5isrN90EP92JA9d+jOUyfmCNZYmE85jL151t/jLSt3GFr3jXlM1UT5tQHXLR7SVA9MRqhS/bjT+rRtDA6g1eFSnhEghYtYldsx5vN9QF4cv7ZVLxPkHJjKm5ttzHBnjyYr9ZcMemiYY52KHNf137UJODQUonEchk5mReUWSBDuic4eA7nQGGPYVH2DzKVG5W+dO/JBCDLqhJwbh4SY1Vi2OoSwhvPDFfhAPOLSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=jQUSoyLGIQn6wGLGMy4gol4iMD5tYXlp5hLDx0frG4A=;
b=GEFlBcNblZLzIdPugOqDJyEuEHkK3oiR7zEmshdIk8Pc6bPa13hQLGn83uaB7+xfwdc8iJDZdQC2YTAVlnS4r0q6zBo5ZkjrdCJnN3Lm+UNmNzp8YrDNlwyDUlRzniKlBcPhBJMr23p6j8R9ruxVmPSKpUlFrVFm8Y0cwlnI2Uw=
Received: from DM6PR11MB3308.namprd11.prod.outlook.com (2603:10b6:5:d::22) by
DM6PR11MB2619.namprd11.prod.outlook.com (2603:10b6:5:c6::25) with
Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.3541.25; Fri, 13 Nov 2020 13:16:38 +0000
Received: from DM6PR11MB3308.namprd11.prod.outlook.com
([fe80::fd2d:9bbb:599e:72dd]) by DM6PR11MB3308.namprd11.prod.outlook.com
([fe80::fd2d:9bbb:599e:72dd%6]) with mapi id 15.20.3541.021; Fri, 13 Nov 2020
13:16:38 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "yang_y_yi@163.com" <yang_y_yi@163.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Hu, Jiayu" <jiayu.hu@intel.com>, "thomas@monjalon.net"
<thomas@monjalon.net>, "yangyi01@inspur.com" <yangyi01@inspur.com>
Thread-Topic: [PATCH v2] gso: add VXLAN UDP GSO support
Thread-Index: AQHWtwhGWO1h49qQ6kexvHIKAocNKqnGD4gw
Date: Fri, 13 Nov 2020 13:16:38 +0000
Message-ID: <DM6PR11MB3308A8F493FC43A19B79B99C9AE60@DM6PR11MB3308.namprd11.prod.outlook.com>
References: <20200701064643.216084-1-yang_y_yi@163.com>
<20201110022130.179352-1-yang_y_yi@163.com>
In-Reply-To: <20201110022130.179352-1-yang_y_yi@163.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
authentication-results: 163.com; dkim=none (message not signed)
header.d=none;163.com; dmarc=none action=none header.from=intel.com;
x-originating-ip: [46.7.39.127]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0aa08a9d-af8f-4924-40ca-08d887d65a57
x-ms-traffictypediagnostic: DM6PR11MB2619:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM6PR11MB2619EF976CE1A5C344F3438A9AE60@DM6PR11MB2619.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3173;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 0kn4KA7E1OVeAQR0AWHDZbsMcHFhrQ0RqRLXzdTGosgDsmKIxnrXo77oPD88n0gvK9ML68UJER9E2SJkHIVBKXqMesPJMjEhjs6bBD/6Q8oC0c5zvIX6wP+OZ2Kqxann8pJM7ByOxShzDPYKGq/HAE6afV4P3vCQzPZyP2L73sStOAfcO//U27Bf3X/N5koJRz6nVFKi8mwG6nPim5IbkJmCgq3+S3cRaPMIWf0LFqF6Y4N3rGpwxH6qCEYPp0/YC6TBXEa/A6HNTx0+uIP0THw2TOtJYTuuzIYBcHZx2+NsS9fMl9Z//pzTGqtD+7Nb
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:DM6PR11MB3308.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(64756008)(66946007)(7696005)(186003)(6506007)(52536014)(4326008)(33656002)(8676002)(2906002)(9686003)(5660300002)(478600001)(55016002)(66446008)(110136005)(54906003)(66556008)(76116006)(66476007)(8936002)(26005)(71200400001)(86362001)(316002);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: vLAEqTR1jnbDAmFSGZ+7Jm5myyY6CQKtdKDSocB8IElqTKF7Mh9Xop1FN/GroaFqUoJVu3qiUvPRYzivaVtk2FJlpLQqB5hUihAeBPox4IEyHNG7GftEsQXQ95RztOjZPGQQedsMmzaGGuwJez4Zb453M/yX8+fQP0lPoRFlYjwgHHr26OXKWLS1C/ZOF1V1pt/hkmwuhNKoSjjvDZkscsdAtMJYZ2XFhMpzaYPNBBqkZbioZmkGpB015tWah19v40oq2bYN199pQgGf/AKK8xBKvbnqPn9HaDV7jC4dHwQZ6F+BiHCaXSJOIkO+iIghUQUcQfO6x2k8ZlGuj0r7i1WyGQN/W0qerC/5sQgajBafxN1XAJQILU3vMjw3TUGr/BDjvkOtH7tP+Q5owxJlkCt6+T8TyUsS9tYnCNOWsAVHLgrP48J5D8kWrVPD1AyHwA+h2SMpcbbbMG2KlXhCAc/KpX3oanX/mP6VUb5VSdlhiJW0dB+GOC0ThxniOBLIyuS4itl5w1kl8bYRncpghSs9uops1+9mBExesYo3vJxWiBUobHCdv1X/XKqd/2GgYz8f88XtJhvw2h2fdFpi2Y3R5gdYqRByxGzlB6MAbEmW9befhm6SdC/lEhlQHG3pUMJpSJ/gYQ33XH4BhnqErQ==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3308.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0aa08a9d-af8f-4924-40ca-08d887d65a57
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2020 13:16:38.0664 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NBZENSshL4CmcTKUkfytQePij5roBGgMqeVxrqRgwMEJ3gvOVj6kmrRQPfH9ktrt10tWQE6OOOkOCVBp2xoBd4twPtYByAvp+XJrvK83bDA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2619
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v2] gso: add VXLAN UDP GSO support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
...
> diff --git a/lib/librte_gso/rte_gso.c b/lib/librte_gso/rte_gso.c
> index 896350e..fb76a21 100644
> --- a/lib/librte_gso/rte_gso.c
> +++ b/lib/librte_gso/rte_gso.c
> @@ -11,6 +11,7 @@
> #include "gso_common.h"
> #include "gso_tcp4.h"
> #include "gso_tunnel_tcp4.h"
> +#include "gso_tunnel_udp4.h"
> #include "gso_udp4.h"
>=20
> #define ILLEGAL_UDP_GSO_CTX(ctx) \
> @@ -60,6 +61,13 @@
> ret =3D gso_tunnel_tcp4_segment(pkt, gso_size, ipid_delta,
> direct_pool, indirect_pool,
> pkts_out, nb_pkts_out);
> + } else if (IS_IPV4_VXLAN_UDP4(pkt->ol_flags) &&
> + (gso_ctx->gso_types & (DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
> + DEV_TX_OFFLOAD_UDP_TSO))) {
That check would succeed even if DEV_TX_OFFLOAD_VXLAN_TNL_TSO flag is not s=
et.
Is it supposed to be like that?
> + pkt->ol_flags &=3D (~PKT_TX_UDP_SEG);
> + ret =3D gso_tunnel_udp4_segment(pkt, gso_size,
> + direct_pool, indirect_pool,
> + pkts_out, nb_pkts_out);
> } else if (IS_IPV4_TCP(pkt->ol_flags) &&
> (gso_ctx->gso_types & DEV_TX_OFFLOAD_TCP_TSO)) {
> pkt->ol_flags &=3D (~PKT_TX_TCP_SEG);
> --
> 1.8.3.1