From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 844DAA0547; Wed, 12 Oct 2022 08:09:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 617C940691; Wed, 12 Oct 2022 08:09:01 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id CF8EC4067C for ; Wed, 12 Oct 2022 08:08:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665554940; x=1697090940; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=D2AjCyM9Cf1N4W19a4pJznN7sGy4VjeJ45qgPhI621U=; b=W+v7Afo7TuaXBG/ogmQaTrKwryHIciy+cw5ih4PsZA3hFu6brfzlG8wL 9YsWxHNsuvTfOUXAh+wFaSuBs+W32HiIU/mPexl74Twu8mBBmaUNZS0pK 2lvwoy/9jNA3vebzwIBFQM/Jut7JdMF3q/8v3HibExoFCRVSfyJulYQbL +veV+ErPt+sLstI5xigA+nL3lD8LKIt8Bczb60tIT8CdWOdR5nenkYIr8 ZvRPoBarxhTM1llLYVjpTGaQEbVDSWGyAD7lKikKretOLVKh99xXVXgjR 48x3MKP+4MH6NStlCSWG8OL9xj7kdMLnEEASiNwOHRXq8PLGxpbse/Nrn w==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="366707898" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="366707898" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 23:08:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="689536826" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="689536826" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga008.fm.intel.com with ESMTP; 11 Oct 2022 23:08:58 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 23:08:58 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 23:08:57 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 11 Oct 2022 23:08:57 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 11 Oct 2022 23:08:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ld6AQ+eJCwHkPGW4Akr/FcyjCfpKUg8Alocu+WnLsc14lmvf9z/JZDl3xzQXX/Qj0HzZlxWyp2ORodSH/KkW84gid7y8in1ZwN5uLdtTeP7YO9nqoSS3R2FGUWWxip2CLEmQ2X86lLWXi2y99dSWys4cHnfj8dvwUURbgaqa43vrsdxZw1Nog35LYSiBOeBYJ+cnsVixz3Mg7KdeFDlpSj2opzaR8HruyVpEFur5lnvme1paSrExjZ931qEOSmG4YTyTsQ7ahyZPSWU3bDP7Kh93UbNEhVjMzVna3ddx4h2YkqkiNf+q/1T5vQ1Bd2Gff6C+bIl6ELtLKiYBkyRI9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iGgBgFW2vyyl5cP8p6BsdzZfESkFaXV65zWD42SuAmw=; b=fjUWXDEc6r1tiDeDGjL+wpngAEBZ1N3Avsv+q//yr609jtmeX70KwnDZOziyOcM5ErSmmuIPdsimyWHsisngE+Yk9+CcHg4rPNF3cG2dvTdHhmMW4kK9uI3CPKVX0s9HAhcowzlEmcQxkEI2+pvaZmESGX7Dd3tqbo7Vt39cktppT76bU96OnG1HOCfNZVvNOeKwzHZ4jWJxDtAj5Uf0mXISSVWficfoZiGAiGsjbS2D4yIp6gVIBhPDCl4S61ccBxJHlaS4O1Ug3gKiENwsdIYZujJaQeoUt+PFKPyVOp/+0yveDPjeSxFEpZIXMo8LOVFJS0fRglIBd7AHgc2sxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3499.namprd11.prod.outlook.com (2603:10b6:5:61::24) by SA1PR11MB5804.namprd11.prod.outlook.com (2603:10b6:806:237::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct 2022 06:08:55 +0000 Received: from DM6PR11MB3499.namprd11.prod.outlook.com ([fe80::3e93:372f:d01:c4f2]) by DM6PR11MB3499.namprd11.prod.outlook.com ([fe80::3e93:372f:d01:c4f2%2]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022 06:08:55 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec Thread-Topic: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec Thread-Index: AQHYyZPna+E12LRgLUaid225pVMmIq4KbIVQ Date: Wed, 12 Oct 2022 06:08:55 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1663308990-621-1-git-send-email-andy.pei@intel.com> <1663308990-621-4-git-send-email-andy.pei@intel.com> In-Reply-To: <1663308990-621-4-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3499:EE_|SA1PR11MB5804:EE_ x-ms-office365-filtering-correlation-id: 6e05f8a3-4b7d-48e9-31bd-08daac183e7e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pmO+jm7i8Wec7VBhQDO6IIWFvnyo6mvPLzwi1h4hoEYRdYidrWLl43W0vFGlf9Q+iMF2vivW975VYZNyEJ8maZYSl+0AmgsMAxGKShMfBVnHYnN2Ak854YCVkgpdZwcYyu86MRzROYGNxpBjh3N+yds40Hv22KmPE8s9yoS8OQF4fvBTeSugLUvfi94I0VldyroyFbbT/AAEEq34nV95TnFVlH3wzZPQCavO1P0hjAS2oeeftQmvH4m7uiculTLnph6JiiCKSUtWUubaE5W242Zoca2qXEd+oC1BpcjbRnu2cwyRRL68D88qJTx9Sg4IMQQSEPCVgct+v1/kVD61O4kbbTN4NKzB5w2rx0m0Y3gRQYMLjilx2kHYWgTtjKoCtwjKeqgegfOtqtPTsifqM4s0Hl2m9VSvAyaAjmSFFZ9t+7lrbuNEgwuIVfi2LWU2wXu3W94AtgRZDjcIQYGDJMIOEhZQrw+AFKHUMaYxHeThDfZw9m0msfxvkeVCxrpCqknc76/52QfZhTQdW80xsI8QhiMg6rr+KRDrl0vvLw20jOvaZ1zO9vHjmmkvg6MuxKOz4U/SBBHAx6GG0d0OfyDP+03ULV34QWXRAJoN30+9jUu/22gqTGM0lWDSgmmku04LFoB9ZSraJH/zSkw1Us8aL5srafj29yt+ZuNBIcTgcNlgpfyE40XGhddeV9dX0oeFs4Q3xyXD9XFILO75Fh+e6KVmrVaPB9oThe1RctGVje90KDabC+aTN6pdGGo4SyN/KNIovpvmUkb2JvWUow== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3499.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(396003)(366004)(39860400002)(346002)(136003)(451199015)(52536014)(41300700001)(5660300002)(38100700002)(110136005)(54906003)(122000001)(4326008)(6506007)(71200400001)(478600001)(53546011)(66946007)(26005)(76116006)(33656002)(66446008)(8676002)(66556008)(7696005)(66476007)(64756008)(316002)(9686003)(38070700005)(2906002)(8936002)(86362001)(82960400001)(55016003)(186003)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mUWNyC18BoppIC6LQ+FDAP715Ja22DlY7/iWdkkHr7q5NRPIppaOARxGI5Jp?= =?us-ascii?Q?mzXA4i8nUotvjGBjfgbgpwjdjXSE9s7sdwvKtfhgS8RFzpSUQwQV3icLGoYc?= =?us-ascii?Q?+MPnlVWU5hsrYoRdr7DbobyMp0rmSFkmyVXbwANkB+2KFaS/IzUrpbazdrZA?= =?us-ascii?Q?ew8qP2YNiU7zm0EZNiRyU/cJkmDRz/G6aRBZ2VdqntYhdNPGUSsqo3CwH4ez?= =?us-ascii?Q?DXvewkoz3X2r0odDE5GK/jOukQWLvoNJbJ8jvN+jm66LxHpYRiXillD5e/Bk?= =?us-ascii?Q?mmN2tEOlamx+sJ+OI4nwWvjopb8Xb1ADz+8tVCLpclB/8bqWqou/zYvDnt1l?= =?us-ascii?Q?taC8clTN5eNZHF5qPTuxsDzviBXr70EmSJTP9gsv5qpIqDw1/te+bVgEhtjZ?= =?us-ascii?Q?FurU27JQHChyn6dCBkVEYQKZBefTubFrmxo3LoQqUWEu/lAL2tRQNHB6eFAE?= =?us-ascii?Q?J2fCdd5ewngeKT/WJF0njrSXyjT1/Xnjr2PR0XMHMAi+HO7oRl9hUuLNt4r5?= =?us-ascii?Q?X6ne9wjE+pdGi6NLRc+/etDBKg6K8oPQBhM5dgbI5mmRgNGOnEAzQHRxACYs?= =?us-ascii?Q?p1scgoIphcHIM1dQ4c/4EA24rSRdBn3O9QG7wT++0VWmpDUyAv6swZYeqXvW?= =?us-ascii?Q?1GBOHkH7dIGggvWsKk8ugMjaJu7Z6EDZgveTK48CUc7bhi56FebfNKZMjOg4?= =?us-ascii?Q?ORVOqhhOff0zAq5v4/6S4eLrN0nGi2yhuJAgIzgim9IWJhgcpfNLTCuXjGhc?= =?us-ascii?Q?BRMsJAlp8gt1cAw1t5fj4iVEh3yARJaweBoAtg/CV1EP3LEM6ktlG+ul2mmZ?= =?us-ascii?Q?4lHnF73w5UvmCKXsXrN3qv+PVNwCOgLbVMeHeOxqJLu8zf3FAXNIEr/DzDcI?= =?us-ascii?Q?lZsKyFUea9MR0pVjRxWGyqoEhxa1aCbrcP8jd1OStngClcln3BlS+L2vFBl3?= =?us-ascii?Q?RGLMQYKU1mPAGvG9fcXTW1P1FCtvr91wOzZcN7bzAvmfLOPMlQHjn4VSEtjX?= =?us-ascii?Q?eAkrnw8kS+5Pi7gTXzUOr0rDt1C4Yi4NsdcMhdgjHzcxdtFxjDLpIXmaE7ig?= =?us-ascii?Q?RYBEdWxZADBNgCfNeDlka6T0pdtP3/lzxlRiDoVK6Yeo8y9mtzsxa/HdfHIn?= =?us-ascii?Q?jx7G4UUgZAtyA3EHj9AV3ts8XhqtAmt/9YHgEnHqJGozlJGA0l3FinDq1EZM?= =?us-ascii?Q?TZTP9/7UtQAMCU+SAkBHhnXhK9xmuzGA7MJjOr3m2qFzlbL3PGfp1eZa7vfj?= =?us-ascii?Q?DjzwKQ067nFMiygOVc80J50/j4wVxN6btKrmfnTLbikqPQgUx3CIXZ1qgL51?= =?us-ascii?Q?jJKczEUfBKaxLQE8luLHnhUHdeXQN+QquYz0EzK9S2IrO6A8GhAyTiDtqtkj?= =?us-ascii?Q?1sW3VNrLzCZi6jRPCvEmKowq9w1Yg9fDWtYtzntPgBZvkD7hTS/UKw8QnYzM?= =?us-ascii?Q?nPPHYIC1WiBwmpTHcMmG7abAPLTf1t03tO3q7AneEudClLpDeukWKL9dL/uW?= =?us-ascii?Q?X7Ll3Me3f/OkBApkYZMcYu/+wt0BR2aEhvyvVZhBb2Zeh8SOrWTDF8KeYo14?= =?us-ascii?Q?BhxKxrwgSmS72AYuiFHT5q21q/+MaJDosNkfnGik?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3499.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e05f8a3-4b7d-48e9-31bd-08daac183e7e X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 06:08:55.3684 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iDFT3/Haxn3COUn49GYc51GVH6tBtYKTImc47EtrRUmCSqW0J55S6GLgCYM39+9N4OySQv5TMD2c7iXViDviCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5804 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Friday, September 16, 2022 2:16 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com > Subject: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec >=20 > Set max_queues according to virtio HW spec. Virtio spec > For virtio BLK device, set max_queues to the value of "num_queues". > "num_queues" is element of struct virtio_blk_config. Set max_queues to the value of num_queues in struct virtio_blk_config > For virtio NET device, read num_queues from truct ifcvf_pci_common_cfg, truct -> struct=20 > calculate "queue_pairs =3D (num_queues - 1) / 2" and get queue_pairs. > Set max_queues to the value of "queue_pairs". And say 'get the queue pair number using num_queues and set max_queues to i= t'. >=20 > Signed-off-by: Andy Pei > Signed-off-by: Huang Wei > --- > drivers/vdpa/ifc/base/ifcvf.h | 2 +- > drivers/vdpa/ifc/ifcvf_vdpa.c | 19 ++++++++++++++++++- > 2 files changed, 19 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.= h > index d16d9ab..1e133c0 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.h > +++ b/drivers/vdpa/ifc/base/ifcvf.h > @@ -21,7 +21,7 @@ > #define IFCVF_SUBSYS_NET_DEVICE_ID 0x0001 > #define IFCVF_SUBSYS_BLK_DEVICE_ID 0x0002 >=20 > -#define IFCVF_MAX_QUEUES 1 > +#define IFCVF_MAX_QUEUES 32 >=20 > #ifndef VIRTIO_F_IOMMU_PLATFORM > #define VIRTIO_F_IOMMU_PLATFORM 33 > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.= c > index 3e5ffba..376239a 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -26,6 +26,12 @@ >=20 > #include "base/ifcvf.h" >=20 > +/* > + * RTE_MIN() cannot be used since braced-group within expression allowed > + * only inside a function. > + */ > +#define MIN(v1, v2) ((v1) < (v2) ? (v1) : (v2)) > + > RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.vdpa.ifcvf, NOTICE); > #define DRV_LOG(level, fmt, args...) \ > rte_log(RTE_LOG_ ## level, ifcvf_vdpa_logtype, \ > @@ -1512,6 +1518,7 @@ struct rte_vdpa_dev_info dev_info[] =3D { > uint64_t capacity =3D 0; > uint8_t *byte; > uint32_t i; > + uint16_t queue_pairs; >=20 > if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) > return 0; > @@ -1559,7 +1566,6 @@ struct rte_vdpa_dev_info dev_info[] =3D { > } >=20 > internal->configured =3D 0; > - internal->max_queues =3D IFCVF_MAX_QUEUES; > features =3D ifcvf_get_features(&internal->hw); >=20 > device_id =3D ifcvf_pci_get_device_type(pci_dev); > @@ -1570,6 +1576,14 @@ struct rte_vdpa_dev_info dev_info[] =3D { >=20 > if (device_id =3D=3D VIRTIO_ID_NET) { > internal->hw.device_type =3D IFCVF_NET; > + /* > + * ifc driver always has CTRL_VQ, I think it's ifc _device_ has CTRL_VQ Thanks, Chenbo > + * and supports VIRTIO_NET_F_CTRL_VQ feature. > + */ > + queue_pairs =3D (internal->hw.common_cfg->num_queues - 1) / 2; > + DRV_LOG(INFO, "%s support %u queue pairs", pci_dev->name, > + queue_pairs); > + internal->max_queues =3D MIN(IFCVF_MAX_QUEUES, queue_pairs); > internal->features =3D features & > ~(1ULL << VIRTIO_F_IOMMU_PLATFORM); > internal->features |=3D dev_info[IFCVF_NET].features; > @@ -1609,6 +1623,9 @@ struct rte_vdpa_dev_info dev_info[] =3D { > internal->hw.blk_cfg->geometry.sectors); > DRV_LOG(DEBUG, "num_queues: 0x%08x", > internal->hw.blk_cfg->num_queues); > + > + internal->max_queues =3D MIN(IFCVF_MAX_QUEUES, > + internal->hw.blk_cfg->num_queues); > } >=20 > list->internal =3D internal; > -- > 1.8.3.1