From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64E57A0548; Fri, 9 Sep 2022 09:35:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E9E840DDC; Fri, 9 Sep 2022 09:35:06 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 422A240A7E for ; Fri, 9 Sep 2022 09:35:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662708904; x=1694244904; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=oWRjRZW3c9x5UD0RjOu3gp/Qs96BfUOIFLp4lcukP9o=; b=eX8ir69yEuRQXTTCzK2t3O1Jb+rvU6A5K2nQUmg0OQEH05jJzT7F9MdG WceqPR5/tWF0MRYAYYjFj3CaBjakkw8byXvpsHU15zgtqdltSZv0WkgsK qnuuc5JpKL0R61bXfVleE3b2A++JGaXrcvHg1B5oQMRlESAmstK4HWgpn KaeLLKus0ETV3k4VTFAjSw9Lp6FH7YCWa1ebajHDNdwIhhggUuvQltdcU 9oRiVZetG8ktRt4LipzSk5XoFJJ8y6MNbIj5NOMhCYyHtSuplS/H5Jn1V 4t8dyQ8SGAtIDegbGPjU3xTfUvy3BWXfEsfsBVtwDXPNf2slLGynJy4c+ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10464"; a="361375770" X-IronPort-AV: E=Sophos;i="5.93,302,1654585200"; d="scan'208";a="361375770" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 00:35:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,302,1654585200"; d="scan'208";a="615189277" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 09 Sep 2022 00:35:03 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 00:35:02 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 00:35:02 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 9 Sep 2022 00:35:02 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 9 Sep 2022 00:35:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D6ocIikkgHgMSGjYEGn9FDCxNRwJG3bmi1SMyy6sozZ/MFwpCzFrb06ZE6oJxJAkjWbAq0pv4ok5qYEEUFX9gGtbbffCrqtKgjZJlSlUv57LK0bGQjili6FBx5catUu9bp64klaBI1TSYH+JYFxkbc95ooz8EyPmbfKh1WZrO1JZShzrKDhivUBuD5RKxuWbICAxWM9fahum2tFZ0Tg2pNEmkSPblU2vVW8/9cymldNLLy0DcxJ5KmWKq+uJdRV0QKmbJd8rN9Jy7xiGl/x0jvOubwVKpkPG9JBx203SOudDSlBOxX4MJRnfFDDy9/k9IEFGmGNtacbTSb7bzUDlTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hkk2kXtvJiIsescIEbVYhBNwwdkWRCHbPNg0It/BKr8=; b=Qqoyyk2s4LgtmR5v3Fv7o5Xwy/JCLvLC5Cx3d+LSqzwcokSY2qRi8z7pi4NNZi89vKu/gxPLRzIAOyNZnLWdR8h4RFUWdZLY0TSWWfb2RbhRSDF7ZNj/5+VQJ8hcPPFDYliNw5KhpBU2MdAaUyor6cNbms21EBWMnbm2R2J94gF5bUDxR6X15y7aIc2F2zppy3Tvir7nYKPiXoauUcEKH3b76mKrhYLyDs16NrNw2YztGsn0eYpA6V31aZILqQF5LQ4f68C8vWyGdveek4LSUbd7DxSK9A0veztn6/cVCSeSXedgMiP8ezH0wwxoPzrh6597V5Bp0+b7mTrAgQ8RLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3499.namprd11.prod.outlook.com (2603:10b6:5:61::24) by MN0PR11MB6012.namprd11.prod.outlook.com (2603:10b6:208:373::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Fri, 9 Sep 2022 07:35:00 +0000 Received: from DM6PR11MB3499.namprd11.prod.outlook.com ([fe80::a879:d1a:5443:a35]) by DM6PR11MB3499.namprd11.prod.outlook.com ([fe80::a879:d1a:5443:a35%7]) with mapi id 15.20.5588.018; Fri, 9 Sep 2022 07:35:00 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" , Huang Wei Subject: RE: [PATCH v2 4/8] vdpa/ifc: write queue count to MQ register Thread-Topic: [PATCH v2 4/8] vdpa/ifc: write queue count to MQ register Thread-Index: AQHYw0dZHdZpoHFTE0iZupyHH+l/T63WtoyA Date: Fri, 9 Sep 2022 07:35:00 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1662616458-164613-1-git-send-email-andy.pei@intel.com> <1662616458-164613-5-git-send-email-andy.pei@intel.com> In-Reply-To: <1662616458-164613-5-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d82b4645-0f97-40d1-dbe4-08da9235cd62 x-ms-traffictypediagnostic: MN0PR11MB6012:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IfR8k/KbipT8NBukPhc8WQdC3dRwXKjAlX+UqUJClZ/inSOYrYqFtCVcoJ/KHtOttZDFDTwAOFv8YwZ//Kz1v98PPZRUmtEimS1xjGv/oVRzxs60z683IT0qNg641VhtnD3hht62y3mMTXyIWk5CiRI+08JpKszW2hOX9J1mp4nmTVyPgA8w4btxSgNjGCcfK2wXfak8laXAczrw50TK1jaUPyV1FWszNRb2NTv/bznvQVNGiz+aMU1yO2JsXvg1ZK83iQ/D2z563dgbTQjoSuthCfd7/tBkIwn+azERmAMjTLj8jtCnEXm9A2GM4W4qKCZZLWvPHjmbcyT9aBXXuiqfM6/bsWqOaACP6RIZfQEpISOgkSJRKlGOMetnWE6sGm6QCjDdYwpvawthpquQVq2J5YizYK4n9nGy501gY5xFolWwNsY/+4+a8lqKOORcF3WYUqvRJcufsJ2XEMqjtkvzyd6SWIHCFtAHwiaILsgV4Dgo4ZG+qqo6AwBKFFnjqU/StFs++3/INs4hDEvDmigoJJWFaCt3F6tAvXcSv5dSr7f7uTMokn/6dLwji+csRbz+A5PtleBS+5yqOD3yDKwoeBByW1wCGJOAUVzqNF+tnruA6mO+ggbF4mzKDN15nMF0TN9xy3uK6e45aqhhq26IPxG5sib76cJFGluRGb3i3srjGABzMkEbQ2SH0PcU8r4zlFW3J411Ew4Pl23CfgKO7qPFrUxhJvLdzxQZ3AziG1VlvRQGEHlM5Dpjiztht0ZWYgOy8Tc07njRMld19Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3499.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(39860400002)(396003)(346002)(376002)(366004)(8676002)(316002)(107886003)(83380400001)(7696005)(478600001)(6506007)(53546011)(54906003)(110136005)(9686003)(26005)(33656002)(55016003)(2906002)(86362001)(52536014)(5660300002)(41300700001)(8936002)(82960400001)(66946007)(64756008)(66446008)(66556008)(76116006)(122000001)(38070700005)(66476007)(71200400001)(4326008)(186003)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YuW8cLJotmtyPXpzsRXWyX1Z2jHhVwlWxc59nWF3YrTLWC9+pnktevJcI6uu?= =?us-ascii?Q?L/QM/iDiGy+6+hjwLvI+IIDtEN1230QvQW3xoiWFs3/jSdGJ5HfgUtnwUx1n?= =?us-ascii?Q?eYgMb+avPzG0EmCIysN+vhDSmSDMOZOqV/sYl18wIOwtWLCYbz4krCoI22z+?= =?us-ascii?Q?cNp31oWxKWMXaUYHtg2w365N0z0LzOYFf/RscnJdVD5PYlsueBrZpRg9v7z3?= =?us-ascii?Q?RePn5BaEd2aLvlYDXA2knrXo4E3U+nUILNANswAAU4hpIiU/HQRYRg4OzrlF?= =?us-ascii?Q?qe3imyiGHe0Rru6Tah4bgBhKHU/ckd7V4Fc55JS4llJrG0ByLZGeMqpH2qjW?= =?us-ascii?Q?wjIJ4+iUjmxwnIhza9e7S554eQYnG+PmybOrSdom83+14f9OMkJmM/7IL/u7?= =?us-ascii?Q?GTdEYR7RWyiJKq1f5hheJPqhpVIJIlE6XXz91Np4RykXeOhcls0fbVNokD01?= =?us-ascii?Q?s0t0XkTJi8CJiqfo57Pv6loYomqxUVoHqGnqi13JwAgZc010ZerFyHxqVoq5?= =?us-ascii?Q?5u6+ui+1gJ9pbvt7tD8fV6QQMZbaTosB793nYxaNJGePVBDMW22z75dAjvEw?= =?us-ascii?Q?IjXuqPwar/OkVQEx7d45t5umzRr2TdDInXUMCK7+gK2E38laAHXrVjhcf/Ni?= =?us-ascii?Q?uIGADOrEo8GJw5DbDGaHE7ZQroYScR5dVR8xrasMlLeT1rJyEhCSBrJYmgjJ?= =?us-ascii?Q?/qAGZjUdLKiTuuAscmWGUfxKJH+RcC0zo5IUWhjtvtHxV0g3pU5EVDyJMJ66?= =?us-ascii?Q?bU+ri/r4NI3U7hG2Cl+v3cUVczzVdW8r9VrO9/pIa9qx9ndr5bp404ImcLLE?= =?us-ascii?Q?bh+XXj33iDviTks/TB448I8mTwPmzST28I6vkPTQ4JT5fwnuT+vp24oFWjn0?= =?us-ascii?Q?PW8++66Gca/FpeuZQadWfRfLIq887+e5sECJTPGKHZPDCQVSltZ+isLdgbkR?= =?us-ascii?Q?/MVuLoKDlyJ1+ZmBPK98l7AHzZ++MZTJg3cZ+B0z2kCI7cpRiYXxq2KfEx8G?= =?us-ascii?Q?SBC3m3cWdTJYvKlvxZjdtzAo/MVi/ERD7AdBFQLB94kaRnpqwGd34rU++424?= =?us-ascii?Q?YE/qUrsll7GLHZr6S8/bxqXZiIYfLQw1zf0rp6tIYCuuQdPtpGrJkmWmxaYF?= =?us-ascii?Q?03xxhVAKl6Iw3abhOyj2xltckj75iRUpvCqR6mNB//+PkUAvIRUomYzgho0i?= =?us-ascii?Q?KGT1uQWdOWiXD2R6vPPVZoNLLEeda+R1QV6DED2jTJ8CO+ncc685rJUrEhFW?= =?us-ascii?Q?Sb00Y+agU4IFeJwxj0lWXBojNpYZn6IADlEbTFGMBvs4719TAipLISD0dR0N?= =?us-ascii?Q?/JbIbUzcJeYv3729aX5BRwpMJ/r7y7+Uwtl9O7rbgx/TTvtoqSqZoVNJIbhq?= =?us-ascii?Q?CZN0qDuhFvFiDs+K3QCD9CHZqTbgQWl0905r6N39GaeAiPgH6fdDrQdJgz3f?= =?us-ascii?Q?bwhfNdhGI6bkvBeQl7Ke+A/6ZCxTcoQ2tce0sv5qod9+GDRdWtXx3rB0QFdW?= =?us-ascii?Q?WAE/7e/M/DDjh0apVuT9aQLeTwHWu+ZiuqTZg3IzWKNiNN20b52x9YWqGdsd?= =?us-ascii?Q?wNPyzPs2jGPiRHFVMdaI4ZonatcXT+zrdhrwdyIM?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3499.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d82b4645-0f97-40d1-dbe4-08da9235cd62 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 07:35:00.2920 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LtzgxpoJPgk/Ce45ekdwp3+WbkUh3FwcDE/bT8dkzSRGKXMoCqFObM4PxDPriCrYqRj/7gVFO+CA8HOjA46eug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6012 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Thursday, September 8, 2022 1:54 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com; Huang Wei > Subject: [PATCH v2 4/8] vdpa/ifc: write queue count to MQ register >=20 > Write queue count to IFCVF_MQ_OFFSET register > to enable multi queue feature. >=20 > Signed-off-by: Andy Pei > Signed-off-by: Huang Wei > --- > drivers/vdpa/ifc/base/ifcvf.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) >=20 > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.= c > index 34c8226..0444d74 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -198,6 +198,38 @@ > IFCVF_WRITE_REG32(val >> 32, hi); > } >=20 > +STATIC void > +ifcvf_enable_multiqueue(struct ifcvf_hw *hw) > +{ > + u8 *mq_cfg; > + int qid; > + int nr_queue_pair =3D 0; > + > + if (hw->device_type =3D=3D IFCVF_NET) { > + for (qid =3D 0; qid < hw->nr_vring; qid++) { > + if (!hw->vring[qid].enable) > + continue; > + nr_queue_pair++; > + } > + > + if (nr_queue_pair =3D=3D 0) { > + WARNINGOUT("no enabled vring\n"); > + return; > + } > + > + nr_queue_pair =3D (nr_queue_pair + 1) / 2; > + } else if (hw->device_type =3D=3D IFCVF_BLK) { > + nr_queue_pair =3D hw->nr_vring; > + } Why above logic will be different for NET/BLK, could you help me understand it? Thanks, Chenbo > + > + mq_cfg =3D hw->mq_cfg; > + if (mq_cfg) { > + *(u32 *)mq_cfg =3D nr_queue_pair; > + RTE_LOG(INFO, PMD, "%d queue pairs are enabled\n", > + nr_queue_pair); > + } > +} > + > STATIC int > ifcvf_hw_enable(struct ifcvf_hw *hw) > { > @@ -215,6 +247,7 @@ > return -1; > } >=20 > + ifcvf_enable_multiqueue(hw); > for (i =3D 0; i < hw->nr_vring; i++) { > IFCVF_WRITE_REG16(i, &cfg->queue_select); > io_write64_twopart(hw->vring[i].desc, &cfg->queue_desc_lo, > -- > 1.8.3.1