From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8BCFA00C4; Fri, 1 Jul 2022 11:21:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21C6141133; Fri, 1 Jul 2022 11:21:13 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 04D664069D; Fri, 1 Jul 2022 11:21:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656667271; x=1688203271; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1j/AdF3leWJHCTD1jtS9PbHwCbM3AgRGeYyTo8jHrzk=; b=HmpINZnZEJlmgxKOaq5jfOpbP6861fdEQG/waGAs5o1vCM1DWjazZmwU dTO+8G2+c2As+Wgw2n6rn5Y2cMgy1eYVSkmXX2Q6Zu2MxKPM10Uz36TOb 0su/UKhSTSNNy/sxs+0C3mlFS/JXUCodDaLeMMfJ1udPlGnTdPNf6fN+2 0oNbYZb7/rXixmks9XZDqkpQxl9QQGf7yr04XemVlxSVCGOHv/40Zsnta RyR4y3y2u3xXr0t9o4OHvO0nxfrEZUD/s99sNdiwqRYDKBOlOQXNt2x04 x75aA9OLEGjJdwihGSNhlNFh0V4IQ63QI3s+QT7790fhdedEZj5c7LlYK g==; X-IronPort-AV: E=McAfee;i="6400,9594,10394"; a="262406896" X-IronPort-AV: E=Sophos;i="5.92,236,1650956400"; d="scan'208";a="262406896" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2022 02:21:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,236,1650956400"; d="scan'208";a="648277131" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 01 Jul 2022 02:21:09 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 1 Jul 2022 02:21:09 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 1 Jul 2022 02:21:09 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 1 Jul 2022 02:21:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jocd0QoTNb1BpG9yxTn/OOeSbAHAyEDdgOM4jszCTXrtmtHF0U5hBnZDNni/LiQLpA2jyjl9G+ZjT03wobdBYzk3rbSw+76GMQoihTCPyJLaADUw15CS29I66ixzZwmM4JnEk8P9vSruHWtCZMPTUUrj/t0HBMxaxd3CxidbBSTUJCdpkBjfigGZTFbcdmzETgpz9aQvWFCOv7IlQmOijSE0CS/kYX3z5/yptxsG0BFSifHsflqjHSfkkMlvUU8OQeWn0TLdcuhiw4YNdjiRSXb51ko3nmZBBvjEwxCY9VEWYThjKnwmm6ekcyA5Pj2dc4YZD2azZwp2oUVNjF0nHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BGHA0ueHleMJ/iW6oB2STKmcQc9R7CgTkR5U7QpqDGs=; b=bsvZ7CkfM3/2qQ0pgUeOiLVGo5HxIHwS1mH58PFOGqjXOKj9xlzjzaghpKt4WtkP2IbugerFWrUeKP+h6JQfeqJcN1hz5BfNwZ+IjLR56NRK7DXxJARdU07qB5V59UqxFW0rxLzEmswNa1Rcp92TXyK3eOgtq5kVBVq5YlgMiq4npA0wzKuSqKzDKkDGeMvfl6jAJnN3THuH6aCgay0hzcdbLAxrbMV8ljU7WQ9JwNOVdv4Ev39EvC4Q+KZ1l+V5DWJ6stGfPSwHX8yGqP5DQ45wX3PEOP7HtYBK9NDZgFjlzRn1halyvP6QerHqc+l0B/iNKOott/HowN9bz8K2kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3516.namprd11.prod.outlook.com (2603:10b6:5:72::13) by BY5PR11MB3926.namprd11.prod.outlook.com (2603:10b6:a03:184::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Fri, 1 Jul 2022 09:21:08 +0000 Received: from DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::e5bb:2070:5248:ce96]) by DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::e5bb:2070:5248:ce96%7]) with mapi id 15.20.5373.018; Fri, 1 Jul 2022 09:21:07 +0000 From: "Zhang, Yuying" To: "Zhang, Peng1X" , "dev@dpdk.org" CC: "Singh, Aman Deep" , "stable@dpdk.org" Subject: RE: [PATCH] app/testpmd: fix secondary process cannot dump packet Thread-Topic: [PATCH] app/testpmd: fix secondary process cannot dump packet Thread-Index: AQHYhus7Emac0m+/kECkYr5nw+F3Ja1pSbVA Date: Fri, 1 Jul 2022 09:21:07 +0000 Message-ID: References: <20220623181502.181567-1-peng1x.zhang@intel.com> In-Reply-To: <20220623181502.181567-1-peng1x.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5cd312dc-3985-4615-4ca8-08da5b4307dc x-ms-traffictypediagnostic: BY5PR11MB3926:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: duKgA0rntJZF+L9jM8bm/XvNCkF6+7Eqibg3vyZ6bVvfyrbIuR603+sy0wh0v3GBavb9LKUJguaBlCZiEXqtlSYakoNnRFAywVtVsDc08A5Ec4k3sA6Fav/0Y9AaxSbYfE7oGCA04If70feFayHT7BvvEQGPsdR03HYhIKnHChcdkGiCyTrHVG7He1+LQpX6wMX4VCdqOOr94WfrzpC9B6K4omikgpSBfLUMF+2auz1pHE+ef1dZHhh6hagFoJ7Fj/ePYp0CKUyQgK0PyE3jWoUy8kEEosufhSEn8gi2uU4sSAfyms9VV6EpMrnbZaKN9aqEivNGcmXBzGV1aoykFRdLuYWEpQy9RV0Hy5M4Q3HXZ7zNP++HJOy+cEDys19jiyupX+/M2OJwHltHoTYyEa7KcD+PygYALX0brcRB0uErPTySEqQjOQX5n/ExHhvSkszCF/8A9LQGsJaxxfw+QPnAicse/kBNaGRXBFd1BiSNAD1VottcF+29+HKx0ln8otGjcqZsCA/9a5wNaOdju2s6D9fION1GncwMD0aoNEBP63so9/T8vyR+vwAIpBx94biD+WrWY4U8r5Ujn8Gx0qZUB4evLH7EX4uBA2CJ1XM6Eledjoqnva5ZXIFVPta1HV704hZn+3rHBZvZVKMT+oA0QQWTcCMUiYYVck3WOmuVaOlx1ZW/EnbMCOqqgVjHN2jXrLF94iUvCsKM8Noy9U9nR3BdtizxiQ+1+/s/6AAyomxSWHcuQrKuy6k21r02Fmw921+2NbWoYxyNsYVhIFUtQi22dn/2fmgUMRodQZ0xCuRHXAMnpLGki5JdF2fi x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3516.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(39860400002)(376002)(136003)(396003)(346002)(64756008)(76116006)(4326008)(122000001)(52536014)(82960400001)(8676002)(450100002)(8936002)(86362001)(66946007)(38100700002)(66446008)(41300700001)(66476007)(83380400001)(5660300002)(9686003)(55016003)(38070700005)(33656002)(316002)(186003)(6506007)(54906003)(26005)(478600001)(7696005)(71200400001)(66556008)(110136005)(53546011)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RdDHvHwSIEAA2nIDl/2E2hXqx63oBlA/F4Q3kE/Q/qxvo7K0Dr+pLGFxFtdm?= =?us-ascii?Q?syBtAWJ8Lv6sauTbe2Tw6zPJRrfc2jKrFgnz0NmgdTALPw9FKxLxkVnkSylF?= =?us-ascii?Q?2H0GrQ+NJcwYnUJF/Cf/4+zo/PYtW9f/OQN5ayuZprUH1uFjaPalaVA6CQL+?= =?us-ascii?Q?/j1e/NUpkWIwQ6+969ZQjZsgSWMChwpUxDAtbiyCmFabvfnExiDIQ58VB0Ye?= =?us-ascii?Q?HquiaIXSw4r/f3prXK3C/+zQvvdgBUNqEVAOWCuIhRpZHzfSSxu/bgpILc8z?= =?us-ascii?Q?uK8MWm2HvymUbLO54q8a1RNRsrblOyIRzA5YENkCAJ2Prt2gTRvLDeyXg3LJ?= =?us-ascii?Q?esD3P9iHOUkRoX0qpgfVtdzEAB7ArTMm35IKu09JxA2JBGgNQEhdEOcZfeO8?= =?us-ascii?Q?kzPO5oc44X4HiMU+huEvcS0aqSlO0pzb+iWNJrsVmAl2YMj4y9Qc98/f7s5O?= =?us-ascii?Q?VyH7C2z1RIxOsLzsTP/qnjnX822DVzXk9Wk17tw45YDtg99Kv77X1K5L7ggz?= =?us-ascii?Q?7Uh4p1cEQd70hzGHpyM0HZdAm1L9K2x/NJ+MD0/mbwHNflBQUDUiCKdjKygk?= =?us-ascii?Q?M1AtWG96RkLpUylxOPdON6JP9dzZ5JmqZZ04PmBaAa/0WrQ+9I1aDC//AOAV?= =?us-ascii?Q?yAfy9Y7M15f+6WcFXlbEc8YgMToEBBRG+3kkDWJ5NIvewj9Z6p+YRvVooMV9?= =?us-ascii?Q?3R9tooCtzlH/WjweK3C4ZBbcXNevYazEk6DMenT8VQcjSWrMRm5Br6hidGCZ?= =?us-ascii?Q?E159TX2gfl6z+nSRHT0z8zBbYZ0XfpxKylgRm/f706k7H+EfJ8/n6u+31+MD?= =?us-ascii?Q?OB/7nUZohYPdFHJxOBpg/jpwVH/ZB7MG2QXkxUZDnY6XPUCwNU72CTC7UiPd?= =?us-ascii?Q?ZkiqG+liKsrZ9NldUqd9/Qt3IBI8rOViSGix1WT29strhy1Iq3sX8ncYZRSA?= =?us-ascii?Q?mtms3t5PknjK1mhVFn15bWBN/XDS6WM5DLjlOpLdlvmNJscrvaB6XxOANGj3?= =?us-ascii?Q?PRZA2K3f5h+MSlJqZsoQlMhB1XDsJfRqGLOR6LziH0d4BksFlGRO3U0tNtkh?= =?us-ascii?Q?BF6C/+Zj5mGpEQZoyytbOn7+i+RTLseX7TGHWmj6UaDuL1isl+NaxHp78R3p?= =?us-ascii?Q?Cnav33cZXUDxKT5Ei8t7JuEf5+MH77TwfCDrT0mxcM0ISjmNmVBBoEN6bn0C?= =?us-ascii?Q?FakwXKV6/7LAfXtbpfcMK4uRt4W9bLArpAnegl3/rBt1t9fRDqpCX6Wfyga7?= =?us-ascii?Q?/IosdyuSVAXDC4vkXs7wm+L4U1CStcsLiFluSJcnd+ZOuf4j+EJPHQw6RCNz?= =?us-ascii?Q?CakYkTBdJ8K/UKMBoSMRulcbOHg7s7aIZJP0hm5bVdjTzKETxuIr2voICbBt?= =?us-ascii?Q?25fkTWhBLC8QLW5cauK7J4XwjJIfArs6VzGadhia/t0JMIQM6odCJ60HMiuj?= =?us-ascii?Q?A50oseg8QKhl+etSQLyNavzWeodNQ0/84d3cEthgVEgmjMUMkZ/LiH1unMWs?= =?us-ascii?Q?p/NqWRTKTVAVLEr/ST1W61CupY5/C2yeXtkmWDpRb/w1F58gSrss7Bu71hZM?= =?us-ascii?Q?gm9ZduNEO+QWGTGf93nsujx5YntV+1wpm7nqnhrr?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3516.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cd312dc-3985-4615-4ca8-08da5b4307dc X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2022 09:21:07.9004 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eKZrhBbUB6X0gpcLyL+Ry5HbuMEA07ddCivpxSsri+dLeRtCuSLAhZF4vHz60kWo6waDvMOl9QWGjYCqsBjSkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3926 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Zhang, Peng1X > Sent: Friday, June 24, 2022 2:15 AM > To: dev@dpdk.org > Cc: Singh, Aman Deep ; Zhang, Yuying > ; Zhang, Peng1X ; > stable@dpdk.org > Subject: [PATCH] app/testpmd: fix secondary process cannot dump packet >=20 > From: Peng Zhang >=20 > The origin design is whether testpmd is primary or not, if state of recei= ve queue > is stop, then packets will not be dumped for show. > While to secondary process, receive queue will not be set up, and state w= ill still > be stop even if testpmd is started. So packets of stated secondary proces= s > cannot be dumped for show. >=20 > The current design is to secondary process state of queue will be set to = start > after testpmd is started. Then packets of started secondary process can b= e > dumped for show. >=20 > Fixes: a550baf24af9 ("app/testpmd: support multi-process") > Cc: stable@dpdk.org >=20 > Signed-off-by: Peng Zhang Acked-by: Yuying Zhang > --- > app/test-pmd/testpmd.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 205d98ee3d..93ba7e7c9b 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3007,6 +3007,18 @@ start_port(portid_t pid) > if (setup_hairpin_queues(pi, p_pi, cnt_pi) !=3D 0) > return -1; > } > + > + if (port->need_reconfig_queues > 0 && !is_proc_primary()) { > + struct rte_eth_rxconf *rx_conf; > + for (qi =3D 0; qi < nb_rxq; qi++) { > + rx_conf =3D &(port->rxq[qi].conf); > + ports[pi].rxq[qi].state =3D > + rx_conf->rx_deferred_start ? > + RTE_ETH_QUEUE_STATE_STOPPED : > + RTE_ETH_QUEUE_STATE_STARTED; > + } > + } > + > configure_rxtx_dump_callbacks(verbose_level); > if (clear_ptypes) { > diag =3D rte_eth_dev_set_ptypes(pi, > RTE_PTYPE_UNKNOWN, > -- > 2.25.1