From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAF7BA0542; Fri, 11 Nov 2022 07:30:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D806D40141; Fri, 11 Nov 2022 07:30:09 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 31BC1400EF for ; Fri, 11 Nov 2022 07:30:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668148208; x=1699684208; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uRSTaR4o2cggV4JT2KZk3J9zYkakl+wYti6Eh7dgmnk=; b=J6k8l+WkdWQsBi68TKhfXQtj/bawr4PISp3UnOphsMPLpb1vJNi3jDDB uFyOrI0/Cme8OFQANOTOO1GA68kWquA8qWP3AhfLg3+V5ympAw91o7Bm9 hZEvRgGreGkL8y0ZpXmXeOXXloTXw+jkKFjdKlaRvAZjcg/EJr10ozOTT MXz9Ij+FSGRQvJtoCPphcCqBk+f3aqoMdgm/ajsvmPgTwTxO/ctj1Fc49 AIsMxK8iCZ4l8zYMPFkiUtojjNce/HGYF+72NOsxZdxJhfS69V3gdhcDq tEk1NmJ0MLWscLTL8+NDfDMhxhOydvL+3+6wGclXeOYu5vUqmUuNSf5Aa A==; X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="291257908" X-IronPort-AV: E=Sophos;i="5.96,156,1665471600"; d="scan'208";a="291257908" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 22:30:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="631940422" X-IronPort-AV: E=Sophos;i="5.96,156,1665471600"; d="scan'208";a="631940422" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 10 Nov 2022 22:30:06 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 10 Nov 2022 22:30:06 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 10 Nov 2022 22:30:06 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 10 Nov 2022 22:30:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RA9WMbwqzypPxhYDs0zEpOw5aRxFVEZ2W9Z5oX7lP7AUk8CL3k25J06S8AkBdBe+RtIPdTsS1cC6BeA7ETjCpLUPk8qZOGVWJ20QD2qsjSp6sz6e5POGiahRZqjelHeDlKu/IA9x7Ranow/uXpZzjMlw6aPS6xmfNdrXTfpZTD9p0M4LUlmQBeMS0h0qkP3IJI381chAxJZOmGegS4UE+bi1KnCPrOOgpcRIGWdX9Y8NEvB9LqY2ylBRVPGujwDXYUizoi6jKBzKhukZMssmFyNMqwmqGaWJOQJvHdwbbNZyEmZGuj9D/yaLz9xkVav8DX6ltKK5GqCkqka2/t8Quw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KiK+aPYrrGB0cWifXZelBXMtEF9M/7msQEWeBcFX/MQ=; b=Tppg1pFIsr00VjZgkqeqDra+0uzOKvX9DbnTvcZLNBLKPC6Hz5o6j1y6z+qnEoz+5V0qcyFB0U4YadQPJ1raN/UvAFUeTlTJI3zQtuwU3qYCsSHlr/h0x0Mn/O6nve1ptAva/ZgrZ/31l8pkdFDtAuZK3Hrt7FCTy5/gnETmqXupEurse3mWz+u35Huf/fSXLbnByDRJV14cIX1pZmyMPbMwoduF9wel1sGbFU/angQ91dJKXwMG3fi8iBKPbSRgPWh74xLGtcpqO+mFDnaWtTeTqwk6X33x0/bOKgh7xkyOwXvTDJ+UyTTZ01SL3aYSupGc59SP4CqoXaYwyUj/hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3516.namprd11.prod.outlook.com (2603:10b6:5:72::13) by SJ0PR11MB4781.namprd11.prod.outlook.com (2603:10b6:a03:2d8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 06:30:04 +0000 Received: from DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::9f93:b8a6:f860:e660]) by DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::9f93:b8a6:f860:e660%3]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 06:30:04 +0000 From: "Zhang, Yuying" To: Stephen Hemminger , "dev@dpdk.org" CC: "Singh, Aman Deep" Subject: RE: [PATCH v3 05/14] testpmd: fix whitespace Thread-Topic: [PATCH v3 05/14] testpmd: fix whitespace Thread-Index: AQHY9JKKtd6pJdOtvUuMgOP0Xmu6v645RLXg Date: Fri, 11 Nov 2022 06:30:04 +0000 Message-ID: References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> <20221109232451.265059-6-stephen@networkplumber.org> In-Reply-To: <20221109232451.265059-6-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3516:EE_|SJ0PR11MB4781:EE_ x-ms-office365-filtering-correlation-id: 6fea8040-62f8-4658-6465-08dac3ae2b25 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0FUtMrRGVmVR7AtOLFkCZcba9l6yXS6ZDEKDEiRWj4JCh161T986EdnurXhw2KUPhREwzYbTM1Dk2+J1WRAqAvWXuYXUfsZgmRHjGJ0w6oJ+Iw4hO1dP94Dhy84zvq8yIHk7HW6K/nUYl8w4tpslBJJZY+3caIDOymy1ike0L2MTndY8FXB2uTrgeSM7FaSy1OVf4PBfSOb2XWhlEJg7C/G1rzoGTs3dJVqx1JhEv9LFIQqmcwfpflXx9+gQfDZCpOdxIRfZiFLEdJxAdZqC3Fy6jNkJxlhXNNG7aZg8x7bzQYanp22exHP1mJeCyGLeeDO3E0VRf8QDplflSDG+Rjtvfeb1Q6iCm14WDJ6zmRawC+X9yT34unv6cCVVRBKWajsaHbz4tNT7V+NoWmPYRSsH68tJA6g9rj7I5YzJuyBzbCpRlvDPqgb4xIa54Tu0qQyf+t9ZIrrxPgeIJdN/SbxQ2nx8TqskNBwMDKhBW+hrvfkKlZCshOF5x1S1+7gcjJWu63Gz2dgokOrtSHizrWHo3jBZUOUopJ3FfXo39njt2GaOYgWNRvqZOuqKmO1OrW7ZfGvIgsCoUPFHLEj2VTx9edjZNM6g9Ou+f1gpjqBBWMZJp6LxjxHK5pz55V7TIfgIHk4s5qYRe7dBaeF5b1B/NqKmL1P71g5VpTkeD2Ul5ggmRS9JTKQeBsgLPRYImYUYScrMQGqb0/cBBUlFv7jLpaMREhxpmDcnJGlhfqD3fSrElMtHKSLOWgavxW8B5wKG07paIve9/DMkSgK4SA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3516.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(396003)(136003)(39860400002)(346002)(366004)(451199015)(82960400001)(38100700002)(41300700001)(4326008)(66446008)(64756008)(8676002)(478600001)(76116006)(66946007)(52536014)(8936002)(66556008)(5660300002)(66476007)(71200400001)(83380400001)(86362001)(9686003)(110136005)(38070700005)(55016003)(33656002)(186003)(26005)(2906002)(122000001)(6506007)(107886003)(7696005)(53546011)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?SlE0ekYvN1R5bVBiMUcrUHFrZ1docERDcE5WbHRsSW0xc2sySmtMTFlY?= =?iso-2022-jp?B?Y1BiM2dzTFM2VzhBV0E4aEEzbWE4V2ZFS1NYVnA3ODRCK2FYc3VQM2Jh?= =?iso-2022-jp?B?T05sdkRQRjQxRjlVS3JZYXZXcjdCR043eEdhQkQzMEZpRHJZVXNFeHFu?= =?iso-2022-jp?B?UFZhekFaUENWTDFlOFo2N1NvVFgrKzRJT1dEWFltcGV3bVRya2pwMEs4?= =?iso-2022-jp?B?djhKR2xMakJuQTdBS0xPUFhXWExETlA1cnEzRmdtNXR3dlo0dmNMK2tH?= =?iso-2022-jp?B?WmVac3g5MHhsYzg2bXlMOUQrdUdwd0NrYnFmdkg0RG1aU1BXSE9jWlZJ?= =?iso-2022-jp?B?UUJxUzVnM2hjM28wcWNremhuNVFJajZaWHQ3Y2d5WWxEVUJMSkIxcTRr?= =?iso-2022-jp?B?NFFlaXBuNlR3TTh0ZEE4M0d3MWtjUWF6NEJIOUorOWFQaWM3S2NNdkFN?= =?iso-2022-jp?B?VWxGeHZrNDhKSXowYWlxVi8yc2loMTZrREthUFlNQlBJREVOV1RZVDB1?= =?iso-2022-jp?B?Z0JvdDQreFRVblNlZGp5NDhOQXhFN0xqQWJaVE42R3VGZHJiTTNjUUw4?= =?iso-2022-jp?B?ZXRRNmNMSFBTdFgzdFdRb3dpNjZRcjd2Z0UvUmFaOWQ2WjNlNlRJbWR4?= =?iso-2022-jp?B?SVdRWjVMRHp3Nk5HUFBiZ3VHUThaUm1RVS8ySnFJSElYeCtqbzRPdHBK?= =?iso-2022-jp?B?RW81R21iOWQrY0dsY3V3NDlYSFNIcGpMdEJ4d3BrUzF6YnlTVk1jNTN1?= =?iso-2022-jp?B?WDRhU2FyTVkrMG5LTExPV2Q0ZFlIUGZkYzdva2llSk14ZndqQk0wUURa?= =?iso-2022-jp?B?ZTZSOHBZL3RlMklGbDBPajhXdDFZTFl4dTR3bDRoaFNrUlZkU21pdUxI?= =?iso-2022-jp?B?YzhOSHczd0FTM2ZOSnkreFFObElzK09YdmpYcnRtV3liRW9DRTlIbEx4?= =?iso-2022-jp?B?dk44MzVpZThPL1drdUxMY0VUdG9yTjQxdm9XdmxYNEVTMk16MXkrZFd6?= =?iso-2022-jp?B?TmxoK3pZNEZyb2FiaDQwbkQ2UUtiaFEvLzhxY1F0bHFLZWM0a2FIcXJY?= =?iso-2022-jp?B?RHZPemREdUE4VjhPMmdqVlRrL2pMRFdZeU1SQ1VKMTRtSVR2VGVkZC9D?= =?iso-2022-jp?B?d3dLMzlTajMvU2NTOU1MTDNPblNFeDZSYVpuVE9DRE5tcmlaK3RFMXdK?= =?iso-2022-jp?B?Ykc2SHgxZGVWNys2U2Z0TW84cHFDY3M0QTBHRHFjb2szd3BZQjA0WGhZ?= =?iso-2022-jp?B?NE90UFQ1WkZ4T095M2JSL0dhV1VYbVVDWXlZR0cwZmVKV2JSTGJZNW5q?= =?iso-2022-jp?B?cE8xL1VJWk52Z3R4bGFhemV6SklOK3JiZ3Y4dnByTGtHWGxaa082SitY?= =?iso-2022-jp?B?UmxNSFkxcHhXL3l2cTZtKzg1SVY5UDNNaVFVWXh0b3JkbG12elcwTFU2?= =?iso-2022-jp?B?ekdlaDBCOEtoWVowMExoMW9SOFFxYkI5R3NlZVhZMUR2aTllZWVXS0k1?= =?iso-2022-jp?B?OE1LeDNmQkh4UWRDd3JlSmhoWXFBeSs3b1BJaUc4OE82M0dtdk5OaEhs?= =?iso-2022-jp?B?R2lRNkg1WjZKTVVXUGZEZkcwclUyTzdEMFJJT3ZvUjMrdVBMOHdLenNy?= =?iso-2022-jp?B?S3draVhsVlZUZk5GMFVXaEpBTms3R1cyOEJDMmh0aHFGTjRPL2RRUUFk?= =?iso-2022-jp?B?a3JyeWxNc21qOHlFbElnM0U4L1RKVzlBbDRyTFYrVG45SktJZ0VPODNS?= =?iso-2022-jp?B?S0RpSnRKeVZERUFHZXFsQjUrNDRTZlAvemM0b0tMMUpLc2dxZkRnbUNZ?= =?iso-2022-jp?B?L1pVZ0JXNzZuY0h3a3RsQ0l6RHhUUkFLV24zdmZQNTRCNjdWTzAvZ29B?= =?iso-2022-jp?B?NkhzVWV5eml3T3dZaTZQNUlLOVhaREg1Z1VBbm9UYWU0RDVyNnJhWExh?= =?iso-2022-jp?B?UElkMlpkMzhpZ2Vyd3NpQUxCUGdrRXpZV2dmYXRFK3Z3VDlOcTBTQVVq?= =?iso-2022-jp?B?K3Z4UkhudUpuL2dFMk1yWTlLUHJLSHEvU0JYY2lDaWJaVTliOHQxWHk1?= =?iso-2022-jp?B?KzkwMDhoaWozcWJaU1phMTNJVTc3T3VzMDVmQzJpKzF1WmJHbjVBc3Iz?= =?iso-2022-jp?B?YlJ4ZUVaWlJzcTRXQ3BNTlhmeGdOOWVZcUZkRExRKzBKSFkrclRYQ2pR?= =?iso-2022-jp?B?RGhTaDBKRWNDN0svcjJlTkdDMDV5Rnp3MHV3cDFXQTRyVlY5NFVwRDlN?= =?iso-2022-jp?B?dEU3MjR1Nk9vTnNielJvb2FRNUR5eXlpYkUzSExuZGRUYmY2dWFjWGpE?= =?iso-2022-jp?B?NEtPRw==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3516.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fea8040-62f8-4658-6465-08dac3ae2b25 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2022 06:30:04.1630 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e8x7pqQzLDTbYIQNhqh3CZA8jZ/+rpQHdZ0vjcdWyww0K6Bc+TP88jPaOh4BzZ0vzHclhMME92lx69SmDBiA9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4781 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: 2022=1B$BG/=1B(B11=1B$B7n=1B(B10=1B$BF|=1B(B 7:25 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Singh, Aman Deep > ; Zhang, Yuying > Subject: [PATCH v3 05/14] testpmd: fix whitespace >=20 > Add space after keywords. >=20 > Signed-off-by: Stephen Hemminger Reviewed-off-by: Yuying Zhang > --- > app/test-pmd/cmdline.c | 31 ++++++++++++++++--------------- > app/test-pmd/parameters.c | 10 ++++++---- > app/test-pmd/testpmd.c | 2 +- > 3 files changed, 23 insertions(+), 20 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 8dc60e938830..7721006cc310 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -2730,11 +2730,12 @@ parse_reta_config(const char *str, >=20 > while ((p =3D strchr(p0,'(')) !=3D NULL) { > ++p; > - if((p0 =3D strchr(p,')')) =3D=3D NULL) > + p0 =3D strchr(p, ')'); > + if (p0 =3D=3D NULL) > return -1; >=20 > size =3D p0 - p; > - if(size >=3D sizeof(s)) > + if (size >=3D sizeof(s)) > return -1; >=20 > snprintf(s, sizeof(s), "%.*s", size, p); @@ -3242,15 +3243,15 > @@ cmd_config_thresh_parsed(void *parsed_result, >=20 > if (!strcmp(res->name, "txpt")) > tx_pthresh =3D res->value; > - else if(!strcmp(res->name, "txht")) > + else if (!strcmp(res->name, "txht")) > tx_hthresh =3D res->value; > - else if(!strcmp(res->name, "txwt")) > + else if (!strcmp(res->name, "txwt")) > tx_wthresh =3D res->value; > - else if(!strcmp(res->name, "rxpt")) > + else if (!strcmp(res->name, "rxpt")) > rx_pthresh =3D res->value; > - else if(!strcmp(res->name, "rxht")) > + else if (!strcmp(res->name, "rxht")) > rx_hthresh =3D res->value; > - else if(!strcmp(res->name, "rxwt")) > + else if (!strcmp(res->name, "rxwt")) > rx_wthresh =3D res->value; > else { > fprintf(stderr, "Unknown parameter\n"); @@ -4088,8 +4089,8 > @@ cmd_vlan_offload_parsed(void *parsed_result, > len =3D strnlen(str, STR_TOKEN_SIZE); > i =3D 0; > /* Get port_id first */ > - while(i < len){ > - if(str[i] =3D=3D ',') > + while (i < len) { > + if (str[i] =3D=3D ',') > break; >=20 > i++; > @@ -4097,7 +4098,7 @@ cmd_vlan_offload_parsed(void *parsed_result, > str[i]=3D'\0'; > tmp =3D strtoul(str, NULL, 0); > /* If port_id greater that what portid_t can represent, return */ > - if(tmp >=3D RTE_MAX_ETHPORTS) > + if (tmp >=3D RTE_MAX_ETHPORTS) > return; > port_id =3D (portid_t)tmp; >=20 > @@ -4108,17 +4109,17 @@ cmd_vlan_offload_parsed(void *parsed_result, >=20 > if (!strcmp(res->what, "strip")) > rx_vlan_strip_set(port_id, on); > - else if(!strcmp(res->what, "stripq")){ > + else if (!strcmp(res->what, "stripq")) { > uint16_t queue_id =3D 0; >=20 > /* No queue_id, return */ > - if(i + 1 >=3D len) { > + if (i + 1 >=3D len) { > fprintf(stderr, "must specify (port,queue_id)\n"); > return; > } > tmp =3D strtoul(str + i + 1, NULL, 0); > /* If queue_id greater that what 16-bits can represent, return */ > - if(tmp > 0xffff) > + if (tmp > 0xffff) > return; >=20 > queue_id =3D (uint16_t)tmp; > @@ -7207,7 +7208,7 @@ static void cmd_mac_addr_parsed(void > *parsed_result, > ret =3D rte_eth_dev_mac_addr_remove(res->port_num, &res- > >address); >=20 > /* check the return value and print it if is < 0 */ > - if(ret < 0) > + if (ret < 0) > fprintf(stderr, "mac_addr_cmd error: (%s)\n", strerror(-ret)); >=20 > } > @@ -7780,7 +7781,7 @@ static void cmd_vf_mac_addr_parsed(void > *parsed_result, > res->vf_num); > #endif >=20 > - if(ret < 0) > + if (ret < 0) > fprintf(stderr, "vf_mac_addr_cmd error: (%s)\n", strerror(-ret)); >=20 > } > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index > aed4cdcb8485..7fc6d91f0210 100644 > --- a/app/test-pmd/parameters.c > +++ b/app/test-pmd/parameters.c > @@ -306,11 +306,12 @@ parse_portnuma_config(const char *q_arg) > /* reset from value set at definition */ > while ((p =3D strchr(p0,'(')) !=3D NULL) { > ++p; > - if((p0 =3D strchr(p,')')) =3D=3D NULL) > + p0 =3D strchr(p, ')'); > + if (p0 =3D=3D NULL) > return -1; >=20 > size =3D p0 - p; > - if(size >=3D sizeof(s)) > + if (size >=3D sizeof(s)) > return -1; >=20 > snprintf(s, sizeof(s), "%.*s", size, p); @@ -366,11 +367,12 @@ > parse_ringnuma_config(const char *q_arg) > /* reset from value set at definition */ > while ((p =3D strchr(p0,'(')) !=3D NULL) { > ++p; > - if((p0 =3D strchr(p,')')) =3D=3D NULL) > + p0 =3D strchr(p, ')'); > + if (p0 =3D=3D NULL) > return -1; >=20 > size =3D p0 - p; > - if(size >=3D sizeof(s)) > + if (size >=3D sizeof(s)) > return -1; >=20 > snprintf(s, sizeof(s), "%.*s", size, p); diff --git a/app/test- > pmd/testpmd.c b/app/test-pmd/testpmd.c index aa7ea29f15ba..04b078a2938b > 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2406,7 +2406,7 @@ start_packet_forwarding(int with_tx_first) >=20 > test_done =3D 0; >=20 > - if(!no_flush_rx) > + if (!no_flush_rx) > flush_fwd_rx_queues(); >=20 > rxtx_config_display(); > -- > 2.35.1