From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32DE3A0505; Tue, 17 May 2022 17:24:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9AED40041; Tue, 17 May 2022 17:24:07 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id C14214003C; Tue, 17 May 2022 17:24:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652801046; x=1684337046; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=lX6I8qFWm7k2v3hG8uLneCUFPsRFCdBCo2acD3YU6nw=; b=ZmGXs/6syzTTOfqhqbHemEZ2FIzceViAo7XTTajvMNIDvo5NoorPrMXP LJNvbNQCxYKOVmzL+wGpF1iRt7kNbq13rgfPGZGGoGwmwB5w9Ga7lN4J+ fj85Dpm8Tr563uubuhYMLrOMbwIZhQScxk3eW0/2MH1ZEDeFtUSd1taqE RPelHCzVwwtYhBjLL3eLqx8IGnktM5orQcVwhkKF0i7vqWQl//ESv7c4V fVsWAbeUDZ6hoREdk3IAPYkyOOlHuAsM1N2ELibpS8aMsPuC4Oe8v3MM1 cBz5JHQWhGmLpD+hHmgMeWQAlJS/1HGVmrCAvdfgEXGCg1DyvZWikG6BV A==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="271163849" X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="271163849" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 08:24:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="638792100" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga004.fm.intel.com with ESMTP; 17 May 2022 08:24:04 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 08:24:03 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 17 May 2022 08:24:03 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 17 May 2022 08:24:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dPgIu+LQXmNf9i3GU2JpPAE1bvN6fbBXgOeZGtyNmLHdf7O6f3iDcyI2fwFoHpJVuABbEQ1J3URHMx6wEwwPtlZelkPzhwooPQdh2hoyrNw4+qCZm8tSI7Vjxyci/QmoGFriXn/WCIW500d5esl1OOpBrdeoXKcUfdNx7UuxELrW8CK/KJ3SBksac1T5OzRXQjE9HTw+0g2vMaMPZy/KzVdmEUahVIsUQi/hw0YmPW6hGTOnrKHzF7M/vzDt5iPBbUdvFfsw34Hp3y5EddOuxSdnpDv9y1wjI/iD1Njm0YyFDl738DNi3ZV9yHFp6mfZk7i3BkqK1gQYGAff9MZRRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SxZLSOHr53cXCosFT8NcjwbvTesIq5Uxy59PVhovW0Q=; b=ksNKf2+UMnLtRSCQqhObo53nbK707puwWe2wxcs618kxOArysHa60/lh0nweaUigyzjYEHnIZtaR0ODzmQJnoPEM5tIdfaXVgHyWnzvgvZVikMdiZU5F/wKL/Hu8CzUhn/IQB6gW86sTmcLKndpbwKzfEDaW1PI/1mzWFAkNXMJofRDNN/xamUn+dt/r6IiqsWulBq/znqECgyB0iT1BOBj4ZqPHo1TlIyyRb0OS+/xcjpJx8fsZqIT5Ykn4hLho68Bsza+e0hKM7T/Wb4KfCtqonCvB/2K/Cef4ZT0hgFHpoCbWr45qhAcOeyBkGGDlpZBzTkciF0bvjQyq08zZCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3516.namprd11.prod.outlook.com (2603:10b6:5:72::13) by SN6PR11MB3183.namprd11.prod.outlook.com (2603:10b6:805:b9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Tue, 17 May 2022 15:24:01 +0000 Received: from DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::187:4143:ba20:d362]) by DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::187:4143:ba20:d362%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 15:24:01 +0000 From: "Zhang, Yuying" To: "Xia, Chenbo" , Maxime Coquelin , "dev@dpdk.org" , "jasowang@redhat.com" , "david.marchand@redhat.com" , "olivier.matz@6wind.com" CC: "stable@dpdk.org" , "Li, Xiaoyun" , "Singh, Aman Deep" Subject: RE: [PATCH 1/6] Revert "app/testpmd: modify mac in csum forwarding" Thread-Topic: [PATCH 1/6] Revert "app/testpmd: modify mac in csum forwarding" Thread-Index: AQHYYGrFalVq6LXZVUaSKSoup1PEl60hiT3ggAG5w/A= Date: Tue, 17 May 2022 15:24:00 +0000 Message-ID: References: <20220505102729.821075-1-maxime.coquelin@redhat.com> <20220505102729.821075-2-maxime.coquelin@redhat.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f8b119e7-e7aa-46ca-2e36-08da3819450e x-ms-traffictypediagnostic: SN6PR11MB3183:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DuTlV90Zsl3tZ4iM1u0oQg7FogkJGoYm4UzlEBQd97WAmo7sFNa0kCztpZljHGdrbUgbzXuHOpZZPmh17GCxmDB/Jht8rrOdA4bUl3mpbE+A9Wd/KXFsAMUZge8Pb0kdRxGxpu1EP56JwrrlTXqgPR1M6yxRg3BB3bGMVXyAm83hqDsTN9OKeDqyaj2GS4nwiJ7Ef6kfGAKUuBcJqN3M6pPyQpHCaFV+OzZWsu2ifoYCLqGXWKMbB25VKrBqNagERkAupGQ6BAdbfGeTAgIM9gZpRMu8JxAxQzGUrSjqts9gHzP8VTwHj+yYI8LSj7E07+GksRZeuBhIfLRHCQQmYZ9wtdDMGxjgp5Ypm+op07FnWCoW00nqGDxG5EsyYzWE0v7E0F7Gx1b9lK5ZCx7ftS3yhCYRTrS+g9HQDX6amKbcL2SRRs9LgW/td5QK5PZ/dgj3yhD4hy49Wqs9g0njurY5BkCNvMAGsQHuWylrMM4A2quXbIruOou+SWI/5DeQotZE81XpTqP8l7AO2e0Wr1OnSyFB9d7LX43c2rBuiblU4+yzhC1qr6rF1zt7qxYogDynyCr384rsVKXTDHVHXwepr1k0nQg8K035Yhy0XnaoR+LYdamstIzVoCXcQbimkcfyCJZ6q7FyQnSo/D8hP0cpSJCYXgiBcvPxsalPm+gqAOFeVvXTzJSA7TTjke8yQKlgHiZzxPRY+lC/lEBSmA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3516.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(9686003)(53546011)(107886003)(26005)(186003)(55016003)(7696005)(71200400001)(33656002)(83380400001)(508600001)(5660300002)(38100700002)(6506007)(8936002)(52536014)(8676002)(86362001)(66446008)(2906002)(66476007)(64756008)(4326008)(66946007)(38070700005)(76116006)(66556008)(122000001)(82960400001)(54906003)(110136005)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hhLqkt/dMFML+nrfMi6QUEQE3m8ct66AwGnTjLNa3PyaRtutRRpIW0lYKGdb?= =?us-ascii?Q?NorFp0e+6eFgnozoG7kmbiW2VlhPQXYNHs/Pz4H1cIw1lN0upiw85h3M2FHt?= =?us-ascii?Q?wa99dKP4LlD7iaO/vu7u9ypuKIVeSJvj+gklcUHGsZyoeL3+uDvBIyThKQ8D?= =?us-ascii?Q?iXhI2s+MJmqNfJM280V53Vt3Xzzeaw24wOKZd6t88tRp9F+s1j6hzO5QZuBc?= =?us-ascii?Q?J3bp5GJPALt9iCFNs8pwM1sd77h7lwhsvbaXWwQGjgmkIdMxLqMzFA/oKsEh?= =?us-ascii?Q?zh/l9oFoAtaObcHuIy3MVev0gMl45aJ78UQbpfkY/ns+e0GtQHORkqnAz5lj?= =?us-ascii?Q?urdXMn74j5DbGh0h4obtVk4CNDmyZBG/67w9AxsR4JAP44IMlvy6mTbXhKT6?= =?us-ascii?Q?1kDDmWbJyKj7pLTPfSxU0lZeMnyOqI7yNl3r0BewTN7mdTKMEQGIcn2n1K6P?= =?us-ascii?Q?lTfjtt0Ps5wvAs0DK3G+jDmllv8dsRbNnVcIGMKDW4Mmdjkga57gcn5vqXB/?= =?us-ascii?Q?do5ZaulibL/fnQ1VqQkAXqKiF8gbwAxkA6k7p4/nGSmy85LFPubYlYKlYK3C?= =?us-ascii?Q?jFdb08h+SfSx862J40eROarBu6z84G/mvOtWLwReyvYsArhtQ5HdWU8Am9iu?= =?us-ascii?Q?6IeXpINcIbjkCefT0mgils92dzbQzsvY7N1wLAXiG4zsVzvVPl6G+aDhUCAd?= =?us-ascii?Q?EWA4KrkTxJC80D6MrzYy2uDYe+h4t/wkRhF0PiFhmfJwOIF+cn+3uNDLgnO4?= =?us-ascii?Q?mPE13cimOYudNDGdZ4f6wARFp0QZ2JKsHjeF2lfOb34M50MQp0xyuKfAi5LG?= =?us-ascii?Q?YQq4Hotih5U3iUctZGdw3Ew5ZzqeVQqXKO2sSPNeuz+beT4FAl7wTu0g3dBC?= =?us-ascii?Q?TGRleHjuCNs5penlRrs2vmTQt71IHqVz42/C68mk1Rz9u9FnCygRZzkwiKzX?= =?us-ascii?Q?LOjSM+en+02wUnoxFnXoMirs/NDbhbOtNFeNXVmbStH7sfCeIiNlBo1+kyYG?= =?us-ascii?Q?z6i1ko/Fc4Ge8U7ZfZQFyFnuDnmgp3BkwJG+RM3hgH1z+Q+UX3LmKswVbm44?= =?us-ascii?Q?G/3s4uW81yAIbvl1actiQjV35iSnLPuQ9U+MdG6O6QnMpWbcE635xhCGwAKC?= =?us-ascii?Q?fFD/i9ystI5rXIjASA/wCTsI2Ft+ZR4xC+MGQU4Vs8Q9XDIGfwQeG5HTSZdr?= =?us-ascii?Q?g/Yx5qcnRApDXDqVsLUPFf1CymMCiZIh+pIejJf3gidFlsk+yGGYvOAs2UYL?= =?us-ascii?Q?QcTamft+vLRmBX6Vro4BG4pcHVaagYZc0+bew+1H4PaSK3kiK+c1McjbGdVj?= =?us-ascii?Q?EO/x7XGSd3FyyS/Gm4JakAN2gTeBX/nBXs+O+oG4WsEPYswR7SYljThUInxP?= =?us-ascii?Q?vKIOVm3HSLI29M4gscO/Y29A1lxG9xCIb1rCU77genpDNXq+wuUmfriUflUu?= =?us-ascii?Q?RK/KZBMlesYShZlwmPZ0SYne3v0moy/jBijQbh15Qz6dPLnbLD+XiSqbAEy2?= =?us-ascii?Q?HRDyvVnWATLW4ZQ7SExycnzqZyxbtegq9664jOrzxytsGB0PeGuSieYYkgO6?= =?us-ascii?Q?0gJDNuiYOMe2led7LXr0UL2KmjsDgl5oEPDyhM/sS8kNip5n9ihGUq3qYEK8?= =?us-ascii?Q?HmG+GFVzpx9zalWBtEgcrAsLJv2UbzHFk2G81Z1LROQ4IhlMTfI/+H/Sifwd?= =?us-ascii?Q?uTj/diaP8rCb/73TfM4mOmQ0TrX+VuANg00r5IStgRdnSsUVS6b9qEpGovpQ?= =?us-ascii?Q?7mmC+6U4mQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3516.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8b119e7-e7aa-46ca-2e36-08da3819450e X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 15:24:00.9929 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LXUSnpiBId4lRNHT1jRbwSgq8JHkyE/nqI/nVAYmN/ptEOcnweOquMmxZdq2M1fABvx1TGdHYlamGn+USwI5VQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3183 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Coquelin, Please fix the code style issue of commit log. > -----Original Message----- > From: Xia, Chenbo > Sent: Monday, May 16, 2022 9:04 PM > To: Maxime Coquelin ; dev@dpdk.org; > jasowang@redhat.com; david.marchand@redhat.com; > olivier.matz@6wind.com > Cc: stable@dpdk.org; Li, Xiaoyun ; Zhang, Yuying > ; Singh, Aman Deep > Subject: RE: [PATCH 1/6] Revert "app/testpmd: modify mac in csum > forwarding" >=20 > + testpmd maintainers >=20 > > -----Original Message----- > > From: Maxime Coquelin > > Sent: Thursday, May 5, 2022 6:27 PM > > To: dev@dpdk.org; jasowang@redhat.com; Xia, Chenbo > > ; david.marchand@redhat.com; > > olivier.matz@6wind.com > > Cc: stable@dpdk.org; Maxime Coquelin > > Subject: [PATCH 1/6] Revert "app/testpmd: modify mac in csum > forwarding" > > > > This patch reverts commit 10f4620f02e1 ("app/testpmd: modify mac in > > csum forwarding"), as the checksum forwarding is expected to only > > perform checksum and not also overwritte the source and destination >=20 > overwrites >=20 > > MAC addresses. > > > > Doing so, we can test checksum offloading with real traffic without > > breaking broadcast packets. > > > > Fixes: 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding") > > Cc: stable@dpdk.org >=20 > With above fixed: >=20 > Acked-by: Chenbo Xia >=20 > > > > Signed-off-by: Maxime Coquelin > > --- > > app/test-pmd/csumonly.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index > > cdb1920763..8b6665d6f3 100644 > > --- a/app/test-pmd/csumonly.c > > +++ b/app/test-pmd/csumonly.c > > @@ -894,10 +894,6 @@ pkt_burst_checksum_forward(struct fwd_stream > *fs) > > * and inner headers */ > > > > eth_hdr =3D rte_pktmbuf_mtod(m, struct rte_ether_hdr *); > > - rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr], > > - ð_hdr->dst_addr); > > - rte_ether_addr_copy(&ports[fs->tx_port].eth_addr, > > - ð_hdr->src_addr); > > parse_ethernet(eth_hdr, &info); > > l3_hdr =3D (char *)eth_hdr + info.l2_len; > > > > -- > > 2.35.1