From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6707A0548; Wed, 15 Jun 2022 11:03:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D122440221; Wed, 15 Jun 2022 11:03:56 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 8026140220; Wed, 15 Jun 2022 11:03:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655283835; x=1686819835; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=k9eYLjYuQ2zM7NwxFsWwdWGLE/0wZ2B1uHLlgGKz+A8=; b=ZDOYb6eCRI62eI9+8H5LeleviDIx/C0JjB9BeOJHRE/kG7VaZLhgnmD2 VSYvljlUbCHYfb/LZRjZZgzF23vutUfcmq88fxnInV4R1XMZx+HRJjDyd TXB0shkXKyIZMhphVnbGjYqnRiL4/UFTM1LQ0pgHp9zUprXXpqottHj6D KgSalm2KepwTVk1A4ByLIaV+Xrixz9vBY6+F3gg87BvbsjhcdVWcl7LSY 61dTm4gcefjL4M9quoQ5iaCCOZ+2TIfxAul9raU97FDnRngTwpDWZiRYt o2y6W6tgBBCotJ9YpBGuUuS2FKUZkEagiU1HcQl0WVJyE3aqwOxTK6sAW A==; X-IronPort-AV: E=McAfee;i="6400,9594,10378"; a="342852860" X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="342852860" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2022 02:03:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="640885408" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 15 Jun 2022 02:03:40 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 15 Jun 2022 02:03:40 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 15 Jun 2022 02:03:40 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 15 Jun 2022 02:03:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PkFQ7Ul0BG1T0JTeg8FPXU9G1xhmNr6npl1D/nI0HcFPE/slAfJDgwwKp/QgYa/64nGwqef5geZaN9BUZ/m9gtMXQ3QV7gR8prXXxzsHh9FGFQ8mek30lVG+TdNOsVitKKGktNm45tUi/Rd0BKrajMRARgQfyBZwTCsEmDm7e8NcDUVtTAnJ6xObkoSGDd0ofVU88xRefUhqsL0GPgXcPSSFcK9gKXI87eXqQxfetucJAC+C5Aw+Wex2MDPyXhJX/wjTxyDe5Bzmm/WGzz5Z8NZCIgIE75i2bGiVTTqkc94cKvyB5ye88HGT61YYEZ3fBwdGqOuFzV64HqjZq/a8Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vB6/I8QWjMR5JdrXoIp/K1zyHK4nynvZcZfA0wU6pCw=; b=Mzfm9d+EyeFoN7go+aEm4DlpCIMipN/QXo/78jjr/5/xnq7qWM9Hbd6RHPLoaiIdk1cK7iCz5VoWRl85UqrHjqShvE1dGl72QnHbE4tiw8GFXEe7o1bEcX6Y42ezXrDHx7zZWfYHrq6xp6Q9smAV/APOnvuUaDxiCJvCeY3bLP3iPvMWTjpdK11JkUN9KOaJjQuz7p6M2/7XRKDWyb3pr8C9jb2y4OlGWAf7F0kMOpSsUsQ8TdkPZEqRdBUWPlCR4/2qbEOHuLrjCpm7sHSMU0Tm/uqsh0w2JI5fQ8VIRijGrZLTpnTf3zuowSe2mCqbxgP9Tfx2/BCknn9m8CEwtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3530.namprd11.prod.outlook.com (2603:10b6:5:72::19) by MN2PR11MB3952.namprd11.prod.outlook.com (2603:10b6:208:153::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.13; Wed, 15 Jun 2022 09:03:33 +0000 Received: from DM6PR11MB3530.namprd11.prod.outlook.com ([fe80::44eb:f525:1e31:d0ec]) by DM6PR11MB3530.namprd11.prod.outlook.com ([fe80::44eb:f525:1e31:d0ec%7]) with mapi id 15.20.5332.022; Wed, 15 Jun 2022 09:03:32 +0000 From: "Huang, Wei" To: "Xu, Rosen" , "dev@dpdk.org" , "thomas@monjalon.net" , "nipun.gupta@nxp.com" , "hemant.agrawal@nxp.com" CC: "stable@dpdk.org" , "Zhang, Tianfei" , "Zhang, Qi Z" Subject: RE: [PATCH v7 1/5] raw/ifpga: introduce AFU driver framework Thread-Topic: [PATCH v7 1/5] raw/ifpga: introduce AFU driver framework Thread-Index: AQHYe9K7fpmg97jRdkOVAScif/e/Oq1QEgYAgAAjtxA= Date: Wed, 15 Jun 2022 09:03:32 +0000 Message-ID: References: <1654742650-7214-1-git-send-email-wei.huang@intel.com> <1654760242-7832-1-git-send-email-wei.huang@intel.com> <1654760242-7832-2-git-send-email-wei.huang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: de14ceb4-f63f-4479-6f32-08da4eadec68 x-ms-traffictypediagnostic: MN2PR11MB3952:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: P8sFd8wIXLgIKNDemozEVOWjhCAJyEgrynmdLVb+779kZuu94/KroU6TDK287qseIN1MYGRqNM0WLVMEbCR7eB3SxXPyPzLa2Gd0EHRDAIV3gyaolLVZA5aRPEKV52HOK6x4avKzpVC/Sc66fbZdgMG4s8nsk8XD1QRUKiqs/Rshwo0OOcyzxSK79l4ZbqtKw0LHq4pJNxh1aPAJlonn01ikA0sAkFqP2uBOtnAQSPVEIHd98NeqMvSM+jcE+/axuufi6c2iGg+LC3H4IrNysOhOLzlLKHajVXXyUyaWD9cqT/fylcUv+aN9kRp5NKwvPzujI3FgbQHI2uw3FBc611OEkkAVGN6AB9oCA0t0nb2RPwBI3ncUYN3P79Nfg887tTeM4/Ur6+ItxRqC3sT0D+TVxa6YUKspyU9jxBeT87EmAC2GVx6QdJE8aIPJdtgn6mwydt1Ji9xAUNjxDuk6zJanZm6E7rsvOyJvRFM71+TAM8m6b+xF/si7c52RkwRfj2RXkfmBsU7ugM4169zLKx7tXHCiu8W2ANqIGvZvhEBAm59cnrVseE9Ge002n6jp0H9PW2eD+LpU5Crm3KGFnbsr5U25kKdgI8bYP0R45oq0IBq5BeDX7l64IvX32ys++gad0pb5uVQCCeRvSVcePwxDSzP0AsrSfjniZ+vsGUaJS/HX+df2YxNsja/ijOtpIFIZf/pe6nsDCoHiUeAtgg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3530.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(66556008)(66476007)(5660300002)(8676002)(86362001)(316002)(64756008)(122000001)(33656002)(9686003)(66946007)(52536014)(38070700005)(76116006)(66446008)(30864003)(38100700002)(7696005)(6506007)(508600001)(8936002)(4326008)(71200400001)(26005)(53546011)(83380400001)(54906003)(55016003)(107886003)(186003)(110136005)(82960400001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Q5HpTltkij20ClbaK6oOCLMvnwSRRmkW+iJNakXOInmbEllafhrsq+AeOPgT?= =?us-ascii?Q?s8tcnHAO0F0gpP6umheol+dTULjRfEFoEfj0H7C2u5rlhXcSG/bbpB5tYaIu?= =?us-ascii?Q?ieQa4gp5T16ZTmTZFRQRqbdhUzLvqqaiFLJFIm41IraGdXfiZlqMGHFdJGtg?= =?us-ascii?Q?f0nSnilFwq3jIvvJ7AHy8A+hHcN5rlEVE1vjY9/b4GMW1W/2pNNkLW+VNCaq?= =?us-ascii?Q?4lo2h0CTghrPtN8r3k4+kspadi0A5P/nlunxeEhsGTRW17Lak/oip2wC3Pgy?= =?us-ascii?Q?oaKzVcEufa/Syp6KBBGej4EjwUxKUPrk8mTQrmj0ASvEKKqDS6XeBNQ+iSz6?= =?us-ascii?Q?iyh3Y7Lc22pEUMnKQoapj/TtgIiaiZVTJXKD7cEIFdGs5K0tVDqfT5di/Yxo?= =?us-ascii?Q?YU++IFP8e59VXNQLECFH4Y7J2jP34Vj/r5TOI7RRF1K1C26AVukmXoH5U+BF?= =?us-ascii?Q?xyrg/d1SdCLXW5H4wa90l6sRAcsNzcsuxsktNrmOpwbF8yJQLZjIs+iEItmw?= =?us-ascii?Q?II9707Iyd8YLJrffL/RIEGVXaZKfBgCPkVkPG80on1tGiBn/MiApUGDF/XL6?= =?us-ascii?Q?qXbdAEEnF0GHgIUPaQdxd4I0A/iKI9SxWIN56lRNipjIohRpzSAaZzJ6afPK?= =?us-ascii?Q?rN+LynY6t+Bdy9ax9MZGQw/ST1hHQDDDLh1h1oOsgGrneRfjGL10CwHSnz2N?= =?us-ascii?Q?6arf5elkcgtZeTPwplgqwsAtpVJUh6XIxOTdHkfRezM3vVzWcIpiCzLXc93l?= =?us-ascii?Q?Aoff3HZxdbqMUAH8oMqCyH+px9bVQhzd1Y3SQnraEYH5A3ZuXLerHs6cx2wx?= =?us-ascii?Q?T26wPk9nuXRtpci2dTM6jxcaGBFAIw1dGy/R7YxJfV06CA8q2AUqeIqVvdPH?= =?us-ascii?Q?xPKn57mR5IfRlEhfnoORV6Fk4h8a/riIAP9E68f7rwnfAlLEyh2nlNnv+1AA?= =?us-ascii?Q?zuvevlrBRMp1AdYWTmsRHJ/ZEjWQON3zvO4EFDhhOfLRVEWCNkK0f0d7v0tw?= =?us-ascii?Q?tiL3gO+Yw/iJLuMe36vQ/ZAJWzhwcSA7v3VSSEJUVaKHpRVsz05fT+2wDDNc?= =?us-ascii?Q?IaF7RmBp/FCeAFrLKoqsoAgIlSpmkebYCSwNqcdpyppA/pdn3Q+b3oMUOikD?= =?us-ascii?Q?z7LVuww143WzzDl62ilIQ8gVgJ0OBZJcqceOgf59mlBQRuK2DQ36TuIturBm?= =?us-ascii?Q?pLHQc5fxBPunQXQtsh4Q3dbU/5a4ACMbMI5yr+DjzvR1i4wozK9e4jPK/u0m?= =?us-ascii?Q?dnSzr+4rU6UzALhUPPBrDZrCt1bpeYs/MEnWipYcGl0f4gWlW7AAOJjuNNJi?= =?us-ascii?Q?0fIyb4h0Bkn51I4cRjVSJNlqI2NOiFogKXXWbaCtqLi1vIqAnMN4v+nyxZKl?= =?us-ascii?Q?WtrRuOWOIZzq61sX7R32K/hvOLk0P96k6WFK4lahtix4uxy7+BSSXe/UsxwY?= =?us-ascii?Q?o7c7g2T1QtLuw8OIkmvCt1ZZuGfzKI8eixv5QGVDqPqyl54y5nAWeFr9y9CJ?= =?us-ascii?Q?FiEyL7ZyRCWJialNK07lSl0tMNYnOAbC/pyLvjLTsjBnaCFpu/o/HtRCUtpZ?= =?us-ascii?Q?GTV8Sl8mN2n608EVzvmXHpcwd7PmcmpLMSehUlpV4++9urs88IKUnbco0lf0?= =?us-ascii?Q?d2qim+iussB46SJ0/1XTWGeBk3ChJXY+YZo88kmcBoKDuHv4Xkn6MCPrsDNW?= =?us-ascii?Q?6oPeg0iSTf5R2Z5qrUXYyep4nz1NIRzvS3Wz4iigPvyaQG8fbN+So5vXMQIU?= =?us-ascii?Q?Ae2cIN9QIg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3530.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de14ceb4-f63f-4479-6f32-08da4eadec68 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2022 09:03:32.8453 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: flfONhaxIYaY8D9kw4Boej4L8nah9Xqnn9n8uCUPXuPH+fafRrzaLwYwEBeYjBlf3q3IvX2KzeZ3v5QV81E/4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3952 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xu, Rosen > Sent: Wednesday, June 15, 2022 14:55 > To: Huang, Wei ; dev@dpdk.org; > thomas@monjalon.net; nipun.gupta@nxp.com; hemant.agrawal@nxp.com > Cc: stable@dpdk.org; Zhang, Tianfei ; Zhang, Qi = Z > > Subject: RE: [PATCH v7 1/5] raw/ifpga: introduce AFU driver framework >=20 > Hi Wei, >=20 > Some comments. >=20 > Thanks, > Rosen >=20 > > -----Original Message----- > > From: Huang, Wei > > Sent: Thursday, June 09, 2022 15:37 > > To: dev@dpdk.org; thomas@monjalon.net; nipun.gupta@nxp.com; > > hemant.agrawal@nxp.com > > Cc: stable@dpdk.org; Xu, Rosen ; Zhang, Tianfei > > ; Zhang, Qi Z ; Huang, > > Wei > > Subject: [PATCH v7 1/5] raw/ifpga: introduce AFU driver framework > > > > AFU (Acceleration Function Unit) is part of FPGA and enumerated by > > ifpga driver. > > This driver implements common AFU device interfaces and exposes them > > to application as standard raw device APIs. > > Normally application can operate specified AFU as below, 1. call > > rte_rawdev_pmd_get_named_dev() to find AFU device. > > 2. call rte_rawdev_configure() to initialize AFU device. > > 3. call rte_rawdev_selftest() to test AFU device. > > > > Signed-off-by: Wei Huang > > --- > > v2: fix typo > > --- > > v3: fix build error in FreeBSD13-64, UB2004-32 and UB2204-32 > > --- > > v4: fix coding style issue and build error in FreeBSD13-64 > > --- > > v5: split patch into several patches > > --- > > v6: move source files to ifpga and rename, use spinlock > > --- > > drivers/raw/ifpga/afu_pmd_core.c | 453 > > +++++++++++++++++++++++++++++++++++++++ > > drivers/raw/ifpga/afu_pmd_core.h | 76 +++++++ > > drivers/raw/ifpga/meson.build | 2 +- > > 3 files changed, 530 insertions(+), 1 deletion(-) create mode 100644 > > drivers/raw/ifpga/afu_pmd_core.c create mode 100644 > > drivers/raw/ifpga/afu_pmd_core.h > > > > diff --git a/drivers/raw/ifpga/afu_pmd_core.c > > b/drivers/raw/ifpga/afu_pmd_core.c > > new file mode 100644 > > index 0000000..a24b517 > > --- /dev/null > > +++ b/drivers/raw/ifpga/afu_pmd_core.c > > @@ -0,0 +1,453 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright 2022 Intel Corporation > > + * > > + * AFU is Acceleration Function Unit in FPGA, it is enumerated by ifpg= a > pmd. > > + * Suppose AFU is found in FPGA at PCI address 31:00.0, then you can > > +create > > + * and test a AFU device by following steps in application. > > + * 1. rte_vdev_init("ifpga_rawdev_cfg0", "ifpga=3D31:00.0,port=3D0") > > + * 2. rawdev =3D rte_rawdev_pmd_get_named_dev("afu_0|31:00.0") > > + * 3. rte_rawdev_configure(rawdev->dev_id, &cfg, sizeof(cfg)) > > + * 4. rte_rawdev_selftest(rawdev->dev_id) > > + * 5. rte_vdev_uninit("ifpga_rawdev_cfg0") > > + * > > + * AFU device name format used in rte_rawdev_pmd_get_named_dev is > > + * "afu_[port]|[BDF]". Please refer to OPAE documentation for the > > +meaning of > > + * port. Each AFU device has specific configuration data, they are > > +defined > > + * in rte_pmd_afu.h. > > + * > > + */ > > + > Could you split these notes? General speaking we just announce license in > head of source file. >=20 Agree > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > +#include > > + > > +#include "afu_pmd_core.h" > > + > > +static struct rte_afu_uuid > > afu_pmd_uuid_map[AFU_RAWDEV_MAX_DRVS+1]; > > +TAILQ_HEAD(afu_drv_list, afu_rawdev_drv); static struct afu_drv_list > > +afu_pmd_list =3D TAILQ_HEAD_INITIALIZER(afu_pmd_list); > > + > > +static inline int afu_rawdev_trylock(struct afu_rawdev *dev) { > > + if (!dev || !dev->sd) > > + return 0; > > + > > + return rte_spinlock_trylock(&dev->sd->lock); > > +} > > + > > +static inline void afu_rawdev_unlock(struct afu_rawdev *dev) { > > + if (!dev || !dev->sd) > > + return; > > + > > + rte_spinlock_unlock(&dev->sd->lock); > > +} > > + > > +static int afu_rawdev_configure(const struct rte_rawdev *rawdev, > > + rte_rawdev_obj_t config, size_t config_size) { > > + struct afu_rawdev *dev =3D NULL; > > + int ret =3D 0; > > + > > + IFPGA_RAWDEV_PMD_FUNC_TRACE(); > > + > > + dev =3D afu_rawdev_get_priv(rawdev); > > + if (!dev) > > + return -ENODEV; > > + > > + if (dev->ops && dev->ops->config) > > + ret =3D (*dev->ops->config)(dev, config, config_size); > > + > > + return ret; > > +} > > + > > +static int afu_rawdev_start(struct rte_rawdev *rawdev) { > > + struct afu_rawdev *dev =3D NULL; > > + int ret =3D 0; > > + > > + IFPGA_RAWDEV_PMD_FUNC_TRACE(); > > + > > + dev =3D afu_rawdev_get_priv(rawdev); > > + if (!dev) > > + return -ENODEV; > > + > > + ret =3D afu_rawdev_trylock(dev); > > + if (!ret) { > > + IFPGA_RAWDEV_PMD_WARN("AFU is busy, please start it > > later"); > > + return ret; > > + } > > + > > + if (dev->ops && dev->ops->start) > > + ret =3D (*dev->ops->start)(dev); > > + > > + afu_rawdev_unlock(dev); > > + > > + return ret; > > +} > > + > > +static void afu_rawdev_stop(struct rte_rawdev *rawdev) { > > + struct afu_rawdev *dev =3D NULL; > > + int ret =3D 0; > > + > > + IFPGA_RAWDEV_PMD_FUNC_TRACE(); > > + > > + dev =3D afu_rawdev_get_priv(rawdev); > > + if (!dev) > > + return; > > + > > + ret =3D afu_rawdev_trylock(dev); > > + if (!ret) { > > + IFPGA_RAWDEV_PMD_WARN("AFU is busy, please stop it > > later"); > > + return; > > + } > > + > > + if (dev->ops && dev->ops->stop) > > + ret =3D (*dev->ops->stop)(dev); > > + > > + afu_rawdev_unlock(dev); > > +} > > + > > +static int afu_rawdev_close(struct rte_rawdev *rawdev) { > > + struct afu_rawdev *dev =3D NULL; > > + int ret =3D 0; > > + > > + IFPGA_RAWDEV_PMD_FUNC_TRACE(); > > + > > + dev =3D afu_rawdev_get_priv(rawdev); > > + if (!dev) > > + return -ENODEV; > > + > > + if (dev->ops && dev->ops->close) > > + ret =3D (*dev->ops->close)(dev); > > + > > + return ret; > > +} > > + > > +static int afu_rawdev_reset(struct rte_rawdev *rawdev) { > > + struct afu_rawdev *dev =3D NULL; > > + int ret =3D 0; > > + > > + IFPGA_RAWDEV_PMD_FUNC_TRACE(); > > + > > + dev =3D afu_rawdev_get_priv(rawdev); > > + if (!dev) > > + return -ENODEV; > > + > > + ret =3D afu_rawdev_trylock(dev); > > + if (!ret) { > > + IFPGA_RAWDEV_PMD_WARN("AFU is busy, please reset it > > later"); > > + return ret; > > + } > > + > > + if (dev->ops && dev->ops->reset) > > + ret =3D (*dev->ops->reset)(dev); > > + > > + afu_rawdev_unlock(dev); > > + > > + return ret; > > +} > > + > > +static int afu_rawdev_selftest(uint16_t dev_id) { > > + struct afu_rawdev *dev =3D NULL; > > + int ret =3D 0; > > + > > + IFPGA_RAWDEV_PMD_FUNC_TRACE(); > > + > > + if (!rte_rawdev_pmd_is_valid_dev(dev_id)) > > + return -ENODEV; > > + > > + dev =3D afu_rawdev_get_priv(&rte_rawdevs[dev_id]); > > + if (!dev) > > + return -ENOENT; > > + > > + ret =3D afu_rawdev_trylock(dev); > > + if (!ret) { > > + IFPGA_RAWDEV_PMD_WARN("AFU is busy, please test it > > later"); > > + return ret; > > + } > > + > > + if (dev->ops && dev->ops->test) > > + ret =3D (*dev->ops->test)(dev); > > + > > + afu_rawdev_unlock(dev); > > + > > + return ret; > > +} > > + > > +static int afu_rawdev_dump(struct rte_rawdev *rawdev, FILE *f) { > > + struct afu_rawdev *dev =3D NULL; > > + int ret =3D 0; > > + > > + IFPGA_RAWDEV_PMD_FUNC_TRACE(); > > + > > + dev =3D afu_rawdev_get_priv(rawdev); > > + if (!dev) > > + return -ENODEV; > > + > > + if (dev->ops && dev->ops->dump) > > + ret =3D (*dev->ops->dump)(dev, f); > > + > > + return ret; > > +} > > + > > +static const struct rte_rawdev_ops afu_rawdev_ops =3D { > > + .dev_info_get =3D NULL, > > + .dev_configure =3D afu_rawdev_configure, > > + .dev_start =3D afu_rawdev_start, > > + .dev_stop =3D afu_rawdev_stop, > > + .dev_close =3D afu_rawdev_close, > > + .dev_reset =3D afu_rawdev_reset, > > + > > + .queue_def_conf =3D NULL, > > + .queue_setup =3D NULL, > > + .queue_release =3D NULL, > > + .queue_count =3D NULL, > > + > > + .attr_get =3D NULL, > > + .attr_set =3D NULL, > > + > > + .enqueue_bufs =3D NULL, > > + .dequeue_bufs =3D NULL, > > + > > + .dump =3D afu_rawdev_dump, > > + > > + .xstats_get =3D NULL, > > + .xstats_get_names =3D NULL, > > + .xstats_get_by_name =3D NULL, > > + .xstats_reset =3D NULL, > > + > > + .firmware_status_get =3D NULL, > > + .firmware_version_get =3D NULL, > > + .firmware_load =3D NULL, > > + .firmware_unload =3D NULL, > > + > > + .dev_selftest =3D afu_rawdev_selftest, }; > > + > > +static int afu_shared_data_alloc(const char *name, > > + struct afu_shared_data **data, int socket_id) { > > + const struct rte_memzone *mz; > > + char mz_name[RTE_MEMZONE_NAMESIZE]; > > + struct afu_shared_data *sd =3D NULL; > > + int init_mz =3D 0; > > + > > + if (!name || !data) > > + return -EINVAL; > > + > > + /* name format is afu_?|??:??.? which is unique */ > > + snprintf(mz_name, sizeof(mz_name), "%s", name); > > + > > + mz =3D rte_memzone_lookup(mz_name); > > + if (!mz) { > > + mz =3D rte_memzone_reserve(mz_name, sizeof(struct > > afu_shared_data), > > + socket_id, 0); > > + init_mz =3D 1; > > + } > > + > > + if (!mz) { > > + IFPGA_RAWDEV_PMD_ERR("Allocate memory zone %s > > failed!", > > + mz_name); > > + return -ENOMEM; > > + } > > + > > + sd =3D (struct afu_shared_data *)mz->addr; > > + > > + if (init_mz) /* initialize memory zone on the first time */ > > + rte_spinlock_init(&sd->lock); > > + > > + *data =3D sd; > > + > > + return 0; > > +} > > + > > +static int afu_rawdev_name_get(struct rte_afu_device *afu_dev, char > > *name, > > + size_t size) > > +{ > > + int n =3D 0; > > + > > + if (!afu_dev || !name || !size) > > + return -EINVAL; > > + > > + n =3D snprintf(name, size, "afu_%s", afu_dev->device.name); > > + if (n >=3D (int)size) { > > + IFPGA_RAWDEV_PMD_ERR("Name of AFU device is too > > long!"); > > + return -ENAMETOOLONG; > > + } > > + > > + return 0; > > +} > > + > > +static struct afu_ops *afu_ops_get(struct rte_afu_uuid *afu_id) { > > + struct afu_rawdev_drv *drv =3D NULL; > > + > > + if (!afu_id) > > + return NULL; > > + > > + TAILQ_FOREACH(drv, &afu_pmd_list, next) { > > + if ((drv->uuid.uuid_low =3D=3D afu_id->uuid_low) && > > + (drv->uuid.uuid_high =3D=3D afu_id->uuid_high)) > > + break; > > + } > > + > > + return drv ? drv->ops : NULL; > > +} > > + > > +static int afu_rawdev_create(struct rte_afu_device *afu_dev, int > > +socket_id) { > > + struct rte_rawdev *rawdev =3D NULL; > > + struct afu_rawdev *dev =3D NULL; > > + char name[RTE_RAWDEV_NAME_MAX_LEN] =3D {0}; > > + int ret =3D 0; > > + > > + if (!afu_dev) > > + return -EINVAL; > > + > > + ret =3D afu_rawdev_name_get(afu_dev, name, sizeof(name)); > > + if (ret) > > + return ret; > > + > > + IFPGA_RAWDEV_PMD_INFO("Create raw device %s on NUMA > > node %d", > > + name, socket_id); > > + > > + /* Allocate device structure */ > > + rawdev =3D rte_rawdev_pmd_allocate(name, sizeof(struct > > afu_rawdev), > > + socket_id); > > + if (!rawdev) { > > + IFPGA_RAWDEV_PMD_ERR("Unable to allocate raw device"); > > + return -ENOMEM; > > + } > > + > > + rawdev->dev_ops =3D &afu_rawdev_ops; > > + rawdev->device =3D &afu_dev->device; > > + rawdev->driver_name =3D afu_dev->driver->driver.name; > > + > > + dev =3D afu_rawdev_get_priv(rawdev); > > + if (!dev) > > + goto cleanup; > > + > > + dev->rawdev =3D rawdev; > > + dev->port =3D afu_dev->id.port; > > + dev->addr =3D afu_dev->mem_resource[0].addr; > > + dev->ops =3D afu_ops_get(&afu_dev->id.uuid); > > + if (dev->ops =3D=3D NULL) { > > + IFPGA_RAWDEV_PMD_ERR("Unsupported AFU device"); > > + goto cleanup; > > + } > > + > > + if (dev->ops->init) { > > + ret =3D (*dev->ops->init)(dev); > > + if (ret) { > > + IFPGA_RAWDEV_PMD_ERR("Failed to init %s", > > name); > > + goto cleanup; > > + } > > + } > > + > > + ret =3D afu_shared_data_alloc(name, &dev->sd, socket_id); > > + if (ret) > > + goto cleanup; > > + > > + return ret; > > + > > +cleanup: > > + rte_rawdev_pmd_release(rawdev); > > + return ret; > > +} > > + > > +static int afu_rawdev_destroy(struct rte_afu_device *afu_dev) { > > + struct rte_rawdev *rawdev =3D NULL; > > + char name[RTE_RAWDEV_NAME_MAX_LEN] =3D {0}; > > + int ret =3D 0; > > + > > + if (!afu_dev) > > + return -EINVAL; > > + > > + ret =3D afu_rawdev_name_get(afu_dev, name, sizeof(name)); > > + if (ret) > > + return ret; > > + > > + IFPGA_RAWDEV_PMD_INFO("Destroy raw device %s", name); > > + > > + rawdev =3D rte_rawdev_pmd_get_named_dev(name); > > + if (!rawdev) { > > + IFPGA_RAWDEV_PMD_ERR("Raw device %s not found", > > name); > > + return -EINVAL; > > + } > > + > > + /* rte_rawdev_close is called by pmd_release */ > > + ret =3D rte_rawdev_pmd_release(rawdev); > > + if (ret) > > + IFPGA_RAWDEV_PMD_DEBUG("Device cleanup failed"); > > + > > + return 0; > > +} > > + > > +static int afu_rawdev_probe(struct rte_afu_device *afu_dev) { > > + IFPGA_RAWDEV_PMD_FUNC_TRACE(); > > + return afu_rawdev_create(afu_dev, rte_socket_id()); } > > + > Function format issue. >=20 > > +static int afu_rawdev_remove(struct rte_afu_device *afu_dev) { > > + IFPGA_RAWDEV_PMD_FUNC_TRACE(); > > + return afu_rawdev_destroy(afu_dev); > > +} > > + > > +static struct rte_afu_driver afu_pmd =3D { > > + .id_table =3D afu_pmd_uuid_map, > > + .probe =3D afu_rawdev_probe, > > + .remove =3D afu_rawdev_remove > > +}; > > + > > +RTE_PMD_REGISTER_AFU(afu_rawdev_driver, afu_pmd); > > + > > +static void update_uuid_map(void) > > +{ > > + int i =3D 0; > > + struct rte_afu_uuid *afu_id =3D afu_pmd_uuid_map; > > + struct afu_rawdev_drv *drv; > > + > > + TAILQ_FOREACH(drv, &afu_pmd_list, next) { > > + if (i++ < AFU_RAWDEV_MAX_DRVS) { > > + afu_id->uuid_low =3D drv->uuid.uuid_low; > > + afu_id->uuid_high =3D drv->uuid.uuid_high; > > + afu_id++; > > + } > > + } > > + if (i <=3D AFU_RAWDEV_MAX_DRVS) { > > + afu_id->uuid_low =3D 0; > > + afu_id->uuid_high =3D 0; > > + } > > +} > > + > > +void afu_pmd_register(struct afu_rawdev_drv *driver) { > > + TAILQ_INSERT_TAIL(&afu_pmd_list, driver, next); > > + update_uuid_map(); > > +} > > + > > +void afu_pmd_unregister(struct afu_rawdev_drv *driver) { > > + TAILQ_REMOVE(&afu_pmd_list, driver, next); > > + update_uuid_map(); > > +} > > diff --git a/drivers/raw/ifpga/afu_pmd_core.h > > b/drivers/raw/ifpga/afu_pmd_core.h > > new file mode 100644 > > index 0000000..4fad2c7 > > --- /dev/null > > +++ b/drivers/raw/ifpga/afu_pmd_core.h > > @@ -0,0 +1,76 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright 2022 Intel Corporation > > + */ > > + > > +#ifndef __AFU_PMD_CORE_H__ > > +#define __AFU_PMD_CORE_H__ > > + > > +#ifdef __cplusplus > > +extern "C" { > > +#endif > > + > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > + > > +#include "ifpga_rawdev.h" > > + > > +#define AFU_RAWDEV_MAX_DRVS 32 > > + > > +struct afu_rawdev; > > + > > +struct afu_ops { > > + int (*init)(struct afu_rawdev *dev); > > + int (*config)(struct afu_rawdev *dev, void *config, > > + size_t config_size); > > + int (*start)(struct afu_rawdev *dev); > > + int (*stop)(struct afu_rawdev *dev); > > + int (*test)(struct afu_rawdev *dev); > > + int (*close)(struct afu_rawdev *dev); > > + int (*reset)(struct afu_rawdev *dev); > > + int (*dump)(struct afu_rawdev *dev, FILE *f); }; > > + > > +struct afu_shared_data { > > + rte_spinlock_t lock; /* lock for multi-process access */ }; > > + > > +struct afu_rawdev_drv { > > + TAILQ_ENTRY(afu_rawdev_drv) next; > > + struct rte_afu_uuid uuid; > > + struct afu_ops *ops; > > +}; > > + > > +struct afu_rawdev { > > + struct rte_rawdev *rawdev; /* point to parent raw device */ > > + struct afu_shared_data *sd; /* shared data for multi-process */ > > + struct afu_ops *ops; /* device operation functions */ > > + int port; /* index of port the AFU attached */ > > + void *addr; /* base address of AFU registers */ > > + void *priv; /* private driver data */ }; > > + > > +static inline struct afu_rawdev * > > +afu_rawdev_get_priv(const struct rte_rawdev *rawdev) { > > + return rawdev ? (struct afu_rawdev *)rawdev->dev_private : NULL; } > > + > > +void afu_pmd_register(struct afu_rawdev_drv *driver); void > > +afu_pmd_unregister(struct afu_rawdev_drv *driver); > > + > > +#define AFU_PMD_REGISTER(drv)\ > > +RTE_INIT(afupmdinitfunc_ ##drv)\ > > +{\ > > + afu_pmd_register(&drv);\ > > +} > > + > > +#ifdef __cplusplus > > +} > > +#endif > > + > > +#endif /* __AFU_PMD_CORE_H__ */ > > diff --git a/drivers/raw/ifpga/meson.build > > b/drivers/raw/ifpga/meson.build index aeccc17..d9a6f29 100644 > > --- a/drivers/raw/ifpga/meson.build > > +++ b/drivers/raw/ifpga/meson.build > > @@ -13,7 +13,7 @@ objs =3D [base_objs] > > deps +=3D ['ethdev', 'rawdev', 'pci', 'bus_pci', 'kvargs', > > 'bus_vdev', 'bus_ifpga', 'net', 'net_i40e', 'net_ipn3ke'] > > > > -sources =3D files('ifpga_rawdev.c', 'rte_pmd_ifpga.c') > > +sources =3D files('ifpga_rawdev.c', 'rte_pmd_ifpga.c', > > +'afu_pmd_core.c') > > > > includes +=3D include_directories('base') includes +=3D > > include_directories('../../net/ipn3ke') > > -- > > 1.8.3.1 >=20 > Reviewed-by: Rosen Xu