From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF824A0524; Wed, 14 Apr 2021 09:06:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73AE9161745; Wed, 14 Apr 2021 09:06:23 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 7A623161708 for ; Wed, 14 Apr 2021 09:06:21 +0200 (CEST) IronPort-SDR: Rygp3KoGlCsHS4yun2GExmYnRiJ6gQ91H7Z3rFlBy6cIiaSXkAxacudAL1iFcMhRNVA/9DZXNV Yph0cJVm/D7Q== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="215072277" X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="215072277" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 00:06:19 -0700 IronPort-SDR: Rlu5aZuBWUWlMjQkB1xTkscIyeSi+xYIQ+RBzYL4NteCVrx0uC7LeOt0qidPbtVJ6q+tDoMERj nbRaO88LEtkg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="521892740" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga001.fm.intel.com with ESMTP; 14 Apr 2021 00:06:19 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 14 Apr 2021 00:06:18 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 14 Apr 2021 00:06:17 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 14 Apr 2021 00:06:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nimuGZXqYtbr6JHzTUyYtvsDXS+OVgOWVs1i2SpiFW/T2ouW+JXxjUQAr1AiQAZIr/FpkZQeN1PIdx2RGHgW7IWXKL9hH+iiQ/B1zK4Ey6HC4qOuRQg+hn/p/ZgtZ0sH1WnJEPicQMdDB76UIUvcX57Y3sFT06hysWzH6/tmbCYRz45zQqWJ71VCVWRk3Bu+Po+cPNxORbcxcQPAY3iZ4aFw6h2H/pz/7RlEa+0Tn4V2Vs93taOtCLBAlf51t1qVSkiWu4/XE8laswEmMUAEvtXpDpecZKgHZNHgxsZYQx/PKLI4PYZ3fKnk14aFN2W/+KReXYISdIV/uPLdVIBvQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ohNtbOsXZPEKPyDevJHBhfbpfQ1qU5MlrHtO6hKeBE=; b=JIWlC9b1HpCh2ggtqkmUBPQRWQc7wpfuq5yzxxEwp4oaOUGKLtY64PF/C8kq0Z/oR5PquipaZOWcyC/yLtvj/TAn1Xv1mpO0mIWSMwEEbCUlTALt52KWwF38bJWNIzV3SjlsLRIAiHwZqqlMGlgSdXWD8WBmn5XytiqSZ/wI1lv3bDPdvmifXXQydsU4DPwvaa6aI75Ebdt9JejXyIcJTWvuKRH11fQDkUcePX3pZ0u6/M73tyYNJND140kNSHIwcWC7S7a10yK57xXfXW9R/Cbfz8G8KugGpJbzFZfo5KtJvbNXkm0jz3Tz8oqGtjG6P9iES5JmKqhzu20F37O1/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ohNtbOsXZPEKPyDevJHBhfbpfQ1qU5MlrHtO6hKeBE=; b=rYpvE37nVcPZlk0/Kl667lTZ8iNedaacVT95i+/m3I8OJ9sVctcxodue9DmSpYtwTJKpi4gKQQirM/QAE8nak/TDqGpf8HrrlX7PeLDdl5caSfBQE6PrjN3WdPV6UihMGlwxhPHkHJLiFpXmMzj2W9PAcN07DATyff391YeM8eY= Received: from DM6PR11MB3548.namprd11.prod.outlook.com (2603:10b6:5:143::18) by DM6PR11MB3722.namprd11.prod.outlook.com (2603:10b6:5:13b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16; Wed, 14 Apr 2021 07:06:16 +0000 Received: from DM6PR11MB3548.namprd11.prod.outlook.com ([fe80::b865:77e3:1509:e121]) by DM6PR11MB3548.namprd11.prod.outlook.com ([fe80::b865:77e3:1509:e121%3]) with mapi id 15.20.4042.016; Wed, 14 Apr 2021 07:06:15 +0000 From: "Gujjar, Abhinandan S" To: Shijith Thotton CC: Shijith Thotton , "dev@dpdk.org" , Jerin Jacob , Akhil Goyal , "Anoob Joseph" Thread-Topic: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto adapter service Thread-Index: AQHXL3l4zO8/00LKDE6IGB+tdObWwqqx1bwQgAA+6gCAAYWR8A== Date: Wed, 14 Apr 2021 07:06:15 +0000 Message-ID: References: <20210409070809.456444-1-sthotton@marvell.com> <8d73cf4b565f5f66badaca26ec3a9f26cedf2304.1618217424.git.sthotton@marvell.com> <20210413075124.GA21@BG-LT7405.marvell.com> In-Reply-To: <20210413075124.GA21@BG-LT7405.marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e420bfe3-912f-4413-b6cb-08d8ff13cba7 x-ms-traffictypediagnostic: DM6PR11MB3722: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:409; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T4iPugBBuG5A9GbFy/FJpoWJmISei/F68jSlrF0E0N3hhb+tqNQGKAZKW/sqN6vOATyKH5wt8X8LGzjwJbFCk7VkSQ5KKxVCyFAA5JuheE7IksMR/oYg3OogskmQk3oiy06qNE8mBYF6LBxKdF3zmN0skQDnkQwTgbMoOz3ebneSx/DDInmAuiF1vSZrYZT4lybUdWueN0KaQUciedaHwFPsLEoWUzEc1qFx3mHqsKfnVqBOqjJGUtmkGdKp70DysaFT5i6TB/zMQfZZ3uNxwQOZBKP4UaiAPiC6YL1DL/gF567WGdfmfhw+/1OzCeEjzRiuJLzla1HnOpMhrcrSimFkFlX+5Y4YmCLBDvfbbETRU81HpReSONXOa64Gbx7XTDiCqZ2DNtfxiBP50XVMgoDWE9hQbUKeAO6P8s9eoYK1WIVQI6BpzuBuuAqjbYoWvaZXVz5qdC/W66hEm8t+t0QoZxrV+mgqdkYmbYAxS7GjuSTiXX/rlTlAJnIk9g+tm2ZijDoG7/Fi4TBSOY0RWrzImxGxPdkY+UkL+ZoqrnRJzlW5yGKgY8boPKHqdyEjRCD+lhcxWujjoIaPqAbi3rVaKj0OHffWywDWyY5eoVA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3548.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(39860400002)(136003)(366004)(376002)(396003)(71200400001)(76116006)(5660300002)(66556008)(52536014)(66446008)(64756008)(33656002)(66946007)(86362001)(8936002)(55016002)(9686003)(478600001)(66476007)(316002)(4326008)(54906003)(26005)(186003)(53546011)(8676002)(7696005)(6506007)(55236004)(38100700002)(6916009)(2906002)(83380400001)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?LTDgmtZB/WMI5pTn+Usl/oFZLFT+jiZaNcyWVXNh2gBsaHMAwcKpQ6Q4+bEl?= =?us-ascii?Q?LuFP5t4kLzfa86FxwnLZlgrJX2rB1yHcyRwQ243EQsSwSNMibDMIO3d9JiCS?= =?us-ascii?Q?ILYyhEchs/zCQDXX3eIG+MTMXXIalQJayA2V0afdgT2km2cO9v61f/cOCnD3?= =?us-ascii?Q?/qW/qavRoCJbD+yuEtWtPWOR5yZN2sYRMy2NC/gxZ+XaqXocEm5PIx6LJzel?= =?us-ascii?Q?j6HsNxFV6sYvVdp3kewLdjrojvSShn1snwkG+F3N87JSZeW2jA8VbC0czMZx?= =?us-ascii?Q?UBEHL+N46yKM47zPWzSvA1rlVsh0BJfMhSF4fM4DMqvjwo9FooFcIJmJGYqe?= =?us-ascii?Q?/JG2R7kew0ebtiLBTIkhWpEyRMUWA7iVZWNhBndBz7LWWlh7Br0zJxoMIFzo?= =?us-ascii?Q?BRb7YRXVKdu3vDMc6Plsc7A9CytzYCGPoy5VEwzRjLWqMyd1/OJnMVZkDuJZ?= =?us-ascii?Q?UMZ72+EASNn0Z3U7gS54fkKvwHgVyHk+HWxCKorgWvtysD4cM9E26DC9ur2S?= =?us-ascii?Q?2hRqXIFblMWpEG//pOc5QS91cFvRk5SXJqU0cWdHhU8vO/+uUE1R9S+WXE82?= =?us-ascii?Q?5ZVdwNStN8vPsDqA5iJ+6H5DwIpmu8BNIZccT5iGadaqP5k67BfbjKhsIA3m?= =?us-ascii?Q?VOl/+ggFxnBimlMJaXt+t23/9Uoo8wWEYxgbmunpAnTJsID003OyZUpcnuW+?= =?us-ascii?Q?B/WbNHGILpL1cihRJvMDRO48xK0wJCpEDjdXDBhZfbDkeW85gZ2EuskerD/s?= =?us-ascii?Q?3TNwS6kh56R5b+lb5B+MIayeY9p40iZaJaMeasabiDPFFl+3+QzVGz+Txnwp?= =?us-ascii?Q?ow+LWPFHEv8MlUMKcUTehL2s7gS6N94tWRLaQdfVPrctT+P1w+pbpfGIh+ld?= =?us-ascii?Q?sSuPY0ksWoI3TJD36+0I3Dry/XcKrBiHyRakcdw6X7YPUrg9l87aHabIT952?= =?us-ascii?Q?OwmvCGhHYE30HH0BwY6EG+b17PQ/DZsee2wpITtFN409tCkwe8apjDJeSwvD?= =?us-ascii?Q?JGQ6YVk46hU8FFvGQrQlESW96lNSm150pDL1OaiarvR68O2YeNFH+KSKlrdq?= =?us-ascii?Q?wTzsSEHPiDWmFBlJw2Ziwo7ac23nZy2ahVoCOVP7kHZfpWoXDMccXCFuZpg+?= =?us-ascii?Q?4PyFttnsmTQE+7gc6U9hQxnskF80yGdw356YR7gHo0Ro8tx312UMa8J/918K?= =?us-ascii?Q?yTly/ShIYFhOx/0A4UM0Ft+PVdkazb1/cXs7ra6WQxPoyx889FfAyLrutX06?= =?us-ascii?Q?75+1KaAgthjMsxSWcpy3TbaahKIw8y5MHRMywauV0ClhizNPLHYDU4nnLdb6?= =?us-ascii?Q?Ehs=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3548.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e420bfe3-912f-4413-b6cb-08d8ff13cba7 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2021 07:06:15.7513 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: apDXpxUGbSuqNZV4gugac1j91BzvSL88R4t38GWUw7mtDNz0HQR9NcM2GAUxu9YyMAZ/qZZtE2LWXbhj2Yl03tzWtCFGRlO+Pdv+M6CwDhU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3722 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto adapter service X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Shijith Thotton > Sent: Tuesday, April 13, 2021 1:21 PM > To: Gujjar, Abhinandan S > Cc: Shijith Thotton ; dev@dpdk.org; Jerin Jacob > ; Akhil Goyal ; Anoob Joseph > > Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto > adapter service >=20 > On Tue, Apr 13, 2021 at 04:08:40AM +0000, Gujjar, Abhinandan S wrote: > > > > > > > -----Original Message----- > > > From: Shijith Thotton > > > Sent: Monday, April 12, 2021 2:24 PM > > > To: dev@dpdk.org > > > Cc: Shijith Thotton ; Gujjar, Abhinandan S > > > ; Jerin Jacob ; > > > Akhil Goyal ; Anoob Joseph > > > > Subject: [PATCH v2] eventdev: fix case to initiate crypto adapter > > > service > > > > > > Initiate software crypto adapter service, only if hardware > > > capabilities are not reported. In OP_FORWARD mode, software service > > > is not required to enqueue events if OP_FORWARD capability is > supported by the PMD. > > > > > > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") > > > > > > Signed-off-by: Shijith Thotton > > > --- > > > v2: > > > - Reworded commit message. > > > > > > lib/librte_eventdev/rte_event_crypto_adapter.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c > > > b/lib/librte_eventdev/rte_event_crypto_adapter.c > > > index d903cdd48..e1d38d383 100644 > > > --- a/lib/librte_eventdev/rte_event_crypto_adapter.c > > > +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c > > > @@ -861,6 +861,7 @@ > rte_event_crypto_adapter_queue_pair_add(uint8_t > > > id, > > > * b. OP_NEW mode -> SW Dequeue > > > */ > > > if ((cap & > > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW && > > > + !(cap & > > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && > > The same check is below ORed with above condition. > > This is confusing. Could you recheck & do the necessary changes? > > >=20 > As per comments above, below checks are used to initiate SW service if: > 1. PMDs supports OP_NEW, but not OP_FWD, in FWD mode. > 2. Does not support OP_NEW and OP_FWD. >=20 > I have fixed the first point where only support for OP_NEW is checked in > forward mode, by adding a check for no OP_FWD capability. Sounds good. Acked-by: Abhinandan.gujjar@intel.com >=20 > > > adapter->mode =3D=3D > > > RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) || > > > (!(cap & > > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) && > > > !(cap & > > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && > > > -- > > > 2.25.1 > >