From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1172A0524; Tue, 13 Apr 2021 06:08:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA67C160A6C; Tue, 13 Apr 2021 06:08:48 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 02A66160A54 for ; Tue, 13 Apr 2021 06:08:46 +0200 (CEST) IronPort-SDR: Z4HFZMdEAgOEIWTT7FUtBpHNroeJ2+JX/PRWT4/hB7m+nvo/v5lEuWzKAhhC2c3fbdqzn1GMfW gwfaWo7CpsbA== X-IronPort-AV: E=McAfee;i="6200,9189,9952"; a="255659320" X-IronPort-AV: E=Sophos;i="5.82,218,1613462400"; d="scan'208";a="255659320" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 21:08:42 -0700 IronPort-SDR: QIgjsU7OjW2n/R2ZCUsEeckX1nwEoxn7w94ubuEvO5m2dl07ZSok3SLOtbT2ZWyvj3GSvpq0xF acuRoz9H9gNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,218,1613462400"; d="scan'208";a="521447436" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga001.fm.intel.com with ESMTP; 12 Apr 2021 21:08:42 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 12 Apr 2021 21:08:41 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 12 Apr 2021 21:08:41 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 12 Apr 2021 21:08:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NELi+9Xc4aNvh2wRTEo2cR7RqJr4kXOH0/nk3XT5VHpaC7V3YwCPeYK+864uEQBAwdugCceIK+4+Fjt7I754mrCmeuuYQLkDMqW3/dDJ1AUspHDAxYT6R4/pCgVyB3SiQXhXaHZ/r5/D5uKLy2cTVV+aBpKRXzwB9fFudjb/0nZaFa99rVQuEm40R4Y/Vly4h+B2XI8CaMJ/n53rDay4wf2WAVBQCRJpjOsyqG3UfHqq3iMVepj8O98FrSbyxPUiKcnAY+adGMN1emDQpA7KoEp64V3jv3X1va9qO2OxOPB0uVVL2QMfDVaj5TiOMPFQ+uHPFIUvJB3r1g+bIsAoVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2mYFN7H/G7BgEAd7QZlomi7TlkYu0lf6frv71WsoQ1g=; b=JU7u6osQMpNvxo6HU3UOWVVlei/lYmRsok1+Rj1YD9THkDDNQ+k/Z7EYAWE2UDzpqFRrkjytzFV4fjINNMlvxXSYvWEoSzMbvpCe7XlmBxE4uoWtghOWax3I1aPVprwN4589izTmzjPQ1wc+p+tLvL8/1tcFFutsisK8+i9vcHl//dh6kxnVR4P2RzCq8KWdMg4NY2QSQrullotTgJoV8G7eaO7ZI7kT5NscKYyUmsQUsNESG6XWxJbrEFn9WS28AfW/si4d/UjHhZr9Dk6EmYEFU/JJ5XYl43M6UbgpKQsdftDjOOQJ547pD86M3pEjreyMqO1naETxhiTK9z1f5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2mYFN7H/G7BgEAd7QZlomi7TlkYu0lf6frv71WsoQ1g=; b=ansY5SnJC3db6A6u1q7r0GQhuGhLvgWSPbHvxeOEd8XlepDONRcxJD+Ppgq84Xy/01q4dSgd5yZWLfv/dCeoBPFQB5AFQIUZcAf5ayqkit+2emniQa6eLs9WELO4acLSqZRDCMdlhztjx21zdWkDO1Rp/oqPxS7Qko6ckMrN+Vc= Received: from DM6PR11MB3548.namprd11.prod.outlook.com (2603:10b6:5:143::18) by DM5PR11MB1946.namprd11.prod.outlook.com (2603:10b6:3:10c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16; Tue, 13 Apr 2021 04:08:40 +0000 Received: from DM6PR11MB3548.namprd11.prod.outlook.com ([fe80::b865:77e3:1509:e121]) by DM6PR11MB3548.namprd11.prod.outlook.com ([fe80::b865:77e3:1509:e121%3]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 04:08:40 +0000 From: "Gujjar, Abhinandan S" To: Shijith Thotton , "dev@dpdk.org" CC: Jerin Jacob , Akhil Goyal , "Anoob Joseph" Thread-Topic: [PATCH v2] eventdev: fix case to initiate crypto adapter service Thread-Index: AQHXL3l4zO8/00LKDE6IGB+tdObWwqqx1bwQ Date: Tue, 13 Apr 2021 04:08:40 +0000 Message-ID: References: <20210409070809.456444-1-sthotton@marvell.com> <8d73cf4b565f5f66badaca26ec3a9f26cedf2304.1618217424.git.sthotton@marvell.com> In-Reply-To: <8d73cf4b565f5f66badaca26ec3a9f26cedf2304.1618217424.git.sthotton@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2075d4f0-53fd-4e3c-b65c-08d8fe31d1fe x-ms-traffictypediagnostic: DM5PR11MB1946: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:178; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: l7f+gvu6qkAOCYeLT+hBVurCLBF3vQENbcSixCOPAaCDNvaSqoRD6HzcjwkUC1muvwccOb88zjS5rFw2PmMdS85jxJ0VfnsCdH6UF/4k4dXnqJudWyJh5T5cVP8f/Xb88Bu4IL4KqIhrIagfY0EnHywI5Bk0JwX6iuR9mKfQ90yjukZLk5X2JdNQYzsWDRXh7noqi/p9jOHWzISFIT/ofHXvgrq1Rn3g7u2YpHCtF/apYnX9KjA8hiHG+FYPk1gnJ06Lgg3gbCHrpnfpBarGkYHJvUkXoc0t35gvuldo8ij1fMY0dlwaTz3fZicXpJ8oLnczo4aXX0vOrzbYCkHrwmguMsflVrej4Af4LcQjWwJbVYGrH0HYYmVQF1wHhtNrNYpSWlg143/JPG/iJvq7pNgQz3Hwr5Su48kPwaGaZBbAG+LChq3UEGkaDeXCoB2o1tDz5oy3IEna8P72V2xYEE1VoEIwrl+0E4qXBvQAsuznZC5syR1OeYXP5Q8Nzw/OaLrecRdt5lOhHtdFJo3m8H+5ohunCELGCytRCbDEtEcSLUuvWf5T+TPHfujz7DwjvuiRo68uT4e/DszCdK8PQJE0bwL+xy/iONBHFRSBd9I= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3548.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(346002)(396003)(136003)(376002)(39860400002)(66946007)(38100700002)(2906002)(86362001)(66446008)(110136005)(55236004)(7696005)(66476007)(33656002)(83380400001)(76116006)(64756008)(66556008)(71200400001)(6506007)(186003)(53546011)(316002)(9686003)(5660300002)(478600001)(52536014)(54906003)(8676002)(55016002)(4326008)(122000001)(26005)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Xzghzv9R7UkWTrksDJxth1lYVoPt+0TxiRdC1pzrVcFaLfDGk9Jkx58ZT62K?= =?us-ascii?Q?UxnYjhd5SBWmP0+nsGMZxoBUrMg1aFX1DxoiBesqXdRroPW8AQay9vdFTKlF?= =?us-ascii?Q?0E8ihW8qeY9kFpVEsga+dLnK26CDVFPZ9Rg3lx5HghaYsxI953YW3+LUgZSw?= =?us-ascii?Q?cVo2YY0MvSXoEqc5CjycV+FheHVX+935pFqpXCwKSYA2dxsfb3MIIonH4/tv?= =?us-ascii?Q?VQnciHfQNDKUgqhrbPyE+zZv9FwR1I7612gjeo3PAFP+M7FDJvF5s/vTVLcs?= =?us-ascii?Q?ZN9v+zFNQDHDJMOuHLEqkgid/CPTc1RFF8GsxTSnjqBuSMXTBG9dFdK1m0FG?= =?us-ascii?Q?zMHSyY1Xmtnc0NFqOXmvu10w7stP3e0lJWIqapmNVy9Uy5NntaZm3LEXv685?= =?us-ascii?Q?eR8ioBrb6oQzcvPZtuiHa115zcPDziRac1knNLZdq2RxK8WSRMjxGuxBFgJN?= =?us-ascii?Q?ct2oOJgdoKNbjdcE2NCs0vsWZG6rDlx8RrSKF926tLsFBfF6+HRhhuxaXH9m?= =?us-ascii?Q?ozA0a6rpcvPcp0I1FB9mvn4jNQmjhkFsXGWLEaZdbJYQP7iK8YyZVPU089hh?= =?us-ascii?Q?zNnQl0j75vJ6UJxHk35HYWylosLJDoEHXBgabLT2w6VuJVIPpdn98Cy77uPg?= =?us-ascii?Q?OwZJ0KDz44gfz/FKmnonRivkAN5TfV2/vM6dpoBsmbu4HbQY2q9bUcE8cAUL?= =?us-ascii?Q?JHNCLUzQRM3c9fmX2KTinRFfOjkFeB+oCAG1Wwbuss+AfKMqAkU38rVFufkp?= =?us-ascii?Q?O4YPaO1ozw9GRWfcZJzX1+cqa86L/7vOLbM9ZoQKCRqYvbrzKPjHEjmafXPg?= =?us-ascii?Q?aTpTscty+6jmBdkdyWkhJtXgysL+X2a+Ij5l+UyLY/6ZevqxWD51ZEp/x89y?= =?us-ascii?Q?Q7AyfQLjIhEa3PwoOA13noEFLuTupAH4Zzq7lYC79vi//vCY8SFboDwCaO4a?= =?us-ascii?Q?d4HXX7Su4tqWaXRk5PK8B2ZidFfeAnGGJE8f7cHxvq8lTTIdvT6Hx8CoTdYG?= =?us-ascii?Q?EdrztdZy5uuMPnwKyUsjT9WXUk03d+5pt47SYC1OQd48dJn3lCF6a9ctB84H?= =?us-ascii?Q?uNUMwm23fjhQHCFoULAEl/hRsWVu6d+wefK7S64LMQj9OUY0fKjHdN5x3mwd?= =?us-ascii?Q?LhZpRzfn1YQu0Ysh27dZ1FTsuSGM0+VjomXzcHsIphxUZ0gaTbh7bVlbg0PZ?= =?us-ascii?Q?8/V/9wLJCJzyIMQuHTaVT1kW/30FoMM+QO+Us4bupRys4OfBKU25DFHt8Y4k?= =?us-ascii?Q?gVdDpd8rSjYM/WArAgyCCt4eKLCX/qf37PgDQ1WDtlJiqCF1w7kQIWHZQhTs?= =?us-ascii?Q?Pv1yv0tJAHXKd6zrJR9C0fM+?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3548.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2075d4f0-53fd-4e3c-b65c-08d8fe31d1fe X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2021 04:08:40.1829 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rwSTDbY8TdUPA1A4ru4pjU21IYWqBmJJ0UgN1oIRDvmo/U0uWplRPMQC+D2ftDF+Q9en4zpIYGyQmwqBkNm/2l5kQgAByjN40YJRkajrYe8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1946 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto adapter service X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Shijith Thotton > Sent: Monday, April 12, 2021 2:24 PM > To: dev@dpdk.org > Cc: Shijith Thotton ; Gujjar, Abhinandan S > ; Jerin Jacob ; Akhil > Goyal ; Anoob Joseph > Subject: [PATCH v2] eventdev: fix case to initiate crypto adapter service >=20 > Initiate software crypto adapter service, only if hardware capabilities a= re not > reported. In OP_FORWARD mode, software service is not required to > enqueue events if OP_FORWARD capability is supported by the PMD. >=20 > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") >=20 > Signed-off-by: Shijith Thotton > --- > v2: > - Reworded commit message. >=20 > lib/librte_eventdev/rte_event_crypto_adapter.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c > b/lib/librte_eventdev/rte_event_crypto_adapter.c > index d903cdd48..e1d38d383 100644 > --- a/lib/librte_eventdev/rte_event_crypto_adapter.c > +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c > @@ -861,6 +861,7 @@ rte_event_crypto_adapter_queue_pair_add(uint8_t > id, > * b. OP_NEW mode -> SW Dequeue > */ > if ((cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW && > + !(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && The same check is below ORed with above condition. This is confusing. Could you recheck & do the necessary changes? =20 > adapter->mode =3D=3D > RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) || > (!(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) && > !(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && > -- > 2.25.1