From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A1D9A00BE; Wed, 29 Apr 2020 09:44:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0ED7F1D93E; Wed, 29 Apr 2020 09:44:12 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A2A821D935 for ; Wed, 29 Apr 2020 09:44:09 +0200 (CEST) IronPort-SDR: PptXMISGo/Zf+2NS9bFLGnfPOunBinZRQ7xsQEkAd4tgvHe+LkY21DsVWS1HZnU5k4FxTmoLAF VmX80B3Hc4hw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 00:44:08 -0700 IronPort-SDR: 5O7yifQaHVjo+uIc4pa/QjNVKuiSq33zXvNr9xVTf+FFECKtptJl2BHz82tmYrD48Z3ovtUyx4 dOj5yTVu0DMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,330,1583222400"; d="scan'208";a="249391569" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga008.fm.intel.com with ESMTP; 29 Apr 2020 00:44:08 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 00:44:08 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 29 Apr 2020 00:44:07 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 29 Apr 2020 00:44:07 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 00:44:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SYyfAOCiqjBZyf/D7Vheo3SCgB0NARv7xSmlj2dhKzx5OlEpgynmbhkLFLMBg9lUm8xZfMSpWFYeYZKlWDryj+1LfXAuDnDTAB8I7On8uQYT24jLq06ZAGEbQ62tpZtMW6ycfBT6UVZQkrViZroaLipxgIGd/V9OB1LVoECL44bD5pBXGwSJtsLjzFRvqhsSRkCNXopr84y0dT8/RVBCASy4I0zK5AXAI1qLWILMBklSl/WNm3b3hURiXQKmpJMCrw8yTx99pjgMTvOxPYz16soyvGpQDDNrviDxatbCRG5ttq2XqT58eKJmhgt48pgb0we5qdev6Ejg3oLFcbV3Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ctjF1NYX7RigwO+dUrKsBF7g2qPxUS52QQb5WZYCj1U=; b=XzzFhECMdf6FGUcm89bdBgUQeJI6jxyJNjW/D8sS7S9BoqMzTmJ3oSaZCX9NrP6awmUOz7ccMFFyLdS/llmBSkA/+VbK+mkLtMHVYhQfr/zDjNozyjHkthQK6BtxVipkImj33kFgtj57I38/iBEvBDs8cHuRtUx+/+e/SG3rgV7GvZCbX3A0T/9+lQ1R86DEEVvBBDl8jZRAGkh/VNz38r/YnKJngWsDv05unY0S4B0sTb2Q2aF5l63LJvgUI9pl97FxhyqFZlpvimaDvcH//lyeTp7gQUJ6SHOufSi+pz+dDp/mEkhCeMx0umJf72Go1jCDksHr+ujs07p6BEmUBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ctjF1NYX7RigwO+dUrKsBF7g2qPxUS52QQb5WZYCj1U=; b=auiqCDlzgMhBJnDyWxkgj+a3DcQiT1MM6fl13tmSbgmuvH+0Xjtr3MbuWbnuk2w1PqLkXQZc7M7pOg3/cNcomt+mZLQmI9qQ9MrC3L0oZ5dZdqKyN9ky1morxgkA9q2dM16B7TZdnXBIJpvah78+pOshXKXpWnbCsb02yRUuipA= Received: from DM6PR11MB3578.namprd11.prod.outlook.com (2603:10b6:5:143::17) by DM6PR11MB4297.namprd11.prod.outlook.com (2603:10b6:5:14e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19; Wed, 29 Apr 2020 07:44:04 +0000 Received: from DM6PR11MB3578.namprd11.prod.outlook.com ([fe80::7143:a5b8:8ade:3fbe]) by DM6PR11MB3578.namprd11.prod.outlook.com ([fe80::7143:a5b8:8ade:3fbe%7]) with mapi id 15.20.2937.028; Wed, 29 Apr 2020 07:44:04 +0000 From: "Yang, Qiming" To: "Zhang, Qi Z" CC: "dev@dpdk.org" , "Ye, Xiaolong" Thread-Topic: [PATCH v2] net/ice/base: fix DCF switch rule Thread-Index: AQHWGW+2cuPjBkowFkir4P+pGZaqV6iPwONg Date: Wed, 29 Apr 2020 07:44:04 +0000 Message-ID: References: <20200423130704.37332-1-qi.z.zhang@intel.com> In-Reply-To: <20200423130704.37332-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a08732c9-af2f-4dfe-5459-08d7ec11172f x-ms-traffictypediagnostic: DM6PR11MB4297: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1775; x-forefront-prvs: 03883BD916 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SLvL1RRJyMa1/oFnwjnbxwZKle6//+iU5wDLlBtsnJh7m9msgD1fjmbqk3POnJ7A393uyQU9sj3WQXgPaJLPUEWttjXpRf3RItig6ZsKOHVywYxe4wCfGayMSFSR3m20vytvkcmWD6eUNLTVfwsg1lYJLLoYj6FbbIy23xro1UkkUXetYjZWqPsCirzYFojF5OjzwQfpwmPNoTqgLISxjwl6lTjHxjFXQR2CDSpN2/9SojQagb56ebs/usbqu8YvcqwpRb9zHb30ayUQaZczhh0qcAfpKqJoDkJAotLDOz7NXopiV72bIxNbZ8sP1G8tLfODAWGO2Iegz897rSHI4NYGdZPsIkMsAmNhgDRt3Z+Kk0zkCvFihMCNyv5ugVgYpDqEtN/oe4Pu05AlbgsEReQ2cpYp5KUUrylJSIjpD9QMmukgjO/d/laC/cd3dF/R x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3578.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(366004)(396003)(376002)(39860400002)(346002)(316002)(478600001)(71200400001)(33656002)(8936002)(66946007)(64756008)(66476007)(6636002)(66446008)(76116006)(8676002)(66556008)(52536014)(2906002)(6506007)(53546011)(107886003)(5660300002)(9686003)(26005)(55016002)(186003)(86362001)(6862004)(4326008)(54906003)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: xs3tdMLZtFeqODvxjYl+OpYZRDu3vVgIh44+8gKamUU3KuLRSeE4nw+rODQNw9u08v7WDW2k4lh8yHJfmFVePdSfbqk3g9jQnNW7bAuXMK3DdNK5nRpG+ZRU1woPrAwtizyhtUIpdXaeI93mb+lg55IHKOqT9XkdmZTFrTABO1ZXiWrN7CCQp1w+46Jz/d0fSCaNN+kivCTg/HS71WtYXdRXfsQ2a83OBMdCyX9cnAaqK26MA/yTm1lnVYTsLw2+ztoJWq7ffpKLYCdAgg8auWqJvh5HyZdOGjj1+RuzzWTV4bwff/tnEyxzc3e0djkhepoc7Nuq3FYoilIw2Hik9jEby8smTuHsocrlKHuvN4FHL57Corbd6tksgOr2XBrpS8lD4wt4wb/Y5sH9vqWCq6OIBvVNh1cOWRxZsVdtzuIFlX7RcanDrkKWOjfC0/b+SUGLd+9p2tQi8JYQXFcPHyPsJbb28gfa8Q3fmHuf0Gv5ZZY315sW46hw7XXTMR20XbEe5YiZynkQfHh5VeVcI4MK3QBgJVPsQZfFY7bl9sWYzuDcbRzjCa1bXOB8FL93gt29MM9VS9ZzoXdfdoU51yx6kG6iWxoe3/lpUKE+t2/UXAX/ykCN47KHkelH4Hj/3LGToEECBBsgO0ZSa/i+YuLFaIwDt8glZQys2bpnBarMxYrwvNch1HaSO70iUXsmvT+ZS47NZxVDK3j+g1mlDbWltb6ENEhWmYgTGUIxui1aukq2kcaGScbqNd/3661UYy69GbQeXlEs4+mS+Obs5n+6mUJSVt1gPJ/R9LMXZOQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a08732c9-af2f-4dfe-5459-08d7ec11172f X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2020 07:44:04.2692 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pPAyHFxcFtwygu2QoM7QLR+XJq2z6LDNldv8llKxKzt9o9r+gWwby1j54nR+YopkjD4uCdDCouQgaDr9NWt7Pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4297 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/ice/base: fix DCF switch rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, April 23, 2020 21:07 > To: Yang, Qiming > Cc: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > > Subject: [PATCH v2] net/ice/base: fix DCF switch rule >=20 > 1. ln_en bit should not be turned on, since we only support Rx VEB. > 2. lan_en bit need to be turn on for a DCF switch rule, otherwise > any Tx packet that hit on a rule will be dropped. >=20 > Fixes: fed0c5ca5f19 ("net/ice/base: support programming a new switch > recipe") >=20 > Signed-off-by: Qi Zhang > --- > v2: > - fix a bug >=20 > drivers/net/ice/base/ice_switch.c | 11 ++++++++++- > drivers/net/ice/ice_switch_filter.c | 1 + > 2 files changed, 11 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ice/base/ice_switch.c > b/drivers/net/ice/base/ice_switch.c > index fd2cf101a..0970ffdd0 100644 > --- a/drivers/net/ice/base/ice_switch.c > +++ b/drivers/net/ice/base/ice_switch.c > @@ -1938,6 +1938,13 @@ static void ice_fill_sw_info(struct ice_hw *hw, > struct ice_fltr_info *fi) { > fi->lb_en =3D false; > fi->lan_en =3D false; > + > + if ((fi->flag & ICE_FLTR_RX) && > + (fi->fltr_act =3D=3D ICE_FWD_TO_VSI || > + fi->fltr_act =3D=3D ICE_FWD_TO_VSI_LIST) && > + fi->lkup_type =3D=3D ICE_SW_LKUP_LAST) > + fi->lan_en =3D true; > + > if ((fi->flag & ICE_FLTR_TX) && > (fi->fltr_act =3D=3D ICE_FWD_TO_VSI || > fi->fltr_act =3D=3D ICE_FWD_TO_VSI_LIST || @@ -6453,6 +6460,7 @@ > ice_adv_add_update_vsi_list(struct ice_hw *hw, > return status; >=20 > ice_memset(&tmp_fltr, 0, sizeof(tmp_fltr), > ICE_NONDMA_MEM); > + tmp_fltr.flag =3D m_entry->rule_info.sw_act.flag; > tmp_fltr.fltr_rule_id =3D cur_fltr->fltr_rule_id; > tmp_fltr.fltr_act =3D ICE_FWD_TO_VSI_LIST; > tmp_fltr.fwd_id.vsi_list_id =3D vsi_list_id; @@ -6615,7 +6623,7 > @@ ice_add_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups, > s_rule =3D (struct ice_aqc_sw_rules_elem *)ice_malloc(hw, > rule_buf_sz); > if (!s_rule) > return ICE_ERR_NO_MEMORY; > - act |=3D ICE_SINGLE_ACT_LB_ENABLE | > ICE_SINGLE_ACT_LAN_ENABLE; > + act |=3D ICE_SINGLE_ACT_LAN_ENABLE; > switch (rinfo->sw_act.fltr_act) { > case ICE_FWD_TO_VSI: > act |=3D (rinfo->sw_act.fwd_id.hw_vsi_id << @@ -6780,6 > +6788,7 @@ ice_adv_rem_update_vsi_list(struct ice_hw *hw, u16 > vsi_handle, > return status; >=20 > ice_memset(&tmp_fltr, 0, sizeof(tmp_fltr), > ICE_NONDMA_MEM); > + tmp_fltr.flag =3D fm_list->rule_info.sw_act.flag; > tmp_fltr.fltr_rule_id =3D fm_list->rule_info.fltr_rule_id; > fm_list->rule_info.sw_act.fltr_act =3D ICE_FWD_TO_VSI; > tmp_fltr.fltr_act =3D ICE_FWD_TO_VSI; > diff --git a/drivers/net/ice/ice_switch_filter.c > b/drivers/net/ice/ice_switch_filter.c > index 55a5618a7..8b007b7eb 100644 > --- a/drivers/net/ice/ice_switch_filter.c > +++ b/drivers/net/ice/ice_switch_filter.c > @@ -1129,6 +1129,7 @@ ice_switch_parse_dcf_action(const struct > rte_flow_action *actions, > } >=20 > rule_info->sw_act.src =3D rule_info->sw_act.vsi_handle; > + rule_info->sw_act.flag =3D ICE_FLTR_RX; > rule_info->rx =3D 1; > rule_info->priority =3D 5; >=20 > -- > 2.13.6 Acked-by: Qiming Yang