From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2FD9A034C; Tue, 30 Aug 2022 04:09:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A845040F18; Tue, 30 Aug 2022 04:09:47 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 2E28E40F17 for ; Tue, 30 Aug 2022 04:09:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661825385; x=1693361385; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gb2buWBKB1dgCMXUdIWQsATiIVrIjXxdEgpnY+6J3B0=; b=TomsUQ96lPJa1Ve1Tad8G5djy6zsN5zudASD6a3S+abbXcqGlo4yI7LA P0OrKjjWTFWohJHhThBZfcMXMeILmSqCQ7Zm+Xhqxw0srLYzi3bRkc6QV LlLblw2NHiMN+LteMIjJGpN3wxZoRy2uHmyoIdgtKJO0tSWuEL0M3HphN jONWCMVNh+9DpzgAs487Rf74fV+8m33Wu7OClgwA+sB0aPIubcOxYQwMg l3ZLDQVHTrpS+4ODdW86L/XXLnCb9okrD27s1F1Tstfh1whdzV3dB/n7g YIziUc090g5wzmhs64pUcE+uvLt4Fte1pb/AwDXx+eq1Ifm12zt6PGK7j Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="295057688" X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="295057688" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2022 19:09:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="856934284" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 29 Aug 2022 19:09:44 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 29 Aug 2022 19:09:43 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 29 Aug 2022 19:09:43 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 29 Aug 2022 19:09:43 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 29 Aug 2022 19:09:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eXIEZtldll4SXzXCy1QgLhxE1diwUUDrgdgYiEt2yqUZkcANaHaBpznokSX0Bs1RiIlcs5tTOUqqT7u8GSJmDRxbolL0QhbG7R6ffRviybdRLseThgAg+eDSzeQvYjkMWbda+F8aairdYaUR8f6mWE1pzvPdBJaHT7RuxClLTvvuRsrghdrl+ZDSN9YHGC74K1t7l2826zwAqRy2plqoANVDWFHsfFhcSyZDaFXfQe1777yt4EpxJ7/Tap+ubClic7t9J3iLqRvdS7ZWzexugW8VkNkHuKwChMBFKMDGBT+EN7nXIK7u/STrbzg5CYU7EzFiiXyGji2zzO3dtbXEVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zqgnDHzQYjvn2s/vMmQvHgYJWmrkAXXFhHDgNkkWBMc=; b=Sw+OGCp+HuXOuTZm5qUxGxMtlkhe5RF4eqiMKeQBZvnI6YA+rhGVI8DvsNf+rze3EAESQgp2GrNcgdgUxVkdn7r0tkgoBMYtBJ2l7UBuEayBRb2J3v2rcdz5oYaj2OQZSTMJziUYV3YW813rp1O42aZszlZPiyiuCBiobVKMauFWVCx+9xDu8+YeICES8R8n8b9VcwkHlX/x+1fwT0mcq1mhE83DQv0mAcQbrOeBiNemtMUbgrCfyLfCsjMKLR0KCTpPiRxfQb7Kx99ldImmEzUCOzOspVWp8KwHgsvdj4V4tSLs/7yG6HGqcWHvkeXIR8qU3D4abynWHsKhhIfuvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3673.namprd11.prod.outlook.com (2603:10b6:5:145::26) by DM4PR11MB5325.namprd11.prod.outlook.com (2603:10b6:5:390::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Tue, 30 Aug 2022 02:09:42 +0000 Received: from DM6PR11MB3673.namprd11.prod.outlook.com ([fe80::451a:843b:9068:7b5]) by DM6PR11MB3673.namprd11.prod.outlook.com ([fe80::451a:843b:9068:7b5%4]) with mapi id 15.20.5566.021; Tue, 30 Aug 2022 02:09:42 +0000 From: "Liu, KevinX" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Yang, Qiming" , "Yang, SteveX" Subject: RE: [PATCH v4] net/ice: refactor proto_ext to remove global variable Thread-Topic: [PATCH v4] net/ice: refactor proto_ext to remove global variable Thread-Index: AQHYuPHeWF1OObbbOE+1lce9h9IYu63Gt42AgAABOwA= Date: Tue, 30 Aug 2022 02:09:42 +0000 Message-ID: References: <20220727165901.457146-1-kevinx.liu@intel.com> <20220826101458.1520919-1-kevinx.liu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 048958c1-4249-429b-2f99-08da8a2cb38b x-ms-traffictypediagnostic: DM4PR11MB5325:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8p2fsaJZ8Pg3FB8FaDPXYxGYRLJw4JFl11vdPV9N3mCFFhlPtcqlmtxUSCj+Cd3noHt/tNzk7Dogd0M4NJEKBM/yapAW1qYz0FJh7LELuyUCsz0Z6iYprw59C86syneSlC/F2gxrnqfZ6A7V6VcJRRrE7zyrZHVNsAPmYuapksuH0gyhiqwVMC0A6Vq4RBcHkgMdmwbiG3BYfn7QP33Ld2HeXaYZEg5UnM89Atm94883uuaiGxgT0poc310NfYslN8JiKcKFS6usUuMJxeeiKlF7udl+JAwFXTMay8MGsZPWHtopjcr//roaumC2UE0Um7m54KX/NDC+9Q6QbJu10d5WFtdoU0vYWVWXLLGMUQbTkcaIHWSgDb4REpbNfvjXKuhrVqIs9dccdoyyuggO2HIFkwGptlqMSh00rbKEBteAiJCA8K9C/KT329dXD956hPxhjw+Rv7+TTxcrCcYVUxj7jyrJj5WAWYZdX5PNxgnlRTZedtmBlxNS9av1Fa73GK5A+vrpnxEaKT0mUrLjzovlayTbP7n/tmGiCE3/+kDDZgsYdm5XSvtF0DCapUINsy3B4bf3Cp5AoClPZRHYh8f6cZ6wDOUILt3KUf8lqGat1ApWfefa6d4GLC1u4xegISYcmOQup5lOkQOuIWkOIV/jI1DYU2uRHSshLKcWJBr1cTz0FnaATL2jzaBWyUm3CTw7tx8S1vkFIvMEjDFCp5ZMQombuRecJd9IY0Jq2JJ7LxOUV9uyp0XJ/ssSC7b2ndwj2eod72VMkkA1aF/OjQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3673.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(396003)(346002)(366004)(136003)(39860400002)(122000001)(83380400001)(86362001)(38070700005)(38100700002)(82960400001)(2906002)(316002)(8936002)(110136005)(52536014)(76116006)(54906003)(186003)(5660300002)(41300700001)(66946007)(64756008)(66476007)(66446008)(4326008)(66556008)(8676002)(9686003)(478600001)(53546011)(26005)(107886003)(71200400001)(7696005)(55016003)(6506007)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?T0dBb0pud3J1YVdibysrM0dRRHkvRmpvRE9FQ2dYVmFWTTY5SVQ5VmZJ?= =?iso-2022-jp?B?T2FxcVJDeGZQWGU4bTRvU3ZDRkM2ZXdXL2ZBaGNNaHRsTHVaUFczVC82?= =?iso-2022-jp?B?MkNlZTc2emV1aktPTjR4T01WTWwweWZpUGgvUDBqcnJOaFVKd0x5WUwx?= =?iso-2022-jp?B?Si96NjNsTTBseEkyWmlIVEZIKzk2SGw1RzdRbFYwMGMrY2dNMUxnaklr?= =?iso-2022-jp?B?UzNmZjRSRnZSaXc3dUNxN2tjU2pYekQvZzR4VW5TWnYwL1p0WnJ5N3pQ?= =?iso-2022-jp?B?QUlJcjc0RWQ3RXFsTlFmdVNhQnphMVBmZksrbWM4aFNvaVpxUzFkMHVK?= =?iso-2022-jp?B?TVlyM29BUzNKMzRpbGVPeGFDZi9DWmU1d2F3UjhRa0RkcUY5dWYxdTdF?= =?iso-2022-jp?B?dkFXd2JBNzcxN0JPYWU5dGVpV1hKaWxFN29ZU1Zyc28yand4TzJabGFS?= =?iso-2022-jp?B?REc2ekFNSU11aUxIM24yTGtjUzBLcEpIRVpQNm85Q0xhdCtUKyt6cThQ?= =?iso-2022-jp?B?TjdHNm1rQkVTLzRrY3BtZ3hBVFZjRksxL0Z2NmlzMFFyM3dFMzBJUUdm?= =?iso-2022-jp?B?Y0l4WXZTTEw4b2pCbExSYUJOTHJKZXdiOG1ma3MzTisvWFpQYXA0Tmxn?= =?iso-2022-jp?B?RnNrdE5jODRRVWl1aVhGdFVCeitVUUpWM2NEK1p3MTFPRXdBQ3ZJaVRh?= =?iso-2022-jp?B?bG1QaGhWMWg5SDExSWZmZXh6dlpDZlBSOVArVzYrTjFNVUt4bkZ3TWJx?= =?iso-2022-jp?B?Tmc5ZU8vUmJSL1JCeWtnSVdUTVF1alhoV0JNYkdYSGZrUDlEYkIvTWlu?= =?iso-2022-jp?B?N2E5MXVidXg3SzNTOHdOY2E1ZjA2ZU1IZUxoQ0hmUmY2NWRRVTJ4RmpC?= =?iso-2022-jp?B?ekZ1bHFyaWk2blR6czhQV1dPckg1bVhEV3BQdlJiZGk1LzJUSVhrdmJj?= =?iso-2022-jp?B?MFY0VlJMNjNWRjU1bUNGK24zeG5zQ2xkSEQ1dmtCS3NIbzhmeFd1UUwr?= =?iso-2022-jp?B?UTM5OGNabGRCbUNnNk9zMWRVVHVOZm54cURKbSs0Z3VkNTA3TFQ5Z3hT?= =?iso-2022-jp?B?V3lJeEkwbWw2NHI4RXpYNGx0N28wREc5ZWpZZHRzOWNCY1F5OEZZN3pk?= =?iso-2022-jp?B?WExCQVBJajBKdVdZOVc3S1gvT3Nqa0JGTG95cVhLalhpZHZVUXo1Mk5q?= =?iso-2022-jp?B?cHV4RVdwak9YYTY3VmVqS1UrSkFEVWc2dmdDUCtJM1E3Z1AzUnpoSFZ5?= =?iso-2022-jp?B?YmNHZ1R1dTJXN09TUUVpUVdQVjJHc1RBOEQ5STgvRkQxZDJJVGE1MEIr?= =?iso-2022-jp?B?NGpoVjFFa3JrTVpBYU4wNGlUN21mMnppVW5jODlPM01QeTc3NkRkZ2lS?= =?iso-2022-jp?B?bUlZQlI5WGxuK3VQVzk4R0hQMFp2ZnBVR21NOHhZOHl5VzQvSmp3ZjRZ?= =?iso-2022-jp?B?ZlVjR0NEU241a1o0UTB5empRQ1FkZWQ5bitXR2Z5SWhjNG1DRmtBU2Mx?= =?iso-2022-jp?B?dzN3aThEdm5oOE5ELzF1SjZQc25UVm9PWTdIUDh5NWY3a1pJU0JkOSts?= =?iso-2022-jp?B?WDdLZ2JCWFFnbnVmVG83TjNFNDdRQ0QyOUFTRzh5VkdRWDhobGNrMnkr?= =?iso-2022-jp?B?U0RSOFo2MkFFLzlXMWRxM3FjYnVzNENYV21OZFFMWElXL2FXK2RvUG4v?= =?iso-2022-jp?B?Mm1RSkNYQjlkaDdQSXlheDlOT2VpRm94RncrWTNrODNYeHdmRHVabDAv?= =?iso-2022-jp?B?WGNNUUM0ZjRYSzAyWmZzYjA5UkNDT1lQZkx3YndjRm4yYko4TDQ5OTBL?= =?iso-2022-jp?B?M2FuK283UDFKZHZlREE4cUxxdjVlK2dhazFPVWFKNlV2ZmpCNmlLUHVo?= =?iso-2022-jp?B?aGZjaDFNTmQ4ZmhldE1RcGlZSElJSHU3WTdnalY4YnRaWGZINkJjemVU?= =?iso-2022-jp?B?WU5Xekt2UFIvajFHNlpqbFZYVGNSblRUQUhIZEpNblJJWmhxb3BhcVFE?= =?iso-2022-jp?B?bjloQnhuZWRxeUZRenlyR0tid2JXTkxRQ2FjZHdpWU8vR0VOdWd3d0Mz?= =?iso-2022-jp?B?MjA4WE5Fak9NKzF1REQ5Y1FvU0ZLbVJKK1FLMkExWDVyTjFDNE1JUXhY?= =?iso-2022-jp?B?VEtLc0NEM3R6UUVub08yN0VtZnpDNS93aFBJNEVvQVlzbGYxbzREbDNy?= =?iso-2022-jp?B?MjZ2M01PMkREdlAxWG9IK2VHZmtxZU9rS0R4Rkpyc0pZaTN3MWsrZWVs?= =?iso-2022-jp?B?a3Urb3ZxT3RoaFR5ZzZHT1dnY3lnb0UrK0lTd0VTQ3h0YzVPOGdwbDJq?= =?iso-2022-jp?B?VWRhdw==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3673.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 048958c1-4249-429b-2f99-08da8a2cb38b X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2022 02:09:42.1159 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EppJWpGcmACwJnnbkT24XcKnYhldxzXnzGicJ5p4Z6r8XALz7NzosE27bmbUY+WR5WC7x+akzg/O47/bupRx/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5325 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: 2022=1B$BG/=1B(B8=1B$B7n=1B(B30=1B$BF|=1B(B 10:04 > To: Liu, KevinX ; dev@dpdk.org > Cc: Yang, Qiming ; Yang, SteveX > > Subject: RE: [PATCH v4] net/ice: refactor proto_ext to remove global vari= able >=20 >=20 >=20 > > -----Original Message----- > > From: Liu, KevinX > > Sent: Friday, August 26, 2022 6:15 PM > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Zhang, Qi Z > > ; Yang, SteveX ; Liu, > > KevinX > > Subject: [PATCH v4] net/ice: refactor proto_ext to remove global > > variable > > > > The ice has the feature to extract protocol fields into flex > > descriptor by programming per queue. However, the dynamic field for > > proto_ext are allocated by PMD, it is the responsibility of > > application to reserved the field, before start DPDK. > > > > Application with parse the offset and proto_ext name to PMD with devarg= s. > > Remove related private API in 'rte_pmd_ice.h' and 'rte_pmd_ice.h' file. > > > > Signed-off-by: Kevin Liu > > > > --- > > v2: Delete doc content related to 'rte_pmd_ice.h'. > > --- > > v3: Delete doc content related to 'rte_pmd_ice.h'. > > --- > > v4: refine code and change the check mode of dynamic field. > > --- > > doc/api/doxy-api-index.md | 1 - > > doc/api/doxy-api.conf.in | 1 - > > doc/guides/nics/ice.rst | 33 ++-- > > drivers/net/ice/ice_ddp_package.c | 1 - > > drivers/net/ice/ice_ethdev.c | 113 ++++++++++---- > > drivers/net/ice/ice_ethdev.h | 7 + > > drivers/net/ice/ice_rxtx.c | 45 ++---- > > drivers/net/ice/ice_rxtx.h | 1 + > > drivers/net/ice/ice_testpmd.c | 2 +- > > drivers/net/ice/meson.build | 2 - > > drivers/net/ice/rte_pmd_ice.h | 247 ------------------------------ > > drivers/net/ice/version.map | 7 - > > 12 files changed, 122 insertions(+), 338 deletions(-) delete mode > > 100644 drivers/net/ice/rte_pmd_ice.h > > > > diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md > > index 186a258be4..e578800cea 100644 > > --- a/doc/api/doxy-api-index.md > > +++ b/doc/api/doxy-api-index.md > > @@ -44,7 +44,6 @@ The public API headers are grouped by topics: > > [KNI](@ref rte_kni.h), > > [ixgbe](@ref rte_pmd_ixgbe.h), > > [i40e](@ref rte_pmd_i40e.h), > > - [ice](@ref rte_pmd_ice.h), > > [iavf](@ref rte_pmd_iavf.h), > > [ioat](@ref rte_ioat_rawdev.h), > > [bnxt](@ref rte_pmd_bnxt.h), > > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in index > > 608494a7c0..6fab7436d7 100644 > > --- a/doc/api/doxy-api.conf.in > > +++ b/doc/api/doxy-api.conf.in > > @@ -18,7 +18,6 @@ INPUT =3D @TOPDIR@/doc/api/doxy-api= - > > index.md \ > > @TOPDIR@/drivers/net/dpaa2 \ > > @TOPDIR@/drivers/net/i40e \ > > @TOPDIR@/drivers/net/iavf \ > > - @TOPDIR@/drivers/net/ice \ > > @TOPDIR@/drivers/net/ixgbe \ > > @TOPDIR@/drivers/net/mlx5 \ > > @TOPDIR@/drivers/net/softnic \ diff --git > > a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index > > 6b903b9bbc..432c6fd7ed 100644 > > --- a/doc/guides/nics/ice.rst > > +++ b/doc/guides/nics/ice.rst > > @@ -110,29 +110,43 @@ Runtime Config Options > > > > The argument format is:: > > > > - -a 18:00.0,proto_xtr=3D[...] > > - -a 18:00.0,proto_xtr=3D > > + > > 18:00.0,proto_xtr=3D[...],field_offs= =3D< > > offset>, > > \ > > + field_name=3D > > + > > + 18:00.0,proto_xtr=3D,field_offs=3D,field_name=3D > > > > Queues are grouped by ``(`` and ``)`` within the group. The ``-`` ch= aracter > > is used as a range separator and ``,`` is used as a single number se= parator. > > The grouping ``()`` can be omitted for single element group. If no q= ueues > are > > specified, PMD will use this protocol extraction type for all queues= . > > + ``field_offs`` is the offset of mbuf dynamic field for protocol extr= action > data. > > + ``field_name`` is the name of mbuf dynamic field for protocol > > + extraction > > data. > > + ``field_offs`` and ``field_name`` will be checked whether it is > > + valid. If it is invalid the value needs to be reconfigured. >=20 > It is not clear here, better just describe when the configure is invalid = what > kind of failure will happen Ok, I will modify it according to your suggestion. Thanks!