From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC9CEA0093; Fri, 11 Mar 2022 08:04:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A31240E78; Fri, 11 Mar 2022 08:04:23 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id A93C340140; Fri, 11 Mar 2022 08:04:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646982262; x=1678518262; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yaveZOUZ3Gef1slN9scZFv9b3NwGMDpuMOkf8+BM2NA=; b=a6eZcjCu5GFjFSOSLcpSvbTBXLZpx4LvrpPEio8etBO2cafMc47+SXSS sOtoVbMaoBT5jaCiGoznWSmXVUv8SGIL4n40kFKow+c+37VzETDERY/oB NsB9BleWDmzOovX0Blx4vQQiyp0ifpXsa87j+POzQr1puKysjumffV5u3 VEH8vNylMOnjfuB22CLAg37QfIzjgJoRDTQ4LFykClGJseExfdwhLBqR/ ZxgCiXWUwOdYYjFLZJhXZAc93VUyAbaOkRhABC3ekjNF5K6fYZ8uQ9lBH qqwwrZoGrBYtcj7o970jC4pOgfGgZwN//1b+dMNiGxG8NYVfl76I5EMd3 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10282"; a="255250627" X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208";a="255250627" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2022 23:04:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208";a="511301971" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga002.jf.intel.com with ESMTP; 10 Mar 2022 23:04:20 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 10 Mar 2022 23:04:20 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 10 Mar 2022 23:04:20 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.42) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Thu, 10 Mar 2022 23:04:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J0xrjkfitCunew3GWMVtPgUaRsf0IVgvNIsWRGWaRH9acNlClVO6GEwd4uqQhYqYbwSKG1Ne+qoDim+y52Q40oZ6NjjBIds/M3PJqnT2LNz1U2QKQD2I4VZl4qnXBET2nd1GmGUmcwaUKk8YMe6f08+saBFrgWbT86A5THCUj8aBIc7Rjd4Yp66iIVCSG1d/ICpooNSOiVqZ/pOQwEnUDYKL14jt3Ze+Q2JIu/X+zGbn2xIwlM3LbfhlrBZ1YbWLdQWuIuTgEZ1joZJirr8eh2jGxIAykWk64oA7NnEzocIk5P25h37HwYu286UKwHFORAvzhI71c0cXtInC16LZbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hiXOKWmrC770Q+7+ELVSL07f7NAGUHRoZrmtghhPRhs=; b=R3umav0Fzl61CAl4c4yfH9IsKB15luPLWCTO6IT5fheycPN2DZ/6TtshkV/hpY9iSxiHFw1atJPPq1yhv2xLPc8sRFuODIg4RdNR7EKR5U217QxTURhMyBQn0XEeMw24DbvAi7LrUl+bT/2QusiM8zxLvpRO3+ZY1GNn1qW06k32p8p5vFWyEeyDgFesbuqc3q4uDIg4MwouqTsI8F4Os1FtRMVAgXvgMATryT3BAg9ZWXG2mNAmhM5uG4/jkA2e+MglmymJosnRHXOmr2b4ofKo0N1DSQqIlJFQEmVC9kUMDit9nOjGTmphLA+vGGmJROIVsYXPwd+4MKen5LJ8Rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3673.namprd11.prod.outlook.com (2603:10b6:5:145::26) by MWHPR11MB1965.namprd11.prod.outlook.com (2603:10b6:300:110::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Fri, 11 Mar 2022 07:04:15 +0000 Received: from DM6PR11MB3673.namprd11.prod.outlook.com ([fe80::ac86:5985:c425:a5ba]) by DM6PR11MB3673.namprd11.prod.outlook.com ([fe80::ac86:5985:c425:a5ba%5]) with mapi id 15.20.5038.027; Fri, 11 Mar 2022 07:04:15 +0000 From: "Liu, KevinX" To: "Zhang, Qi Z" , dev , "Yigit, Ferruh" CC: "Yang, Qiming" , "Yang, SteveX" , "Xing, Beilei" , "Li, Xiaoyun" , dpdk stable , "Zhang, Yuying" Subject: RE: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments Thread-Topic: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments Thread-Index: AQHYLFMrmcbnV8+Plka1o7AMbr9s5ayqatqAgALMlICADJwpUA== Date: Fri, 11 Mar 2022 07:04:15 +0000 Message-ID: References: <20211224150925.3296471-1-kevinx.liu@intel.com> <20211229093702.1930214-1-kevinx.liu@intel.com> <20211229093702.1930214-3-kevinx.liu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 992f737a-1b19-47ce-adf2-08da032d5abb x-ms-traffictypediagnostic: MWHPR11MB1965:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XDIcJ7cYfu4ddT0V4NGprNnFKjQxAoY11jNPjBcjKLuZibobAkSKbAfBi/p3fHdGNGZOTmOZ9ePTr9cxbiTXiwqywmsZiZG/UsXzYX6zZmAQumnE0mOt1u7ZS5CJ0ETKom/Ugv4g4tjbUfJHK/fAtDSJYKFcAQ/CwwWZVk4d3O92W2dsHeMWRs2J9Erm8vwcTNqQi2G3QxvsVJ+KMysA3OfPuq42CVJ4NM3MIDocaj94KlPwB0PjdNaOgeDSGZYEdXdJH0Oejff+PKh6bPE6rB8scVBBAF6Jd1Ox14bpS3GLBjUiUEovqYV4+t8l6J0PkTSv3eA1eqjHTzeBGdXsHNieh+dYGYYAzB5NpgBuujVfwFBtixSU0OzumXGhR9pa5NFeDbfJBpWbGKmbnqhmV2wJARcPgMxH6v63razrOm/va5pm4/+ljFwbDu23miDJbm4e3ybdV2+wOKiLyJ0Hk1wrU+5U4tcx+AMjPv6rmyjmTZR7e+fxHHmV9vc70gOx6494hQBGGGgSiL3tiOgh9Vuyt/PgKDpF10T5SzlDCedpYGjaNdk98BvQGi5TALL2xsWC32BGGb7hWAavGcJrz5nQNAwdUD0WM/r0ZoxVKDzBTlI8CuQt2Rcksd7V1E8sbC0SU00bbD92GWtXqvtaiKgEWX36App0OUFrAFT7aL1w0+++3mwgczHcgPR4sSQd898YRoMnF1QAjxw9NkPrGw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3673.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66446008)(64756008)(450100002)(66946007)(76116006)(66556008)(4326008)(8676002)(33656002)(9686003)(66476007)(38070700005)(52536014)(107886003)(122000001)(82960400001)(55016003)(86362001)(38100700002)(71200400001)(26005)(186003)(2906002)(5660300002)(8936002)(83380400001)(6636002)(7696005)(6506007)(508600001)(54906003)(110136005)(53546011)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?cnkxVVM3cGVxOXJOU2NzL0RjM2tubFFxb2VaSTFhY2daTUxkRG1zNnc1?= =?iso-2022-jp?B?L3RoaEthSzVBVUQ3bDFwa3NKOWpDUldIQTB0aXFmaUtnaWFKN1JQdmkv?= =?iso-2022-jp?B?WUVOejF4NXFVYW9TV0ZEMlBPbGVHMnhDWU4yV0lrN1FnYmR2V0QwL2dh?= =?iso-2022-jp?B?b3hGOVQvUEIwc3VqVERRdTJJTlJtRzYzcUhyWFdOQ2N5blE3OW8wTTdH?= =?iso-2022-jp?B?b3J5bUI4MTBvYkxOSlUvNW51OC9QKzJ2aUFLQXhNcWd0SStMblRlOU83?= =?iso-2022-jp?B?QVNDQlhvN3gzamJqZFVlWVJlaXdoQURyZ2d4RkhsMjhYWlcrNWRCQlhr?= =?iso-2022-jp?B?Wk5pL0lNQjgxdm9ad1RPMFBPempKTFU0WW5rZjZmaTBINFRTSEpUMk50?= =?iso-2022-jp?B?Q3ZFTkhxM0dnUThCZTJGdndTVDJBNFJqRm42Vy9XaHJYcWZ6dmhLaTBI?= =?iso-2022-jp?B?MWlIYzRxOUpPTklJUUZwZnJJMGJ5NTlQWE93bFgvOG1oMUlKckxadmk1?= =?iso-2022-jp?B?RHhuNnFJdlVoTi9VRXU5MW0yOXk5V1V1TmIyWE15Z252V0tRMGUyUTJv?= =?iso-2022-jp?B?ZTk3MEtEQjFaVFBPaCt3WFo0VUphelU3TlU3TWo2RU92UktKa2VtbUk3?= =?iso-2022-jp?B?bDJCMDZFSnBZLzRaeWtydndZeU5PaC9EOTV1UGxVQWU0RWltM0I3TTIx?= =?iso-2022-jp?B?SS8rOEFjYzk1ZVVTNlpyYW1GcS8wMFp3OW1PejFicS9UMnZBcUQ2dXNY?= =?iso-2022-jp?B?RXRxWUVaeHFFT3RIN28zWThEL1orLzRvK2oyaXFpNFZWanZjMUdtTEhX?= =?iso-2022-jp?B?TFJoVGo0MTh5Y0JmZ25GZnhrSEZrMWt2Mko2UG1STTFtOE90ZnpEbUtR?= =?iso-2022-jp?B?VUhYc1FCMVN1VW9ndFQwdzUrQUJ3aVZDajVldGFjMVgraXhVa0F3NzdT?= =?iso-2022-jp?B?QmZPMVJNbVlreGRxbUo0K1Rua3dWSXpCQWRyUlZrM2pwVEVWOHhIbW5v?= =?iso-2022-jp?B?SVdGRVhDblBsbGp3WWI2VWdQdlNvaDZHU3N0UHZ2MkJZNnB6L0hlbTgr?= =?iso-2022-jp?B?UjlreHJ6aHVYc1RVOVhNOS9ZaE1KdmpXdHpXanRUdFM3MWRPUExlbFBz?= =?iso-2022-jp?B?RE91V2tCdEI0LzBPNjhLUVhJWEF0TTVTWkI3Qml6TVdGbTUzWVpxaUZG?= =?iso-2022-jp?B?VDV6VXJ4b0ZWYnlHZUhkY0FXakV1Z1E2WkVlU1dUZXdtQU5zN0NISUtG?= =?iso-2022-jp?B?SUZHbC9PSWJDamZwSStEdXJTUkw0L1RiNHhmWGFTRnA2QmxnRTdQbFlG?= =?iso-2022-jp?B?bDhoL2FoM1htSjR3QWVIOHJ1TGZkS0pidGh0MXpwd0I3L3h3ejV0aytq?= =?iso-2022-jp?B?anlOcXdmbWxteUgwS1hucEZUZFBTemkyczZjWjVtQS8yYkxiT1YvUlBa?= =?iso-2022-jp?B?b1NkSjJoblZEbXAxVnc5N3FXVXhXc1pDdTNDWm9xZUNRZDllNzB5aHUr?= =?iso-2022-jp?B?UkdmY052bU1vdUVCTlJNdGNHaWh4c3VheTFrRWVKWlZvUXVXL24wZlBX?= =?iso-2022-jp?B?VmZ0YzNuWEp5SWtWL2JlSFkzT1NPY0FtV1JjMHk2eFdPWklQQUdyY0tY?= =?iso-2022-jp?B?VHh1UlRTMURURVhjbUlBd0FmZTVwamZMWXY3aVBjRFhWWk1CaWJBWHZ6?= =?iso-2022-jp?B?THRIV091cGxBcjBKYnFYMXFPaXE1RXlhT0pxWi9wV1dmaWV1M3hXVjZm?= =?iso-2022-jp?B?cVEvdHk3Sy9JOGc4bkp4SCswUEFSU1RzUzhuN09LQk9zY0ZMZzhPaVJL?= =?iso-2022-jp?B?ZlkvckNzblE0WW01QzBTWEdJRmhTWlcycDVBVWFSdDFHU3dUcFNzWmFN?= =?iso-2022-jp?B?UjNoRVdPbWJXcnl3c20zSFE4UUtibU1KZVYyajhFTmhBOTFIUjMwcngy?= =?iso-2022-jp?B?SlNHQjZqRm1SV2JxbHl2LytsZm1UcXllZGhnMXpyYUczVFkzMy9sS2I1?= =?iso-2022-jp?B?WTZ0R1hSZDVndnA0NkJkclB4SnFSSXNHZjdqVjM0T3pyejdubC9VTDRa?= =?iso-2022-jp?B?MS9UL1JnU1gzVmF0T2dkaDdwN0Jtbk5wcjVUUXdZcmRmVWc3T3ovMHVH?= =?iso-2022-jp?B?OHg=?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3673.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 992f737a-1b19-47ce-adf2-08da032d5abb X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2022 07:04:15.6226 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SSjMSgNU7bZDxvb8Vlppj+A7Tfd1tFFFKdHtUj3hEzhHPumNXIG9Od/ND018kuxJ/3Ju9VJBZoIUhaYFPjDXHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1965 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Ferruh Yuying has already reviewed it days ago. If you can, I hope you can change the status as soon as possible and try to= merge the code in RC4. Thank you. > -----Original Message----- > From: Zhang, Yuying > Sent: 2022=1B$BG/=1B(B3=1B$B7n=1B(B3=1B$BF|=1B(B 14:30 > To: Zhang, Qi Z ; Liu, KevinX ; > dev > Cc: Yang, Qiming ; Yang, SteveX > ; Yigit, Ferruh ; Xing, Be= ilei > ; Li, Xiaoyun ; dpdk stable > > Subject: RE: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi- > segments >=20 > LGTM. >=20 > > > -----Original Message----- > > > From: Liu, KevinX > > > Sent: Wednesday, December 29, 2021 5:37 PM > > > To: dev@dpdk.org > > > Cc: Yang, Qiming ; Zhang, Qi Z > > > ; Yang, SteveX ; Yigit, > > > Ferruh ; Liu, KevinX ; > > > stable@dpdk.org > > > Subject: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in > > > multi-segments > > > > > > Testpmd forwards packets in checksum mode that it needs to calculate > > > the checksum of each layer's protocol. > > > > > > In process_inner_cksums, when parsing tunnel packets, inner L4 > > > offset should be outer_l2_len + outer_l3_len + l2_len + l3_len. > > > > > > In process_outer_cksums, when parsing tunnel packets, outer L4 > > > offset should be outer_l2_len + outer_l3_len. > > > > > > Fixes: e6b9d6411e91 ("app/testpmd: add SW L4 checksum in multi- > > > segments") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Kevin Liu >=20 > Acked-by: Yuying Zhang >=20 > > > --- > > > app/test-pmd/csumonly.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index > > > 02bc3929c7..c235456e58 100644 > > > --- a/app/test-pmd/csumonly.c > > > +++ b/app/test-pmd/csumonly.c > > > > > > > @@ -513,7 +513,7 @@ process_inner_cksums(void *l3_hdr, const struct > > > testpmd_offload_info *info, ol_flags |=3D > RTE_MBUF_F_TX_UDP_CKSUM; } > > > else { if (info->is_tunnel) -l4_off =3D info->l2_len + > > > +l4_off =3D info->outer_l2_len + > > > info->outer_l3_len + > > > info->l2_len + info->l3_len; > > > else > > > @@ -536,7 +536,7 @@ process_inner_cksums(void *l3_hdr, const struct > > > testpmd_offload_info *info, ol_flags |=3D > RTE_MBUF_F_TX_TCP_CKSUM; } > > > else { if (info->is_tunnel) -l4_off =3D info->l2_len + > > > info->outer_l3_len + > > > +l4_off =3D info->outer_l2_len + info- > > > >outer_l3_len + > > > info->l2_len + info->l3_len; > > > else > > > l4_off =3D info->l2_len + info->l3_len; @@ - > > > 625,7 +625,7 @@ process_outer_cksums(void *outer_l3_hdr, struct > > > testpmd_offload_info *info, if (udp_hdr->dgram_cksum !=3D 0) { > > > udp_hdr->dgram_cksum =3D 0; udp_hdr->dgram_cksum =3D > > > get_udptcp_checksum(m, outer_l3_hdr, > > > -info->l2_len + info->outer_l3_len, > > > +info->outer_l2_len + info- > > > >outer_l3_len, > > > info->outer_ethertype); > > > } > > > > > > -- > > > 2.33.1 > >