From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7A17DA034C;
	Mon,  8 Aug 2022 06:43:35 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 456094014F;
	Mon,  8 Aug 2022 06:43:34 +0200 (CEST)
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by mails.dpdk.org (Postfix) with ESMTP id 0B646400D7
 for <dev@dpdk.org>; Mon,  8 Aug 2022 06:43:31 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
 t=1659933812; x=1691469812;
 h=from:to:cc:subject:date:message-id:references:
 in-reply-to:content-transfer-encoding:mime-version;
 bh=gQl6G0bNLL8rJ/48CYVTy0bIWGGrSlwcLro8cq1Rni4=;
 b=UqiBhvWGpaGHdDKEQHHXIHgBsdkyvzaUKQPmg4hWr7bQLqTvqvkTRlIE
 19AfyJO/yNUwwpSDUA4mQR03TIhhEfxR59TMynNR5I6DQpSWbDhHYSFGh
 PJVFPRmPBt9z3ehN0GSJQFcJplYK0ZwJ26UwVqSIiodUxDC3PAox6gdin
 VuP9Rg0mTS8wTE8TNcSkY37EP6/WQgc1ZXZp/Kn2UIr3Dc4omlgdy2ew3
 asOR5CBX5p9lmYHWW4W6FYf6A+VCPAFiGA6VJO9sb1so7sjha54mh0jU4
 fRTv0ghv+Afn01ym8V4QGRFPAgkqPYNSD8xVwOqbcNefK9f3mjkmfFO+q Q==;
X-IronPort-AV: E=McAfee;i="6400,9594,10432"; a="291277149"
X-IronPort-AV: E=Sophos;i="5.93,221,1654585200"; d="scan'208";a="291277149"
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 07 Aug 2022 21:43:30 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.93,221,1654585200"; d="scan'208";a="637152129"
Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83])
 by orsmga001.jf.intel.com with ESMTP; 07 Aug 2022 21:43:30 -0700
Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by
 fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.28; Sun, 7 Aug 2022 21:43:30 -0700
Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by
 fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.28; Sun, 7 Aug 2022 21:43:29 -0700
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
 fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.28 via Frontend Transport; Sun, 7 Aug 2022 21:43:29 -0700
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168)
 by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2375.28; Sun, 7 Aug 2022 21:43:29 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZqoWKsm1Hy+f7eoQULZcty6Tq7IQCxAdArHARRqS6VCd3f2tKM1niZowWq8Sn+MCZ+vPkXUWP2YMVYhrdIOZAIxtuvO8wRS/eNakgnmXVMWXuUYfRzk9qgsE44/i4f2XzP/d6TPW5tZn2dIcoW0e2qRr5kXpp62l6FYVb4ZOdNcf8ISQxDWkNocx2I+blNXUKzT/nNatwaksMHGaDg3GojRekr3wtgJYRQaYrV5dzNLpviGPUmgNonJ3ZqiPO/chby42ls+Nta6BGNGPCt6vzwke4vjyfZBfB5LhGE6PSrIpV656N1H4XPogZKkjBjXo/VgQGHXZS8B+am4zPVCBHA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Tx5C0/cAkVV2qALvP8ffWicBLnWM+OeY1FxhEUIVqnM=;
 b=fQPWgGpVFbmBo68thfHzO//CtS6sa3w17j9SJd3rHd+DKZ/q/t8l12TQlQBot1ZBor4S4KhWu/7N7YQE+y8jhe/Lt1QOI/eLAmjUNxlFtX0c4L2Z82QqNSwrm7IP1UISrLp16uviLgpCWvrAG4BmTsDSDigVFOkkO0OJzX/ujipVlhBdSa9uNncXflGc9scexotKZqb+1DS1fFt2PYQcSbLj9+BWDCWmQ1suqNAu4wSHHiKT/HOTWsNxgQ/eTEBm1bRn2gR8BUQ8Aw1Rudn2v1NhrhRXeSH4ei0DRwB+1bWxkVZ00ooRMmLopevvHJbXbLL36aCwFeDG3Q4Cl61TlA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
Received: from DM6PR11MB3723.namprd11.prod.outlook.com (2603:10b6:5:13f::25)
 by DM4PR11MB6312.namprd11.prod.outlook.com (2603:10b6:8:a5::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.19; Mon, 8 Aug
 2022 04:43:28 +0000
Received: from DM6PR11MB3723.namprd11.prod.outlook.com
 ([fe80::6c95:eaf7:e652:9301]) by DM6PR11MB3723.namprd11.prod.outlook.com
 ([fe80::6c95:eaf7:e652:9301%3]) with mapi id 15.20.5504.020; Mon, 8 Aug 2022
 04:43:27 +0000
From: "Guo, Junfeng" <junfeng.guo@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
CC: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Li, Xiaoyun" <xiaoyun.li@intel.com>, "Wang,
 Xiao W" <xiao.w.wang@intel.com>
Subject: RE: [PATCH 03/13] net/idpf: support device initialization
Thread-Topic: [PATCH 03/13] net/idpf: support device initialization
Thread-Index: AQHYp0tjraZD6oPpn0OhVudSbuSQ/K2kcztQ
Date: Mon, 8 Aug 2022 04:43:27 +0000
Message-ID: <DM6PR11MB372312F9A688892BBF0142FBE7639@DM6PR11MB3723.namprd11.prod.outlook.com>
References: <20220803113104.1184059-1-junfeng.guo@intel.com>
 <20220803113104.1184059-4-junfeng.guo@intel.com>
 <20220803081138.1439da10@hermes.local>
In-Reply-To: <20220803081138.1439da10@hermes.local>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a7156497-a29e-4d3f-a96e-08da78f8894d
x-ms-traffictypediagnostic: DM4PR11MB6312:EE_
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: V8Uks3QK2uynkmRKZgaixZRM+qSFV8rCkS6nrD8TCIlm3AY4QBHqWBXxz9C6UXgt2P82wQ5Oc2wIXFMeA+PQN6sHPitEVnE7Cdxtb3Tff/g5A5OXVEJQFfXk3Gbi7ZQPLeDAFaEKTc2QxtzsoR1nJpZvOTWBQvo6t8wKE3SUQpCoRQs2m3QTIhXhNdAvtRkhpEp+J1cX2VuM2zPbIje5H/4B65712cYfm8QFh8n4TVTeVst9EtWYUpYdqM9KoRLIPOA/u0rYMCEvz6sjTWx4xdEGOZXYhN0TTB9Mg7VBcrB6ioRIqzr8ci2pw30/oFqLmeVepsmVaTC3xsombgLks7B7C1v9auG8SqxHw8e+qiRUTUSz+lCRfqg61wTbnIOuF2pmTA8ECgwg3xM7w1SS9+AaGT6ZJd306Y1SvwpRKpbr1i6GRIwUK1nMJ6s3+at4E1svaDwH+M9Z8PYhTC1EsoDjv5B2IHS4Z1E07i37pEsDLZ/wNWkfeETEWN+fHw4B9EyJzUX+TkNqfEgQdvfeUMFd3um99vWC+7WJgPeBZd5E7ncUCzXWwyZwvaLampW15Im3PHmEG09DGBWgvMEG9FKEv8xohyxjaEnjEjz5S8H6iPFfm4gA7w+37o5bpXS40cJTCe+y8icHlAI/aXwSc9PmOQ032DgevNACPR1xIDZsiufngjLJ+vNb7/J+kr4bNdvKTY+d9mVVr1mGOHzbg15WTSQNJXOarMaAfLm3l8lmMLFHt2ovVWoJsnQF+YdOmEIqieZNPBqRLS8smtzV9OqeSjQfu402QFCyA+tDfsVLGm2p1Pj3+Dc5GSrGR18u
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:DM6PR11MB3723.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230016)(39860400002)(366004)(346002)(396003)(136003)(376002)(26005)(7696005)(6506007)(71200400001)(9686003)(107886003)(8936002)(4744005)(55016003)(2906002)(53546011)(52536014)(33656002)(86362001)(186003)(54906003)(41300700001)(478600001)(122000001)(82960400001)(83380400001)(38070700005)(316002)(6916009)(38100700002)(66946007)(76116006)(5660300002)(8676002)(66446008)(64756008)(66556008)(4326008)(66476007);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?I6LtRarnjqdWSl/ZEIZWxJaw13Kcy4I0KV5Dqj/FCxef218Wwk4GJ/MNQQkm?=
 =?us-ascii?Q?MiluoL7oahayGk8tNS1eCcBR9Cv90wqyIfF+k8tbg0MtXDJK516pazvjkM4e?=
 =?us-ascii?Q?50n+INv6tpBykyv/ujBvN2PlprEcDc9FagUrHl4DsY5s1iit/jXTcxJrMnXX?=
 =?us-ascii?Q?vWilYGqH3SeEmEDNSawhK0gvqny46CLnfFN86ELH5M8Xv/0tCprEg3Eejrxx?=
 =?us-ascii?Q?8RjjI/lgE6CVfn36O8NEVMgAp1tp4Ynpug2jDhRo9S2a3YGGDYLcsCKZFwnp?=
 =?us-ascii?Q?I0bOj2c8rnSxKxwGwO4xCZwFuBWKorTWTak15gjzOJjgs0OO8DLwTQE/XStb?=
 =?us-ascii?Q?dDel0NaEjzKARwuv/qTFAAluLG4oT7L9SXd//5KNRSBhUfSzCoxHpOASIDba?=
 =?us-ascii?Q?8F1AqVhikwiNqLcX6b8/3KcTMBT7DwKE+jZHcW+uxyd2v56lBvknZSkIrPuA?=
 =?us-ascii?Q?Xy2Grn0CCOhnH0I5D5qOx0oqhuCLj/Y3OG/wB0+4jFBCDFnDuabr9wKfd7wX?=
 =?us-ascii?Q?YHKAUVaZVf1Iz6Sf7UTyHrT8ILp1Y8kZfoZkFs8dFdh3xMuYSsYuvms/SYR2?=
 =?us-ascii?Q?wVW5lJOP4HP57NWVSIZ47XFNlGBJg+W5OZa9SJiKhl7C1/NnOCwFxus/DL+j?=
 =?us-ascii?Q?FZWT2YrUaIwhkZC7y6dLoPt0Hn3UKWdY1eyPlRXZqOFJGsUukMsz9qImWIoK?=
 =?us-ascii?Q?CCw5C9/uq7i3Bixkko9TtObriocRxjA3xYTYcRQlRvTUt45wubLdRzPrfw1l?=
 =?us-ascii?Q?VQH5ogQinkMDfE4quvUG1WAX+5ukDJIbiDeTSQQO4NlY9F6X9P5dUVVM1rI1?=
 =?us-ascii?Q?kxDngH7stBySA5MrD3aan02qGcLRMQdcBRLakGwGTTVOABcUBD2erkPO2iUp?=
 =?us-ascii?Q?SCpCbUI97XL/+7HvamPlgLofRqa5vtmV/ocftUd1QrC/QdOPwWSTCK8O129Y?=
 =?us-ascii?Q?VEYWeFNz7U9AoqtNPtw5mJprpJs7jWU9XNQh3ZWvNHBDSoiLGfLlQk9tmtDe?=
 =?us-ascii?Q?6StSBulnfcJ9+LD3/dXJO4wlWaEuul6akAZSg6P9UqotVUme0Ib7eIGiEmH8?=
 =?us-ascii?Q?UfknTMYCNIuQ4vICYlLtMqbaIoJ4szx88AhkK0FcM0VGvDM2RoUIyGTpabHS?=
 =?us-ascii?Q?0+mxMJgy009fxD3SLFLeXIdgwg+lmncUtvg0YTY4g07DSuYB9gqlTfZsaZRi?=
 =?us-ascii?Q?lVwOZCmU2e+H29lv157W/J52A/+1T0hMwxuCV+XH8S9jJTSXfhHG7XKi5HgT?=
 =?us-ascii?Q?MkWts/lCfAWE45SdMcI+gIEpoiGu/FsJDsqnEb9qjheV632t+9L7pntLPY6n?=
 =?us-ascii?Q?x2jrZwCb8XmbBMnZCFD8OiY4WDJFfPL27AbYbNdCbdNHuUXDavThDk0g44VG?=
 =?us-ascii?Q?ZNkM1sSfsxWihcIDYtLMWll2YmeOD47pkfag0ELXazm1m2yn8pMLym2xkn38?=
 =?us-ascii?Q?IMZfqk1FfO5yJQW+BR6tDeYo1h/c/D9/IUZazVcF0lEPcZe6H5vySbaLKk1u?=
 =?us-ascii?Q?QaiY5GW1f100slXKhktNpaZWrinrKPyJalH0xka+LGJLXfddq7oGMAR7lZh7?=
 =?us-ascii?Q?Hb5EwepHBF1PFZsV5nCf7GWJp4xE6ZfHQhe8NJFM?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3723.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7156497-a29e-4d3f-a96e-08da78f8894d
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2022 04:43:27.6668 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PzcyFND7Ob5QGiGx3z1aSEkT0ciScu0wbXRsmERChCS8tcRD/9KEOJQmYkFnrCxu/bDskyvt0r+euGx/kHVeaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6312
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org



> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, August 3, 2022 23:12
> To: Guo, Junfeng <junfeng.guo@intel.com>
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; Wang, Xiao W
> <xiao.w.wang@intel.com>
> Subject: Re: [PATCH 03/13] net/idpf: support device initialization
>=20
> On Wed,  3 Aug 2022 19:30:54 +0800
> Junfeng Guo <junfeng.guo@intel.com> wrote:
>=20
> > +
> > +static int
> > +idpf_dev_configure(struct rte_eth_dev *dev)
> > +{
> > +	struct idpf_vport *vport =3D
> > +		(struct idpf_vport *)dev->data->dev_private;
>=20
> Cast of void pointer dev_private is unnecessary in C (only in C++ is it
> needed).
>=20
> > +	int ret =3D 0;
>=20
> Useless initialization, you are setting in next line.

Thanks for your review! Will refine this in the patchset of upcoming versio=
n.

>=20
> > +
> > +	ret =3D idpf_init_vport_req_info(dev);
> > +	if (ret) {