RE: [PATCH 1/2] net/gve: switch copyright from MIT to BSD-3

["Guo, Junfeng" <junfeng.guo@intel.com>]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Tuesday, March 28, 2023 16:55
> To: Guo, Junfeng <junfeng.guo@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Rushil Gupta <rushilg@google.com>; Joshua
> Washington <joshwash@google.com>; Jeroen de Borst
> <jeroendb@google.com>
> Subject: Re: [PATCH 1/2] net/gve: switch copyright from MIT to BSD-3
> 
> On 3/28/2023 3:08 AM, Junfeng Guo wrote:
> > Switch copyright from MIT to BSD-3 for GVE base code.
> > In the meantime, remove MIT license exception for GVE driver.
> > Also update the maintainers for GVE driver.
> >
> 
> I guess you are switching 'license' from MIT to BSD-3, not copyright.
> Copyright holder is still Google/Intel etc..
> 
> Can you please update patch title & commit log accordingly?

Oh, yes!
This patch just switched the 'license' from MIT to BSD-3, not copyright.
Will update this, thanks!

> 
> > Signed-off-by: Rushil Gupta <rushilg@google.com>
> > Signed-off-by: Joshua Washington <joshwash@google.com>
> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> > Signed-off-by: Jeroen de Borst <jeroendb@google.com>
> 
> <...>
> 
> > diff --git a/drivers/net/gve/base/gve.h b/drivers/net/gve/base/gve.h
> > index 2dc4507acb..ac0fc1472e 100644
> > --- a/drivers/net/gve/base/gve.h
> > +++ b/drivers/net/gve/base/gve.h
> > @@ -1,6 +1,32 @@
> > -/* SPDX-License-Identifier: MIT
> > - * Google Virtual Ethernet (gve) driver
> > - * Copyright (C) 2015-2022 Google, Inc.
> > +/*
> > + * SPDX-License-Identifier: BSD-3-Clause
> > + *
> > + * Copyright (c) 2022-2023 Google LLC
> > + *
> > + * Redistribution and use in source and binary forms, with or without
> modification,
> > + * are permitted provided that the following conditions are met:
> > + *
> > + * 1. Redistributions of source code must retain the above copyright
> notice, this
> > + *    list of conditions and the following disclaimer.
> > + *
> > + * 2. Redistributions in binary form must reproduce the above
> copyright notice,
> > + *    this list of conditions and the following disclaimer in the
> documentation
> > + *    and/or other materials provided with the distribution.
> > + *
> > + * 3. Neither the name of the copyright holder nor the names of its
> contributors
> > + *    may be used to endorse or promote products derived from this
> software without
> > + *    specific prior written permission.
> > + *
> > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> CONTRIBUTORS "AS IS" AND
> > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> LIMITED TO, THE IMPLIED
> > + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
> PARTICULAR PURPOSE ARE
> > + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
> CONTRIBUTORS BE LIABLE FOR
> > + * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> CONSEQUENTIAL DAMAGES
> > + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> SUBSTITUTE GOODS OR SERVICES;
> > + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> HOWEVER CAUSED AND ON
> > + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> LIABILITY, OR TORT
> > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> OUT OF THE USE OF THIS
> > + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> DAMAGE.
> >   */
> 
> Why not using SPDX tag for new BSD-3 License, but add whole license to
> the files? We have SPDX tag to prevent this.

These are provided by Google team. So I just keep them unchanged here.
So you mean that we only need to keep the license tag part as:
{
	+/* SPDX-License-Identifier: BSD-3-Clause
	+ * Copyright (c) 2022-2023 Google LLC
	+ */
}
Right?