From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D335D42D79; Wed, 28 Jun 2023 04:19:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9101406B3; Wed, 28 Jun 2023 04:19:11 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 6AA1040151; Wed, 28 Jun 2023 04:19:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687918748; x=1719454748; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=SSASawz8BDBr/KQKUHP1WAAyOCOHRw70drjwCpV/yX8=; b=SCBUX8jv54jIENzVOa1EkVaV0w1BKA3S4Z3G8pJLYoIYEflxzOy8+i48 a4Gz+mH7BGuLZF2pJuXoWu92qe2n0C5ukrplYJ/qBy1QOoCls0J9WfpQi yZF+13G0KWlaqNYsi23iirtAEDhQfUrC2y0hJXJ3zUxlVCVCam9Orp7AM 0sBIGTHemWbCXzLPWZ/FiJ8Cl6gzzVApSAMq0tDS9gOuo/7JreIJOk214 z0oUFMkkja7UWaBfO0zkuYIbVbVSYx6vMRaRh23LJdbdVsc2Ct1W5GQuW B06eulCIEhzhkGgmOSBEwj3/6lMmS2ScaPfNBjifBcmn7HwNpg5puhuOq A==; X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="425401110" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="425401110" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 19:19:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="861324695" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="861324695" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 27 Jun 2023 19:19:06 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 27 Jun 2023 19:19:06 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 27 Jun 2023 19:19:05 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 27 Jun 2023 19:19:05 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 27 Jun 2023 19:19:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AqE9SQlSimc77qJKfK+MyOFQnJ7zdrIZLWtJPs0pVdIgDk3kolc2ZwDJG7LEdnosI3o+nPQjcFCdsiR9WWefo7GasytmT+fZC0TE3v5VEkUVwMC2cfMInJVhdrihosv9WDofKlkd8W7Jda7QHeXOE0tW2iiT0rtHOTao3Xcmu1zJkwHM7fedHBgcmEolit2qfOOF3CzDwJksVC1mVbdBfVbuA+C3yfZgaBdkjKYfb8IGy+CkrpMVmv6z9XKuKFQz+C2ixtIBKNqulxBdCCpA0r2CxnG8IcfeEpJlBNCiPpl5X7WqY+fafGsuN7c8ZxXJt647+suwJkhI0bxKCFzi3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SSASawz8BDBr/KQKUHP1WAAyOCOHRw70drjwCpV/yX8=; b=RJCxMsLnWAtuNlgWjXKc0ys1ZP8VeN2P+5p0legwYIYufvkd0EGpUt7eqoX13uyA8Ur9UDCHNeES5zdbGr8x3Vd+ADqWFvDQ6ZBitsVwquQ9Vhvjb01sADfpronHwF0Qr2dqkxHeGpRTda6IiDQS8mRBTi0R02+yqZB8tyATYTd40YjqBpeym7Dw/NRkIRwyfRhSMTNCuLLmHRgMjCJ89C8Ca4kMBqwxI3VOHj3939TCmAJ9HzD9q1Xo4zcx/qOZy0oBohuvZORP+UJmGFayl2oNpjMAPE02AuHOgVzJBabi9yUxKFjThtm/7us1eC5pkIatyx8kP/QirnYG6r1T6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3723.namprd11.prod.outlook.com (2603:10b6:5:13f::25) by PH7PR11MB5913.namprd11.prod.outlook.com (2603:10b6:510:137::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Wed, 28 Jun 2023 02:19:03 +0000 Received: from DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::199c:7b:b9f2:8330]) by DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::199c:7b:b9f2:8330%6]) with mapi id 15.20.6521.024; Wed, 28 Jun 2023 02:19:02 +0000 From: "Guo, Junfeng" To: Thomas Monjalon , "Wu, Jingjing" CC: "dev@dpdk.org" , "stable@dpdk.org" , "He, Xingguang" , "Laatz, Kevin" , "Richardson, Bruce" Subject: RE: [PATCH] examples/ntb: remove redundant logic for dev close Thread-Topic: [PATCH] examples/ntb: remove redundant logic for dev close Thread-Index: AQHZnn8fKksuWIuunU2iJeuifQPfVq+fbWAAgAAhFbA= Date: Wed, 28 Jun 2023 02:19:02 +0000 Message-ID: References: <20230614051423.176572-1-junfeng.guo@intel.com> <1980494.zToM8qfIzz@thomas> In-Reply-To: <1980494.zToM8qfIzz@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3723:EE_|PH7PR11MB5913:EE_ x-ms-office365-filtering-correlation-id: 3f7ce7be-c52d-4e9b-daef-08db777e0a23 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7JHlmnwQBMladj0DVTilDvcq+MW5mc0DHtv4yMHHlnppApBr6LbGS9VhgHimxhjJlsGPipVGZhkjVIAFusoxwlZLE0SCb4RdszfY8jsygQdhK6SxRoeevZLVzkOoQXeH67IR+EGlCgnvrlD7laTYUNitjJt71YgEvf+W7a04DhIamVhh1XmFErv5ueXgRhizzK4oIw5F7XDjohQzidAe+7YrZPU9A1E1G+GT5kMTjs53hjAj1wKpTwHtfSi8k8WWHfxfvheDEIJ1vHI3UOZdmvrXt+DMtZv/5hItwJnjDAyomt2XXx9gRCvHpINua6jbdeZ76LNNxC/Jwfpb4YNmfns+IGyKJ5cR0dk5lNzsQOsyxIl+3kboVOSLO4DduDPxWovnj2BXhVs0tx8iUbERyMYNjXv2wWSNZHiRrygQT8/v1jUjXGEM74CD6nbLTMmk0hAabYw0LJ+0CalZDBtsYpy/SshvX92V65/lUmTsipnhkHJc2oJlB1Nl+eOOFi+yKb0qYT1FIn4HATmvThrP2UWvmT3azeKzASZS43X9GVskHDUFd7YAHHIwQxAfxfebMr9vHNRlDD3LRN6FSHwLCaFU+6sqNJFfdi5a39cGdN1u1iZ677kVENplXJ8ppHAw x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3723.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(376002)(346002)(366004)(136003)(39860400002)(451199021)(8676002)(66946007)(41300700001)(107886003)(66446008)(64756008)(55016003)(66476007)(66556008)(4326008)(8936002)(6636002)(76116006)(316002)(6506007)(26005)(53546011)(186003)(9686003)(110136005)(54906003)(478600001)(71200400001)(7696005)(5660300002)(2906002)(52536014)(38070700005)(38100700002)(122000001)(82960400001)(33656002)(86362001)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Y+OfxT/w14cYH7DwSJPwE9uBTb/ajl5qvaTz4WAXI+NV5DzGtKyGbCd/3/MA?= =?us-ascii?Q?AKm/JD77gK7FgbrJtQUOGGBT8yZyRWdC7wX/2RAm0qQMBSQG487oBBK3FJuN?= =?us-ascii?Q?zPgvbFi7+Z8DlkTxpnSAtdWZS2LZ+co6hMJbd1HJaGqwc235ITi0KKtpx4dm?= =?us-ascii?Q?Bz3FWQkcxsfM5jJB5RCP4aX1pqoKv95OFdET0kRdHs9/mfVmO76XprvQ5WX/?= =?us-ascii?Q?+og2fW52mX12JfB055jODg1bWk4k92YAwMJkETeGCjJXn86x45/+sgK0IByS?= =?us-ascii?Q?Ovymgoz0TYDjMj8/G63R7Vc11vxXTpnqK3EioSBAITMhaIQgns+Zq9kcehvN?= =?us-ascii?Q?L4NhGUBcXAR6D3rfwn4T4DmQH7GncNY7yxNRkksBhi6hoRJold39r7ZLLxgl?= =?us-ascii?Q?+fHupGlHwgS5FYuaUmTnxcKXyI5OrelcRMEaWBVfZRvSDQ//h8HcMcs290wa?= =?us-ascii?Q?kbLnGOg7PZdBswIFM80nMk8UY0y31H87aSuVpiFBEYX4wY7WU2U1r5S50qmQ?= =?us-ascii?Q?CBhcxwooPUdnDFfLbuCt2c+Wx4FWKghWcMEgIbIjzn9EI2mi3Km0djdnfhU4?= =?us-ascii?Q?+5XDQY/ekKccIMvaRS+7c9o5dxm2sKfK5U//kVpbx5OOHAQ2Y1G+85RS5GFE?= =?us-ascii?Q?KSh2cw0nlsOTsFbR9S4+4EL3PA9GkiSkXPyZT5wqEcyBK27HqiVmqHS3ok89?= =?us-ascii?Q?M/I9BpbY4UVfVZ43EBIsJjJ8GYuS3zKjNGyDRY/9L2d71mLjAR8OKsKf/Msb?= =?us-ascii?Q?wIDXpHJaXRIXgRxfpbMdYi6aJAo3Ui8YrgMjyd5rSd906gioU8jntt9jbqVy?= =?us-ascii?Q?AJSAfeY/afuJStend/oBDoCJc8/ygpVGlh1f/Mqer4zbZDsC4wsVWlDQec6g?= =?us-ascii?Q?vaxJ+9M8gojqPqFl/a4ld3YgTgyrz+O7+dz4Wl8wHsn/o7pXSQmjAWnMgumh?= =?us-ascii?Q?MilFdpRctrxX4jlA1mESbmkqrJyXdxKuKG/+rcWB0IMz+cmpFogzzyVKEVg1?= =?us-ascii?Q?Ho1nkV/Peb2Bc0WevRMtktuU2+JMp3rBu7BmNYOfvNmcTno1sXo5i9pKUj4E?= =?us-ascii?Q?oS0/Z8dRFOoeVSVJuWfSURFKLmsvSZOstrdUCldH433oCNmnBszDZGkqXtRK?= =?us-ascii?Q?KCxzCbwU3Uh6+0k1DFjr6PIVxBpq0ta/7dUQ8/1dZRbiTDhB/z6Udcg1OkFL?= =?us-ascii?Q?7cpaY11kuouIgCB+3iSzgy03IDnIvUcdcfkwz39LUczYoeUHIeuCA6f5e5FR?= =?us-ascii?Q?yDKCn2VzHpNqC/jLFXEfumuEpKUhghJ7BAQLGMLFA+K3VdqQvoHAU/9FdH/K?= =?us-ascii?Q?f2qkkPeqQsj+Oun1ziuF2txaoQY2fN14D3D4bA8NLwJz9vLfiPUg3iYty8aR?= =?us-ascii?Q?ye9M/mdYd/TP8VBEAspazN7LyaxXGkq8pGxdXc+oZqH0ucYxf3NfV59assHs?= =?us-ascii?Q?2Q1CvaQn/tyuDYkw4NEnX6Onq1vZlXiMgasvojj027MTqmSHzlyK2090DzZn?= =?us-ascii?Q?nV1GWdIm6TrGxfgSIXw8faC0uxKBDLxH7k7iM1FVVcq0DJ9iFB6kiMw67NmT?= =?us-ascii?Q?MikDycexNcZnZZK3pf8aQaNRHMXnYKJThfiWdaZi?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3723.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f7ce7be-c52d-4e9b-daef-08db777e0a23 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2023 02:19:02.2467 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vZN5Vzf0ShpLD0bL/2ejTJAOXp6Og+QBNXwBKZL7JGT8EWu9A+1rlGZb3wZS5Vyrkb8jGZMtDSPi/S1snvVG/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5913 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, June 28, 2023 08:12 > To: Wu, Jingjing ; Guo, Junfeng > > Cc: dev@dpdk.org; stable@dpdk.org; He, Xingguang > ; Laatz, Kevin ; > Richardson, Bruce > Subject: Re: [PATCH] examples/ntb: remove redundant logic for dev close >=20 > 14/06/2023 07:14, Junfeng Guo: > > During EAL cleanup stage, all bus devices are cleaned up properly. > > Based on this, there is no need to do extra device close process, > > which may call the dev ops '*dev->dev_ops->dev_close' twice. > > > > If this dev ops for ntb was called twice, the interrupt handle for > > EAL will be disabled twice and will lead to error for the seconde > > time. Like this: "EAL: Error disabling MSI-X interrupts for fd xx" >=20 > You should fix ntb to not disable interrupt twice. Thanks for the comment! Yes, it is exactly what this patch did. The interrupt disabling process is part of 'dev_close' ops, and will be called twice (one in EAL cleanup, another in ntb example cleanup). Now that fixed & covered by the EAL cleanup, there is no need to run dev_close at ntb example. Just remove that redundant logic. Regards, Junfeng >=20