From: "Guo, Junfeng" <junfeng.guo@intel.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Wang, Xiao W" <xiao.w.wang@intel.com>
Subject: RE: [PATCH] testpmd: optimize forward stream statistics
Date: Mon, 6 Jun 2022 09:02:50 +0000 [thread overview]
Message-ID: <DM6PR11MB37234BBD53E8BD00973CE33DE7A29@DM6PR11MB3723.namprd11.prod.outlook.com> (raw)
In-Reply-To: <129023c1-a16d-4a4b-5547-1d9effb601b1@oktetlabs.ru>
> -----Original Message-----
> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Sent: Tuesday, May 31, 2022 23:28
> To: Guo, Junfeng <junfeng.guo@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Wang, Xiao W <xiao.w.wang@intel.com>
> Subject: Re: [PATCH] testpmd: optimize forward stream statistics
>
> On 5/24/22 11:27, Junfeng Guo wrote:
> > 1. add throughput statistics for forward stream
> > 2. display forward statistics for every forward stream
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
>
> Sorry, I don't understand why summary say "optimize", but description
> do not say what is optimized and how. It just mentioned some additions.
>
> Shouldn't summary say:
> app/testpmd: add throughput stats for forward streams
Thanks for your review and comments!
I'll update the patch in the coming version.
Regards,
Junfeng Guo
>
> Any reviews from testpmd maintainers?
next prev parent reply other threads:[~2022-06-06 9:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 8:27 Junfeng Guo
2022-05-31 15:27 ` Andrew Rybchenko
2022-06-06 9:02 ` Guo, Junfeng [this message]
2022-06-01 8:46 ` Singh, Aman Deep
2022-06-06 9:00 ` Guo, Junfeng
2022-06-06 9:39 ` [PATCH v2] app/testpmd: add throughput stats for forward streams Junfeng Guo
2022-06-16 16:39 ` Singh, Aman Deep
2022-08-11 6:57 ` Guo, Junfeng
2022-08-16 9:32 ` Ferruh Yigit
2022-08-18 6:57 ` Guo, Junfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB37234BBD53E8BD00973CE33DE7A29@DM6PR11MB3723.namprd11.prod.outlook.com \
--to=junfeng.guo@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).