From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63416A00C2; Tue, 27 Sep 2022 09:28:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 308A942802; Tue, 27 Sep 2022 09:28:02 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 1824441145 for ; Tue, 27 Sep 2022 09:28:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664263681; x=1695799681; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=03k4JcZHmHPfCiYmnsErHDjlTiN7ei06l11qz/U6BdE=; b=LlO3mtlx4Jph5KVzPVRHtiJTbvtD0V0qeJk2fWL7tp52hiZCE34q5oAA wBFAICWOmGF4FYduwpnQSWN/textjydPofdqEeu+WIxSCUgnBWtF5Jy62 y6sBZOcBiegkdOk0N8kmfRTOdeKhXDxGyDUUulrapyiRDSeIqRAYfkSFK KT6XJ8qSGsmHILowPFEWG1SjNbUAPOpXvasxYJqtDMH5Kxj393QOY+hsJ ILNp9HbjMQAF4NDdDQFkWjQzgGmjE9MZnD/XZbjt6lkc1hEq5tWpm2E2R 3Ep8JTw4Q2oI2lr0HMd+KBRbpiKQYBpkGEcycPr8pV21FetixHd8zDNp1 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="288395870" X-IronPort-AV: E=Sophos;i="5.93,348,1654585200"; d="scan'208";a="288395870" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2022 00:28:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="725407528" X-IronPort-AV: E=Sophos;i="5.93,348,1654585200"; d="scan'208";a="725407528" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 27 Sep 2022 00:27:59 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 00:27:59 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 27 Sep 2022 00:27:59 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 27 Sep 2022 00:27:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D46ggcnmOrjCQk3JkGBipyMe/AHdsruYuSZdYqh7RXxhitWUSCzRZCxiJsrhimnHLhxQkzW/SGzy2cXrllsTYFp0lFZq6jksJlwE2GA5hvWLHWvCrEFmTQYsLgLLZUDcCXdqvOdLJtYF+5Wa2T+vJlTzfG3OkthiyU82jYQJ4Uu/RqVvsCFFRr2XBxMaP9wOkc+7HzPgmXaKZ9z224xN352OQYWtQga0Z+t8iXQXzV+duxofKZHk+Ea2ylWtctvh8m3lX93LRkig8Trhi+I780D/qCF6SeNfv7uZb4y7K8emwj2e5l6YjGL6gKlmDHyPVRr83MqQIjHuhiuvGjeiXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xgl6RUs2lOJpGRNVG6dEnbVN+LlU2rDXxsZut3+g3LE=; b=dqYrC9zlWp/5B+XMWkOh1HDyCFg1STDEZ2bq1vzaLpUDAhzF9uQKhS/3hmdR4k4f+hZgzd1w4EYadZA6PaRgl4ZYzID6uNnLneGBghyTM2iWZSL5NXs0LJi6f2KCSU+MNNz7Cz1AvJ+xeudlpX0ws+lYXxy6fbRnv7fBE6syCxTfzDIMP1ZM5oEILFEL9oUBKjg5UGn2Kofp6DRJHPJW1Dnv2wWKlMvrsaOAmDFYq6aPf0vSPnrJAVr4uDwVNNI4T2dCHe3ap4usbuixw2l8JGlNRIGWoV6QpgnPZhN8/C+BjB9a1x8gTDB2+yRKVMauQr6EGa8DHvVFhZ7XUqV1RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3723.namprd11.prod.outlook.com (2603:10b6:5:13f::25) by PH7PR11MB6555.namprd11.prod.outlook.com (2603:10b6:510:1a9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 07:27:57 +0000 Received: from DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::126d:f905:c1d6:dcb9]) by DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::126d:f905:c1d6:dcb9%5]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 07:27:57 +0000 From: "Guo, Junfeng" To: Stephen Hemminger CC: "Zhang, Qi Z" , "Wu, Jingjing" , "ferruh.yigit@xilinx.com" , "dev@dpdk.org" , "Li, Xiaoyun" , "awogbemila@google.com" , "Richardson, Bruce" , "Lin, Xueqin" , "Wang, Haiyue" Subject: RE: [PATCH v3 2/9] net/gve: add logs and OS specific implementation Thread-Topic: [PATCH v3 2/9] net/gve: add logs and OS specific implementation Thread-Index: AQHYzzBg9uv2X8ubkky5T9sBHEFf3a3tX2QAgAWGHsA= Date: Tue, 27 Sep 2022 07:27:57 +0000 Message-ID: References: <20220829084127.934183-11-junfeng.guo@intel.com> <20220923093829.3019525-1-junfeng.guo@intel.com> <20220923093829.3019525-3-junfeng.guo@intel.com> <20220923120128.771e0778@hermes.local> In-Reply-To: <20220923120128.771e0778@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3723:EE_|PH7PR11MB6555:EE_ x-ms-office365-filtering-correlation-id: 7a4bd58e-e663-4cfa-2619-08daa059cd02 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: S/us5oeyjVZteSswuxvl1eAOMl/b8ejxyUuLsiJpJqUeNTR0KpRh3zfm1CN+FqClCSvw1GdaN0qN7Ge5Oh49h7kUrjT39YchFVRRTL5E4c+zEBmse9A5I6hCDEgVAMb9lc4fahOMDMayQZqxx38NOXDxl1HEZJGG7/Vfk7ytINx4xT1D47TYksUAO2hP8oUV9etjSLPJLTSDnktWMwiAm+I19J0IlPmvbCIPqDKGfG1atu4O3Uee18LaPBhYMDOTdUiXjlCqj0hzqMU0afnBs34yzcy3RBYM/j9TCs2DG+/HSCVaMOzwCpaDQ40TCsUX+9fzVMVwhOyWmMB/otfJPDQrqfnzaDch5xPfgvGVlPWVw4BB5trukwOxchQwphyhcW349Y0V8k/qpIQo0jgE4vSsfWrwt+v+1vsXpYZ22K6FJPJwJdzt8qOT7zOeBCF+TgUVym5ghysvwlHAqjcELwo2dW8ErKnjR5sEd+X2JgHVY7qjLPaDcDPmkGb28qT8911qvMKoS3rG4aPzQwg9iq8u7lEgCDzgG9EM2VO5BLKV6OnxZq06CE6jLoE6LnQxAUvu2/dG49XU2ZN4NyAnvbWmBHI1PGTyh3I5lw0cQJ68/Jid4y3wUzcHn3m7HmI94sF9KmTFuisgDJehoNXhD0qcX4+KKkw4h3saXuMksUVG6rT+aG4L+w88i/PjSn+CTBZlQ9caxamC2Mjn1uY6DZVzjCx7QST/QbN4lxajNdk/3zwMcs5moimfvW7ZGR3px9t9/SBppod7fRpl3ujC6A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3723.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(39860400002)(376002)(346002)(396003)(366004)(451199015)(33656002)(55016003)(71200400001)(478600001)(6506007)(7696005)(26005)(53546011)(9686003)(83380400001)(38070700005)(8936002)(52536014)(2906002)(4744005)(5660300002)(86362001)(54906003)(66476007)(6916009)(186003)(66556008)(66946007)(316002)(82960400001)(66446008)(76116006)(122000001)(107886003)(38100700002)(8676002)(64756008)(4326008)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o3byHCGDz2F7M6jy7P4VsmZwlW3Ni05srh25+YF9boqoJ/hmDYZbpKIrGVPr?= =?us-ascii?Q?MNRySQR2Z00yim9ixG2I/U7jq6QdbET+5NYkFz4mSd8S37P56KVPbiNQOGib?= =?us-ascii?Q?IX7pusf7yComxT5FgBaXeS7wVxD3AwDBQxi36Ak8BJVnVvCfUoWebag+JEU6?= =?us-ascii?Q?oWGDrQAu4PmuZ1K0zttz1SJkQ5Haftsa5eOKX3na8bLtNtRF1C4oyqMnUyAj?= =?us-ascii?Q?vbl6KKeLZZzhep/cGtYFXSJJRLcdUX/e+bz3EnfI3pCx3DD4fo0xCtxgwRBp?= =?us-ascii?Q?GRVAobZEztqUoFXGTXFnq7jAZl9WN5mhw2+eAfVFiTpkCafc1SMi926RKk/G?= =?us-ascii?Q?VjKiSIcXVWJ4gKCtmbvx0YVgky02KF3JCCUSAdOR36dOEBHRBc4g0yHQE/Ri?= =?us-ascii?Q?TxUHBcNKTk7HpoJ9dGE0r/SqtPhDodCYJR3bUOmEYRkPYkayUwsp/DT9oCpB?= =?us-ascii?Q?gHAFBhlhOITftAg3tLpja5uRMQQpZgd2QsiLblulvYWZI3pjzqTIfp4zitJG?= =?us-ascii?Q?qD7GQetxJxBSaLE+vn65EZrY4iyCFKJJswel0e4I4hLt6cwxegKFLJW9vGag?= =?us-ascii?Q?heqQvBzVYL3Fv7RJ/Gv+sWIKnitdzRul6AJKi0o4IREDZ4h+lfx/BZ7e+7zN?= =?us-ascii?Q?G9iyNIPxd8EzyQ2rt/UePdpUC9KmZFnuBi4+Q1arWX7L3DHcsjRD5ptQ7kIl?= =?us-ascii?Q?tVo16kk8/CNERu/GdBD+a9qBE5FFQSL78uvFLcbBYcKmaperxNOYpC2qgJ5b?= =?us-ascii?Q?vvg8OlV4jXDTU5dltim2dvhheKrlpRsokzlCxLIYOLRAGc1CjoJBgUIxRobk?= =?us-ascii?Q?IhXFR9gbhPxGECjM+tajTfziOEg3zjuKTHMelW3mcdKJvoC7cLfChatoUU+a?= =?us-ascii?Q?EWvcAhWO/uZ/AtSSMHlKVNLKgp/ZTxWtm1xnUVa54u4jZdn+C5JNX6+kFsyH?= =?us-ascii?Q?4n7sCjwZnlJnj7WpBHx0wTCHzqPVXucgcyDuR9NA3TE1rTDQSWPmCpAoQppd?= =?us-ascii?Q?oanFxVKqSNvbt2DmmEgrDpOAebeewQgdOoQmsDBx4DwWA5Pjt+EZlDiiqU0M?= =?us-ascii?Q?+GhbScEpjSv3VKOtEtAifTjyTr5GfPg6U+vEkAf5xogOvj5uUDtU5w7oPAgF?= =?us-ascii?Q?hWiYmsA/G+EjEi0coDmXxhzVaJS1jiOxzYbVLMmDdsGMmZGBCqbKgJXBo7rX?= =?us-ascii?Q?a/UFRCGTRgN+Fpn1kAuqxbCA9HWNe1CebNfwQlWah76BhzjRCYkYOAy1Wcge?= =?us-ascii?Q?9GN/Kfp1Ms7Wyoa+zj8LGSoQl5VoHRgh5bHC+pAChut1X169OebI4IMqgX/p?= =?us-ascii?Q?NCW9ZzhpnxNrd/5HYB5GzJVLJSZw+Upp34eYDV9sDm+AJhHZNaWYEzvtslNZ?= =?us-ascii?Q?brFKi+QKiy5+crPYNoaKcqOimJEfozZ1ntyN6xm37ImfG4+0B81jOUIXYBZi?= =?us-ascii?Q?MC/VI14zNJcEEzpuuHL8qN8HtHqN99jB9q8aR7nbziZeSCtXZrJC6WtfJorU?= =?us-ascii?Q?PvjTYNt2biJ9/NpxF6WXHWFOgokf9PiGf5onWQoBYwOrrjZZ518gjzAKcCfX?= =?us-ascii?Q?5EArk4Wk7rSnnfeTWqXDjUNh28guj5n3oJhlR0IP?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3723.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a4bd58e-e663-4cfa-2619-08daa059cd02 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 07:27:57.7725 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oAHDGFX3Xy3yAHC47hL8wUKaSrjqIlQhoUSNXwIYi3zB/hbjZfAGjAyXjpssh7N1FCnxAYP/D5k6lHWSzvKqJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6555 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Saturday, September 24, 2022 03:01 > To: Guo, Junfeng > Cc: Zhang, Qi Z ; Wu, Jingjing > ; ferruh.yigit@xilinx.com; dev@dpdk.org; Li, > Xiaoyun ; awogbemila@google.com; Richardson, > Bruce ; Lin, Xueqin ; > Wang, Haiyue > Subject: Re: [PATCH v3 2/9] net/gve: add logs and OS specific > implementation >=20 > On Fri, 23 Sep 2022 17:38:22 +0800 > Junfeng Guo wrote: >=20 > > + > > +#define PMD_DRV_LOG(level, fmt, args...) \ > > + rte_log(RTE_LOG_ ## level, gve_logtype_driver, "%s(): " fmt "\n", > \ > > + __func__, ## args) >=20 > Many of your existing log messages already have newline, so using this > common definition will create double spaced log messages. >=20 > Please audit all usages and print one newline. Sure, will double check all the usages and update in the coming version. Thanks!