From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6430641CE0; Thu, 23 Feb 2023 03:49:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1770942C24; Thu, 23 Feb 2023 03:49:57 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id F13C740DF6 for ; Thu, 23 Feb 2023 03:49:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677120596; x=1708656596; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=oVQjdGuD9TQ91GxGVMO9ARHO1aHFDx/DhtkhwdpS8PI=; b=aNT5ow1K+iPXbzRNNGoRUIIZmNv1Z0897mvqPV5r8L9Sm//ELw5IGLz+ OG4DGSuomlEaQ64e/KDHpV+mV13GVxXAsWtdK+SBfNngaCCI7XhIxzpy1 K9HIsnAmhSNNF+AroStDULXBLQVIDJPrDtP+yQE3EcvJ3wL113lj5K1ZG w9YxZvfSnPUdLGFsFhTXkjiXfZdBqJx9uHEprk8rEwfsmQhjWoQvR9F6B TQtj0hza5LyBz40jTWX/3wTa5UIjyK8QuL+5IhrqOQR3KXwX2dFZcQeyr AkRhyjJcOa4AjAGtzvmbJjjST229a7jKrSQZLCuhXJftIouVNfhcKEHAa g==; X-IronPort-AV: E=McAfee;i="6500,9779,10629"; a="331768589" X-IronPort-AV: E=Sophos;i="5.97,320,1669104000"; d="scan'208";a="331768589" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2023 18:49:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10629"; a="622161330" X-IronPort-AV: E=Sophos;i="5.97,320,1669104000"; d="scan'208";a="622161330" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 22 Feb 2023 18:49:54 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 22 Feb 2023 18:49:54 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 22 Feb 2023 18:49:53 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 22 Feb 2023 18:49:53 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 22 Feb 2023 18:49:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IpXJQ1b/St1B559AxUNQhsW7o0QB3YAQHmzQ64XAM3tqRl9xbbQdb6cUdLWNjCRGYMGqOwGyzQs2b9/Mp6EybATbc08BbA0sOSBBhtJZtyN0fTluriMFwn2+TU3hdqZpcXuxoxm5zXg+Z6vW/P1+XZDH+qkXlXHDbZB/Qgfh582C32JAE+ywWQsf9lfPhGyVS1KrekQ7LHkzJ8GpVIIaQ+5twMA2XXHgkJdAAOZkNbSchhNt1ahEDuobaGyzCve6pVBbHU+I8bVwK6+I7YbY83XJG4ouxEeTqlJPEOMo+sUj4f1jKGYqpTfeid+FtqDoVBnMJLCrN0c3/zqeEwBlgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hL3Wh5kQH2BzmAZ3PQL+Sfh1sCrtnKdR2fctlyu7JRk=; b=A8MfgMmNU8axXELmBucH5OGPmCuL/FgkI1UH7usXqWhZ5Jh6xCBg2O4TGwVH1E2cDbn7YLAauW0bZWz1wNPblgggKerAtQ0/EKNqUXGV4AaNY+XCquOqvPDrHg+WiTLeGmPgrohMZYSuiYML0XOjCIaanXPsvdd8daEJ46x9Cti2pAJYY0saxKp2qgfVOzPfisrX8WJz4S7pKQ8VMMk020BGsP4uX0MYm/9dU5GWxITKUuWbmaCzu96Ukyg6K4dVlMt1fKgbKoA3Tlpu0dQbVFKca5/Tl/xRqFzR+EufILwZMtW7rtSOMtU654cZ503+00U5qgD65ztHobZkdKnmjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3723.namprd11.prod.outlook.com (2603:10b6:5:13f::25) by SA1PR11MB8255.namprd11.prod.outlook.com (2603:10b6:806:252::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Thu, 23 Feb 2023 02:49:51 +0000 Received: from DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::b060:3d57:bbe5:baa8]) by DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::b060:3d57:bbe5:baa8%4]) with mapi id 15.20.6111.021; Thu, 23 Feb 2023 02:49:51 +0000 From: "Guo, Junfeng" To: Levend Sayar , Ferruh Yigit CC: "dev@dpdk.org" Subject: RE: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats Thread-Topic: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats Thread-Index: AQHZRf9jJVyxpMfB2UCtrNkeb7UMUa7Zjp0AgAAM3YCAAjtK0A== Date: Thu, 23 Feb 2023 02:49:51 +0000 Message-ID: References: <20230221141350.12335-1-levendsayar@gmail.com> <20230221141814.13674-1-levendsayar@gmail.com> <68DCC243-8E0A-4BE9-8D7F-2D704B427EAE@gmail.com> In-Reply-To: <68DCC243-8E0A-4BE9-8D7F-2D704B427EAE@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3723:EE_|SA1PR11MB8255:EE_ x-ms-office365-filtering-correlation-id: 38d13b5c-035a-4b93-8163-08db1548a2b6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xrQcBRO5ZfXo5H+fy7SjIEHMnPgopT/XGiGhA2oOZkb14KXIqCNxiQuKQa6PNGEEC3ubnlyLGb95sMAxEMNqmAeaSWyXmlqL86fbn4FCFRSZ8Ay+5Y7IvxCT+odtfYpqJoHm8osRMuvu++GtrJpFduKcztOhER1hJsZ4TwH+0lFr25FV1cuN++5plUOLwosfKLz+f4EyXiWUTt/vAUpsTN/LxcbvyDhv0uLqr+7Yow+va8rqXkFIa3FKEwnN0O5sPyZeCfu+O1lJiPYz7okmVXeKdrLQgeNaMXYYuekePmwlv6Bv/6ODqaW6KG2Vw15VV/jet+Tl8kNlgi//6rE4ZfVWAmYxksjmHZgTCqmjm4qzzyZ3/o7bdtkxXfZe0EvAcl53lP2oRQ0EdrwEkxe2bC0qsderx01L4ru8XFPdheKaqPLNsaLtqc2VMNUBIlYMUhH/bBUtp+g8i5mUVxMhqOqSUII+hRe3KPsByBIDP2gBQZxdK9311S2Lf3mKPWCt2USR1jnqgPIcA6q1lNCGhv5fUSHv6REImcrrsQMFtdF3MV/YJ7fpfC33DVmbap3QWUDZHfFNpc+V9yEhiMY4m4Cq/qfrOEPrM7GIq0xaPugL0y7E3fHSuT5lg8aL8/uIgxGKXbce5DHUiwtkgXczXgedzI1RaRQ1b3Nz6xcak92XXOrHH1qJphh0vLnEX4ieHPSvu1+0mTfo1yr1JZ04IQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3723.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(396003)(136003)(346002)(39860400002)(366004)(451199018)(86362001)(33656002)(41300700001)(66946007)(66476007)(9686003)(55016003)(64756008)(8936002)(186003)(26005)(66446008)(66556008)(52536014)(53546011)(76116006)(7696005)(110136005)(38100700002)(316002)(71200400001)(6506007)(8676002)(82960400001)(478600001)(2906002)(122000001)(38070700005)(4326008)(5660300002)(83380400001)(4744005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cIhLVSafPIgeWtqsXtU3lyw/9zIs8J7+wSQIUrqsTn7aDGwZiyys/zrhcuGK?= =?us-ascii?Q?pw+MupMr/RHMKvHeLc/sd/sjY74SQo7R3gcJXZd1WG5Fb+2hlgM1pI+QbAgb?= =?us-ascii?Q?OF6bgIdx2DCK6JOUdNqJzPzzjuOA5sIoFSWabecq5mzr/PgtFLdnG82mGT2V?= =?us-ascii?Q?Jd3lqmhkzMbiAgVO/0BA/JSleAGDywxe8eEvP4ti3p1uoxBz6ttagiiTn8I0?= =?us-ascii?Q?9afJwq2ygr/62PG7fEKTpbLd5uYRpndYlMSrI9e2bmBqgHwWY5LqzpWIAZMn?= =?us-ascii?Q?b4rxCOWm2KWUcFjh9VeshpGmEHjk7siKdFiT2QQNv6IRC8niw3rovcdh+J/o?= =?us-ascii?Q?slDff5KaBkKUDtQ4A+HVkDcqv1Q18Nsb/pooXf9KfoYpwFC1VtEqplJx0pRT?= =?us-ascii?Q?uRIJ1s75TP9SAHW3Yn9s7tviFK1w4dmZEOwW+K4Ntq2QFz8vCPRe7OpHjS3X?= =?us-ascii?Q?Z/kfPH1GPPql3/LR14Zz2DH1j2wWn1PoaYnh4jSZ5KU2cGrsdeDcKAdwSRmn?= =?us-ascii?Q?GcGmrP2aJOOVvjinqHwGLVGsNsiEHa2kbLyHBV3WR6eknScD0qvanIJKhFlx?= =?us-ascii?Q?S3b3xqGS+p2A1RApYLE2bB24PfwL72ZMF8UVKPSpcUZJyzhkRtB0AudnfCY0?= =?us-ascii?Q?DDUA+psR1oM5UgQJ9ZN3g4gSh6B6UimzPZYu8raqQzy1N9hk7iNwsVwW6ANl?= =?us-ascii?Q?2FnXRhJ4+6WWlQHej0hEsNGRvKUBo7RjTK5TBOyKieJrDtac05hsfm/Xo+nH?= =?us-ascii?Q?ezVhHL4E80beR/tvr3zjlRrkx2H2Ktl9tx2RaAlvPVEPYJ+jHkTSWWhO3UBD?= =?us-ascii?Q?O3lvcGlpcwFm7lBm56cbh4OSq3YUTR3bVcrHEmaF51/hJDbaqyZA0C3rDWys?= =?us-ascii?Q?gHxq4ildn4k498NGv/VYcao+rYC+d97IrHpvIru+qXFgOEytxG9ft78by8W5?= =?us-ascii?Q?z4ti6D41eAE751Ue3vfe/QrKAjUeK4rrjpHya2XfBWXxQHVLq4/Ifq055jbp?= =?us-ascii?Q?5F8uHxKEK4UkniLYvI7tIbbHMKwFsOg63Q8pYZvntuoIeIGceFNL9Rcoz3Rm?= =?us-ascii?Q?3UYCrildFnZv70qjIIpve1MXqm8G54F27677H+qRBRwrMBA6lEvJNokJv0/m?= =?us-ascii?Q?Bb7Sww15O7+iCJKWtCsyFqWvBzFTOPrgsNZmFJcKzMKv+TsyVLzwz2URVLyL?= =?us-ascii?Q?gU/aj0A53Zx+UVWFvdpCnYKT46q2y4eOTPDD7A8DAzTNpPepEKd5viBKoztc?= =?us-ascii?Q?T/9ZxuE4tWUOMyzDET6oVOzYke3w8h6ZG4eTMBoLODjB2EWi9NHoGVvrQtM8?= =?us-ascii?Q?JaO8Buv3pQ5pFoE3S8W7uOLMYBUV8bUPCDTgYrnw/lSXVTEO1Inlr7U6GFbO?= =?us-ascii?Q?GBOxl6sDkcuEqXVlkmjrdsyCEJlijsUaOQcvvFN11DfGUO26sQmnqoLsCYuR?= =?us-ascii?Q?fQYiMBYWmpWgy2FufZ0GC1kmVOeIg9YAtvCHSvnPrp4CCOaClgIFPhOyY99p?= =?us-ascii?Q?C5Q3+qIdxN/K9dSMt3W3Sz+KIGoJDWD7k83tlSIrcMfHYyyYmCkxANkoEgx9?= =?us-ascii?Q?DRWSux8EBDApoIYsIEK47WAlGnXPvLJJD0D4nuUV?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3723.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38d13b5c-035a-4b93-8163-08db1548a2b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2023 02:49:51.4130 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JPHpjjde4jAr0ZEiRBN0THrFr133Axx1pdeZQ8fUGVCtRVFj4sgHupHsbD2J2oZQEzifwQAMU4JKoZ7Ti04zdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8255 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thanks! > -----Original Message----- > From: Levend Sayar > Sent: Wednesday, February 22, 2023 00:44 > To: Ferruh Yigit > Cc: Guo, Junfeng ; dev@dpdk.org > Subject: Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats >=20 > Thanks Ferruh for the review. >=20 > > On 21 Feb 2023, at 18:58, Ferruh Yigit wrote: > > > > On 2/21/2023 2:18 PM, Levend Sayar wrote: > >> Google Virtual NIC rx/tx queue stats are added as extended stats. > >> > >> Signed-off-by: Levend Sayar > > > > Reviewed-by: Ferruh Yigit > > Acked-by: Junfeng Guo > > <...> > > > >> @@ -20,6 +20,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) > >> if (nb_alloc <=3D rxq->nb_avail) { > >> diag =3D rte_pktmbuf_alloc_bulk(rxq->mpool, &rxq- > >sw_ring[idx], nb_alloc); > >> if (diag < 0) { > >> + rxq->stats.no_mbufs_bulk++; > > > > It is not common to record bulk alloc failures, but as 'no_mbufs' > > already recorded conventionally, I guess it is OK to keep this extra > > stat if it is helpful. > >