From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0EA7A0C47; Tue, 10 Aug 2021 06:35:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C0BB4068E; Tue, 10 Aug 2021 06:35:21 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 7056940683 for ; Tue, 10 Aug 2021 06:35:20 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="278581216" X-IronPort-AV: E=Sophos;i="5.84,309,1620716400"; d="scan'208";a="278581216" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2021 21:35:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,309,1620716400"; d="scan'208";a="671536270" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 09 Aug 2021 21:35:19 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 9 Aug 2021 21:35:18 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 9 Aug 2021 21:35:18 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 9 Aug 2021 21:35:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fKGp3rnmufB30Y2SG7pid0inuEcG84mkCLtbXDHyZ6lSSdJ1cLA2ljnRXS6E2ulEjztgSxiWDBynecag4FKnzvX6pd5cvECSZSsRNCDMr8jU+LzwGxqkU1aMTJvgoUgJjv0R/3fpEuaSC3w7APPuo0gK2d4tKZzj/gUK4B5CvddOrJFLmkHI458AEGdoJlXDi40KKxdLla1iMmYQJh0tCSiaj4qO9dXnpd1ZhIbG6LwBiHZ5dRmsyrYvRwjgfSjaFAPWzj9aU8UjOnrcnG1AfOzNg6eT94P/R4Z7coP+tNlvmPF3Qk7lKGXxq0wVLGssbBE1eWuLvuCVAniIf1MWMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m+l+PsLxvH10eAWZ4V5Dco552sTiP2afi5o7cbPXTJM=; b=BgPJCs4AIM2aTd6TKRp0PsvT+1CNFbQzYIsgZZlbDwX0eNT0vql7OIUqKYicGSohoPRJOnHAid1N9NFpPFiS1sFWNjLbPETFPiEw49ENN4dKuhXgI0mzFYQe+iogk2RKODJn2Hwk64CMQ4h5lYohRVrZigRq+CuQcO7OR1Y6SLJDF7TEhprkqJ58aL9zuNtskqkZYzJB/CmLXo+W9CimuI7ZvOH3lszy49H3jyCBHI7l6WGdvtfnuqRms+Qx/COiM7ervKoYqmnWd0BNKdu9qS6puvK3iMZDcmUnvlJtHC+kylUZGlF9r0dPEkb3kRSH05tY0rjNtKRSDSDreJN+xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m+l+PsLxvH10eAWZ4V5Dco552sTiP2afi5o7cbPXTJM=; b=owTgMTTnte89dCnPw7jnk4Buv6Jy4H9ww2UISnjP7ww/EASeFO82odYn81q41RVEbV+VaGNzKAFrJNrsq9VuHkypnWW/5nUkuPtk97aG95Niw8KhSFduxMPqxUBSPj+QklCUD1JQQb9oyxmpVm1KM3UCZWbX27BzgKR6TIc831I= Received: from DM6PR11MB3723.namprd11.prod.outlook.com (2603:10b6:5:13f::25) by DM5PR1101MB2074.namprd11.prod.outlook.com (2603:10b6:4:50::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17; Tue, 10 Aug 2021 04:35:16 +0000 Received: from DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::1c0c:7480:b096:196d]) by DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::1c0c:7480:b096:196d%5]) with mapi id 15.20.4394.023; Tue, 10 Aug 2021 04:35:16 +0000 From: "Guo, Junfeng" To: "Zhang, Qi Z" , "Yang, Qiming" CC: "dev@dpdk.org" , "Swiatkowski, Michal" Thread-Topic: [PATCH 04/28] net/ice/base: change dummy packets with VLAN Thread-Index: AQHXjZJAs1lykjQEK0at5imgpvpsB6tsJujg Date: Tue, 10 Aug 2021 04:35:16 +0000 Message-ID: References: <20210810025140.1698163-1-qi.z.zhang@intel.com> <20210810025140.1698163-5-qi.z.zhang@intel.com> In-Reply-To: <20210810025140.1698163-5-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0931271-6fc1-4c6a-d1cd-08d95bb84090 x-ms-traffictypediagnostic: DM5PR1101MB2074: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: whRMFEfo9nFu/je+JHu4SvLSUZlxur2I8qQ5FQiz3FsIigcAsA3I2PSYXhe6HeWnZf/Vslod7StXUmI/06u+/iwPZIBc+i1i/Ea8IT7TvDzZeZjq3IEg98sl/6Qjd3skg/ZysLOo1A3HIw4SXXynflsD2vPs3ir3Id6nxQyVxGed+V9VPBj/zz6twRc94UgmaF3E9WxE3lhGp2dpH0efpNZcTvgAnuHACIk4IfXdwZecvSVb1tJtaHsHLeLL2IbSxwzi52aUhldqt2YLrzcaXE1AgRlXsTbns8X15SUYJC4WNyd5AWP/F1thkEJuvLgCoU88SwDPZ8ilWPVK9nN6gvuHwQJa4Ev9+uFylnSZxA9t7fY/ZCqjLBaKQsahTyk+QIGEKtkFimeIXAohCjjpcW7/8CLSJ8mfwk1nSDcgcX0AyORjvLiCC82Skte8UqL8iaFoeG5zn/IEsdq3kehKjYpHJVJuoEg3YFTn/wnUUJOetuTkFHglAjlIkTxEDca4B8KKR0JiDPsd4abtd/DPFcYSnO3+RofI5rMJRIuNjvMH9KXkc7EEStfX8NTxEPKkSv4uKEvZhB1GuzTko/UbiJw+P3wB3QBl49GuBWU0eUvnbOcGvqATq1nBCcAQwKS6XBD2dd1ujyErLGca6wHltUWPyxL1WPR2yanuhbYuKaCbb4gQLHMxpNaHIvlYOmaeFXywKJKWKIUlWOX021sfJA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3723.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(396003)(39860400002)(366004)(136003)(26005)(76116006)(66446008)(64756008)(66556008)(66476007)(186003)(33656002)(38070700005)(5660300002)(66946007)(54906003)(83380400001)(110136005)(107886003)(4326008)(7696005)(316002)(2906002)(8936002)(38100700002)(6636002)(6506007)(55016002)(9686003)(52536014)(8676002)(86362001)(478600001)(71200400001)(53546011)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sDQBcX52dy01ZDrrcw1s1uJXz/SuYpZhWL7celC+fpL05+/7TyBCI8qNbBNt?= =?us-ascii?Q?F72H17+GOMuzLW3xg7LrahKylNMiHzEldAgZ4kiuFQZKx4OXwyj0vhDnFPAz?= =?us-ascii?Q?gfr+NPoyMtexzeiounIEPhh7cgV0qoaY3H5665s53fT5aaTTTJs3R1cNk3ee?= =?us-ascii?Q?DghCuKJwfQhp9AjH8N3SbhoxOKK9Yal8z4T4ePvBBYh3Er/qTD0AQltmfWkv?= =?us-ascii?Q?cChNEJ0+VnU+wEzST80W0j2W37ec8rvYNjqqk8JiFarVotd1KEc8Rd7Zx8jy?= =?us-ascii?Q?EXbsGrVMRl58chqvPKo/ReOZQAC2I2gBs+8UBZ2gpKXbz8mGwlM0U1KQMWi3?= =?us-ascii?Q?brIVqn3C0CcxitPTaOQcEBB0FRjqPqYZotwFKkJwSAwYLAK/6HfrnQVEMESY?= =?us-ascii?Q?cUrGuOD9uerzlBOWMSfUgPj2J6LAyrHyypaVcG0JdZm4MT59xdPYFNfeYFR3?= =?us-ascii?Q?+DU7LBMxcoiwtczT+r3Mt+X0czGdt/ACDbi/fT3oxvz412ctu6wfh2XXZmFj?= =?us-ascii?Q?noTrBE4a3YYnq1yzxidhvGYwjq6UMefjcX6f3xtM+2H1jLgyVi5N4cQozuzu?= =?us-ascii?Q?b4uaW3F2HIGW1J9gPWQZDTG5GCMmJfX+U6hvVvx6LE2LJgXTK20kvrPQxVEk?= =?us-ascii?Q?za9cZx6UkRp6VIv9yyGjepQfYHs79ZWJ2+gWuQbm3fxRKhKeRVHVo+HR+8zA?= =?us-ascii?Q?4byfhF9hTikG/FXiwcI4BgRRAAquzLNEMYxyYFqt/vF9UQjx+u9G3JXXj5xA?= =?us-ascii?Q?hNGHYUYrW8EXrMhJzRvHJcei9ckfywSs0bawKBWoIgAotDa4i3OfY+Z08snP?= =?us-ascii?Q?nu0WqK4eu2ysROH8N/YeRDIWnrkqez7gkrZcAIhDVNlti/+946XPvcRxZ3kf?= =?us-ascii?Q?GRAIdYg8TWQxwPNT1vHRcV4vGTP0aOBQ0Dx/fuZQMXzp2z4yoPNk65alDwaN?= =?us-ascii?Q?8Xb4ef+XlRuBDEu1qh9YtD/QiIixAM3UHTJvGwTSbBYFgTzVrRU8TIt3ifmp?= =?us-ascii?Q?11z8eO0OW1uMaa8xu3v7ia3lMz0QzraQ6g8vP1Lp7+4gH6iSRNM4CjlTwaGT?= =?us-ascii?Q?tMcwMsUJUguAZnevHdyYJyIfIfFT9bmUkajwP/rMcG2uQf55sVTLmyAIVXTz?= =?us-ascii?Q?t8Qm3IZtw5sj14fuyYz2xazzi1l0MwgrfmIQJ+j8Nf2yqecn4lYTyx+sywCb?= =?us-ascii?Q?i7tQshPMv4wxUtDT1rlQ7J3qmzCDv82up4VG6+WfNrY4mIbd/VM8E0aQc6hh?= =?us-ascii?Q?j8+77FFVv4qIa9W1TztPrSoYYS/jb7RHN8vnVuX/VC6nyU/ixtp4RimPOcSY?= =?us-ascii?Q?fqzwQRzaRBF6p97ljt23/EGK?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3723.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0931271-6fc1-4c6a-d1cd-08d95bb84090 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2021 04:35:16.4059 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dquDsNePpNrKzSemz+i66c24fiR1/6E5aK5+zTtIIu4uzgpwFHv+c5ugoW2T9xoNe53pomoQjwIZu2ehF0cE6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2074 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 04/28] net/ice/base: change dummy packets with VLAN X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Tuesday, August 10, 2021 10:51 > To: Yang, Qiming > Cc: Guo, Junfeng ; dev@dpdk.org; Zhang, Qi Z > ; Swiatkowski, Michal > > Subject: [PATCH 04/28] net/ice/base: change dummy packets with VLAN >=20 > Ethertype was traded as VLAN tpid in dummy packets with VLAN. > This led to a problem when user wanted to add filter for VLAN and > ethertype. >=20 > Change ice_vlan_hdr to reflect correct order of VLAN fields in > packets (VLAN tpid, VLAN id). Correct all dummy packets with VLAN. > Move VLAN fields before ethertype and change offsets. Leave values > from dummy packets unchanged as they fit to new VLAN layout. >=20 > Order of offsets in ice_prot_ext_tbl_entry for VLAN protocol should > reflect order of fields in ice_vlan_hdr. However, hardware doesn't > support matching on all tpid. This should be done by matching on > packet flags. There is no FV word with protocol for VLAN and offset > 2. Because of that, adding vlan tpid with not zero mask will lead > to error in creating recipe. >=20 > Signed-off-by: Michal Swiatkowski > Signed-off-by: Qi Zhang > --- > drivers/net/ice/base/ice_protocol_type.h | 2 +- > drivers/net/ice/base/ice_switch.c | 148 +++++++++++------------ > 2 files changed, 73 insertions(+), 77 deletions(-) >=20 > -- > 2.26.2 Acked-by: Junfeng Guo Regards, Junfeng Guo