From: "Guo, Junfeng" <junfeng.guo@intel.com>
To: Rushil Gupta <rushilg@google.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Joshua Washington <joshwash@google.com>
Subject: RE: [PATCH] net/gve: Refill all descriptors that were consumed
Date: Fri, 15 Sep 2023 02:28:04 +0000 [thread overview]
Message-ID: <DM6PR11MB3723E6B73F20274A2DE5DE0DE7F6A@DM6PR11MB3723.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230914205213.564562-1-rushilg@google.com>
Acked-by: Junfeng Guo <junfeng.guo@intel.com>
Regards,
Junfeng
> -----Original Message-----
> From: Rushil Gupta <rushilg@google.com>
> Sent: Friday, September 15, 2023 04:52
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; ferruh.yigit@amd.com
> Cc: Guo, Junfeng <junfeng.guo@intel.com>; dev@dpdk.org; Rushil Gupta
> <rushilg@google.com>; Joshua Washington <joshwash@google.com>
> Subject: [PATCH] net/gve: Refill all descriptors that were consumed
>
> Refill all consumed descriptors instead of refilling a set amount of
> descriptors everytime. Also, lower the rx-free-thresh to refill more
> aggressively. This yields in fewer packet drops for DQO queue format.
>
> Signed-off-by: Rushil Gupta <rushilg@google.com>
> Reviewed-by: Joshua Washington <joshwash@google.com>
> ---
> drivers/net/gve/gve_ethdev.h | 2 +-
> drivers/net/gve/gve_rx_dqo.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/gve/gve_ethdev.h b/drivers/net/gve/gve_ethdev.h
> index c9bcfa553c..fe7095ed76 100644
> --- a/drivers/net/gve/gve_ethdev.h
> +++ b/drivers/net/gve/gve_ethdev.h
> @@ -27,7 +27,7 @@
> #define PCI_MSIX_FLAGS 2 /* Message Control */
> #define PCI_MSIX_FLAGS_QSIZE 0x07FF /* Table size */
>
> -#define GVE_DEFAULT_RX_FREE_THRESH 512
> +#define GVE_DEFAULT_RX_FREE_THRESH 64
> #define GVE_DEFAULT_TX_FREE_THRESH 32
> #define GVE_DEFAULT_TX_RS_THRESH 32
> #define GVE_TX_MAX_FREE_SZ 512
> diff --git a/drivers/net/gve/gve_rx_dqo.c b/drivers/net/gve/gve_rx_dqo.c
> index 236aefd2a8..7e7ddac48e 100644
> --- a/drivers/net/gve/gve_rx_dqo.c
> +++ b/drivers/net/gve/gve_rx_dqo.c
> @@ -12,8 +12,8 @@ gve_rx_refill_dqo(struct gve_rx_queue *rxq)
> {
> volatile struct gve_rx_desc_dqo *rx_buf_ring;
> volatile struct gve_rx_desc_dqo *rx_buf_desc;
> - struct rte_mbuf *nmb[rxq->free_thresh];
> - uint16_t nb_refill = rxq->free_thresh;
> + struct rte_mbuf *nmb[rxq->nb_rx_hold];
> + uint16_t nb_refill = rxq->nb_rx_hold;
> uint16_t nb_desc = rxq->nb_rx_desc;
> uint16_t next_avail = rxq->bufq_tail;
> struct rte_eth_dev *dev;
> --
> 2.42.0.459.ge4e396fd5e-goog
next prev parent reply other threads:[~2023-09-15 2:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 20:52 Rushil Gupta
2023-09-15 2:28 ` Guo, Junfeng [this message]
2023-09-21 16:37 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB3723E6B73F20274A2DE5DE0DE7F6A@DM6PR11MB3723.namprd11.prod.outlook.com \
--to=junfeng.guo@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=joshwash@google.com \
--cc=qi.z.zhang@intel.com \
--cc=rushilg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).