From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B07CEA0542;
	Sun,  9 Oct 2022 11:14:23 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A310341141;
	Sun,  9 Oct 2022 11:14:23 +0200 (CEST)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by mails.dpdk.org (Postfix) with ESMTP id 107F740042
 for <dev@dpdk.org>; Sun,  9 Oct 2022 11:14:21 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
 t=1665306862; x=1696842862;
 h=from:to:cc:subject:date:message-id:references:
 in-reply-to:content-transfer-encoding:mime-version;
 bh=8JPRgRQnEJ0F4QIA5tRffVrJLaRKp2kW/ilze82cAf0=;
 b=IKNZC35xANJwMdTpG1IeJKdMek+2SWJ9Vx1vzxVA8xNNrNkfI/WhKuH1
 p6eSR+yNotk3dYm3ctA0SPVZnSx6L3dXWBV1afDzaIa5TDCZCwyxUb+gO
 e7n9w78Q1JleuzaDfTZbmTDwRZ0vYTNFsrJ822rDNIJq5L/+w1XioOoGV
 AXmMAMNs9NuNaDvSs0Nw/ItMaehQqkbqUrY0xWKpPZSYOYWfk2qWJDR4W
 J+c6VgLH4CpABGRAZGP8VNjGIgCNovuPHu+bYZiwF5XGBTqkJY5ZRH3px
 073RUkCZR2PSy9qyFeS1DNMH5W1es/vilx9Esth8wgHeNyrHIaWbiBq7H Q==;
X-IronPort-AV: E=McAfee;i="6500,9779,10494"; a="283766454"
X-IronPort-AV: E=Sophos;i="5.95,171,1661842800"; d="scan'208";a="283766454"
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
 by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 09 Oct 2022 02:14:21 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6500,9779,10494"; a="627954566"
X-IronPort-AV: E=Sophos;i="5.95,171,1661842800"; d="scan'208";a="627954566"
Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14])
 by fmsmga007.fm.intel.com with ESMTP; 09 Oct 2022 02:14:20 -0700
Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by
 ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.31; Sun, 9 Oct 2022 02:14:20 -0700
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
 orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.31 via Frontend Transport; Sun, 9 Oct 2022 02:14:20 -0700
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169)
 by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2375.31; Sun, 9 Oct 2022 02:14:20 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Pp1pdhXvK6ISRCECH2gm0ZxZgWVjuzKlXjZ0tE5JDhzk8UpoAQGgeekgm8GCaQF0emGI9uZ0r8ZDupRYMw2ilCFBJpsHUNHNXyMYcgx1Va2T4W2F0Ut7nG7ps2KUZJ/fHrvuYVMMvInbN1t+4IwDIATIn8FuF6Fvpg9B3qtFak9o+y62veK5R5iNpBfyQgQpe8tjMwf1El0wBDHB+mVMwAE3h+OKRNfSjmcgGhbmVH/KJDgy/9C+doEhygtz9OVBpGUUbasuCTZxNCdIUDFoE/IzZ8ujWK+j5vEMcuyTwT8QaQH+JuOnCcfzHLzGy0FjKHKK1VINNnyVHh/RfdZXug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=osXsqUh0wt12ZlHfYO1la1btTM6gKbfi9jQLc/LTWWs=;
 b=lxJisocNlUeBDbPzV2J2CT/6UraMpOvCjohzom8BuxmKGCB+JBw4bw8K1I99lr/qavvvMy/vTVmRoSEM5b2R0Dl3TYo5CzbC8T756UzXV13ntoTBt4zZTKx9kQPm441wKLskxCOGzeiJ0YEwz2QzCvgBv3E/fXg6+/jbs3hQRbQsYxuFLSXNdfBlPoFrkjRxLPlHfCnldedjLbu7Vwq/65gZ2RGn3jyYiwMBLCIkS9Udm9bfdUSPq/teQXaqM8ro+OEuDJhwckWLdzrZdiKEQdbBg2896weY8lONKMHNYhhrjEylMgyoTaRl8yeP7mG2sm2h7ky/+Vrc/RVq1AVb6Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
Received: from DM6PR11MB3723.namprd11.prod.outlook.com (2603:10b6:5:13f::25)
 by MW3PR11MB4652.namprd11.prod.outlook.com (2603:10b6:303:5a::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Sun, 9 Oct
 2022 09:14:19 +0000
Received: from DM6PR11MB3723.namprd11.prod.outlook.com
 ([fe80::126d:f905:c1d6:dcb9]) by DM6PR11MB3723.namprd11.prod.outlook.com
 ([fe80::126d:f905:c1d6:dcb9%5]) with mapi id 15.20.5676.032; Sun, 9 Oct 2022
 09:14:18 +0000
From: "Guo, Junfeng" <junfeng.guo@intel.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, 
 "Wu, Jingjing" <jingjing.wu@intel.com>
CC: "ferruh.yigit@xilinx.com" <ferruh.yigit@xilinx.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "Li, Xiaoyun" <xiaoyun.li@intel.com>, "awogbemila@google.com"
 <awogbemila@google.com>, "Richardson, Bruce" <bruce.richardson@intel.com>,
 "Lin, Xueqin" <xueqin.lin@intel.com>, "Wang, Haiyue" <haiyue.wang@intel.com>
Subject: RE: [PATCH v4 2/9] net/gve/base: add logs and OS specific
 implementation
Thread-Topic: [PATCH v4 2/9] net/gve/base: add logs and OS specific
 implementation
Thread-Index: AQHY0kOAop+2U91Q0U+YXiYPXH35w64BeQoAgAQqrLA=
Date: Sun, 9 Oct 2022 09:14:18 +0000
Message-ID: <DM6PR11MB3723EB32F7CE5FB48829AAABE7219@DM6PR11MB3723.namprd11.prod.outlook.com>
References: <20220923093829.3019525-2-junfeng.guo@intel.com>
 <20220927073255.1803892-1-junfeng.guo@intel.com>
 <20220927073255.1803892-3-junfeng.guo@intel.com>
 <8acea1a5-1a48-4a27-1384-e09f4da63c4c@amd.com>
In-Reply-To: <8acea1a5-1a48-4a27-1384-e09f4da63c4c@amd.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM6PR11MB3723:EE_|MW3PR11MB4652:EE_
x-ms-office365-filtering-correlation-id: c8f1f13b-a85e-4e8c-e50c-08daa9d6a559
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: b3AhooRCq6JuBETMnVUgX6ZsVVRHgs68A3S3XEwQ5GhCbTNuST2lE1qFlQOLeZzGFKpxc2+xfd2hvWtR2OEMy7jqPoPBKN+IXurAjXKZNU36104aB+9Jy6L1ZyfQxYp2xIx1k9nCFGE+voGdrI45vK+B8dgDggXrViumqRvrtuy2HIQWlX1QiSUtiZDbS7xeenblQ1r7ArVwd7UlV4oXgJQqRUKfUEBJBq73KWiXAhL1rfGcLzzYLTgnOHfeGhpp2GcNCrjYHB4ca+5v8RcciVc6QMWjWSzUNXYBidvOhnE9tz3SvxW8X/AwTUeTvTBK97F19OLc428ojM2eJZ2AjKgIr8Fhm94I5iYGYLOb28gxt2WIiKvbv74VDtACbQf2gPU8tGugC0O8+AodJ4Pu4+2u8wn7/+DEHOouZCtwOL3ilefrr/yLGap1JgK8GjvyWrLq2+4TEISKIpT5MPeHuDDQw8Dpg9NuSd39GiWb2iC+ChgBZVYKhkXRnZkCanC3G5Vap1wMyzkIAU2kQjwy5w14F8N9WqsiRR9CyQFFopamEKjGh5dEIzicvaBtciucRYu7SyCYJZT2lOFuLbxEidob4bef4uuo1v0H72Bm7vnfUnF4XfpQiTNYyje/PoLnvRYEwa2HuqwqanFsBbcUf13YvQliXW1L6UKVkMYpHD+MYghw/mbLExZyvo1Su6CU5ILNcxVOZfkRKUkzqhsuOC1HV7q8iLP8Alwux7bjg++JdbXXizV5NZoUwdB8rNmWRNRwV4ZHxhEOsO6OA3p3+g==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:DM6PR11MB3723.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230022)(396003)(39860400002)(346002)(376002)(366004)(136003)(451199015)(53546011)(6506007)(9686003)(26005)(478600001)(7696005)(107886003)(83380400001)(186003)(5660300002)(2906002)(55016003)(316002)(110136005)(54906003)(6636002)(71200400001)(8676002)(8936002)(41300700001)(52536014)(4326008)(66946007)(66476007)(76116006)(66556008)(64756008)(66446008)(38070700005)(86362001)(33656002)(122000001)(38100700002)(82960400001);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Jrr4/9IfL+f1Fhs8Ecy3AD5ITQkdpqHiKP3hasZgjEBwhYf/+K2X2BDFi7md?=
 =?us-ascii?Q?z0tLDbtkKOt0U3QQ8yBfCm4qC4UaRPF6AEwiWZFkdCa4Tyoj1qBS0QEjswmd?=
 =?us-ascii?Q?CMf0TkOvg/fPdy4os0AgS0S82lfbD9IXnS+b2X4Iz8QgYhkdPf7Ee6FbteMU?=
 =?us-ascii?Q?OiTWSd1s1dql647IG1wMQrQj1RaOzfXKJk4LyqYoENMG1YhX8Gvd7HDxwFoH?=
 =?us-ascii?Q?WNqfGRb23akGhsBQ9fIl/nTZmAaML+0oL2kcnPMeMVpxqCfhJ70meFQJ1jHE?=
 =?us-ascii?Q?v4XYTPPwMPgJSDt73CacQIsSeG0o8+Q6EWfch9etCowZEAaAgHavheYf2v2Q?=
 =?us-ascii?Q?7Laki/eyzb1zDw3oBoXoG5B2nlzul7rCRoBbC/z+oXnJw4a9uiU6exMqCStT?=
 =?us-ascii?Q?1t1GoJ87G0VcgZpbQl38fSfmSyGTr6mUAflNDSKKRnmGqrAa7JNSfN0Xye4v?=
 =?us-ascii?Q?yqHTnjRrufFf3wJFtDZ4ydRPmH/RAsor/ls2cFwEz5g5aQ78HfPzq5fDGkoJ?=
 =?us-ascii?Q?gb2dSe2gTyOapIyDAiQoDwHhqml204ZR3dwHnK6c2yyFDIq60sQ4nS98eNsK?=
 =?us-ascii?Q?sTqd/8ceqZArAcuNKgzKLF2+cHKN/AyqT+1t1cOPTC4wEITvWj35bvERvB5S?=
 =?us-ascii?Q?9b0cNANqm0oeytjebzfo0w1x+fZUtjctptGRgBXNe2e5DxalBmDao9bxkMG+?=
 =?us-ascii?Q?HpgxD7vqu4ztiEGF9970bfD+YtffhIruE7m8GXts/MeLJI+UaHETAZzvQ2gH?=
 =?us-ascii?Q?+smh6y4KUKAMY6wkvgY/SrAKbBSl+KOZamfUQTBgLn1FXwkv1Nje49lQd7fs?=
 =?us-ascii?Q?PJgyQ2s42s/f391gQmWqCrfLBmn/DFik9x55wNcPmNIfnpWjCcBJbjhc5SB+?=
 =?us-ascii?Q?sxJRX4vGhYpR2v0sl+MBAHXT6OMAHbySXlAgMkUToT1vSJMAqCJb6DZ5GmY2?=
 =?us-ascii?Q?rwY3eu+4vII2sSVZ+jLA37J/nyVze0BdJQliqjCvXQRea9mUN5b3T9o8vI2Y?=
 =?us-ascii?Q?Ro5JsUaqEd1pQ3qzEhBt7Y9McbVn9CtOKYsca5wIOJMz+qTsj/pirZKII/OR?=
 =?us-ascii?Q?fUntM6q2ImiOAlKjbjUp1THoxTnUXj887Ult9zd5Kq009AwCdX9Tcstdg6LB?=
 =?us-ascii?Q?NuGIiuTlJOGPLLMQR/N45KSlrNd2lMxhEJSXsdfejYvxAa0TOgrt6hdYW8My?=
 =?us-ascii?Q?GKYV5vMvKcaQjAL3NzF4xVNpguQ5SaQ6YJsCkJqyvZEQJwUnMAWPXmrLt93f?=
 =?us-ascii?Q?Cb13q26W6CaEFxdgfZkCaXOPz3G7XpYlJ3gamnS2FSUMckiTBIZWXj5YL7qd?=
 =?us-ascii?Q?iPRFQulwQh/FVodZDCdvEP7Rf5ZiVgjgcm+FKxqJTSaEm/3sUutLCJehXFLx?=
 =?us-ascii?Q?Bi5BJfVbbmZUjJfAhPVlDQhk+r/qDv3H9zMIbKufmBwxVoqEgHnOejNFQpJQ?=
 =?us-ascii?Q?o0VvV3n9MQ6j7U+h9KiNlSWg7Fz7tG1Z3DDBII8rLqplfP+06MvfEZft2SHZ?=
 =?us-ascii?Q?nMapdJENPtBV85lntkyJEJGzbUsndpcKnTPYknV3q15HHsGYK5wXCCFib6/g?=
 =?us-ascii?Q?15MQORfqJlZvW+ccrGDIdOD4b4Jq2TCFNKaqCBi0?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3723.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c8f1f13b-a85e-4e8c-e50c-08daa9d6a559
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2022 09:14:18.8105 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9xsK6kdxBM5YHh1ew5VU9Dc9LO+/HXxhuwbIEDD/3vXYnxpXWNaifD1Olja/Ol/khp0JBpoh9v9Hphbrsf9Q1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4652
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org



> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Thursday, October 6, 2022 22:20
> To: Guo, Junfeng <junfeng.guo@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: ferruh.yigit@xilinx.com; dev@dpdk.org; Li, Xiaoyun
> <xiaoyun.li@intel.com>; awogbemila@google.com; Richardson, Bruce
> <bruce.richardson@intel.com>; Lin, Xueqin <xueqin.lin@intel.com>;
> Wang, Haiyue <haiyue.wang@intel.com>
> Subject: Re: [PATCH v4 2/9] net/gve/base: add logs and OS specific
> implementation
>=20
> On 9/27/2022 8:32 AM, Junfeng Guo wrote:
>=20
> >
> > Add GVE PMD logs.
> > Add some MACRO definitions and memory operations which are specific
> > for DPDK.
> >
> > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
>=20
> <...>
>=20
> > --- /dev/null
> > +++ b/drivers/net/gve/gve_logs.h
> > @@ -0,0 +1,14 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause
> > + * Copyright(C) 2022 Intel Corporation
> > + */
> > +
> > +#ifndef _GVE_LOGS_H_
> > +#define _GVE_LOGS_H_
> > +
> > +extern int gve_logtype_driver;
> > +
> > +#define PMD_DRV_LOG(level, fmt, args...) \
> > +       rte_log(RTE_LOG_ ## level, gve_logtype_driver, "%s(): " fmt "\n=
", \
> > +               __func__, ## args)
> > +
>=20
> What do you think to move 'gve_logs.h' to next patch, since this is
> extern 'gve_logtype_driver' which is not added yet.
> Although files are not compiled yet, logically I think it suits better
> to next patch.

Sure, make sense. Thanks!