From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66DD4A0032; Wed, 11 May 2022 14:35:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13BD140DDD; Wed, 11 May 2022 14:35:16 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 3FA38406B4 for ; Wed, 11 May 2022 14:35:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652272514; x=1683808514; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZrHix8F9tjX+HJjy+cSbpLGdwnecVN86LRBvgLK7+xA=; b=NewpZ0UTCYfrBRsMSyo3UiK/o1T4el9P1OcCOaWbCkPHciqz8gwQUe35 uR+1dnyPJeKYmjUC3F4MdNCKm9ErinqqgNKQxXaHnPTwuBUjXexnD8LQa TcNJhWjvRPmoYl8vZ4xjKi/juh5A4t2J3hBavALqHPPioFiQtkyI/D4yh Hli8ybgWQxXhxz4QeZiBzZM2GqOzp12OaE5GNZR0Bd9HU3/mDsrUKxinH /xCukKk7+fFa9bW+ru/ca42Zi81ybJnNkOlMw79fR7UYMbZtPkIfpSlAn 7VerCxNJEFx7DJHmw7eB06Hx3GeVAxQqa8bEz0YQN3ixeXK9tJRGZqbhn w==; X-IronPort-AV: E=McAfee;i="6400,9594,10343"; a="332719966" X-IronPort-AV: E=Sophos;i="5.91,217,1647327600"; d="scan'208";a="332719966" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 05:35:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,217,1647327600"; d="scan'208";a="697557164" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 11 May 2022 05:35:12 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 05:35:12 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 05:35:12 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 11 May 2022 05:35:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fHEdq22o4GG9JSprrYxvLC+9W9bszuYCpC2L4tnNqsS+tsh/MB7Gni8Xy7SbVB73QlLUMfoOAnPuUmfcTWmR836xn8sdN3JMbh63qyItvOgZqCIuxWnzJyxZyYVoniX/kyueBbN+UuR7/pX+K2bV9Nrzeb8tl4HCIg7e5oTY8laNfRghkus5Y6zmMf4bfwU5jggeDTISA6enj5traCP0Dno7/KybbAAXan/RSKjySbHKl9wDW7FE8JSAV9bgG9N8o6xetw7bd40GZjN+RYG0w5fUYC/CvviqqgOzfgaotNEwtr88GNxd+S8WcDhuwC38UjfW5Zop5UlG9Ggyf6+ceQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QiPsDNoJTUD90+tiBOwpDAfH5seoqGKE4tEwZhnV1hg=; b=YYYnS+fOS2HoWCN5saxbpR9f+zYj6MukVobRO4LvwbMyL3Tc4+nag3/+9KssaOtgcnaB8iXOgS+xkBJGzng/II1JdOOXf0I9Giv/A++L2ZERlYb1SCo+t3saXYvZVd94haHFc9B/6+wJc52vBQzLJy+aBlGl9i2qXH3Pf0L23iOe3926bYhHRXz+kvBmTaL/sSBrT6wMPXH12sK5Is9QiSi/zAei7Kwdua5aPXy43ydA+RceUjHNNNgd/E4AiY4hcSjiu+popX8HTcd5e7v9+mbMWqhLXI9y0Kjml+3/6IXcndfqn1CgWHsx+bSDxz1pCfxDR5HNwjpEC/2Po43QwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3819.namprd11.prod.outlook.com (2603:10b6:5:13f::31) by CY4PR11MB1254.namprd11.prod.outlook.com (2603:10b6:903:2c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 12:35:11 +0000 Received: from DM6PR11MB3819.namprd11.prod.outlook.com ([fe80::4838:60ae:b637:3fc0]) by DM6PR11MB3819.namprd11.prod.outlook.com ([fe80::4838:60ae:b637:3fc0%7]) with mapi id 15.20.5227.023; Wed, 11 May 2022 12:35:11 +0000 From: "Power, Ciara" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Zhang, Roy Fan" , "Ji, Kai" Subject: RE: [PATCH 1/3] crypto/ipsec_mb: add GCM sgl support to aesni_mb Thread-Topic: [PATCH 1/3] crypto/ipsec_mb: add GCM sgl support to aesni_mb Thread-Index: AQHYSmqd9o0sVTwtGE2SSulj8k0ktK0VPgqAgASTUjA= Date: Wed, 11 May 2022 12:35:10 +0000 Message-ID: References: <20220407103041.4037942-1-ciara.power@intel.com> <20220407103041.4037942-2-ciara.power@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9a827f5c-5d1b-4359-8507-08da334ab093 x-ms-traffictypediagnostic: CY4PR11MB1254:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0BX+YPfBsYJ8yWIsOu4x8Y/zKAojSV6bwoss3ex0N77TXBN+6YcI7FcqMdZZThdv+1c/bShrX1MJn7wJ5v6gJkJK7LJIslVlHpLGj2aE9PcOpr1wtYSZxFR2RJx9BM7D5oMvEgQb5kTOtIZNK0/U+Vp8IxgO2yY5NT679hxR3K8uEgSVELiJiphyBZNeiXA+2tZAu6f7aDGaTrezkvOZr/u6YacrVIVTIH2Uvw+yFR2N3TIgjm5GQ5lsQSWl65LBTisgZA+Ib1TG//VKhfgV5egOBs5MKlOmklLkL0QOFmLxl/69yraexyWMsAj1dSE9Po8dE98wXozlgq/D1LdCrVBKC1kkIelIkS5K444yfqAeJtoUDHIVAaG64jxVYcnhOvYy+pyLyfQ0bJqRoWs6RaX87GcpqjaHawJJWI4HcnvUviPSEHtxHRyIzcl6z85TMMOoREju09AReY8ISYNvpKF68ZVptKXjZdK0XeOOMeKEM7zPggjaytqIL9khYHjWvydHqJqdtczQ4fR3yW7sHu25dEEklJi9d50YmK19UDbgtfqbYmqlRhs8oqsF3PoLlIX3E7ZPAxEb4BtfhPcv8ixtOOP5R6XxJELmwPe+q3c4B4VgWmYmiyK5tzgiW5s84LLlqY7UvYEz7ZiER1Jo2duQI7+O4VsemIpJ/jl3iGw6DkImPCfYewzr1mw/2aghdEpEW+Q4FNRAD2ofkQT2uA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3819.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(55016003)(53546011)(6506007)(508600001)(66476007)(33656002)(71200400001)(52536014)(7696005)(82960400001)(86362001)(26005)(83380400001)(38070700005)(2906002)(66946007)(186003)(66446008)(76116006)(66556008)(38100700002)(316002)(8936002)(9686003)(54906003)(110136005)(8676002)(107886003)(5660300002)(4326008)(122000001)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Lyrp8G0f91RJGROsfIUZlVvcKG9+S0enjmwqpFWNXFKh8t9LjUacEPL86xa5?= =?us-ascii?Q?dAkTldFUS+dKCufZ0GRhcaeV3WEzDIDsZaBR8Q7rNHU9xqdqM7IkmeoM9VYN?= =?us-ascii?Q?kLS6n6PVOLYrCYVa00RHL35t59fnb6y+iQWTX0u7SmvnwAYSp/tIsUf2dncV?= =?us-ascii?Q?fLu9OaINDa/fh46AEkilcog7e1emDlXVzfl7K1DKTK1cSsgEMlGsrvdj7u5v?= =?us-ascii?Q?ij6t9lROHtLwYQ3LhaSvNc5HixLju/Sqd8eNuDXq7eMoZQ7ohqOlBQci1Pnz?= =?us-ascii?Q?hEJX+oe+UNoPV75HYETU8JqwyWS8Z0W086h8ZxWb3UNyGCF1JJsjg1SyL4F0?= =?us-ascii?Q?p61hb9DgvviDd+fLsvZhfjIRyMO+QAAmwixhFZsAQOeq+cQaXTnX1fWI/ZU1?= =?us-ascii?Q?uF8Wd7rHNmMxPJlHoZn/uMnqpUCFkdSmORxdOHei7o9SURBcGqW7yoTPNKvK?= =?us-ascii?Q?8Lqzostb5p6xM1S4xcmqwc/72SstyvvnWcPATYOQyaB3SQQFhYTRmAnS3o7+?= =?us-ascii?Q?qJyIrZd4j+vFxwL6iF+ULJjOPPHN9I3RUS9rhWqRHlvMOk1c2Pg9nk9fzOw5?= =?us-ascii?Q?R3xylgJyjIjKr9EaIUMFil1RnJfXiMab6idF0AIjZW+M+jmyuWYAL0h3N7aP?= =?us-ascii?Q?p3q4dB7KQTkqgWOa8Bk6wbqJo8Dqxm54pFGZ0yp8umfSJq7/RT8KkoOwZIqx?= =?us-ascii?Q?bS6MZRlAYUWEAULMwr8oImgqz8UHYXdA84nqkGdXA/zHQGlG2RD078K4w3LM?= =?us-ascii?Q?Bs6Mg0kVLCqe5Tg/Aeh7NJZxzKho9ELBCS3HFlELaXdHIf/+iWwkeB9pujsD?= =?us-ascii?Q?c8s7ypR5zwwNAmHe095Hf9dmj3VxWe3tpsE+FaxetH51tGp1rBD5oEEQ24LC?= =?us-ascii?Q?c7x5eSXqYfCUbf78q6wtF75CgL+KpTcRRpzT6EvwHqvW0dPexRLj6tgb0EX4?= =?us-ascii?Q?IPsfF5flWyhg6zBYRBCV0DIUJ+aHWRaRh+xPxB5LESCy+SXyf7V18+0pkZ1i?= =?us-ascii?Q?shxfjTQR6VqA8ir3tgN6KvXCwK6MHPhb8O5/7nMiH4zdyAK/LCaCBHO/Hzg8?= =?us-ascii?Q?QgZfXcHJpDucyh9W9v1oqW4WC5zeGjrtOAjKBLLH8PbdbebpcmPFjTKfd4M1?= =?us-ascii?Q?TP2ovCt1CGIFE3jMnPvvscB3uqTlVjoY3ruXFFyVrHKjQ5J35IKNtKzQ/WMc?= =?us-ascii?Q?YAoqxnJgjz/ogqokW5r/C6mDVuZYl98XN4MjAODWG1nVH1pcsqLT9r4cLi9h?= =?us-ascii?Q?AzyfZ5nyAqoh5ahSk+RJ9wLXPvIb1kP8hLT3yCRMT+jlhIkWteZa9tdkhtIj?= =?us-ascii?Q?0CE/b3z9/XtnNn+wTfdVy5oQUPZzYJ+5qSbM8NX7VP+dMnsQHXJVYjuxuf9T?= =?us-ascii?Q?hFhkb4RZqGcH4cttpoFy/FQmVfNIuLQRKLzWS9rbkST3ZLfgEBYR2/8RV260?= =?us-ascii?Q?btXNDYsWd7bnrGgEtLO50pCNu23tKKLcjEOU2izL6wB+bue167pzgxMMl0IT?= =?us-ascii?Q?3Ev2PNXzAwikWsINecXOZYCKF4oxNn+gaOOVMAj5fcH/kUDKIkeglThGfDLv?= =?us-ascii?Q?jZeXzp7fX+NjOtnA7PSJNhNrtlwC4cd25aN8Mq5yD5+Ph3opKYEdRvIuHTVP?= =?us-ascii?Q?/bhN7XCvLRAq0VHssWj2/E8rIEVWoHanjAIGgXGSLSO/hTXsV7yh5tahiH6y?= =?us-ascii?Q?z3tllT8MaFfhJBR1dg4ZkKhskwuIW0+oVwCYmdGd9f3/tq7Ix8yec1c/HabV?= =?us-ascii?Q?bD6yu4Mwwg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3819.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a827f5c-5d1b-4359-8507-08da334ab093 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2022 12:35:10.8932 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B2QIKDZHeSNE62faEXVtCybdlV+9bL00Fz3OZDlJfqYKSFRbRQhKKu62DAm5jQN+gYoJgBNBkP2/sw3NEIFemw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1254 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Pablo, > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Sunday 8 May 2022 15:40 > To: Power, Ciara ; dev@dpdk.org > Cc: Zhang, Roy Fan ; Ji, Kai > Subject: RE: [PATCH 1/3] crypto/ipsec_mb: add GCM sgl support to aesni_mb >=20 > Hi Ciara, >=20 >=20 > > -----Original Message----- > > From: Power, Ciara > > Sent: Thursday, April 7, 2022 11:31 AM > > To: dev@dpdk.org > > Cc: Zhang, Roy Fan ; Ji, Kai > > ; Power, Ciara ; De Lara > > Guarch, Pablo > > Subject: [PATCH 1/3] crypto/ipsec_mb: add GCM sgl support to aesni_mb > > > > Add SGL support for GCM algorithm through JOB API. > > > > This change supports IN-PLACE SGL, OOP SGL IN and LB OUT, and OOP SGL > > IN and SGL OUT. > > > > Feature flags are not added, as the PMD does not yet support SGL for > > all other algorithms. > > > > Signed-off-by: Ciara Power > > --- > > drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 144 > +++++++++++++++++++- > > drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 2 + > > 2 files changed, 142 insertions(+), 4 deletions(-) >=20 > >--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h > > +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h > > @@ -946,6 +946,8 @@ struct aesni_mb_session { > > struct { > > /* * AAD data length */ > > uint16_t aad_len; > > + > > + struct gcm_context_data gcm_sgl_ctx; >=20 > I don't think it's necessary to have this context data in here, you can d= eclare it > inside set_mb_job_params, unless this causes a performance drop. >=20 [CP]=20 It can't be declared in set_mb_job_params unfortunately, because it needs t= o exist after that function ends, which is when the final job is submitted. I have now moved it to qp_data rather than session. Have implemented your other suggestions in a v2, just sent to ML. Thanks, Ciara > Thanks, > Pablo >=20 > > } aead; > > } __rte_cache_aligned; > > > > -- > > 2.25.1