From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EA6943100; Fri, 25 Aug 2023 15:47:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9919B40695; Fri, 25 Aug 2023 15:47:03 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 4242F400D5 for ; Fri, 25 Aug 2023 15:47:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692971221; x=1724507221; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bmPNNmQdtMAYAdFo8g1lhOfHOAA836wcR1MLYs6Ycbw=; b=A5+TdxbcRIXzjGiZDkKw6AR+bYdS17AgCYNZlDwFIwxmJqqMqwvut/Vj 9qi5u1Do3NOKZmzQ/1H6zMLA5yZO5fs5Masu8D3uZ2iqQlg5skWrX34VK i6LpUqrIsgEIOxLpaf5hrfCVKNiyBRDI+pYRff9bMT/7QkTw7dCBFvP7W Bew6/BbuKugCcJ8KC60ckhFuWJ5mW0SphPY1xUZ28c58SLXJlsWndGB/w Sq2gcGR3DkhLyKCZTvFByAK7q8skUkXlE5KX/wPPO/aZgzTyKoPJ5Uxgi XQGP1bb8eEcZs3XrjAzsbqmO3VjrQiUn+fqEe8ovLKR8trJyzImU9K9U/ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10813"; a="438654995" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="438654995" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2023 06:46:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10813"; a="861089084" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="861089084" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 25 Aug 2023 06:46:58 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 25 Aug 2023 06:46:58 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 25 Aug 2023 06:46:58 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 25 Aug 2023 06:46:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uok80j4rnC+Gvw2WJ9vxKGEzuquKq3aYzTnY2KPDyzNV5O8F37RySM8PQXz+uSjCpPrbHRKMDG8z9viGuna257y8q+CQaE3r2GdLOrA4XpVvhoqWHzpsukDIaKQpjk9WL9nSLkrP09ybv1KjK0meQqvEGudYqPUwPNZ/+xLDcN265PCgs3a80GiiYCDVYcDihdxIqOTPBwRreoGtvpW9RHogSlRkqt23jA9QjWGeER0GAffYanyoq7U3GAmsUFmk+QnXe1sEmyCpWOQQciortTmNjnZQqpLkvrTZWUJ/l1w/wZTuw6puC7Pz0zqrav8CqPa52DsF7Z09/0ZB+Drt6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UozI19SYBzm4t511hBDWM5us7B5+UnR2IjnypRE2PWw=; b=H7kRgVyf6/BX47HCXZ/bylYq/TTfCshPBB2FwGPQ6QQEoYkLvJ7TSi/47vF5i8eFo9ZlqVoQGcJJoW9V+fJtwvwq9xe5VMcSshK5vHRWVhXPKl1cEy+f/+KM28XY47Rrt/83rGZZ7P7AxVF2qiV0LMGnuH51A2Sy0whrwFstwYhP7OAI9oizTt/hbUYmxZvL/736Uc81NjxdcYDa2o03uIiA4VMO63LuGV8vS+M0up3nLiZOc+hJh/JMaNqcIqW6fK1VrQmNDjk29FPxPrm0DCtkiVhvCqbMuPYQIiTRm4zawn1eUF+epmrArUmrqj/hcq/vRikZ/8KShY1wIfLNUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3868.namprd11.prod.outlook.com (2603:10b6:5:19f::13) by MW3PR11MB4601.namprd11.prod.outlook.com (2603:10b6:303:59::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.27; Fri, 25 Aug 2023 13:46:56 +0000 Received: from DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::2729:6170:6e40:89c6]) by DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::2729:6170:6e40:89c6%7]) with mapi id 15.20.6699.028; Fri, 25 Aug 2023 13:46:56 +0000 From: "Naga Harish K, S V" To: "Kundapura, Ganapati" , "jerinj@marvell.com" , "dev@dpdk.org" CC: "Jayatheerthan, Jay" , "Gujjar, Abhinandan S" Subject: RE: [PATCH v1] eventdev/eth_rx: fix null pointer dereference Thread-Topic: [PATCH v1] eventdev/eth_rx: fix null pointer dereference Thread-Index: AQHZ1mRQ3v9JArFzI02MTivPjZm0Nq/7CC/w Date: Fri, 25 Aug 2023 13:46:55 +0000 Message-ID: References: <20230824082331.713236-1-ganapati.kundapura@intel.com> In-Reply-To: <20230824082331.713236-1-ganapati.kundapura@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3868:EE_|MW3PR11MB4601:EE_ x-ms-office365-filtering-correlation-id: 7518f093-54a6-4bc6-1564-08dba571bf1e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v6BIObDCnuZ3Wk6TuuhFoYbnzCBh5poRYMxkCkoMcJULHdIDkNtEPfLuDlBRGiLLL7m07W9RuqxposIAXcgutE20UKuPjW1fAwiheL7JlSo5EAVtPIhEQ0UbNV5Kkok0VfNG4Kkf6LaVhfGPjQYsR+BwkoWvwZokfV9PVKK4DxJMaq+lEsgmAgtOQ5vUF/82IdR3C180zQgeliPhNgWhPR/RNjS7VmwTooxJohp9Ni46LBt94+iWhj9BTAR5qPE6ngETPUdHOUmDdfvUjaWZKgLEEJqv+Ow9c7xDmCyzZnVqM+wTLs1AGpf921ld4rjxiYMqqM/tQyfG/FcofTVkpxnTqrEpUZSDc3pA7hHA/DaZw9KWk4IuqNNBmAbkx86EaGmXkvbHt5p8TfIQasi19OUschDx3LhXa2pqB36K8+57efl7//T3Vdsr/+R5Kn9OjutWbVfiTJILJ0qx7ALaKBLATMT0qkqwYEGCpMQP+fXeZeh2Cy2xbT1Y/I7cVH+CFr56PviXzK08B7kxarcwMFqrX6SQwwv9lgziGMr+5058Tj8XpqUQ7EzJi9rZ+01y8mZVrXikMjI4TLmSr+veKmRkc2MOdaCZAnb4eJdU/3mzGBXsaXslcEzrpDVFmaP97vC9GpYiLBE/ce3CJGTWEA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(346002)(366004)(39860400002)(376002)(1800799009)(451199024)(186009)(83380400001)(9686003)(478600001)(26005)(55016003)(5660300002)(52536014)(107886003)(2906002)(8676002)(8936002)(4326008)(82960400001)(38070700005)(38100700002)(122000001)(66556008)(66946007)(76116006)(66476007)(86362001)(71200400001)(41300700001)(54906003)(64756008)(53546011)(33656002)(110136005)(7696005)(66446008)(316002)(6506007)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pyy16BPzZeX3ly0DwlQRaV1RhNpRPCMKlmld7sLYqunFbqxXruf0LVwJtXxe?= =?us-ascii?Q?u7MVT3wa1msG3tpi3LWEJB9cS2UgHpKbZtoMOg96ND4B3lW9Bb6YSmGXclk8?= =?us-ascii?Q?jJmsw6Xc6+m7iTtLyUBQshLmrUXbANgtTZZaL9MHGNzvNgHXM/ow02jXFS4E?= =?us-ascii?Q?L/ivHfmfzLO1H4hUTe6NhCShMv8BASKs/iapJw4KreXV7zWqfiDh5WKspdzZ?= =?us-ascii?Q?sEG7hkZX+K50CinrRoSDW3FF942KUmXxEktGz0NoR9flWMRtOiFXOU5jPCwS?= =?us-ascii?Q?7YPfZ1qB18awy//D4tbvRcVGniLY4TlbYkSSjfB9P27EpPXco7wbcXWbIO1L?= =?us-ascii?Q?H2Kwfgt3o6dUkIbrylknpLYBJkiceJ445LWq6XUjNSKE7DenYgX3hjZd6y4b?= =?us-ascii?Q?1EJp5lAvzYjoUzzkPty/CTVjdMNBPeEwto5GXjeXDmRpoF/+WulAevyVnPVg?= =?us-ascii?Q?Fj6hwKja+W9Bv0cOCMfTr3alBVu9cFgrzvk8EyhmXZJd9njwIzG4OyJpKZTw?= =?us-ascii?Q?QN3RjNGADDpCYOoTs30yM+/GVJ02qzxpDk18qgOpWf5rXcvCLrLcuI42zSEA?= =?us-ascii?Q?feCGPCr+AK31FWtNLE5WtirsjUi21BQUubje5DarMFqz7qVn5a3KJSC8jHaF?= =?us-ascii?Q?6Pqt1MB972L2RXHzhWevhJAmtyD3UCHPNyqJDjzGEYVWiQgtt8sM+hJC4vq7?= =?us-ascii?Q?WcK2HtLvKwz+Bt23FxrxRJ06RMArXMLIiO/B8qbjsdXFlgKDxkizAib4BtM7?= =?us-ascii?Q?kSpWWtlP6ZrD2bSErQF6SsOPrWoczYi/KLeu2ZGw1yZD+Opo+LjNEYTyXe2B?= =?us-ascii?Q?Cr63D8fAJTchtKYSLZATQ79uWhyySDac5O3685L9iIB5cUHW7ik0uvh93y5M?= =?us-ascii?Q?FJaN15vQp7E+Bz8ExP7PqBSGF9urgMDwKqAUg8Ap3LIA5kfqEiGW40jjAeTP?= =?us-ascii?Q?OGUXIh3R7EJsxFPITDpvVJsjnwPLXo4lQw+gsS90PG3UWrwSq3IM5qi+1iWH?= =?us-ascii?Q?RrtbNYT3LARW3yazZ8QSdAiQNGaHmTlweUOXa1pOsT/01aek6MzBvPH8qSGA?= =?us-ascii?Q?TajrUre+diAbBkYIJOvVT+t4tzbbCTjG8UW8GThk+e++t77UWFqYIJ+X9W10?= =?us-ascii?Q?B1MabWzQAhYsq/kfBgBIOJj+1KUizKKdgXq/zkoPpqbMCf2EyPeRDDw0AVui?= =?us-ascii?Q?gdR0/8FgVIy4lCzoxnFKlBKQIMYDRUTl7ERZUph40+FNILBxVZPwUYF+9bXV?= =?us-ascii?Q?6oo6ggJo0tDQvzSitNmXMObq4rvebDblwZyimGLuJbKbPBM9U3OtzqqUxUeb?= =?us-ascii?Q?BbwWAvJBy1emDnK3aV/QEFPkFQpTvPt8DnxHBCRg3ZkAj75b0HAEtJmF/joC?= =?us-ascii?Q?c72dkj4NsbUn69WaA4Qf4lI1Pa690aR2w2+dJAgHrkNo87PWI4y/uFdChCF0?= =?us-ascii?Q?EB8244rCaGNKEZGWrB4VLoC6XG9sdeeJcUFlS0Y/rRwCjP36hiRfRHX+Mqvj?= =?us-ascii?Q?BoxDS8RYzt1e7wgmy2JZA4nYQumimkmLRfEwn9KCWnf4kqusLZAiBIlaayGB?= =?us-ascii?Q?+GSb6KWXsws8QvXuTHsZ7nh2BkuOTzyKXvnO/qhV?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7518f093-54a6-4bc6-1564-08dba571bf1e X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Aug 2023 13:46:55.9095 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gj/bIKXoYjUzZxWe+8IQQacDcU2m2ksRBlHQxzR1ndH3Is60Re0PeHOTCFNxBj3eAAEjDVs2ANL/5z5Bdy6IrLJiOqVin/wKv2rp/r1yDQc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4601 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kundapura, Ganapati > Sent: Thursday, August 24, 2023 1:54 PM > To: jerinj@marvell.com; Naga Harish K, S V ; > dev@dpdk.org > Cc: Jayatheerthan, Jay ; Gujjar, Abhinandan = S > > Subject: [PATCH v1] eventdev/eth_rx: fix null pointer dereference >=20 > On passing NULL as a last parameter to xxx_create_ext_with_params(), > rxa_config_params_validate() uses default values and dereferences NULL > pointer leading to segmentation fault. >=20 > Fixed by returning after using default values without dereferencing NULL > pointer. >=20 > Fixes: 8be6c94d6d90 ("eventdev/eth_rx: add new adapter create API") >=20 > Signed-off-by: Ganapati Kundapura >=20 Acked-by: Naga Harish K S V > diff --git a/app/test/test_event_eth_rx_adapter.c > b/app/test/test_event_eth_rx_adapter.c > index 2d5e197666..0233c87779 100644 > --- a/app/test/test_event_eth_rx_adapter.c > +++ b/app/test/test_event_eth_rx_adapter.c > @@ -407,6 +407,12 @@ adapter_create(void) > return err; > } >=20 > +static void > +adapter_free(void) > +{ > + rte_event_eth_rx_adapter_free(TEST_INST_ID); > +} > + > static int > adapter_create_with_params(void) > { > @@ -427,6 +433,13 @@ adapter_create_with_params(void) > rxa_params.use_queue_event_buf =3D false; > rxa_params.event_buf_size =3D 0; >=20 > + /* Pass rxa_params =3D NULL */ > + err =3D rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, > + TEST_DEV_ID, &rx_p_conf, NULL); > + TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > + if (err =3D=3D 0) > + adapter_free(); > + > err =3D rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, > TEST_DEV_ID, &rx_p_conf, &rxa_params); > TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); @@ - > 512,6 +525,13 @@ adapter_create_ext_with_params(void) > rxa_params.use_queue_event_buf =3D false; > rxa_params.event_buf_size =3D 0; >=20 > + /* Pass rxa_params =3D NULL */ > + err =3D > rte_event_eth_rx_adapter_create_ext_with_params(TEST_INST_ID, > + TEST_DEV_ID, test_port_conf_cb, NULL, NULL); > + TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > + if (err =3D=3D 0) > + adapter_free(); > + > err =3D > rte_event_eth_rx_adapter_create_ext_with_params(TEST_INST_ID, > TEST_DEV_ID, test_port_conf_cb, NULL, > &rxa_params); > TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); @@ - > 634,12 +654,6 @@ adapter_queue_stats_test(void) > return TEST_SUCCESS; > } >=20 > -static void > -adapter_free(void) > -{ > - rte_event_eth_rx_adapter_free(TEST_INST_ID); > -} > - > static int > adapter_create_free(void) > { > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c > b/lib/eventdev/rte_event_eth_rx_adapter.c > index 93bed18e93..fe84471523 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -2493,6 +2493,7 @@ rxa_config_params_validate(struct > rte_event_eth_rx_adapter_params *rxa_params, > /* use default values if rxa_params is NULL */ > temp_params->event_buf_size =3D ETH_EVENT_BUFFER_SIZE; > temp_params->use_queue_event_buf =3D false; > + return 0; > } else if (!rxa_params->use_queue_event_buf && > rxa_params->event_buf_size =3D=3D 0) { > RTE_EDEV_LOG_ERR("event buffer size can't be zero\n"); > -- > 2.23.0