From: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>
To: "Carrillo, Erik G" <erik.g.carrillo@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
Subject: RE: [PATCH v4 4/4] eventdev/timer: change eventdev reconfig logic
Date: Tue, 20 Dec 2022 09:14:33 +0000 [thread overview]
Message-ID: <DM6PR11MB3868344E9E6DD52D54D3EB58A1EA9@DM6PR11MB3868.namprd11.prod.outlook.com> (raw)
In-Reply-To: <IA1PR11MB6418D5D05AFE976CDFD4B55FB9E59@IA1PR11MB6418.namprd11.prod.outlook.com>
Hi Gabe,
> -----Original Message-----
> From: Carrillo, Erik G <erik.g.carrillo@intel.com>
> Sent: Monday, December 19, 2022 10:48 PM
> To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; jerinj@marvell.com;
> Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> Cc: dev@dpdk.org; Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> Subject: RE: [PATCH v4 4/4] eventdev/timer: change eventdev reconfig logic
>
> Hi Harish,
>
> Adding a couple of comments inline:
>
> > -----Original Message-----
> > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > Sent: Monday, December 19, 2022 12:29 AM
> > To: jerinj@marvell.com; Carrillo, Erik G <erik.g.carrillo@intel.com>;
> > Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> > Cc: dev@dpdk.org; Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > Subject: [PATCH v4 4/4] eventdev/timer: change eventdev reconfig logic
> >
> > When rte_event_timer_adapter_create() is used for creating adapter
> > instance, eventdev is reconfigured with additional
> > ``rte_event_dev_config::nb_event_ports`` parameter.
> >
> > This eventdev reconfig logic is enhanced to increment the
> > ``rte_event_dev_config::nb_single_link_event_port_queues``
> > parameter if the adapter event port config is of type
> > ``RTE_EVENT_PORT_CFG_SINGLE_LINK``.
> >
> > With this change the application is no longer need to configure the
> > eventdev with
> > ``rte_event_dev_config::nb_single_link_event_port_queues``
> > parameter required for timer adapter when the adapter is created using
> > above mentioned api.
> >
> > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> > Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > ---
> > v2:
> > * fix build error in documentation
> > v3:
> > * update doxygen
> > v4:
> > * fix programmer guide
> > ---
> > ---
> > doc/guides/prog_guide/event_timer_adapter.rst | 17 ++++++++++++++
> > lib/eventdev/rte_event_timer_adapter.c | 23 +++++++++++--------
> > lib/eventdev/rte_event_timer_adapter.h | 13 +++++++++++
> > 3 files changed, 43 insertions(+), 10 deletions(-)
> >
> > diff --git a/doc/guides/prog_guide/event_timer_adapter.rst
> > b/doc/guides/prog_guide/event_timer_adapter.rst
> > index d7307a29bb..b457c879b0 100644
> > --- a/doc/guides/prog_guide/event_timer_adapter.rst
> > +++ b/doc/guides/prog_guide/event_timer_adapter.rst
> > @@ -139,6 +139,23 @@ This function is passed a callback function that
> > will be invoked if the adapter needs to create an event port, giving
> > the application the opportunity to control how it is done.
> >
> > +Event device configuration for service based adapter
> > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> We can use '^' instead of '~' here to make it a subsection.
>
Updated in v5 of the patch set.
> > +
> > +When rte_event_timer_adapter_create() is used for creating adapter
> > +instance, eventdev is reconfigured with additional
> > +``rte_event_dev_config::nb_event_ports`` parameter.
>
> How about something along the lines of:
>
> "When rte_event_timer_adapter_create() is used to create an adapter
> instance, ``rte_event_dev_config::nb_event_ports`` is automatically
> incremented, and the eventdev is reconfigured with the additional port."
>
> > +This eventdev reconfig logic also increment the
>
> "increments"
>
Done
> > +``rte_event_dev_config::nb_single_link_event_port_queues``
> > +parameter if the adapter event port config is of type
> > +``RTE_EVENT_PORT_CFG_SINGLE_LINK``.
> > +
> > +So the application is no longer need to configure the event device
> > +with
>
> "application no longer needs"
>
Done
> > +``rte_event_dev_config::nb_event_ports`` and
> > +``rte_event_dev_config::nb_single_link_event_port_queues``
> > +parameters required for timer adapter when the adapter is created
> > +using above mentioned api.
> > +
> > Adapter modes
> > ^^^^^^^^^^^^^
> > An event timer adapter can be configured in either periodic or
> > non-periodic mode diff --git a/lib/eventdev/rte_event_timer_adapter.c
> > b/lib/eventdev/rte_event_timer_adapter.c
> > index a0f14bf861..5ed233db00 100644
> > --- a/lib/eventdev/rte_event_timer_adapter.c
> > +++ b/lib/eventdev/rte_event_timer_adapter.c
> > @@ -88,7 +88,20 @@ default_port_conf_cb(uint16_t id, uint8_t
> > event_dev_id, uint8_t *event_port_id,
> > rte_event_dev_stop(dev_id);
> >
> > port_id = dev_conf.nb_event_ports;
> > + if (conf_arg != NULL)
> > + port_conf = conf_arg;
> > + else {
> > + port_conf = &def_port_conf;
> > + ret = rte_event_port_default_conf_get(dev_id, port_id,
> > + port_conf);
> > + if (ret < 0)
> > + return ret;
> > + }
> > +
> > dev_conf.nb_event_ports += 1;
> > + if (port_conf->event_port_cfg &
> > RTE_EVENT_PORT_CFG_SINGLE_LINK)
> > + dev_conf.nb_single_link_event_port_queues += 1;
> > +
> > ret = rte_event_dev_configure(dev_id, &dev_conf);
> > if (ret < 0) {
> > EVTIM_LOG_ERR("failed to configure event dev %u\n",
> dev_id); @@
> > -99,16 +112,6 @@ default_port_conf_cb(uint16_t id, uint8_t
> > event_dev_id, uint8_t *event_port_id,
> > return ret;
> > }
> >
> > - if (conf_arg != NULL)
> > - port_conf = conf_arg;
> > - else {
> > - port_conf = &def_port_conf;
> > - ret = rte_event_port_default_conf_get(dev_id, port_id,
> > - port_conf);
> > - if (ret < 0)
> > - return ret;
> > - }
> > -
> > ret = rte_event_port_setup(dev_id, port_id, port_conf);
> > if (ret < 0) {
> > EVTIM_LOG_ERR("failed to setup event port %u on event
> dev %u\n",
> > diff --git a/lib/eventdev/rte_event_timer_adapter.h
> > b/lib/eventdev/rte_event_timer_adapter.h
> > index cd10db19e4..4b757773db 100644
> > --- a/lib/eventdev/rte_event_timer_adapter.h
> > +++ b/lib/eventdev/rte_event_timer_adapter.h
> > @@ -212,6 +212,19 @@ typedef int
> > (*rte_event_timer_adapter_port_conf_cb_t)(uint16_t id,
> > *
> > * This function must be invoked first before any other function in the API.
> > *
> > + * When this API is used for creating adapter instance, eventdev is
> > + * reconfigured with additional
> > + ``rte_event_dev_config::nb_event_ports``
> > + * parameter during service initialization. This eventdev reconfig
> > + logic also
> > + * increment the
> > + ``rte_event_dev_config::nb_single_link_event_port_queues``
> > + * parameter if the adapter event port config is of type
> > + * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``.
>
> We can update the comment here in the same way that the .rst files above
> get updated.
>
Done in V5 patch set
> Thanks,
> Gabriel
>
> > + *
> > + * So the application is no longer need to account for
> > + * ``rte_event_dev_config::nb_event_ports`` and
> > + * ``rte_event_dev_config::nb_single_link_event_port_queues``
> > + * parameters required for Timer adapter in eventdev configure when
> > + * the adapter is created with this api.
> > + *
> > * @param conf
> > * The event timer adapter configuration structure.
> > *
> > --
> > 2.25.1
next prev parent reply other threads:[~2022-12-20 9:14 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 5:55 [PATCH 1/4] eventdev/eth_rx: " Naga Harish K S V
2022-12-14 5:55 ` [PATCH 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-14 5:55 ` [PATCH 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-14 5:55 ` [PATCH 4/4] eventdev/timer: " Naga Harish K S V
2022-12-14 7:04 ` [PATCH v2 1/4] eventdev/eth_rx: " Naga Harish K S V
2022-12-14 7:04 ` [PATCH v2 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-14 7:04 ` [PATCH v2 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-19 3:51 ` Gujjar, Abhinandan S
2022-12-19 5:45 ` Naga Harish K, S V
2022-12-14 7:04 ` [PATCH v2 4/4] eventdev/timer: " Naga Harish K S V
2022-12-14 7:31 ` [PATCH v2 1/4] eventdev/eth_rx: " Jayatheerthan, Jay
2022-12-14 9:50 ` Naga Harish K, S V
2022-12-19 5:33 ` [PATCH v3 " Naga Harish K S V
2022-12-19 5:33 ` [PATCH v3 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-19 5:49 ` Gujjar, Abhinandan S
2022-12-19 5:33 ` [PATCH v3 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-19 5:49 ` Gujjar, Abhinandan S
2022-12-19 5:33 ` [PATCH v3 4/4] eventdev/timer: " Naga Harish K S V
2022-12-19 5:56 ` Gujjar, Abhinandan S
2022-12-19 6:20 ` [PATCH v4] " Naga Harish K S V
2022-12-19 5:48 ` [PATCH v3 1/4] eventdev/eth_rx: " Gujjar, Abhinandan S
2022-12-19 6:28 ` [PATCH v4 " Naga Harish K S V
2022-12-19 6:28 ` [PATCH v4 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-19 6:28 ` [PATCH v4 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-19 6:28 ` [PATCH v4 4/4] eventdev/timer: " Naga Harish K S V
2022-12-19 17:18 ` Carrillo, Erik G
2022-12-20 9:14 ` Naga Harish K, S V [this message]
2022-12-20 8:12 ` [PATCH v5 1/4] eventdev/eth_rx: " Naga Harish K S V
2022-12-20 8:12 ` [PATCH v5 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-20 8:12 ` [PATCH v5 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-20 8:12 ` [PATCH v5 4/4] eventdev/timer: " Naga Harish K S V
2022-12-20 9:11 ` [PATCH v5 1/4] eventdev/eth_rx: " Naga Harish K S V
2022-12-20 9:11 ` [PATCH v5 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-20 9:11 ` [PATCH v5 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-20 9:11 ` [PATCH v5 4/4] eventdev/timer: " Naga Harish K S V
2022-12-21 6:03 ` [PATCH v5 1/4] eventdev/eth_rx: " Naga Harish K, S V
2023-01-02 5:14 ` Naga Harish K S V
2023-01-02 5:14 ` [PATCH v5 2/4] eventdev/eth_tx: " Naga Harish K S V
2023-01-02 5:14 ` [PATCH v5 3/4] eventdev/crypto: " Naga Harish K S V
2023-01-02 5:14 ` [PATCH v5 4/4] eventdev/timer: " Naga Harish K S V
2023-01-04 6:41 ` [PATCH v6 1/4] eventdev/eth_rx: " Naga Harish K S V
2023-01-04 6:41 ` [PATCH v6 2/4] eventdev/eth_tx: " Naga Harish K S V
2023-01-04 6:41 ` [PATCH v6 3/4] eventdev/crypto: " Naga Harish K S V
2023-01-04 6:41 ` [PATCH v6 4/4] eventdev/timer: " Naga Harish K S V
2023-01-12 7:06 ` Jerin Jacob
2023-01-12 16:32 ` Naga Harish K, S V
2023-01-12 16:30 ` [PATCH v7 1/4] eventdev/eth_rx: " Naga Harish K S V
2023-01-12 16:30 ` [PATCH v7 2/4] eventdev/eth_tx: " Naga Harish K S V
2023-01-12 16:30 ` [PATCH v7 3/4] eventdev/crypto: " Naga Harish K S V
2023-01-12 16:30 ` [PATCH v7 4/4] eventdev/timer: " Naga Harish K S V
2023-01-13 13:51 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB3868344E9E6DD52D54D3EB58A1EA9@DM6PR11MB3868.namprd11.prod.outlook.com \
--to=s.v.naga.harish.k@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).