From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F624A0543; Fri, 12 Aug 2022 18:11:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA2E440A82; Fri, 12 Aug 2022 18:11:06 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 7A95640A7F for ; Fri, 12 Aug 2022 18:11:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660320664; x=1691856664; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=dQtbwvMNN0EjyhHoVEiGUCviny+1SI/0c8qAcpgThig=; b=ngA4RFoWMjn3vqTQiLKhfovky47ff1oiljjEIo1yYpYFeMZ93q0d0RKS z6Qq9wUsem0njEX2o0XTU3AUqcx8tTj5/w11rAyvwkLJFameaVZI9DIg0 L3BbGPPRzD317c6iosyGljrX6GLXyMp0sWTDJpa6vkhVL1P1dOyJ8UMRy AVLY2S8lhXo7DcUoJC7fDBU/GDfidKEsJZiTfpWaD4LNb5IGtlDlx4umS l43SRCHsD4r8Z8hrm2o215JAzVue/HH0Eeyu+50v31qyb4UmRTZKYK5+z A8UfayeYlFZP6mnFvVnjjvZfYDFpjach8qahSZ2GOFXozEQ4JuZ6/PXUP Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10437"; a="355629224" X-IronPort-AV: E=Sophos;i="5.93,233,1654585200"; d="scan'208";a="355629224" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2022 09:11:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,233,1654585200"; d="scan'208";a="695306386" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 12 Aug 2022 09:11:03 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 12 Aug 2022 09:11:03 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 12 Aug 2022 09:11:02 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Fri, 12 Aug 2022 09:11:02 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Fri, 12 Aug 2022 09:11:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jRMK5N42NeXpGZBCkV38GsEb6bRGX3oESkwPle/iu59s+MihWbRtFQHSJJivAKG2cmHEUCmkYqeEVEPMrxdarYyiIo7TBwjjHEOv1sF1awLTnqhvt0JgJdBXRTpSCThhnTIs/7U3b247DEcCV4OGTor+uYDYI3pL1l3ONn3pVrG4xDGa6Vb4MSoH0uL+Wu0XOnOEY6JYWCSa0qXkEagqqjVULe23eFU/gyhIUNWKczPFFDbONsHjHhcnChI9JpT0MccghQfCV3WdlgHwiKbrJAeansDKArLvA0NudJ8M/pxJmTFffLOSJjDXP4OgY8/kyHvVHfkZ6rN6Sz2PpkQd9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZUlXbmITB7rTeFOF8v8sDXpQwSmAC0M6fVxB0DuDPYc=; b=Qpn1ix63SaxiisPrfKyRdhdoeTtERIqdZkdon6Ygvp3O1vL0KUqbvFAcNheSBH2IxTAxEezJ+NstiAle1bnBmSkO6oP4jO+h+4Gl2NuMdw/SXRvigJCNonEpWmMTTaXW/69RSBHqVGLEHazmQ6W49z3r512up03NsOZuourYpn+j9O9r8AzYq3StTNifONSNKrJeOZwJgGLBzCWw9G2ShJkYlL26R0DutiFEDF2gsIjH4SgThvkuYYqQq0IcgYFvS0QmddidC0GwIMnG21qadqd9khPT/ZrW26wtdtn5Oq28Fo2AkNKr/95v0c97QdFmBELa1jSEUcRBFGYqz0pU4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3868.namprd11.prod.outlook.com (2603:10b6:5:19f::13) by BL0PR11MB3028.namprd11.prod.outlook.com (2603:10b6:208:7a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.17; Fri, 12 Aug 2022 16:10:59 +0000 Received: from DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::128:9f09:dd7:d6b9]) by DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::128:9f09:dd7:d6b9%6]) with mapi id 15.20.5504.020; Fri, 12 Aug 2022 16:10:59 +0000 From: "Naga Harish K, S V" To: "Carrillo, Erik G" , "jerinj@marvell.com" CC: "pbhagavatula@marvell.com" , "sthotton@marvell.com" , "dev@dpdk.org" Subject: RE: [PATCH v3 1/4] eventdev/timer: add periodic event timer support Thread-Topic: [PATCH v3 1/4] eventdev/timer: add periodic event timer support Thread-Index: AQHYrZgvdaek2OLQmE2RVW4+JcG8h62qEurQgAFdvqA= Date: Fri, 12 Aug 2022 16:10:58 +0000 Message-ID: References: <20220810070722.3110873-1-s.v.naga.harish.k@intel.com> <20220811153638.3992403-1-s.v.naga.harish.k@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 80873701-852c-41b2-4c89-08da7c7d3e9b x-ms-traffictypediagnostic: BL0PR11MB3028:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6S+9wu8Qhd898XcCCBciQMwvLysR7uJGG8WP355OxXTpm2ofUK0h7hyGnbVZVWxHMd3KZt2zr2X0f1KUQnt2unLsNKFQ0GsyKX9YETmhJwM3xQ0nUOf4If27Oh4bIuoTfnY31+IOXidfNAK8eiYF+Cg6D7MOYvOFU8I8EX6onDF7Dqfy7Cr1tS+T19KiztAGngWGwuY0ThbioFU4WRPr4K5fQs+bUFFSzOvDyGwvR6kNSggNIWDBjn9n+Iz6zSxg9NgqhCPzIrrufuja4TS/A+kZEMCMFMkOUlNR04ZxwBsediAVrcyLo7uZUYQReRuhqCBFqpdasuyj3Qe0M7B4OeNaN44e2oGkc2fmr0SRvQ+UILBRLnkYhou5t5Uf1qgvjNyF2seQuzoMysi3U/2v4c38RmejGMxK0DWtVlWP47sEqIC6tNDCzIdWF1IBHgQ9GMQD2leWQaNKLC/ANUWuJKkghDEqs1G+u8D6tHmmy02lIE1SgSsdE1fQtKG+KnG2ElqzmvAdhnsaBoAkEZAar5jq8G8liPGMvQMOxScPeIkAAF0Uwr+9NAfM5ttCW/4U269xfI0rUNdMyW7yuk+jnYTAJSe/WIwJip8A0JIKDKjHcmw5exc/9FEc601CmpKQnMWzBDoE/DElH5yTfjf/1JvJvHreAeH2wOi49zHkSBnSuyyYDY5eM7L0wIfqQDdnwxR3MQgbwhi8Y/VvbUtH538xM/xGhD8T6wbZlBVjoLFdEKqo9BtV1wXzFlx8mVY1oPN1tvAPdStmL2wWwIYZCKhGKsIBQal3n/8lREhxvI0ynt++qzmG0gbpGCfdUJZs x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(396003)(136003)(346002)(366004)(39860400002)(86362001)(186003)(71200400001)(41300700001)(26005)(53546011)(55016003)(9686003)(122000001)(8676002)(110136005)(316002)(83380400001)(7696005)(6506007)(54906003)(2906002)(4326008)(66946007)(64756008)(66446008)(33656002)(478600001)(82960400001)(5660300002)(52536014)(38100700002)(76116006)(38070700005)(66476007)(8936002)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?j0EKT2/d0ECraVZzIm7XBdM/wB2KBp/xyRqtfu5cF7pniDZxoUAm+/St6hrC?= =?us-ascii?Q?zd9FCTXbwQgSfpec0ATAFSyZyQ1Iwdfk5pBP2I2Kfo6Ps5bmW7M3c+9HsDIP?= =?us-ascii?Q?KMPmQEk+Yhum6X5CNQCnnCtCFS1Lf2p/9BHnmEaEilplFUk3y3SG/9k+Pn4K?= =?us-ascii?Q?d9qdEL1oTl56kRDkQz5iyCcGgZhEgByFLkKyt/6Q3hqS02KyNGRmrI5x4xU9?= =?us-ascii?Q?cBO80fo8GDVG1Kq5KwOX3Do07wMxyHu1WSEWtNfoOvOeXLIcuFOWacJmF3gr?= =?us-ascii?Q?AadQboCfZ5pHshuM87u2RSNg2uNOaZS7ystDKKeOoKVwbwu1HPYdTVcKZ5A8?= =?us-ascii?Q?yOKzyJhmMIK32lBwKvLwIlsL4CcPQxoVm0RMKg3NIUsLJrk8kQRQ7B4CPlOH?= =?us-ascii?Q?pso+8j5lOYqEQGvQisy/5+dMVugM7ZWczNL8djV/aCnfYp21BidrJUm3jcfo?= =?us-ascii?Q?mljkM8EhLYqBGu+8hrex3ecng7DLRJObx/StuOMp6l98OxDonBhHZ+aUHIMZ?= =?us-ascii?Q?UFyLi27qyMRE/fzWvGu6L/v1ycxf8fcqIlduc+IqWDbHCTud9az9O5Eo0bWY?= =?us-ascii?Q?Q5J4upkEofdAHME9oidepQKTXkBRsxnTKWAvMFo/ULHnTw7cAqUY3YAiPdj0?= =?us-ascii?Q?rNo0s3FjAwHtZ8tIGa+uRkL9i/8mgMXWgiDZmgL3Uyej8LOA4Y8Z1MKiFQtv?= =?us-ascii?Q?PTUD55/TNB3/eQyXHnVPz4NRyo3ntPbaQelsAtDIlpsSIJ5P1AkR+wjvOepi?= =?us-ascii?Q?gTs1BqKHOjrFWUf0wTRUUCAryw+qp3mMokewgA9C4QM4deQYodjOgFMa4Fj6?= =?us-ascii?Q?WXkYmHKd/nrqsl/9tz5S0TqXRN9JT+16PSfLkzi0BdwvM5hpDQl/arV/JzDh?= =?us-ascii?Q?Txf2B8vDIhMDM6s2dR2N0dGDoK1k0jGJFNWAyoHxgTtlBohhX8vWDkfzY45W?= =?us-ascii?Q?4SwixR5BXEprQE1qJysoPIWm6AvhV6XpX0ar/wpd6QLNqjtRPY5zB0iRhu4x?= =?us-ascii?Q?hY8T63Gqk8NnkL+Fx+iGfChCF8Ds/Glv+rQ7oMMQow7s9VkS29aRvJcvPMaa?= =?us-ascii?Q?rNFqEgJMBVFBQjLYrMPdBq1JqNlHRH8YmhxzJg5Pkm4Cn20GqmqL12m7tMM/?= =?us-ascii?Q?IDMTVXmZhdNTW8ggb9fONeA7ejiqjS8LTPITTsnE45g/pUu7clNVRoQnQy+2?= =?us-ascii?Q?W3JDktQMi+E9i0uUaMLZdAWmIphuoerOGZ6AWkE2QxZ/v6xNaGElpZIU/5Np?= =?us-ascii?Q?7KTRFVHUKNk7LRMS+7GihBK+Dp5j7YzR5I23vumP0vA1u5MWbe2ZNvkYvj/5?= =?us-ascii?Q?Gd3eXLto+dT/nD9Hm/krzQpPsMhldl7UvvMFRCs86NR4j2NXznEOgWa433OS?= =?us-ascii?Q?HCf6GJ5gIropV83Rlwg8lAYJKLQSXi+jvKArPtFBDiMnpPAhXndyad2S3yyA?= =?us-ascii?Q?25hsGqg9ecozJ33QHXhL9fwebfOK1BLGreSXjJHL8XauOzess368q7oGH/yN?= =?us-ascii?Q?4OMkyWzBxRQ7an8q0on7FP4OCUw1BgQu1MPurwymrsaE300FV7nDBaKF7MZ5?= =?us-ascii?Q?tLxinYs8/ox7Q4aysjZoi1VHCmkiul9nzrkGgX+B1nlViJqqx95WJCFLXRmY?= =?us-ascii?Q?pA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80873701-852c-41b2-4c89-08da7c7d3e9b X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2022 16:10:58.9155 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OuBVmITtxe2KudQpWBdJuX/kLGE7XW0fJnMhKvXJRhUr29otZGw1BBBnjbnTnLxlU9ecsnsPGykq4XJCI+NLx+hjwZX6/9+A/6MAMaO35LY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3028 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Gabe, > -----Original Message----- > From: Carrillo, Erik G > Sent: Friday, August 12, 2022 12:52 AM > To: Naga Harish K, S V ; jerinj@marvell.com > Cc: pbhagavatula@marvell.com; sthotton@marvell.com; dev@dpdk.org > Subject: RE: [PATCH v3 1/4] eventdev/timer: add periodic event timer > support >=20 > Hi Harish, >=20 > > -----Original Message----- > > From: Naga Harish K, S V > > Sent: Thursday, August 11, 2022 10:37 AM > > To: Carrillo, Erik G ; jerinj@marvell.com > > Cc: pbhagavatula@marvell.com; sthotton@marvell.com; dev@dpdk.org > > Subject: [PATCH v3 1/4] eventdev/timer: add periodic event timer > > support > > > > This patch adds support to configure and use periodic event timers in > > software timer adapter. > > > > The structure ``rte_event_timer_adapter_stats`` is extended by adding > > a new field, ``evtim_drop_count``. This stat represents the number of > > times an event_timer expiry event is dropped by the event timer adapter= . > > > > Signed-off-by: Naga Harish K S V > > --- >=20 > <... snipped ...> >=20 > > diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c > > index 1dc4f966be..4a2a1178da 100644 > > --- a/lib/eventdev/rte_eventdev.c > > +++ b/lib/eventdev/rte_eventdev.c > > @@ -139,7 +139,11 @@ rte_event_timer_adapter_caps_get(uint8_t > dev_id, > > uint32_t *caps) > > > > if (caps =3D=3D NULL) > > return -EINVAL; > > - *caps =3D 0; > > + > > + if (dev->dev_ops->timer_adapter_caps_get =3D=3D NULL) > > + *caps =3D RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC; >=20 > I think we should move the definition of > RTE_EVENT_TIMER_ADAPTER_SW_CAP to this patch, and use that macro > here as well. With that change, this looks good to me. >=20 Updated the same in v4 version of the patchset > Thanks, > Erik >=20 > > + else > > + *caps =3D 0; > > > > return dev->dev_ops->timer_adapter_caps_get ? > > (*dev->dev_ops- > > >timer_adapter_caps_get)(dev, > > -- > > 2.25.1