From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4EA5428B5; Thu, 6 Apr 2023 09:36:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C05840F18; Thu, 6 Apr 2023 09:36:37 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 7ECB240DF6 for ; Thu, 6 Apr 2023 09:36:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680766595; x=1712302595; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+RfhvIwKAPrfVoURvAZ5HLOFRLh1yiG6rqDMSDP4y3Y=; b=KSP+m/ZHUO8yj72jtAPrzIg1eYhcyQM6sB1Qp+ArlMPIaJBHCwKZQBhe 9xbGsjW9Duz9P+GWQS0CcbAtIVoTOK1X/Xl4/3zkltjeer326H3vtC9lg cVWJdcUK7toH4VlWOzLGXq38k7ACJmUZnghxZ9oyJfM3qXnXeRr4FnrA7 uiq4UzcShyIC7GA1SjdPBEC2GZA4hqkIIl8hXhUGdtyHOv84zneAhuVCp qeClVSHU55S0EonpVVvHusjgmbL+W8RO/RcAUP8tYCf2Ni1hYI7irRJR0 GpJTi68Y06Kj1VeOeGO88ZuYL7osahv6/C6WJZAOdpAgKT//UHlaYIbkP Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="345265354" X-IronPort-AV: E=Sophos;i="5.98,323,1673942400"; d="scan'208";a="345265354" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2023 00:36:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="719607439" X-IronPort-AV: E=Sophos;i="5.98,323,1673942400"; d="scan'208";a="719607439" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 06 Apr 2023 00:36:33 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 6 Apr 2023 00:36:32 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 6 Apr 2023 00:36:32 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 6 Apr 2023 00:36:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QUV3w1IMliPou7YiW1xTZpFnfvgU7Ydjxuu00HFxMcPytyzqBhwMMfMFLXdpoZlMGC/ivTJZZPP1tt5CIu/ladEb/TOd+ygrPru04HDzGZU8L4VunVnhLwjxOPP7eN52qbj3H63tozjdb8Io2jASFc40Is8pnFqVwW6nS959/WsN/wLAXOV3nZy85O3saEDoY8wTV9wa2mhFWP12EMAUTupXUBH25NN7WLE+ZH7++tBjyewoEXJm/SiUHgQfec9N/0Ek7CHBCbP+l+ygjYz28OhymGVWdDoWWdi0GCEQhJ4x3CVJF+nw2M7lNg1/thvfBydfzK9TkczPXnFiUjOtJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kpEh9uPf5XwlVo4u2c1RbGhOrTCq2uswGn+Ou3va4co=; b=J4DZp0NJuRV/gDTtGCrtgnIp9v4L/bsJ1BB7JLuecSi4fz9LLxBCal/XVjgAZI61WSB/Ait6b5vCFE//CloQ+mJLdfMEc5itepnmfB3my7wdafjcwaT9U15CoO6Ru+jnr0VqfEIgvffTBvUbeSV/0qowsoZy0PgDoIo0d3fcrO8F9NJp9EJ2pgokpr41GrRCpyKAnkZV2at2fhGVpxs1W/Om8titftPRBP0W2CrYWVegKcq1C1gk40if/5P2cfHBecvAhntzID6T2TQ0Vccgtli5KcrFQGeVRnEh6JreTRpES3fnwfhLCrtUkT4xkGbWbOBhGnnZLP57vPWEVfmF0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3868.namprd11.prod.outlook.com (2603:10b6:5:19f::13) by SA3PR11MB8047.namprd11.prod.outlook.com (2603:10b6:806:2fc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 07:36:30 +0000 Received: from DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::d0e5:45c5:88e:f324]) by DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::d0e5:45c5:88e:f324%4]) with mapi id 15.20.6254.030; Thu, 6 Apr 2023 07:36:30 +0000 From: "Naga Harish K, S V" To: "pbhagavatula@marvell.com" , "jerinj@marvell.com" CC: "dev@dpdk.org" Subject: RE: [PATCH v2] eventdev/eth_rx: fix invalid memory access Thread-Topic: [PATCH v2] eventdev/eth_rx: fix invalid memory access Thread-Index: AQHZZ6Mj3nk1ti9QxEezHZo+xJvXV68d5HcQ Date: Thu, 6 Apr 2023 07:36:29 +0000 Message-ID: References: <20230405093959.2052-1-pbhagavatula@marvell.com> <20230405094332.2862-1-pbhagavatula@marvell.com> In-Reply-To: <20230405094332.2862-1-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3868:EE_|SA3PR11MB8047:EE_ x-ms-office365-filtering-correlation-id: 9ba3121e-8f49-42c6-071c-08db3671a321 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U6F7W/+PZgWFZG4F6WkoAiVngPt/FWRIYpgCPct9t9wdAlMZh24QePVJgl0L4WPqk1VOwD0eafc/o6jq36IYDoYFGykIOhpdxCFf10KEDajW3y7st0jRxr+DE3s3hPfF5Lpg6zeGKMEiRYd7ASwA1YjlYtDZGvmU/TAbnB6/uuwsEi2c6s9FA3NhhEeyCmA1Gg49IqjhaBw2mRyydP6h7j+pAhzHPFCJglB5FCTTOF/ITm5afWLhZKyXk9FCXtw8qa2KvRI1vM0bDi0Ubh5ejsZtLOvJysc0O0ImrbifhGnyjMZiqRc+xEfLCICGiyNg+J18qllF740DoB8IsYIV9PPJveeJbyKRYuEj43geaTVusPBLKnPHT8SXZ6PyOPvZbkeZjRsBL7kkpTlUrjk0Ftcxcf87TMbM7+IWBbsh9bM9Na+vKcL47nojDJAMMBpuo8TVd9ZLKxPubQFoIoY1BCjWo97E4aB+XVTMZ+eqVdFuDzm/Ro4Abniddyha4cavkrvJ2uEl04BH7Ko2Y5/kRX3UovN85ygWWRmKnfqceA2Nq6qjruCY97fRohmufgvLgC6smpgw1vyQlUKnnCs5gEhqb+4jpAxNelzhLlke61yEJTStWQ2cKoZD1NItOw2U x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(366004)(136003)(376002)(396003)(346002)(451199021)(33656002)(86362001)(38070700005)(2906002)(55016003)(9686003)(7696005)(71200400001)(186003)(53546011)(83380400001)(6506007)(26005)(4326008)(8676002)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(41300700001)(122000001)(478600001)(82960400001)(5660300002)(52536014)(38100700002)(110136005)(316002)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hnRUnmZ0stoxDyXZj884UFJbK2xDkVrsh2XCgrE0w/lhuET+qKcSjfMLxpaE?= =?us-ascii?Q?ZaDTLBF8hR8iO3b0ZBUnDhTb/s+6t/NpPaLgjKIYLNhoy2faSlOWUrDlQRjW?= =?us-ascii?Q?keYFzHurWd6EdbVHDLNyGuRXT4z3riwMGoCOh5ST33lPE6MMr6hTG41zTm8w?= =?us-ascii?Q?F4Fb7W3UaX6+AsiOSoKS6A23ocDxthO/Fissq2TGiNzSSYKRk87eAVv87pJO?= =?us-ascii?Q?iaQIvsN5FaydyzEc8h3jnkTVVivbgzglPFPyqYdsccRh+2KpoEgY31lwGROF?= =?us-ascii?Q?S52Byn63V7bP7sHP5li2ypCRUGJ2RcI8o1UUf0/tPgm1eAR/9JbBzBkfEasU?= =?us-ascii?Q?kE6yGbJRM49XkHFuLUaX4zPWs0BuySaGLjx5Iry0pse7mVOURme8kj3wFYHm?= =?us-ascii?Q?tk+9npLSWyZwmmmTMcAhjnEKpvje2e3fTlBdK/dlv7C8XliHEWmjLYgfeDZa?= =?us-ascii?Q?VnBQ+LQg+zM/wFU+AOWwPlldU3cRWqsGZPBd18lYypvl3epz6+6Y/9q/cl9e?= =?us-ascii?Q?xmY+CKJbWsXx7q2fR40WCbwYjFk3HC7VDaRy+v1ka2004tNDrZeyLC0LMiMl?= =?us-ascii?Q?oua4HneOLCsEoeUW1BNcOeVboYE8ePt35Bcn8GNvS9BG2VkYFJD0EZm/1vrI?= =?us-ascii?Q?X/PQHHBUh1BMlJTtuUBRhO2CgULsIH9JdNH+k9rl6/0BfaBEafBd3hCHpEnf?= =?us-ascii?Q?StpKkxDQ8ZfWQNVxCqoQKgobcWVF6xV8RBacRqcd2YgC5If5/EsX8zm1s7ym?= =?us-ascii?Q?QP/78swQCiHR9ySV/2qCB1Rd6yKtbCsthSJoYXzaW96bF3TsFLvX+64MxXrA?= =?us-ascii?Q?wXJBk4z4kEcY/4jEob/PMCkGe9UAKTDBpCG8M0nBBfaPqSE1dTCZQdAHCOLg?= =?us-ascii?Q?ZD+l6wKLldOD/l0kkwRUOo10o0hz+Bw5nC4jt569yV5WGntOB1tWNOiI2YvW?= =?us-ascii?Q?brnKRH8O0hwIdYHs+sIvVXJ9acIrcTJJNbWM+kbdxIlg6F8JcedpRE0MYXmH?= =?us-ascii?Q?uBjO4vp6KseY7fq2At3IPbOpFHkCZeme5a4XONt7F8rkqXOXSO+5sc8BqntA?= =?us-ascii?Q?/KMzye5W1KpFzTz02DMpYGifXEyO4zUpsmGSwUPF64Takn8JgOmb1Q1os6YC?= =?us-ascii?Q?tlrR2ChCWOFVYANQg3+ZDEgOfm/+JJC5NX65xGXJEJI9tu0fOt91JUMk7fiP?= =?us-ascii?Q?1+S3qCjr1/w5CgK4cldXL7gfzcO2LU6Hhyx/W6Qd4iZ5Avs+3WymNe5zOqqv?= =?us-ascii?Q?tCT5NTk/ibz61qxRCVNaa7uhRkaFF9Ag5zUE6jCT5n5coih4G7rLukMAGII/?= =?us-ascii?Q?a2St6/tIMtzNNwZOPG1NsCI87SZDkoqJcKSVZrpIl47+nRjzHsOpwKnEaBUH?= =?us-ascii?Q?dP9SN3R/kBUb579sZf5ivqHFxVRF5dEZuCivo6ZTGK03rEfjC9qnl55SabcZ?= =?us-ascii?Q?dua/WsrLlwlHj/846hDA76ya/4fZbuqDZ2wyG5o993tmHHQjAt9MSWfdrgzT?= =?us-ascii?Q?xS+65cCzJLGSbs2A3iWk/pNKmY+K/D6TcvLYjvPMMoZmU5w/cSM1DgWDrgri?= =?us-ascii?Q?S3pH49aeVHGRZStAKJ0Up0afm4KmWheoDcx7s3IWRKhCxnTT6+cgKsqoRiZT?= =?us-ascii?Q?LA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ba3121e-8f49-42c6-071c-08db3671a321 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2023 07:36:29.9033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zv0q9bZjlwJCWFU4t9YINk5qjkja7eUvG8jkBKRA05uJeL7yXyseJ8FqPpScRND5RbawmXHNCtlsUOYXGBw3ariyH6uTypJqe4KfLYfkKP8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8047 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: pbhagavatula@marvell.com > Sent: Wednesday, April 5, 2023 3:14 PM > To: jerinj@marvell.com; Naga Harish K, S V > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [PATCH v2] eventdev/eth_rx: fix invalid memory access >=20 Which invalid memory access are you referring to? > From: Pavan Nikhilesh >=20 > Rx adapter internal service structures are only initialized when non-inte= rnal > port is added to the adapter. > Check if Rx adapter service is initialized to determine if runtime set/ge= t > parameters are supported. >=20 > Fixes: 3716f52186af ("eventdev/eth_rx: support runtime set/get > parameters") >=20 > Signed-off-by: Pavan Nikhilesh > --- > v2 Changes: > ---------- > - Remove unused variables. > - Fix spell check. >=20 > app/test/test_event_eth_rx_adapter.c | 2 ++ > lib/eventdev/rte_event_eth_rx_adapter.c | 24 ++++-------------------- > 2 files changed, 6 insertions(+), 20 deletions(-) >=20 > diff --git a/app/test/test_event_eth_rx_adapter.c > b/app/test/test_event_eth_rx_adapter.c > index cfe6052d7e..b1775e6af1 100644 > --- a/app/test/test_event_eth_rx_adapter.c > +++ b/app/test/test_event_eth_rx_adapter.c > @@ -1230,6 +1230,8 @@ adapter_get_set_params(void) > /* Case 1: Get the default value of mbufs processed by Rx adapter */ > err =3D > rte_event_eth_rx_adapter_runtime_params_get(TEST_INST_ID, > &out_params); > + if (err =3D=3D -ENOTSUP) The queue needs to be deleted from the adapter instance before returning, = otherwise teardown fails as adapter_free fails because all the queues are not delete= d. > + return TEST_SKIPPED; > TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); >=20 > /* Case 2: Set max_nb_rx =3D 32 (=3DBATCH_SEIZE) */ diff --git > a/lib/eventdev/rte_event_eth_rx_adapter.c > b/lib/eventdev/rte_event_eth_rx_adapter.c > index c1cd124002..a8a5564b65 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -3466,30 +3466,14 @@ > rte_event_eth_rx_adapter_instance_get(uint16_t eth_dev_id, static int > rxa_caps_check(struct event_eth_rx_adapter *rxa) { > - uint16_t eth_dev_id; > - uint32_t caps =3D 0; > - int ret; > - > if (!rxa->nb_queues) > return -EINVAL; >=20 > - /* The eth_dev used is always of same type. > - * Hence eth_dev_id is taken from first entry of poll array. > - */ > - eth_dev_id =3D rxa->eth_rx_poll[0].eth_dev_id; > - ret =3D rte_event_eth_rx_adapter_caps_get(rxa->eventdev_id, > - eth_dev_id, > - &caps); > - if (ret) { > - RTE_EDEV_LOG_ERR("Failed to get adapter caps edev %" > PRIu8 > - "eth port %" PRIu16, rxa->eventdev_id, eth_dev_id); > - return ret; > - } > - > - if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) > - return -ENOTSUP; > + /* Check if there is at least one non-internal ethernet port. */ > + if (rxa->service_inited) > + return 0; >=20 > - return 0; > + return -ENOTSUP; > } >=20 > int > -- > 2.25.1