From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCE78A0543; Wed, 10 Aug 2022 09:20:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A11E040694; Wed, 10 Aug 2022 09:20:38 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 862E04068E for ; Wed, 10 Aug 2022 09:20:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660116036; x=1691652036; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=31X3GYghUCworOIR8SEqvmyd+BCB3j0NKQPHasqWzic=; b=dO6F3g0GK+SHmhmtHZjRg/efrg9xhJ2nWvvJGtFx0d4yMBE+FP1aEchU uuU5tvQjRGQozeG1f+TaaFA5/nwKG1O0eZ2vVgLNa5WMgWXZ6WuGKJiT3 SVUv6rnuLXXK3Nt+RrF25qxFrFOxfyqxxEXGiluWseBwNae34oFnYJPk1 gJzJeJuLcM6bzeJhJFvcbQ1bQuqxqZjLaYZuo7F8etbAJ1CHAAFAY2gcl MDc5ROQLTzajH48kYM+fpmB485YuIy9j+zL8FSEBChaE0TWV2S+5EuxRh SZxKWar5HY2JJ0ybTsGO9PhhDG12vEd7BOgEiwS4tR+IdSbuKSNPH8iof w==; X-IronPort-AV: E=McAfee;i="6400,9594,10434"; a="271403507" X-IronPort-AV: E=Sophos;i="5.93,226,1654585200"; d="scan'208";a="271403507" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 00:20:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,226,1654585200"; d="scan'208";a="581126249" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga006.jf.intel.com with ESMTP; 10 Aug 2022 00:20:35 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 10 Aug 2022 00:20:35 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 10 Aug 2022 00:20:34 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Wed, 10 Aug 2022 00:20:34 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Wed, 10 Aug 2022 00:20:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mWtQhxHhldD7rpAWu53fv20CznjGU64hcHDbLa+PUOCGl8zHj8buvbdRTSW3LTA3UVSDMUV9J/MQylWYo6PiGh69XwQ0KkbCPg68fBUV02QveulRi6LXQQ3HZrKG1t62pJ+KuMeMXUxkB2SRAMZwoYZ4GJ4YvqUTRy9wUWJjhxUScTdBsJInSozXq1Wp2Wvd56Tv9+0hW4moqSY/Z5p08QiyyIsWdzkAtJUnhRhbGGfiUUQJ2xOwKJNM4tZ8rLFKNg96r0Q3KLr69jaMNT+8oB6USQTwm+2rZ7yXho2P8BJIIlns7U7V63LwIgDfimdQucCgdvlWb4YvigHCEOPnsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uLWRH/Jkpe55HXPc8MV/VATJ/ecCB4vxPiPFlYAwyrM=; b=fduZtisQ6L2B2icMnmLga8AQKN1hecJsFjyTdsAy1ooFt+VVnhmdnZlunsy1bzot3ezdKX/1UneWUjY8kSX4jKhvoMx6MeoI6a3XMQ7HsMh2MJ91dh5d7PLSs1AU2JOunxSUDwZLkV7ArqVuLkjg6WBy4zcu9IV+n+EirowZSQRK1GrSFKWB5ETYzyMB38Z4lqqf/rWgvOwp+qChYWSx/HrDmZcg0shrZV7y5J4+6v/Z4ufdC1xTIwnjcuOHu5JXfC+XNuBqcukMB6/7BouoSWlOcLo1w4nm/tZ/HFuqit1esZtUxj7Q88I9hkxtCTzQ6SptgRl+DNx7cP0TW2ygBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3868.namprd11.prod.outlook.com (2603:10b6:5:19f::13) by SA0PR11MB4656.namprd11.prod.outlook.com (2603:10b6:806:96::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Wed, 10 Aug 2022 07:20:33 +0000 Received: from DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::128:9f09:dd7:d6b9]) by DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::128:9f09:dd7:d6b9%6]) with mapi id 15.20.5504.020; Wed, 10 Aug 2022 07:20:33 +0000 From: "Naga Harish K, S V" To: Stephen Hemminger CC: "Carrillo, Erik G" , "dev@dpdk.org" Subject: RE: [PATCH 3/4] timer: fix rte_timer_stop_all Thread-Topic: [PATCH 3/4] timer: fix rte_timer_stop_all Thread-Index: AQHYp2FgOrM+fy35nUqUWZJXBKger62nxBqw Date: Wed, 10 Aug 2022 07:20:33 +0000 Message-ID: References: <20220803162651.3145945-1-s.v.naga.harish.k@intel.com> <20220803104906.4013d349@hermes.local> In-Reply-To: <20220803104906.4013d349@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a88633b2-cacc-4e1a-5217-08da7aa0d063 x-ms-traffictypediagnostic: SA0PR11MB4656:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6WcjzWIo5wbO2yBVdtHeBPRe/sJGUjEl/Sy9sl1UIHmgfQN/NX5nknDJR6SKCoaKT/cXQDbFcEmJeIoVYmwL8XM9O5JPDiTym67tYL6H99jfRAgZd2kcZxuJBlUA4yaHi0ztqMquqFkwsc8pK5X+G8Xo+MevBznTHaZ8Xp9C7SwMh9s5FeicE/A6wdDgeIjRZReddPidSU0IxpI7v2enSOSjgqn8rxtOnf05o5gluwtmJXoGGsIpM94Bm/8Sm72ECUp6m39XttNyUOjcfgBAEsgQn6uUe8y0ljrJF/CMFTA1zEukrAu7OjEi8K3ZcYkXjU2gxaZQW2pboUiPWgy04D7lGfNYL4RcbCWuU8ZVdJ9Siw4kYJeEI5yF3j2waIYhwIYYWUduimwhBTP7RyOytAr3WJ4b2dLlJE0hGYlJx/CrIBd0CnF4WqPPaCJLWsgiwYACed4LVjTJFdE7jP4UA8d2KCQ6B5xib99Fw6wJWgpturYKZWrQXWduiDhNMzTKkc4FXlgbfB85RT83ynkSLz6vcz9fPgbGqOEfVqxyTHepKwymF+ZLSBmwx5AY1qXTgHAH1SWrGMCGp2IY1VWEMlVKmN1/WVaG/iGBUt8GqtD39v7mVOB/IiUMjlyjJtzTRdWKIYMeFE9khe8MA/NlG4ZcUdihvKVZoyuVwRiJSpjpUpsjP1yGC+TLRNsaGlJa0uXxggfaXUIVo0Aj7vVvHSt9fqsebH1GLqSKp6ZXPvfmcciUUTFtiyCyNdGiaA0dV0sM+dQO0NcNgEIauS9aeE+5iiGcwqxMGJ3xRmQ95nrdDeSFWuyOAbEsx+aYBTPH x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(396003)(346002)(136003)(376002)(39860400002)(55016003)(122000001)(316002)(86362001)(66556008)(38070700005)(71200400001)(4326008)(8676002)(64756008)(66476007)(82960400001)(66946007)(76116006)(66446008)(54906003)(6916009)(8936002)(52536014)(83380400001)(478600001)(5660300002)(186003)(33656002)(41300700001)(4744005)(38100700002)(26005)(9686003)(2906002)(7696005)(53546011)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SMq3iHDXcOgp3vqguKaFsAM+bJ34AMuVQCpe08vFHBv4GHm14VtXFX16syeK?= =?us-ascii?Q?4tVDYnnBoRAjDWmELJvL8xvZcIGQ6cKBwa0LbMIYoZelpEgUBtYdkTfsyrC2?= =?us-ascii?Q?GxbsluGF5Uwz0X+aMpVL8H6PJXa66MUmcHF631oUYQP+5JTXzuu8pAvoTbK5?= =?us-ascii?Q?IrdN+WWsQtFCPHYHQcynAa/A81oN1T1GV41JKdojNJ+cIPWV+lsGSxrUUJ20?= =?us-ascii?Q?VgATkprPB3JjU30EXN4nvgQs6LrF+K1NWGWxxdoyIyXRRjaCQbWhOROsyih5?= =?us-ascii?Q?Rc09c2htffO8kU293qf5gLI8jPCarXgUmxHuVOhLpJN1B1LeOwqrJD0CBbJH?= =?us-ascii?Q?pMBSZiVjQkRFi/UwZG94dZc5BBa932nSp+2SBtfbdkqEGockH+p2ypSFJ8jy?= =?us-ascii?Q?8Uqcmlr083BoTFJRyRQJnjZy3xnXJz6LWsPcElD4OjlKX4HjzR2KGqs7C6ym?= =?us-ascii?Q?E0b3SNNS+hX9fOkHTgJL9B1u+LVxCOUwpTowqVEospteuFKPIlGzWlPzRnj4?= =?us-ascii?Q?oBx16B2FpP50zH8LfhzdURxRogUtJkA/LFuIf3wshk4qvJVQc7uvTRcuY+5t?= =?us-ascii?Q?FDLc/kmkpeP+99FtSQB6srmhjXJi7qY31agz23G8vKaK+xeq4AQFhvkFXUOH?= =?us-ascii?Q?/mfBKvvn0yTgv4QeIDUwB3ZtVlYJKSy5VsKdBhhliAV8qoPjKA7F55Bqm+Iv?= =?us-ascii?Q?QqxvMLOrGrbqa1reThkWXPlrVyT+d6UiXWtfpJdnTzy6JQSFIJGI/BdMCZTG?= =?us-ascii?Q?jt/RUK9zclERnZgIBsuHN51BLKR+YotbGkA90G06jeYiiUFhiWs7D8zbu8Na?= =?us-ascii?Q?HhhqayhVlkBYt7JxR8vRw9vKfVJ8+f3wN7Vf6QH9lrW0+h5u5tOguj4ID1h6?= =?us-ascii?Q?GwcpWNVJaeYY9LjZ2CpEPTdu7+vID9/WyM73ib3sVuASTc60P31I31b9IQwf?= =?us-ascii?Q?4G/H5FDVosB7qU4Qgu7THrwZpTNwSg2h9XYLolir3ROoXk+IlTA5M7+caN2l?= =?us-ascii?Q?kVWsmtnsOPBzFuR6New1E4Cz70znYEmk4mI426fit8aEm0tSZIrkqhjEuD0U?= =?us-ascii?Q?uu6X0XlJagjVkCd3UQVV4YLYUu+eqOQJUIA5VEMuOtzcDZAqVVFOf6kKyM1T?= =?us-ascii?Q?db7J2p5BnvnqPhvYxP4jmlSAQp70ps9hpn3Q/BPnOD6tR1YGEa3OndCTDs5V?= =?us-ascii?Q?Cfpe9MiDCANGKYeTP2HOVzuGYXYPTmco5cA3ttUXlzxe34DELZzEMil7xW9u?= =?us-ascii?Q?oJn/2bSacT4GacZ57pkUnFlYAfOrK6DqRENA/K3ANz2ahZ8kz49Z5FX9ftVv?= =?us-ascii?Q?yZwW4vqihpIcqQttEpfV7/yYAOO0riU1/nFNHMmiw/HuuGuOUiB0jISfMGDt?= =?us-ascii?Q?78sZhs58/7AIPWbFWegMxPcWdc4s6W7y6J1bDHLuUcLSz4C/ezyBar9mPyFu?= =?us-ascii?Q?vcVLq25O4DBOx7AMQirvVjnFPTLTfVjVoF/12GlQidzdslt1h+d++6zvPeuJ?= =?us-ascii?Q?dQk5zIEWmWx+jU4TPDQL9MwR3Lpp4M81uf9M1jinHYTXXyjG36DKQO/q7ObK?= =?us-ascii?Q?aGuZ39iAb8Tg9B5KMRv5LKpoTV0FatkGhaqFyEg83gAKXygjhJwf8cuY+ioy?= =?us-ascii?Q?Gw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a88633b2-cacc-4e1a-5217-08da7aa0d063 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2022 07:20:33.5559 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CIRmvQMuEvfaicwjwapcf49Vxb2sJh76NJax0k5w06bUpVpTwmIH+GnIP+0EqSEz8atA/yH19qqTmlhcj3NTkFjfLIQ6P1odfj8o7deet48= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4656 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, V2 of the patch is submitted with suggested changes in __rte_timer_stop()= function. -Harish > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, August 3, 2022 11:19 PM > To: Naga Harish K, S V > Cc: Carrillo, Erik G ; dev@dpdk.org > Subject: Re: [PATCH 3/4] timer: fix rte_timer_stop_all >=20 > On Wed, 3 Aug 2022 11:26:51 -0500 > Naga Harish K S V wrote: >=20 > > there is a possibility of deadlock in this api, as same spinlock is > > tried to be acquired in nested manner. > > > > This patch removes the acquisition of nested locking. > > > > Signed-off-by: Naga Harish K S V >=20 > The wording in this commit message is a little confusing, what is the exa= ct > lock conflict? >=20 > After your patch, there are no longer any callers for c with > the local_is_locked flag. Please resubmit and remove all the the > local_is_locked from __rte_timer_stop(). >=20 > It looks like the test suite for rte_timer is not exercising all the expo= sed API's. > That's a problem