DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	 "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
Subject: RE: [PATCH v2] eventdev/eth_tx: fix runtime parameter test
Date: Wed, 17 May 2023 10:37:39 +0000	[thread overview]
Message-ID: <DM6PR11MB3868FEB00DDC0203B949AC33A17E9@DM6PR11MB3868.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CALBAE1Mc-jZ48mj7mBbm-vKR_a5qYfox_kOvw0kK+kWTx-R1RA@mail.gmail.com>



> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Wednesday, May 17, 2023 1:46 PM
> To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Cc: jerinj@marvell.com; dev@dpdk.org; Jayatheerthan, Jay
> <jay.jayatheerthan@intel.com>
> Subject: Re: [PATCH v2] eventdev/eth_tx: fix runtime parameter test
> 
> On Wed, May 17, 2023 at 11:09 AM Naga Harish K, S V
> <s.v.naga.harish.k@intel.com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Jerin Jacob <jerinjacobk@gmail.com>
> > > Sent: Wednesday, May 17, 2023 10:49 AM
> > > To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > > Cc: jerinj@marvell.com; dev@dpdk.org; Jayatheerthan, Jay
> > > <jay.jayatheerthan@intel.com>
> > > Subject: Re: [PATCH v2] eventdev/eth_tx: fix runtime parameter test
> > >
> > > On Tue, May 2, 2023 at 11:27 AM Naga Harish K S V
> > > <s.v.naga.harish.k@intel.com> wrote:
> > > >
> > > > TX adapter capability check logic is simplified.
> > > > The UT has been updated to skip the test, if the API to set
> > > > runtime parameters is not supported.
> > > >
> > > > Fixes: 1d176c7add08581 ("eventdev/eth_tx: support runtime set/get
> > > > parameters")
> > > >
> > > > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> > > > ---
> > > >  app/test/test_event_eth_tx_adapter.c    | 11 ++++++---
> > > >  lib/eventdev/rte_event_eth_tx_adapter.c | 33
> > > > +++++--------------------
> > > >  2 files changed, 14 insertions(+), 30 deletions(-)
> > >
> > >
> > > Please fix
> > > Is it candidate for Cc: stable@dpdk.org backport?
> > >         eventdev/eth_tx: fix runtime parameter test
> > >
> >
> > This patch (feature) is added in DPDK 23.03 release.
> > So, thinking this fix may need not be backported.
> > Please let me know if it still needs to be backported.
> 
> If there is stable free for 23.03 then we need to do this.
> From patch author PoV(as per policy), we can mark as Cc:
> stable@dpdk.org and stable tree maintainer will do rest.
> 
> The only case where an author does need to add Cc: stable@dpdk.org is
> when, it is fixing something in the current release where a bug is introduced
> in this current release.

All review comments are addressed in V3 version of the patch.

  reply	other threads:[~2023-05-17 10:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-02  5:36 [PATCH] eventdev/eth_tx: fix runtime parameter set API Naga Harish K S V
2023-05-02  5:57 ` [PATCH v2] eventdev/eth_tx: fix runtime parameter test Naga Harish K S V
2023-05-17  5:19   ` Jerin Jacob
2023-05-17  5:39     ` Naga Harish K, S V
2023-05-17  8:15       ` Jerin Jacob
2023-05-17 10:37         ` Naga Harish K, S V [this message]
2023-05-17 10:35   ` [PATCH v3] " Naga Harish K S V
2023-05-17 15:10     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB3868FEB00DDC0203B949AC33A17E9@DM6PR11MB3868.namprd11.prod.outlook.com \
    --to=s.v.naga.harish.k@intel.com \
    --cc=dev@dpdk.org \
    --cc=jay.jayatheerthan@intel.com \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).