From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA95CA04B5; Mon, 26 Oct 2020 03:05:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3CEBD1E2B; Mon, 26 Oct 2020 03:05:21 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 9E6F81D9E for ; Mon, 26 Oct 2020 03:05:17 +0100 (CET) IronPort-SDR: +InMrJq2kvSknuuRT8fe5CP5mfSK1xYsWklORtdDNrTr4tGVMKLqlMUayYgyrTCx71yEv1sTbm Gj34zBvEqSWw== X-IronPort-AV: E=McAfee;i="6000,8403,9785"; a="164371751" X-IronPort-AV: E=Sophos;i="5.77,417,1596524400"; d="scan'208";a="164371751" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2020 19:05:15 -0700 IronPort-SDR: e/DlPvqR3llxWpBuHVHUbFMKdD1/Q3EEhoAmtzi9baZegnZ/Pw4eYXbOh+b77waj3D08zs7fqR tREeSV5wPWiw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,417,1596524400"; d="scan'208";a="360225566" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by FMSMGA003.fm.intel.com with ESMTP; 25 Oct 2020 19:05:15 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 25 Oct 2020 19:05:14 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 25 Oct 2020 19:05:14 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 25 Oct 2020 19:05:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Th7chgDkl8YbcVPJBvIlHM4L+/65sfTP/W/AgFxAcse4OSCbS/FdvzdPFSLiUhUuCySlYMmVNY5eGGsrIn0VCyczZUZsRcpVe0PA0/Rruopcd2IKOv3enNRDDU1ZPOc7dcWPU/vy5WnhBfboL0F86fBWqzMr9WzgejOsqxqgXIoiWbiqsRh0aGchJw+Nh9kYTK7jbwb05vBcxtq7MLDFnw0Shb570FOVUi+SkYSgumOeAEzBnS9vzGceyO3/T/stOjcjpBvzNW56rlLWUp8Y8dyMKuGS4AYv/tUewniFuxvPdLT/aY9UrOxsF2apc96dS86pUJDmt80o/HgQLt+ybw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xhodZuD0EGql/hjYcrvfCzJ76HTr8bX4yYKtnyExvqw=; b=gaucVcr8dIxTN1W6NdrpRihUatk1SmHTo/Uh0TWhc3lyETaoaiuKfKl22qZBe0BSi/L/5hnWOcLKBH/jWKJrf+2Kup9Kl4Hj7zZsDT6qmBGsM0NOm2NtC9+/tqtQj1TzPulERHsxZG8KsmtpjkSYllzrylp9KXvAaGkde6KMb3yNVVSbfNMOhzKAMwM4fl14jUjKwqcgEZp5hb9LjVoi/zt8q/uCeAPnMa02o3MGnC3v7FhSg4oh7x8u/7kvGsmN1jHX8KclfJjljyq+lN+ybA/leaNcHrAwJ6Z+YUZtrPEPFRsHxuwACjILo4HdOQMhCdQsQ0vAGWP5cn7x02gChw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xhodZuD0EGql/hjYcrvfCzJ76HTr8bX4yYKtnyExvqw=; b=ZLI4lhAyvWKslCqUHRqqFjwic7YzhFUZjw5xaXocl7lAgoi7w5IKTM45ovrdgUAgLTPRjm+JhPhhAouGm3oS8BvcxzfHAztmd05NNRPieHCazITN+94pmc8C/RJQdzBfAlq/nfE0ADmsOzMdLKF5I1MwHUk1lGBW95lFnroAugU= Received: from DM6PR11MB3898.namprd11.prod.outlook.com (2603:10b6:5:19f::12) by DM5PR11MB1532.namprd11.prod.outlook.com (2603:10b6:4:a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Mon, 26 Oct 2020 02:05:07 +0000 Received: from DM6PR11MB3898.namprd11.prod.outlook.com ([fe80::a92e:e0e3:fdd5:1e6e]) by DM6PR11MB3898.namprd11.prod.outlook.com ([fe80::a92e:e0e3:fdd5:1e6e%7]) with mapi id 15.20.3499.019; Mon, 26 Oct 2020 02:05:07 +0000 From: "Zhang, AlvinX" To: "Wang, ShougangX" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC] net/i40e: refactor of hash flow Thread-Index: AQHWqQmovzOs9Hmt9EGx1jLqlA6CkKmk3u2AgARC3BA= Date: Mon, 26 Oct 2020 02:05:06 +0000 Message-ID: References: <20201023065616.50116-1-alvinx.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7fadb9c8-1238-4a36-ac17-08d879538fa8 x-ms-traffictypediagnostic: DM5PR11MB1532: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1265; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jrw0z+1uVpkhDFl9TsfmqFaGZ9PKB0PkENV4iEusrL0layKeR9qiFm/3B4bbI2iF5HN2uLNB5/aZOqqrY31t+nk93AR5n/9pJTYt3KbACv2Hua4+x86uGOfi0w04jOofj2pFiEaBnOLu6HNRbywnZ6U5fOuaNMAp2W0vRiEOxoz8zsKo8Msr+D+2t+g2JaBY6Sk/OEG69Ko2og2R11p0N1SdxsOs7yBB54QVasVrnbASeS3h3RvbFYdxUF1KIPlrIrNQt0gbblIrXoGgmXhh5heY/AyMfRfU9K8iHGXZSkXRKPylgB57M4su3S5VHJtpG0HprIvla+jW/qY3qYsjug== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3898.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(346002)(39860400002)(396003)(376002)(76116006)(83380400001)(86362001)(110136005)(71200400001)(66946007)(316002)(64756008)(26005)(52536014)(9686003)(8936002)(2906002)(66476007)(5660300002)(66556008)(8676002)(33656002)(478600001)(186003)(6506007)(55016002)(7696005)(66446008)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Fjv1jBJe6oH3xCEdDjgQwqm9lMxqyCrn6Q7fW21qHeSVMFTca7pTztCE5Gc5dTsOOcysmsqjfzfFUgmIA8yr4DLjvMvBQYseE0BbnoblAZ86nn574NVGQpP3KIA4Yzi4FgtrzRxIkM/7hI8CxLp1jij3dmFQ+2JSECgFSX9oa0XewgRhsA4dbmvq/CGb4GxJaUbLh5ttXsuQcgDtL7hOgDJMSa+ui1kw3qkqFDIO5KU7ty92mOvMW8E3BXH5NZ9K6W1WyX29vqUBAJwRTCICU72D3QdECQOK/IlwwF7Z9E6dYzL7wL015ycqAojgVThHZseKg4UybB0/n7vNp+XebFBHoBrFrl1/L2WS8Kvj13DfKafZJBEIdpTqKpjE1PqYu5zR+s5vaaOSrbDfFXU8tS+TJX8wJneZdapDAouZCfZpB6IShqoyPuesUzS+EX02ms3FnqT3Ibe2DYu9fnnOBz+WpEA1Ec/mRlmptxrkdBurFv4oktBqkWqMGQeplkLs5/pbrpIBH6WptN3OYr5vWV1IKLh9y/YCFVMpZWsE/1IsFWkBOjDNr89YkJCN+PKLPTwxYYVo469jbzy6/vsm1GoL7QtYbRTtUDA6pwMWMt0HbrGzQSTyoHkL9DDfFcua0SFV62KQ6De+Yu6rBBc68Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3898.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fadb9c8-1238-4a36-ac17-08d879538fa8 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2020 02:05:06.9869 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zEkjnkXVT25Uw7GD+hIRESpXjD2VzHf8QmilJ1C0r88Auq/wGftTm84Al9Jb/8ADB4U1kPXy4mT6B8hFtVduww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1532 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC] net/i40e: refactor of hash flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Shougang, Yes, I will update them. BR, Alvin > -----Original Message----- > From: Wang, ShougangX > Sent: Friday, October 23, 2020 4:43 PM > To: Zhang, AlvinX ; dev@dpdk.org > Subject: RE: [dpdk-dev] [RFC] net/i40e: refactor of hash flow >=20 > Hi, Alvin >=20 > > -----Original Message----- > > From: dev On Behalf Of Zhang,Alvin > > Sent: Friday, October 23, 2020 2:56 PM > > To: dev@dpdk.org > > Cc: Zhang, AlvinX > > Subject: [dpdk-dev] [RFC] net/i40e: refactor of hash flow > > > > From: Alvin Zhang > > > > 1. Delete original code. > > 2. Add 2 tables(pattern RSS type matched PCTYPE, RSS type to input set)= . > > 3. Parse RSS pattern and RSS type to get PCTYPE. > > 4. Parse RSS action to get queues, RSS function and hash field. > > 5. Create and destroy RSS filters. > > 6. Create new files for hash flows. > > 7. Update doc. > > > > Signed-off-by: Alvin Zhang > > --- > > doc/guides/nics/i40e.rst | 4 +- > > drivers/net/i40e/i40e_ethdev.c | 840 ++++++------------------- > > drivers/net/i40e/i40e_ethdev.h | 43 +- > > drivers/net/i40e/i40e_flow.c | 617 +------------------ > > drivers/net/i40e/i40e_hash.c | 1315 > > ++++++++++++++++++++++++++++++++++++++++ > > drivers/net/i40e/i40e_hash.h | 34 ++ > > drivers/net/i40e/meson.build | 1 + > > 7 files changed, 1587 insertions(+), 1267 deletions(-) create mode > > 100644 drivers/net/i40e/i40e_hash.c create mode 100644 > > drivers/net/i40e/i40e_hash.h > > > > > diff --git a/drivers/net/i40e/i40e_hash.c > > b/drivers/net/i40e/i40e_hash.c > > > +#define I40E_HASH_VLAN_RSS_MASK (ETH_RSS_S_VLAN | > > ETH_RSS_C_VLAN) > > +#define I40E_HASH_L2_RSS_MASK (ETH_RSS_ETH | > > ETH_RSS_L2_SRC_ONLY | \ > > + ETH_RSS_L2_SRC_ONLY) >=20 > This should be ETH_RSS_L2_DST_ONLY, right? > > + > > +#define I40E_HASH_L23_RSS_MASK (I40E_HASH_L2_RSS_MASK | > > \ > > + I40E_HASH_VLAN_RSS_MASK | \ > > + ETH_RSS_L3_SRC_ONLY | \ > > + ETH_RSS_L3_SRC_ONLY) >=20 > ETH_RSS_L3_DST_ONLY ? >=20 > > + > > +#define I40E_HASH_L234_RSS_MASK (I40E_HASH_L23_RSS_MASK > > | \ > > + ETH_RSS_PORT | > > ETH_RSS_L3_SRC_ONLY | \ > > + ETH_RSS_L3_SRC_ONLY) >=20 > ETH_RSS_L3_DST_ONLY ? >=20 > Thanks > Shougang