DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, AlvinX" <alvinx.zhang@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
	"Guo, Jia" <jia.guo@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix X722 FDIR field mask
Date: Fri, 29 Jan 2021 03:46:02 +0000
Message-ID: <DM6PR11MB38983B7787849459ABAE4F1B9FB99@DM6PR11MB3898.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MN2PR11MB380756CDC6959BCDADE485B9F7B99@MN2PR11MB3807.namprd11.prod.outlook.com>

Hi Beilei,

Thanks for your review.

In theory, RSS does have the same issue, 
but in fact, there is no command to set the mask bit of these field when configuring RSS.

BR,
Alvin

> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Friday, January 29, 2021 11:34 AM
> To: Zhang, AlvinX <alvinx.zhang@intel.com>; Guo, Jia <jia.guo@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] net/i40e: fix X722 FDIR field mask
> 
> 
> 
> > -----Original Message-----
> > From: Zhang,Alvin <alvinx.zhang@intel.com>
> > Sent: Friday, January 29, 2021 10:09 AM
> > To: Guo, Jia <jia.guo@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org
> > Subject: [PATCH] net/i40e: fix X722 FDIR field mask
> >
> > From: Alvin Zhang <alvinx.zhang@intel.com>
> >
> > The absolute field offsets of IPv4 or IPv6 header are related to
> > hardware configuration. The X710 and X722 have different hardware
> > configurations, and users can even modify the hardware configuration.
> > Therefore, The default values cannot be used when calculating mask offset.
> >
> > commands and packets as below:
> >   flow create 0 ingress pattern eth / ipv4 proto is 255  / end
> >   actions queue index 2 / end
> >   pkt = Ether()/IP(ttl=63, proto=255)/Raw('X'*40)
> >
> >   flow create 0 ingress pattern eth / ipv4 tos is 50 / udp / end
> >   actions queue index 2 / end
> >   pkt = Ether()/IP(tos=50)/UDP()/Raw('X'*40)
> >
> >   flow create 0 ingress pattern eth / ipv6 tc is 12 / udp / end
> >   actions queue index 3 / end
> >   pkt = Ether()/IPv6(tc=12,hlim=34,fl=0x98765)/UDP()/Raw('X'*40)
> >
> >   flow create 0 ingress pattern eth / ipv6 hop is 34 / end actions
> >   queue index 3 / end
> >   pkt = Ether()/IPv6(tc=12,hlim=34,fl=0x98765)/Raw('X'*40)
> 
> Not very clear about the issue, the above flows will fail to be created with X722?
> And you fix is for FDIR, does RSS have similar issue?
> 
> Beilei
> 


  reply	other threads:[~2021-01-29  3:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-29  2:09 Zhang,Alvin
2021-01-29  3:34 ` Xing, Beilei
2021-01-29  3:46   ` Zhang, AlvinX [this message]
2021-01-29  5:11   ` Zhang, AlvinX
2021-01-29  3:54 ` Zhou, JunX W
2021-02-01  2:40 ` [dpdk-dev] [PATCH v2] net/i40e: fix inputset " Zhang,Alvin
2021-02-01  3:26   ` Xing, Beilei
2021-03-01  7:06   ` [dpdk-dev] [PATCH v3] " Alvin Zhang
2021-03-09  2:56     ` Chen, LingliX
2021-03-24 11:38       ` Zhang, Qi Z
  -- strict thread matches above, loose matches on Subject: below --
2021-01-29  1:56 [dpdk-dev] [PATCH] net/i40e: fix X722 FDIR " Zhang,Alvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB38983B7787849459ABAE4F1B9FB99@DM6PR11MB3898.namprd11.prod.outlook.com \
    --to=alvinx.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jia.guo@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git