From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E711EA0A02; Fri, 15 Jan 2021 10:50:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BE26140E8A; Fri, 15 Jan 2021 10:50:29 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 09D61140E5B; Fri, 15 Jan 2021 10:50:26 +0100 (CET) IronPort-SDR: Ijfu3WDM+mGOeqJ6alkmY8osm8QxbhXFPfBkfQoHz/6VzKryAHvPt+A4q7KTGz1sOC7EGbgGDh 5jgmg5XWyTcQ== X-IronPort-AV: E=McAfee;i="6000,8403,9864"; a="178613264" X-IronPort-AV: E=Sophos;i="5.79,349,1602572400"; d="scan'208";a="178613264" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2021 01:50:25 -0800 IronPort-SDR: K4mJGu3+7pZ4ctAnT8JcOSTk3A+H9Rljytc7Ps7SuZyOhj7pcbzniVQ/r1nmMU2p5mkMAC/ykf y056XKJFUJlw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,349,1602572400"; d="scan'208";a="354244512" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 15 Jan 2021 01:50:25 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 15 Jan 2021 01:50:24 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 15 Jan 2021 01:50:24 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 15 Jan 2021 01:50:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BTi6g2gYkP3QKFG0ITWTFQc1Nx7KBFUH9S2RaHk6+VS4TQnGG3izXcawt6lCRDTM5KqRf6amuG+pPnZWJxCyyW/GtGFhCfXTBxYfnBCV5/G99PnnBvJsNXs2uWUCM6upAjMrflLPSyHIogZ2Y0Qj9e7+SmD6AMZup/lqNBe+0bIEOUQ3GY0oOGP2J8+aYtj3jBHMBeTLGEgOCd8rjenJ9OhM+oAQh2cqQmP17kNFPC71xhiGI0asvSEJz7H/PpssOLNLFZ4Toh+CaptsOu6suEavl8zu9vzOESygdOmv9flXWdWMMrIHATxMMfGUkN1oV8KRksZOjUdj01DY2osZoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OA8JATEPlxvWYGQGoq3m72v6wCumyx0JJ4oM15DnYCA=; b=JL+TSvBwsEmd/qGDuesP8VCYKk/nZIL9Tco0mHnhbrwE0jN28Vd563hFJXtyteMl96Ic4mtYESzLUOckPHIMx3JY8IpY0lRO3zMA+7iVYKfWrkBNgPkZ7mheQeO7tVL1gibQHzrHNCBVHa2pmlo/eERkSPXAroRevpYoSAUN1NWe5ymDx7ouqnIB3eCAFc6boCtd4/lIrTUkFbH7a64DKcDIlYuu85uZLVDGpUQpHr4X3QIWmPtsdM/G6d9V+qD+7RUikMvTj/ZFCXex6xXozBK8pEzwtdYMXhkdBPG3JgxYjuXsod9uQkhHbM3DieNraX0U0GHQODssicCAE/lGIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OA8JATEPlxvWYGQGoq3m72v6wCumyx0JJ4oM15DnYCA=; b=AfGGhTlP7GmgsznKo7PKuVmTt8LXJbn0ZxH5ojPz5S62lhoVnHfJ93fnY1mmkw3e+JPltkFaoavmcH3EgGI3xZQYXtsgnSFFXaEa1c7hhQM7RTrfbzkozON7IDd/t8Q3buqJim6M6cYUuptwqMJRIEM8pvJR5s27bNk5Mtrzl7s= Received: from DM6PR11MB3898.namprd11.prod.outlook.com (2603:10b6:5:19f::12) by DM6PR11MB3132.namprd11.prod.outlook.com (2603:10b6:5:69::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Fri, 15 Jan 2021 09:50:21 +0000 Received: from DM6PR11MB3898.namprd11.prod.outlook.com ([fe80::cc62:30d:7ddd:cb3e]) by DM6PR11MB3898.namprd11.prod.outlook.com ([fe80::cc62:30d:7ddd:cb3e%7]) with mapi id 15.20.3763.010; Fri, 15 Jan 2021 09:50:21 +0000 From: "Zhang, AlvinX" To: "Guo, Jia" , "Wang, Haiyue" , "Xie, WeiX" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3] net/ixgbe: fix configuration of max frame size Thread-Index: AQHW6wwsYh2hvsZcf0yIcgODMlmFA6ooVwCAgAAUCbA= Date: Fri, 15 Jan 2021 09:50:20 +0000 Message-ID: References: <20210115023126.26248-1-alvinx.zhang@intel.com> <20210115070029.2768-1-alvinx.zhang@intel.com> <6a633c4729aa49e6a9473d5e78edff60@intel.com> In-Reply-To: <6a633c4729aa49e6a9473d5e78edff60@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.39] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 448b977b-2ef4-4af6-a1b3-08d8b93af90b x-ms-traffictypediagnostic: DM6PR11MB3132: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U8+2fAY3WA19+SJJTlQzjlKMgAf4OrNIH8VBzFBWfwoSdNWiF3+wb2le70zIYT0eYlBjMFlDklMEiyYYaeirAh7A2SiyolzXhAIZj+9AW2naiCDXCutCn5YGOt/4o092ndYq4CITBhB0WI4r3PXlkPkRMsgzuOx3igOFo8wFzZ5pt9V6ShZ9T3azewTTKnFGB+BK8zsSE2vcw/I/LFhvtflCMWyI2+AA90hM04z6parES2vT+3d6IiZ1gB2Y+uGzjJWEyZ63lvUz+5eBfydJnKj+qCAXqsX5zMg7J0E+oVejvnzJN0Pn69sMCdPHwrSK5yWmPqtewQo/eeHIPxih6XrlmvPn/ntoaO8FI9gH3q23xmSC02nMO22dKPGDJvoIiVWkmbHvMKXjtjV9em9azw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3898.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(366004)(396003)(346002)(39860400002)(450100002)(2906002)(6506007)(316002)(64756008)(53546011)(4326008)(33656002)(71200400001)(110136005)(7696005)(54906003)(478600001)(83380400001)(66556008)(66446008)(9686003)(52536014)(26005)(6636002)(8676002)(76116006)(55016002)(5660300002)(186003)(8936002)(66476007)(66946007)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ElIw0BGbcI3XSr6k9d3ag8wEjzwAWoIBqeB8XCesiiqzfa1Gn8TXPbe03s3I?= =?us-ascii?Q?1MiChxc8IJGNaqusbyX62qusxlA2dbhY9nLlT1H4RrQsONGgHWwFidQHxvKc?= =?us-ascii?Q?lTAYHheEXUSn+qziX/zIFpFXalokuvSS413DQkH5SLxpGtVo32w46q2V614T?= =?us-ascii?Q?K5gN9zeaehGciMs8tVhG9gPJbrwGZ/khdbrl84dRUaDKTevd1M2SWxCy9Q6Z?= =?us-ascii?Q?mvcyuYP7y/Ber+670ddfrG9Rc7EGJPxNnr9V31mbhPmPPDbZTFgg9eU+Whvl?= =?us-ascii?Q?ybLu/I36i2BpfoLbES9/FP5SrOVs/cQvfuDCUNTDtd3Qnl2LkzyNnNzfNaYE?= =?us-ascii?Q?kx0a2tfo/JXpvHH3npzQEZl378wSdWLlB8LkpK9TmRe1BcQsGAl2WwuWwTAh?= =?us-ascii?Q?VNh988kM87pfKCb+gdq46huAzH0sH33us2m9bJ1ouHqY26ijxXsRTWubbt67?= =?us-ascii?Q?q1V0X56P2ih6/K55SMNxvVXRlx/ghna1xTeQizTfSutQ/BFBKbISbbR9wHwJ?= =?us-ascii?Q?WGxdodo5EnBjoDxP5PpES5KZPjChv8DYoaPS1Z6iS1Mnd9/TizIe9S39ZBcd?= =?us-ascii?Q?B5KTJSRASB5SavawDIIrvUg+lryn0RbpWaQMG/KoPkYpQZExc4a6Ki9t0dwC?= =?us-ascii?Q?pOyiZPIUAoVjIhRrBfk82AtwbSU+vRh4QnlM62QJDG2UUmHQWjAaXQG21j7V?= =?us-ascii?Q?3XuHd9v/rI1PHFeNS3f14tcX+PgsIYAtDUrDhwFLz0fBnmQVgpfvCjlz4orY?= =?us-ascii?Q?mdPLe7z0C0wErHXCSAtMuJbdjvR5rHZzvym3IcktqI+/usemNAtfi3xdItdB?= =?us-ascii?Q?k14kNdYZbI1Rvy9soKrJwZO+0HF+DwDYwFLQPwSGlL73GcFaOIXaNPn0E6nU?= =?us-ascii?Q?MDCsKdqo4lzSqsZMZ8+xgbruK6qML1zzleONc2+MOnEaj77H5HLF1s/nJ+8T?= =?us-ascii?Q?awo/Xjs+4lT0jZ99meWr60QT3+EGDouu4vmMjiK/FR8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3898.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 448b977b-2ef4-4af6-a1b3-08d8b93af90b X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2021 09:50:20.9006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lWG/lVOLhW2riJSk+9B4Nl/Xcy5nw0AH+AvVupGMGfvxsHwf6YkaTgFrBbD3/6E4dq3u4Ffo20DjwoRfVBp/lA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3132 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix configuration of max frame size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Guojia, Thanks for you reply. I will modify as we discussion. > -----Original Message----- > From: Guo, Jia > Sent: Friday, January 15, 2021 4:15 PM > To: Zhang, AlvinX ; Wang, Haiyue > ; Xie, WeiX > Cc: dev@dpdk.org; Zhang, AlvinX ; stable@dpdk.org > Subject: RE: [PATCH v3] net/ixgbe: fix configuration of max frame size >=20 > Hi, Alvin >=20 > > -----Original Message----- > > From: Zhang,Alvin > > Sent: Friday, January 15, 2021 3:00 PM > > To: Guo, Jia ; Wang, Haiyue > > ; Xie, WeiX > > Cc: dev@dpdk.org; Zhang, AlvinX ; > > stable@dpdk.org > > Subject: [PATCH v3] net/ixgbe: fix configuration of max frame size > > > > From: Alvin Zhang > > > > For 82599 NIC, jumbo frame feature is not supported in IOV mode, but > > if a VF requests to configure the frame size to that not bigger than > > RTE_ETHER_MAX_LEN, the PMD should not return -1. > > This patch keeps ixgbe PMD's handling mode consistent with kernel > > driver in above situation. > > >=20 > Why it should not return -1 and what is the kernel driver behaviors relat= ed with > this patch? >=20 > > In addition, the value set by the command IXGBE_VF_SET_LPE represents > > the max frame size, not the mtu. > > > > Fixes: 1b9ea09c067b ("ixgbe: support X550") > > Fixes: 95a27b3ba5f5 ("net/ixgbe: enable jumbo frame for VF") > > Cc: stable@dpdk.org > > > > Signed-off-by: Alvin Zhang > > --- > > > > V3: Restore variable name from cur_frame_size to max_frs. > > --- > > drivers/net/ixgbe/ixgbe_pf.c | 17 ++++++++++------- > > 1 file changed, 10 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_pf.c > > b/drivers/net/ixgbe/ixgbe_pf.c index 833863a..1ffde56 100644 > > --- a/drivers/net/ixgbe/ixgbe_pf.c > > +++ b/drivers/net/ixgbe/ixgbe_pf.c > > @@ -555,17 +555,20 @@ int ixgbe_pf_host_configure(struct rte_eth_dev > > *eth_dev) ixgbe_set_vf_lpe(struct rte_eth_dev *dev, __rte_unused > > uint32_t vf, uint32_t *msgbuf) { struct ixgbe_hw *hw =3D > > IXGBE_DEV_PRIVATE_TO_HW(dev->data- > > >dev_private); > > -uint32_t new_mtu =3D msgbuf[1]; > > +uint32_t max_frame =3D msgbuf[1]; > > uint32_t max_frs; > > uint32_t hlreg0; > > -int max_frame =3D new_mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN; > > > > /* X540 and X550 support jumbo frames in IOV mode */ if > > (hw->mac.type !=3D ixgbe_mac_X540 && hw->mac.type !=3D ixgbe_mac_X550 > && > > hw->mac.type !=3D ixgbe_mac_X550EM_x && > > -hw->mac.type !=3D ixgbe_mac_X550EM_a) > > -return -1; > > +hw->mac.type !=3D ixgbe_mac_X550EM_a) { > > +if (max_frame > dev->data- > > >dev_conf.rxmode.max_rx_pkt_len) >=20 > This condition is only for X540/X550? >=20 > > +return -1; > > + > > +return 0; > > +} > > >=20 > Assume that return 0 means success to set vf lpe, return -1 means failed = to set vf > lpe. If it is not support in VF, why return 0? >=20 > > if (max_frame < RTE_ETHER_MIN_LEN || > > max_frame > > > RTE_ETHER_MAX_JUMBO_FRAME_LEN) @@ -573,9 +576,9 @@ int > > ixgbe_pf_host_configure(struct rte_eth_dev *eth_dev) > > > > max_frs =3D (IXGBE_READ_REG(hw, IXGBE_MAXFRS) & > > IXGBE_MHADD_MFS_MASK) >> > > IXGBE_MHADD_MFS_SHIFT; > > -if (max_frs < new_mtu) { > > +if (max_frs < max_frame) { > > hlreg0 =3D IXGBE_READ_REG(hw, IXGBE_HLREG0); -if (new_mtu > > > RTE_ETHER_MAX_LEN) { > > +if (max_frame > RTE_ETHER_MAX_LEN) { > > dev->data->dev_conf.rxmode.offloads |=3D > DEV_RX_OFFLOAD_JUMBO_FRAME; > > hlreg0 |=3D IXGBE_HLREG0_JUMBOEN; > > @@ -586,7 +589,7 @@ int ixgbe_pf_host_configure(struct rte_eth_dev > > *eth_dev) > > } > > IXGBE_WRITE_REG(hw, IXGBE_HLREG0, hlreg0); > > > > -max_frs =3D new_mtu << IXGBE_MHADD_MFS_SHIFT; > > +max_frs =3D max_frame << IXGBE_MHADD_MFS_SHIFT; > > IXGBE_WRITE_REG(hw, IXGBE_MAXFRS, max_frs); } > > > > -- > > 1.8.3.1 >=20