From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77A20A0093; Wed, 20 May 2020 09:56:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05C7A1D162; Wed, 20 May 2020 09:56:40 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 610831D14A for ; Wed, 20 May 2020 09:56:37 +0200 (CEST) IronPort-SDR: xhUDiTUJPd3hhD4nzXVazjnV/SjRhb5FtuXjxDzOWVcRcozu/OPjrwnj22Tbn1JIw30XD+meso mArMwWVJ8aAw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 00:56:36 -0700 IronPort-SDR: Fmi48Ikl+djvMF7wFZ3vz/BYo68jCFMCv48OOIbjxuid8EzcU+CIDo4bdLB18MkQY2cjD12gIs avSM1O4HxhNg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,413,1583222400"; d="scan'208";a="466438072" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 20 May 2020 00:56:36 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 00:56:36 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 00:56:35 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 00:56:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cruY7zR+HxH7pzD7WzZ/cGXxyW9nrYIJMUqvWa1Sv78W6rBQsr/x8zd80vvEO7TDathumAA47KVgWzgDeJC2Qdgz3P+nURT4F4tZimINU1LYhg9dwjwT+XVR6hQpv79cUJumdAmAhXXfNDSukZhdhEJZHiAF0pzh16AFlubkzaoIi1KMvIfWb1OXbWKTDhL2KvmKWqLpXmUO7uxMckx008Po0Ex8JpeGWFbyKN93/MhF1sv6XJ7FqLzTewcxEG01b5hEZXZjsiajgOsF/D2SwuUcfiDWV8Y9VQvDL/JsDCLwK2RaVkXyB1XLoxp6d0+IhtWcq5u7uoZUUjyHpv7LhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EuJQnyNGv4SHB8XAHqEQlUA5Bw+OirtjQcbFE7iW3ZQ=; b=NtKjai3LW7dAs4Bo9KAKhYM8rxwqVAJa0ZCE0v6rVzkQScA6cfcblNTPYYAJJJsW/HqtT3OpmLnUtw7h5iEaWQ4ruNEvP0TkDV/5eFEi1GO5fyIFxlIkU67GjHSRGk2c11s/gVxURIPC5CQY1rgP+BHkg8PV3NQ4hxv9wrsEaOrqvejQcyDHw4Vkj4q/lwhTazEnpKUyny9Lye3vtIUv567xSNgxfXRxmUa5/ndtZjsLe/sVmQUS5K0wle1o4x3NFoWg+iTwW8W0RKjDWJV2qPRQZ7rXzr4sPareh1xHUqi30XTJvxU1lA5M2VLpbAjpaJDOt8qpxu+3r81nS393rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EuJQnyNGv4SHB8XAHqEQlUA5Bw+OirtjQcbFE7iW3ZQ=; b=k3h/N1glql+NERzi2AybmIenw3JJPsaDudANQRoHWGobwVOrU3ZacpTehihql1TWrWqbBBYiBIwzGwkECanDp7Vdy07yvigzdiJV+k1c0os+X2DS2nRROFAuLb+/cmlHc7EP1GNy7tBljdnxBOdbiv80cUaPnvPs0/0OyThWORI= Received: from DM6PR11MB3898.namprd11.prod.outlook.com (2603:10b6:5:19f::12) by DM6PR11MB2858.namprd11.prod.outlook.com (2603:10b6:5:bd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23; Wed, 20 May 2020 07:56:34 +0000 Received: from DM6PR11MB3898.namprd11.prod.outlook.com ([fe80::4825:cee0:6bed:6354]) by DM6PR11MB3898.namprd11.prod.outlook.com ([fe80::4825:cee0:6bed:6354%7]) with mapi id 15.20.3000.034; Wed, 20 May 2020 07:56:34 +0000 From: "Peng, Yuan" To: "Rong, Leyi" , "Wu, Jingjing" , "Xing, Beilei" , "Ye, Xiaolong" CC: "dev@dpdk.org" , "Rong, Leyi" Thread-Topic: [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured Thread-Index: AQHWLnMh1zOq/uAUJkOxENrmafysA6iwm0eA Date: Wed, 20 May 2020 07:56:34 +0000 Message-ID: References: <20200520063950.50315-1-leyi.rong@intel.com> In-Reply-To: <20200520063950.50315-1-leyi.rong@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.204] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 53798efa-d3a1-4cc7-6026-08d7fc9350d7 x-ms-traffictypediagnostic: DM6PR11MB2858: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1247; x-forefront-prvs: 04097B7F7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2d5JfsQlaUqskqk8mqkYHg5PRlegX7HDllOutFJo7ek4ttYpugdEHonPB1qn7SAF41jjf/baEDMuIt5NwiS9CibTYvQKR7Z+s2AVUlM+rWzGam+U1EHGGEgw1wNx9Y38avCVs9/U7XSjvX+RXVdW2QNwF35/5SnqENK7Ae5e1T581hBD5OQu+yct2wQPRm//3TZj20KT0RF8gwN7kgs1jeACfgZAsXcI1uHzl8kB+Gw+Hk/S/MmCGWC2/dFZiy2G6GxQSVOkk08diQVtJhV4F9ODhvtnIvAOhfFxJYd8Iodl5TQ6NbyvkZ7eqxv0axZHan4LWKfMl0neyFi871iaeg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3898.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(366004)(39860400002)(376002)(396003)(346002)(71200400001)(55016002)(107886003)(86362001)(26005)(52536014)(316002)(64756008)(66946007)(7696005)(186003)(53546011)(6506007)(76116006)(54906003)(33656002)(66476007)(66446008)(66556008)(9686003)(6636002)(5660300002)(110136005)(478600001)(2906002)(4326008)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: wiJWbu/ZWiHDSffdw+hwTms/DZplDYRYNBtLMJsIA0CA9oOFpOtktpOlw6CVMgOD4RDWJUzdq0BBkI0Qb3PN1e3a3oeF1qxVp9yxtqw8MMVGIWg83HGV2UCTCrYdVH2aDFHF/P/qCQgQahhTTE/4mKB5eejurC8+y4aal4yJHHxQILM4FLudgX3XwWYMVkqzTdM3BpErdCqUCjUt+a9wVkIihf0fvgbLqVxMRR3m7pFrZqaTmXBUQ76pPBVPX8yppGB8r8NtaEpA4w8lBHHo2jqZUZF81QqdfxNjQBEfCry+4WGxRnaLttTL+HR1HKDmFp1mRCZT4y47SG1AeaCzdxgW5QAlGNYIEumoKKpr5c1qDoWFjR/LQHEGE+xdCKRUqmepTeKEn4U81ObvFhZwpUmvdKfq1AmVo9+Ie08q9EWK477kiJkR9fmn73KFYVwMuPCTe3yR+mxqs4pDlO6hD+pm9dQ9JEiH7g2Sz7OJYuA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 53798efa-d3a1-4cc7-6026-08d7fc9350d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2020 07:56:34.1649 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ehJ4y68nqjPPcYrKMzUD/vsgnVFqKlR1M3X4dVuzEw0stU0H4p3Y9nSwE9TAKIji86Ib/uwKVdnmPIQtrDzacg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2858 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Test-by Peng, Yuan -----Original Message----- From: dev On Behalf Of Leyi Rong Sent: Wednesday, May 20, 2020 2:40 PM To: Wu, Jingjing ; Xing, Beilei ; Ye, Xiaolong Cc: dev@dpdk.org; Rong, Leyi Subject: [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue= reconfigured FDIR ID parsing will not be handled correctly after queue reconfigured, ena= ble FDIR ID parsing per Q regardless of fdir_ref_cnt to fix it. Fixes: f71dbf852d46 ("net/iavf: add flow director enabled switch value") Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h in= dex 73968847f..59625a979 100644 --- a/drivers/net/iavf/iavf_rxtx.h +++ b/drivers/net/iavf/iavf_rxtx.h @@ -509,8 +509,8 @@ void iavf_fdir_rx_proc_enable(struct iavf_adapter *ad, = bool on) { if (on) { /* enable flow director processing */ - if (ad->fdir_ref_cnt++ =3D=3D 0) - FDIR_PROC_ENABLE_PER_QUEUE(ad, on); + FDIR_PROC_ENABLE_PER_QUEUE(ad, on); + ad->fdir_ref_cnt++; } else { if (ad->fdir_ref_cnt >=3D 1) { ad->fdir_ref_cnt--; -- 2.17.1