* [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured
@ 2020-05-20 6:39 Leyi Rong
2020-05-20 7:10 ` Ye Xiaolong
2020-05-20 7:56 ` Peng, Yuan
0 siblings, 2 replies; 3+ messages in thread
From: Leyi Rong @ 2020-05-20 6:39 UTC (permalink / raw)
To: jingjing.wu, beilei.xing, xiaolong.ye; +Cc: dev, Leyi Rong
FDIR ID parsing will not be handled correctly after queue reconfigured,
enable FDIR ID parsing per Q regardless of fdir_ref_cnt to fix it.
Fixes: f71dbf852d46 ("net/iavf: add flow director enabled switch value")
Signed-off-by: Leyi Rong <leyi.rong@intel.com>
---
drivers/net/iavf/iavf_rxtx.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h
index 73968847f..59625a979 100644
--- a/drivers/net/iavf/iavf_rxtx.h
+++ b/drivers/net/iavf/iavf_rxtx.h
@@ -509,8 +509,8 @@ void iavf_fdir_rx_proc_enable(struct iavf_adapter *ad, bool on)
{
if (on) {
/* enable flow director processing */
- if (ad->fdir_ref_cnt++ == 0)
- FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
+ FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
+ ad->fdir_ref_cnt++;
} else {
if (ad->fdir_ref_cnt >= 1) {
ad->fdir_ref_cnt--;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured
2020-05-20 6:39 [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured Leyi Rong
@ 2020-05-20 7:10 ` Ye Xiaolong
2020-05-20 7:56 ` Peng, Yuan
1 sibling, 0 replies; 3+ messages in thread
From: Ye Xiaolong @ 2020-05-20 7:10 UTC (permalink / raw)
To: Leyi Rong; +Cc: jingjing.wu, beilei.xing, dev
On 05/20, Leyi Rong wrote:
>FDIR ID parsing will not be handled correctly after queue reconfigured,
>enable FDIR ID parsing per Q regardless of fdir_ref_cnt to fix it.
>
>Fixes: f71dbf852d46 ("net/iavf: add flow director enabled switch value")
>
>Signed-off-by: Leyi Rong <leyi.rong@intel.com>
>---
> drivers/net/iavf/iavf_rxtx.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h
>index 73968847f..59625a979 100644
>--- a/drivers/net/iavf/iavf_rxtx.h
>+++ b/drivers/net/iavf/iavf_rxtx.h
>@@ -509,8 +509,8 @@ void iavf_fdir_rx_proc_enable(struct iavf_adapter *ad, bool on)
> {
> if (on) {
> /* enable flow director processing */
>- if (ad->fdir_ref_cnt++ == 0)
>- FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
>+ FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
>+ ad->fdir_ref_cnt++;
> } else {
> if (ad->fdir_ref_cnt >= 1) {
> ad->fdir_ref_cnt--;
>--
>2.17.1
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel, Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured
2020-05-20 6:39 [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured Leyi Rong
2020-05-20 7:10 ` Ye Xiaolong
@ 2020-05-20 7:56 ` Peng, Yuan
1 sibling, 0 replies; 3+ messages in thread
From: Peng, Yuan @ 2020-05-20 7:56 UTC (permalink / raw)
To: Rong, Leyi, Wu, Jingjing, Xing, Beilei, Ye, Xiaolong; +Cc: dev, Rong, Leyi
Test-by Peng, Yuan <yuan.peng@intel.com>
-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of Leyi Rong
Sent: Wednesday, May 20, 2020 2:40 PM
To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com>
Subject: [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured
FDIR ID parsing will not be handled correctly after queue reconfigured, enable FDIR ID parsing per Q regardless of fdir_ref_cnt to fix it.
Fixes: f71dbf852d46 ("net/iavf: add flow director enabled switch value")
Signed-off-by: Leyi Rong <leyi.rong@intel.com>
---
drivers/net/iavf/iavf_rxtx.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index 73968847f..59625a979 100644
--- a/drivers/net/iavf/iavf_rxtx.h
+++ b/drivers/net/iavf/iavf_rxtx.h
@@ -509,8 +509,8 @@ void iavf_fdir_rx_proc_enable(struct iavf_adapter *ad, bool on) {
if (on) {
/* enable flow director processing */
- if (ad->fdir_ref_cnt++ == 0)
- FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
+ FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
+ ad->fdir_ref_cnt++;
} else {
if (ad->fdir_ref_cnt >= 1) {
ad->fdir_ref_cnt--;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-20 7:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 6:39 [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured Leyi Rong
2020-05-20 7:10 ` Ye Xiaolong
2020-05-20 7:56 ` Peng, Yuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).