From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 352D8A04F3; Wed, 8 Jan 2020 17:17:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 13BE11DAD0; Wed, 8 Jan 2020 17:17:20 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 66ADB1DAC9 for ; Wed, 8 Jan 2020 17:17:18 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2020 08:17:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,410,1571727600"; d="scan'208";a="211584975" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 08 Jan 2020 08:17:17 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Jan 2020 08:17:13 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 8 Jan 2020 08:17:12 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 8 Jan 2020 08:17:12 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Jan 2020 08:17:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TVxZFmW/azWTbgyFlYWWKZLRA5IuT80LPZqpaTZFwlcoOxznDPAPHqOSxsAwBsDzsiw2hbReWT3B5GikTgr7odRLm435yNtm3RAVqb/Ap8nZUavhzXbEWDHW0dx4hRqvjE9LDFQSyghvw5gT9FTdU3g8bxWmMw6JHl58AjoeSMjbV6wyAw3vg+k9ZJDPkaSS1MlkONP5+hjg8NpTLmypViybNkj3w2vlY9Nrv0WLDaxZlFPTVCN4IR+Ni9r8dgA+jjfZ1rYt5JoBtxcmcA/81kPWGcNQnoIG15ZH6L8AQL6z/qo6IqwMImmJJ47rSh/Y5t6RVkozqrvTDy8l0lKu/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eHFn34o6Cmd1mRmFgNYOle+HpCt9o39a36odgiD0NHk=; b=YmqR9wDeGIuk0Ny95Tqk7fSql0loNDJpqy9Z2avkN/9GcOVQnrTZW/esp4EuVUDUUarzYAOiwZgK3v7rrA4yOHcnyJK1TOCXdrE1rHxQHwtUDQcZKwZ6H110kWzZPFKUFEPJ0tfOTSzwhfYy9f9UjYFR/JPtTBheCi9U7ITCfOgyGU3vAu+Lhv+YngSUG/9MnNr7roMytHZ5eSCtYKpHANsL4XQ9UASWJ0hN4amJUbsW/2J2HOF/55Yvj30BWcYdTObZuc73WQasGxy3+rx/ftRoI97ZzjX8uFFZ6li1rXDRyoZQ02noOhXaaPUkBar9qZLYu6M3xKtTp5yevWIODQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eHFn34o6Cmd1mRmFgNYOle+HpCt9o39a36odgiD0NHk=; b=MdYbDLXQ02I6hD3XAxeXVKlE1ywnN9glynRWeCnSpchNpvDk0YQr8RFC9LzLlpy505bknqQERZizgRDrobw4Whk2JhNuruDjeLBcmLc1PiewoQQ13o3jEA71ulIAPJ8OxWI+X3RTzPyTxIXo8KgEAgSw9T46hsKf0ocwWJ1CeQI= Received: from DM6PR11MB3914.namprd11.prod.outlook.com (20.176.126.24) by DM6PR11MB4074.namprd11.prod.outlook.com (10.255.61.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.9; Wed, 8 Jan 2020 16:16:51 +0000 Received: from DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::29bf:9a8f:7bba:dd26]) by DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::29bf:9a8f:7bba:dd26%6]) with mapi id 15.20.2602.016; Wed, 8 Jan 2020 16:16:51 +0000 From: "Iremonger, Bernard" To: Ori Kam , "dev@dpdk.org" , "Xing, Beilei" , "Zhang, Qi Z" , "Doherty, Declan" CC: "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow command line for ESP Thread-Index: AQHVxjIfztr0l6FXDkOlg6dlbZfwH6fg8CtA Date: Wed, 8 Jan 2020 16:16:51 +0000 Message-ID: References: <1575982632-23059-1-git-send-email-bernard.iremonger@intel.com> <1576577756-648-2-git-send-email-bernard.iremonger@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzkwNDM5NjItZjJiZS00OWQ2LTgzMjItNDQ2N2RlZjhlYzQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ21obzBZMjB6WVZtdUlvWU9FYUJoSmpCcVhQNUxtRVBtd200M1ZBUEJwVFYzcXJubStKZXgra25ibVVOWEx3ViJ9 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=bernard.iremonger@intel.com; x-originating-ip: [192.198.151.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 86c83bff-99dd-40ed-8f1f-08d794562b77 x-ms-traffictypediagnostic: DM6PR11MB4074: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 02760F0D1C x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(39860400002)(396003)(346002)(136003)(366004)(51914003)(13464003)(15404003)(189003)(199004)(76116006)(316002)(5660300002)(9686003)(33656002)(107886003)(478600001)(71200400001)(53546011)(110136005)(4326008)(7696005)(6506007)(66446008)(64756008)(66476007)(86362001)(2906002)(66556008)(52536014)(81156014)(55016002)(186003)(81166006)(66946007)(6636002)(26005)(8936002); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR11MB4074; H:DM6PR11MB3914.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Og6GRwumCnPNM2tv0aFASek8SrHpw10S2Spc85uNGPHMJZxgH0cpWZLVAA+uYTN5rbJg3fjQjfft8wbbHfqSOAmKpZNLAo5hrV7LrrshHP9uQcws568Tqu7x/BsSIeJJIfXl8laEK34VPhzOOqrVok5tanKG7XLrXR93URpICNvzv3i09RTJEBgNwnSQNqQWgDkvfXgB3QLrSzVtm3BXc9qwRZf1BeMQZBtOT2IDMYErH/x5wa0/CpY5A43DDbKo45YUjEAe5DnDFqmYuRJes57thWHvTrjfQQ16i5tQy9ykFqNIU/EObOCmvY+gDLdzHHjMNDkJD3OSuLM8KNjZLWxOJFUzpmSbcQOkMkGdEQ63ppanFHXD1ZoBSRzonzopxcZxFfSSqYlTJrqr5uZSlP0FBu3s+UYVTRoRKQckAbkNbJihFcVz5VjoNnupUSmzVoPFWuJRPCobkmTApCyKz5UOygcSViuKvZmoXkX8C8cXYKIX5R7xCD2KOlzTqh3KyzywgFGTNNXQlWWDk+DgzcTnKnLBBQwphEajTkKJy4I= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 86c83bff-99dd-40ed-8f1f-08d794562b77 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2020 16:16:51.1839 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: du0v86G1kkPZBUTzpqf8oxEritksv2QcpZ/TSqB2P5YUmFc6bcwRiOBo7CiFEHwC72N08hbES1qzHK3JA1T0JXeS9Z6Mbbd7uoyjZNpLK0U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4074 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow command line for ESP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ori, Thanks for the review. > Subject: RE: [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow > command line for ESP >=20 > Hi just small comment inside. > Thanks, > Ori >=20 > > -----Original Message----- > > From: dev On Behalf Of Bernard Iremonger > > Sent: Tuesday, December 17, 2019 12:16 PM > > To: dev@dpdk.org; beilei.xing@intel.com; qi.z.zhang@intel.com; > > declan.doherty@intel.com > > Cc: konstantin.ananyev@intel.com; bernard.iremonger@intel.com > > Subject: [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow command > > line for ESP > > > > add ITEM_ESP > > add ITEM_ESP_SPI > > add debug to cmdline_flow.c > > > > Signed-off-by: Bernard Iremonger > > --- > > app/test-pmd/cmdline_flow.c | 37 > > ++++++++++++++++++++++++++++++++++--- > > 1 file changed, 34 insertions(+), 3 deletions(-) > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index 99dade7..f1b0610 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -213,6 +213,8 @@ enum index { > > ITEM_TAG, > > ITEM_TAG_DATA, > > ITEM_TAG_INDEX, > > + ITEM_ESP, > > + ITEM_ESP_SPI, > > > > /* Validate/create actions. */ > > ACTIONS, > > @@ -746,6 +748,7 @@ static const enum index next_item[] =3D { > > ITEM_PPPOE_PROTO_ID, > > ITEM_HIGIG2, > > ITEM_TAG, > > + ITEM_ESP, > > END_SET, > > ZERO, > > }; > > @@ -1017,6 +1020,12 @@ static const enum index item_higig2[] =3D { > > ZERO, > > }; > > > > +static const enum index item_esp[] =3D { > > + ITEM_ESP_SPI, > > + ITEM_NEXT, > > + ZERO, > > +}; > > + > > static const enum index next_set_raw[] =3D { > > SET_RAW_INDEX, > > ITEM_ETH, > > @@ -2593,6 +2602,20 @@ static const struct token token_list[] =3D { > > NEXT_ENTRY(ITEM_PARAM_IS)), > > .args =3D ARGS(ARGS_ENTRY(struct rte_flow_item_tag, > index)), > > }, > > + [ITEM_ESP] =3D { > > + .name =3D "esp", > > + .help =3D "match ESP header", > > + .priv =3D PRIV_ITEM(ESP, sizeof(struct rte_flow_item_esp)), > > + .next =3D NEXT(item_esp), > > + .call =3D parse_vc, > > + }, > > + [ITEM_ESP_SPI] =3D { > > + .name =3D "spi", > > + .help =3D "security policy index", > > + .next =3D NEXT(item_esp, NEXT_ENTRY(UNSIGNED), > > item_param), > > + .args =3D ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_esp, > > + hdr.spi)), > > + }, > > /* Validate/create actions. */ > > [ACTIONS] =3D { > > .name =3D "actions", > > @@ -6052,6 +6075,9 @@ cmd_flow_tok(cmdline_parse_token_hdr_t > **hdr, > > static void cmd_flow_parsed(const struct buffer *in) { > > + printf("Flow command line parsed successfully for > > command=3D%d.\n", > > + in->command); > > + >=20 > Why adding this printf? It is useful to know that the parsing of the flow command line is successfu= l before going into the PMD code. I will remove in the v3 if you think it is too verbose. >=20 > > switch (in->command) { > > case VALIDATE: > > port_flow_validate(in->port, &in->args.vc.attr, @@ -6230,14 > > +6256,15 @@ flow_item_default_mask(const struct rte_flow_item *item) > > case RTE_FLOW_ITEM_TYPE_GTP: > > mask =3D &rte_flow_item_gtp_mask; > > break; > > - case RTE_FLOW_ITEM_TYPE_ESP: > > - mask =3D &rte_flow_item_esp_mask; > > - break; > > case RTE_FLOW_ITEM_TYPE_GTP_PSC: > > mask =3D &rte_flow_item_gtp_psc_mask; > > break; > > case RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID: > > mask =3D &rte_flow_item_pppoe_proto_id_mask; > > + break; > > + case RTE_FLOW_ITEM_TYPE_ESP: > > + mask =3D &rte_flow_item_esp_mask; > > + break; > > default: > > break; > > } > > @@ -6327,6 +6354,10 @@ cmd_set_raw_parsed(const struct buffer *in) > > case RTE_FLOW_ITEM_TYPE_GENEVE: > > size =3D sizeof(struct rte_flow_item_geneve); > > break; > > + case RTE_FLOW_ITEM_TYPE_ESP: > > + size =3D sizeof(struct rte_flow_item_esp); > > + proto =3D 0x32; > > + break; > > default: > > printf("Error - Not supported item\n"); > > *total_size =3D 0; > > -- > > 2.7.4 Regards, Bernard.