From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CE77A04DD; Tue, 21 Jan 2020 17:28:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A8424C74; Tue, 21 Jan 2020 17:28:56 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 7A2F83977 for ; Tue, 21 Jan 2020 17:28:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jan 2020 08:28:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,346,1574150400"; d="scan'208";a="275343413" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 21 Jan 2020 08:28:52 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Jan 2020 08:28:52 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 21 Jan 2020 08:28:51 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 21 Jan 2020 08:28:51 -0800 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.54) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Jan 2020 08:28:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=msAYo7QIXZ9OyFXldR5/5MHlfdleqSDnNxWhXVNj8WR4lVZLZpL3DTyOjD/EPtQDXFbE6Oag1S9p+CrQTZE98Vnlz7ykk50HtqNXiaaVKJzeEvwnjYrZk/iKwpIxs6hd52eE2QY9sWjCL6mTjKbPJaOsvNpTXYCD/P1SAkhEo/ao8qUKLDZJ5VEFYN7sTHxbyhecG5dbykcxFKqEh1A+aJTAxRBF4Ywp/UxPSgtOaINxDo/zjsqIljE0qTkvg0Q2lh9SaUwb5ytL3ezeUqCrEaA47EwbzMpLeVS8c6EOiKLoY2hXe4o//H4I6bWJXcOwfzNoac7riZHrcqQ9bwiAHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rOiq1MKeYD3kyfP+DrO4NmMAbJqKnKs6mfoZStCGdcg=; b=dLIbN73Hkb4K72RjlGLT1TpSOM0immU/1kQ0YW3PCzeV3ttZDpYJZ7Qn2nXjrt2yhJ/LRZnaxerI18Kt9kaEMjOli+FHokHyDh5yDCdUqK1Rpe5sJ4Ljvib10fepbB58SPVWaSACpJXJOrICUtp/YdjFubvO51l2tp4E8RjuQaSFlf2lN2mmmEWxv+bPK70eNeTliH98kKo+zn5Mm4mcvqOrlPGr3MAoXqk02JELrjqDK8FBkKtLFmXRKLME5IONHlS0lBrAZ7XK4vd/aPAj0tDKRaSw4l38f/HOiBFTn92L+Od53mOPf1j52sVqVUA+jaASknJvvyMuxUcfF5jNxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rOiq1MKeYD3kyfP+DrO4NmMAbJqKnKs6mfoZStCGdcg=; b=bGkdgOm8kz8Q/c8R+9QaSox8bLy66aVsreom5rpyKH1EGvveq9AhI9ySfTTWoVgsef1i452V3HTtoIuQ2sUJrBV0EXQrTDay3iyLnJbKkWXVX+XB+Y8TluesB25lnsI7mC6Lwg4ZEH992c/avcTTIVIP/AGlcC9Nc+BxMHFrMkY= Received: from DM6PR11MB3914.namprd11.prod.outlook.com (20.176.126.24) by DM6PR11MB4505.namprd11.prod.outlook.com (52.132.250.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.18; Tue, 21 Jan 2020 16:28:41 +0000 Received: from DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::29bf:9a8f:7bba:dd26]) by DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::29bf:9a8f:7bba:dd26%6]) with mapi id 15.20.2644.026; Tue, 21 Jan 2020 16:28:41 +0000 From: "Iremonger, Bernard" To: "dev@dpdk.org" , "Xing, Beilei" , "Zhang, Qi Z" , "Yigit, Ferruh" , "Sexton, Rory" Thread-Topic: [PATCH] net/i40e: fix i40e flow director merge Thread-Index: AQHV0HRDUVd5Fe53tEeGKmJGanBKh6f1Tkog Date: Tue, 21 Jan 2020 16:28:41 +0000 Message-ID: References: <1579622533-15909-1-git-send-email-bernard.iremonger@intel.com> In-Reply-To: <1579622533-15909-1-git-send-email-bernard.iremonger@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTEyOWQ4NDYtMjUxNi00YmM1LTg3YmYtYTBjZTdkYjBjOWVlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaUZ5SG1vbDdnb1FhR3hPMUtHUXJpTEtLTE9RT2Y0b2ZhaXJIOXgxR21BUzErTXdleU9QeXFSQXg5MTQ0WEJTYiJ9 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=bernard.iremonger@intel.com; x-originating-ip: [192.198.151.189] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0a5ba597-d396-4852-d656-08d79e8efa18 x-ms-traffictypediagnostic: DM6PR11MB4505: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-forefront-prvs: 0289B6431E x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(366004)(376002)(136003)(396003)(39860400002)(199004)(189003)(26005)(8936002)(6506007)(53546011)(8676002)(81166006)(7696005)(2906002)(186003)(86362001)(9686003)(66556008)(64756008)(66476007)(478600001)(66446008)(6636002)(33656002)(55016002)(76116006)(66946007)(71200400001)(5660300002)(316002)(110136005)(52536014)(81156014); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR11MB4505; H:DM6PR11MB3914.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Jmmm6vaeOr2Ao+Vulclhweh38ocIGYAsxKz0wyaWuw5dw67FL7oK2cjbaBWoAgnVsJnUst9gpkQwniG8YZ3OZ9ywJJoVdOAVS7n9467CdlYdNi1JTvJjGbfelPMjSNg/qIh2Ke3bqTd0p3dtbbnt2iKocD+t3JyOBDPzA8k3RgY5k6Cta92OJDE+Fas38F1q2V+VxMC0uOpu4Re0k4gubzHLVvG3FD0B0DPhGXfICix2NZHOFRxHxAjOBubf5EKNfSWixlTJPXjCpxPNPSJrMbG45nZ435OMEglt/lnTZjWAmYebu09DQ6jKlG//sXGSeupNDlP3SZpN5sspxKDRBn8iEqiRPGRbQwqUfTIKQvtnlevF9cqOTx/EkuFwQRxm073Apb4w789NDVFzSVJ3if8YENOFFeoGjqq5gKmXaUP4ekw3Hq5IPcFwY6BKj6Zu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0a5ba597-d396-4852-d656-08d79e8efa18 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2020 16:28:41.3381 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V83Hf+EF6KumHVw+thX78mg9sDo3oQkp7Ols3Qo5iGLStdhHnTuOUoR7D4N2lNzghqItcDQVbOzHBmRDVgqJIRaGfm4tRDYkk5wcM2JNm3w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4505 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix i40e flow director merge X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Iremonger, Bernard > Sent: Tuesday, January 21, 2020 4:02 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Yigit, Ferruh ; Sexton, R= ory > > Cc: Iremonger, Bernard > Subject: [PATCH] net/i40e: fix i40e flow director merge >=20 > Merge of i40e_fdir.c added checks on cus_pctype->index which are not > necessary and caused flow creation for ESP to fail. > Removed the added lines to fix the issue. >=20 > Fixes: c5f8365bc85d ("net/i40e: support flow director for L2TPv3 over IP"= ) >=20 > Signed-off-by: Bernard Iremonger > --- > drivers/net/i40e/i40e_fdir.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c = index > c346073..1d7c392 100644 > --- a/drivers/net/i40e/i40e_fdir.c > +++ b/drivers/net/i40e/i40e_fdir.c > @@ -1063,12 +1063,7 @@ i40e_flow_fdir_fill_eth_ip_head(struct i40e_pf > *pf, > pctype =3D=3D I40E_FILTER_PCTYPE_NONF_IPV4_SCTP || > pctype =3D=3D I40E_FILTER_PCTYPE_NONF_IPV4_OTHER || > pctype =3D=3D I40E_FILTER_PCTYPE_FRAG_IPV4 || > - ((is_customized_pctype) && > - ((cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPC) || > - (cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPU_IPV4) || > - (cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPU_IPV6) || > - (cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPU) || > - (cus_pctype->index =3D=3D > I40E_CUSTOMIZED_IPV4_L2TPV3)))) { > + is_customized_pctype) { > ip =3D (struct rte_ipv4_hdr *)raw_pkt; >=20 > *ether_type =3D rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV4); > -- > 2.7.4 NAK, causes problems for L2TPV3