From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A467A0556; Thu, 20 Feb 2020 16:29:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB5071BF98; Thu, 20 Feb 2020 16:29:22 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D10B12BA3 for ; Thu, 20 Feb 2020 16:29:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2020 07:29:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,464,1574150400"; d="scan'208";a="229512173" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 20 Feb 2020 07:29:20 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Feb 2020 07:29:19 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Feb 2020 07:29:19 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Feb 2020 07:29:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BbTLFMh//BGeyoIfOu09bNi5kyf6U8x8jJ8D88lu4mcBiZZBhMKuRbFiJJdwu8QcJJlkwvLnk7JsWQfWC7SCp5gvsW6coFU4I4aUoDLcFAZ2DoD4/ZFa/iRpJMldvu2mlNYvuh4fU36CcaQskU3Ekcys7CxrKB38RYlIxisG5VIRps7SLGDWG+HKXOfbgvExTsvpkh/pRWkVtKec9ewlV22FqRj9OfItk/+KyaCNMevv6s3AiOf5/aWaPUikjo1FYmI1zb6hyKupYzcxm0KUVU4hTI8J8DUIzBOL+I9UIr9idyJlpa6phufDUgRQneZEJD/By3kzO0U7lJx6nt+exg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9RpQee6+LRzDp+ZDeePmFl9jhIre8HnOrFXxm5iksd0=; b=RH4QYWDtz1DKGquDVqAFZnDkV/7hKsocPeW7i3Pa3o/lknCcqxlKVu2WcFhOsuMLxGTxXC6GrgLwvax2kTQSkvjPlCiQZiOR5he5jJvbTxsChp+Lg8ppirTvOr+9b6eNvpKzG6KMeNoni37jtSEk3xc751JvEM5y5lvdg+BltrHGoWmhvzpvOX16MosZybf4FfmjVxCpIGI8wMO17ONooetkz5bepHBmIOLk54oK9HkV63ypstHTBmybqCD4s3pzKj8dNFGbKRSoDpkXN+ijOCmVcYS317EsZdn/frFomjUmYteZDvDTQotMmwLFPzZROKT7UP34ZD29FuKzqgoApw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9RpQee6+LRzDp+ZDeePmFl9jhIre8HnOrFXxm5iksd0=; b=NbcNhncoIqjPT87c7YsyzfHSoY2NCe1FV96O2zbDrIDsE4zQh0urS2989McCxu4H5Z3kih2a6I5/bAWBAS99kvTfMvfsNCX0/S/9SX/D6456wSz6YeC7MbWOWbgIIz+RlnONuqU50TU+ejfPoHOTIxuKwtxjEg6pDc5aalroiZs= Received: from DM6PR11MB3914.namprd11.prod.outlook.com (2603:10b6:5:197::24) by DM6PR11MB2587.namprd11.prod.outlook.com (2603:10b6:5:c3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.29; Thu, 20 Feb 2020 15:29:17 +0000 Received: from DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::e18c:c44e:cd8a:91ee]) by DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::e18c:c44e:cd8a:91ee%3]) with mapi id 15.20.2729.033; Thu, 20 Feb 2020 15:29:17 +0000 From: "Iremonger, Bernard" To: "Govindharajan, Hariprasad" , "Lu, Wenzhuo" , "Wu, Jingjing" CC: "dev@dpdk.org" , "Yigit, Ferruh" , "stephen@networkplumber.org" , "david.marchand@redhat.com" Thread-Topic: [PATCH] app/testpmd: fix wrong return value in parse_port_list Thread-Index: AQHV5/FxjToNPoqSgESleWVv/gFHaqgkNDpA Date: Thu, 20 Feb 2020 15:29:17 +0000 Message-ID: References: <1582205191-14105-1-git-send-email-hariprasad.govindharajan@intel.com> In-Reply-To: <1582205191-14105-1-git-send-email-hariprasad.govindharajan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2Q2N2IwNzMtMTA5Mi00YTJlLTg3MzctNzM2ZTBhNGUwNDBjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidGU2NENlNFRmSGpvNTFwTzZ2dVp1QmVMbTJWbkNkTXUrKzcyb3dzelFGMmFnZThURThnM05xdDA2UFB2RnJoYiJ9 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=bernard.iremonger@intel.com; x-originating-ip: [192.198.151.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7d9582bf-066e-40c5-2448-08d7b619a60b x-ms-traffictypediagnostic: DM6PR11MB2587: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-forefront-prvs: 031996B7EF x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(39860400002)(136003)(346002)(376002)(396003)(189003)(199004)(54906003)(8936002)(81156014)(8676002)(81166006)(66476007)(66946007)(71200400001)(7696005)(55016002)(2906002)(76116006)(66446008)(52536014)(4326008)(66556008)(64756008)(9686003)(86362001)(33656002)(110136005)(186003)(53546011)(6506007)(26005)(478600001)(316002)(5660300002)(6636002); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR11MB2587; H:DM6PR11MB3914.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qGch4yD7uQPctp5L3Nj82hwjvsAT+EH1e4+36RFadW4IW6nXfJdfMLLh4grSBq50aMgu+yfeT0/RfKovxTaohw6VHw+avm5EzN5rVPMrWSg2RwkP4UtJgz6VP7lkCp9BzX/mCX3LPmvuD4WfyoOGa+Ng8VolJxzHivnCz/aW48RoW849In/dcssnquDjIJLRn5GsonbErid/bCyHOqQ8alhPhShKec/ClGu8SS1bkk5v2hWgFKbfb054Fb3pE5fM0FMln+kvx0WZmlJmxsjFpLjlmZIoA3LnYwtoSRcpG3mpSu1tZBlz6sOyLjtCZbyUxnvd6OYJRGdyA+EiKG8dfFf7t52SdEfv8PaabKoy/S90sVb+59a2hSJFRkQwtO1v6rkIekjUbweJJLvqfGAIVXUp0Ia+XEpSdGZC95eexg/NqMpCJKVEMU4RbZd61THJ x-ms-exchange-antispam-messagedata: u/DIap5E5F7Rsj9x6+IcBeDYptfUpijFwFwjHSIQVdTuF/t78VRIKJ6YyXVK1dK+0ObTuWwnyWv5UZWuZElZCqKK1w8AzyL8dc2wCCH/shLD67kDuNkGJ8/KjOqdlm9CyB2mgPGRvzlu7ueJmqXq2Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7d9582bf-066e-40c5-2448-08d7b619a60b X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2020 15:29:17.0911 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8inbCXBdDYMiew5ICNMQ9g55jXgW/mFCjCT46KocDwDlDXJQyrBEsmOFX3Ke95VPBIkK33cKb7IBAPyFJQQW6BZmv794Ukh8lX24FFSGPck= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2587 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong return value in parse_port_list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Hariprasad, > -----Original Message----- > From: Govindharajan, Hariprasad > Sent: Thursday, February 20, 2020 1:27 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; Yigit, Ferruh ; > stephen@networkplumber.org; david.marchand@redhat.com; > Govindharajan, Hariprasad > Subject: [PATCH] app/testpmd: fix wrong return value in parse_port_list >=20 > The function parse_port_list() is designed to return unsigned int value. = After > sanitizing the inputs, it is returning -1. Changed it to return 0. >=20 > Fixes: 2df00d562d20 ("app/testpmd: add --portlist option") > Cc: hariprasad.govindharajan@intel.com >=20 > Signed-off-by: Hariprasad Govindharajan > > --- > app/test-pmd/config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > 9d95202..91db508 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -2642,7 +2642,7 @@ parse_port_list(const char *list, unsigned int > *values, unsigned int maxsize) > unsigned int marked[maxsize]; >=20 > if (list =3D=3D NULL || values =3D=3D NULL) > - return -1; > + return 0; >=20 > for (i =3D 0; i < (int)maxsize; i++) > marked[i] =3D 0; > -- > 2.7.4 ./devtools/check-git-log.sh -1 Wrong headline format: app/testpmd: fix wrong return value in parse_port_list Line too long: Signed-off-by: Hariprasad Govindharajan Otherwise: Acked-by: Bernard Iremonger