From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23262A0535; Tue, 4 Feb 2020 15:40:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 707291C06A; Tue, 4 Feb 2020 15:40:20 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 80F131C001 for ; Tue, 4 Feb 2020 15:40:18 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 06:40:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,402,1574150400"; d="scan'208";a="235181727" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 04 Feb 2020 06:40:16 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 06:40:13 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 06:39:53 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 06:39:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B+HgZVwroFjftYGzIGNeLjkVqo0ZdqOnNigGJOTDuGu5+UDL+ySQpnDiG3Ln1tMkaBx0gXAczwswK1TwsBNzdtDSOQYI9mowDYQi+srIa564Kc+SpFQCVKMXFbfa8gdENGJpYL8t2S6aTrz97M81EigX+Sx35vUVgt4ccpr37Qd4Eu7fuBuyyr9hgRR8BBQG6+b8tf0TUNBYaorIW3pYnPq3xHVy2tpdgh5/ciZtP/CsShRTVVNYVOzJ+lciTAo1TL3lqMu7kBEr/0wZicISb4okGHL++jNQHptqgj1Y2AB/ld+FWVjsjPtR07gdsy9m++y/LSYoMH/Pl9X5js7wGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pNeNMX6Uu7gnPVGK2UE5so2zB48SEax/mg8UwbG0Rf8=; b=gn6XezhzaXCVc6UUJPQG7CZecogidE2oQWugx9zPay/EV2LFi0+nrRK3XmhRi2A10iqSgERN4mo8GM+2jOenxsRzEs5GIdf5uz+sQUIXvuyeM7u1QxTMaQjkz3Jd3anhuAjso1Nm3A4mXU0dvre+z4b6m1Dj7lDl12uiyffWsLO3dv6/VpEMBPCMI7PJ62Qj1srU74nPbf4C08Q+ICXyXo8GXVZScisl/e+uI0r/qecxFo68GXLQXv0PK9dlE4Iw+gQCqQYDR8VFrA4jm5pBCX4PYQiv7j1BvlI6Ct8Kd1zOPHluLCv5YoYQS/RF7+khbPexU4VHfZwnq0pnYx3AWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pNeNMX6Uu7gnPVGK2UE5so2zB48SEax/mg8UwbG0Rf8=; b=vvjekWc/X4GUTtMYsd0s5tqcDKt2uvgVxyNligeb5O7fHSFOlM/WGBtTmgIDTwCfyRvrernyYJIZDBDJ/aYXm7Wnak4cBGGPjztMQ6zAyn3wxVq/Qo2zQSLhdQF9lMZc/zo7vUEpg3fwCFu3Ep9vdvjpfIi2dv61BAcNrbtr1rs= Received: from DM6PR11MB3914.namprd11.prod.outlook.com (20.176.126.24) by DM6PR11MB3868.namprd11.prod.outlook.com (10.255.61.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.29; Tue, 4 Feb 2020 14:39:34 +0000 Received: from DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::a4f1:3592:a3f7:b633]) by DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::a4f1:3592:a3f7:b633%3]) with mapi id 15.20.2686.031; Tue, 4 Feb 2020 14:39:34 +0000 From: "Iremonger, Bernard" To: Ori Kam , "Lu, Wenzhuo" , "Wu, Jingjing" CC: "dev@dpdk.org" , "Yigit, Ferruh" , "viacheslavo@mellanox.com" Thread-Topic: [PATCH v4] app/testpmd: fix copying the name of the dynflag Thread-Index: AQHV22CrTp7kaW1h/0qO0yTTZ7tEG6gLGtIw Date: Tue, 4 Feb 2020 14:39:34 +0000 Message-ID: References: <1580390564-186435-1-git-send-email-orika@mellanox.com> <1580823586-144444-1-git-send-email-orika@mellanox.com> In-Reply-To: <1580823586-144444-1-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDAzNmU4MzYtNTU0Mi00ZjRmLTg3MDAtZDI0OGI0OGMxNmIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiODhLRnhkYjlma2l0eDUxTW1QcStGTklBczdMREcrZndZWGtmZENOSlg0UHkwQzhLTWw4TUFjQWJoWjNvVkYySSJ9 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=bernard.iremonger@intel.com; x-originating-ip: [192.198.151.191] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 22657b12-dbac-4ef5-67d1-08d7a9800d8e x-ms-traffictypediagnostic: DM6PR11MB3868: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:254; x-forefront-prvs: 03030B9493 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(346002)(376002)(396003)(366004)(136003)(199004)(189003)(53546011)(6506007)(86362001)(71200400001)(54906003)(4744005)(26005)(186003)(7696005)(9686003)(81166006)(55016002)(316002)(81156014)(4326008)(8936002)(33656002)(5660300002)(52536014)(6636002)(2906002)(478600001)(64756008)(66556008)(66946007)(110136005)(8676002)(76116006)(66476007)(66446008); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR11MB3868; H:DM6PR11MB3914.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LXO3licBtTx179tzWiJcsvBaRaKLOmDlNX8LHnfSLiTTyWmtHgz1UnKEXw7jSl3fhVM8Sx6zODZxcXwJFaJtJrQ7HcEdD/UvlX2yuMTprs0WK2Z3pN3VlbmiulSRowlFwzOm3ZLJZLrSC/XJAcJkpWlOfuSlsJWAYpMCGGlL+2H8T4lkCo7RHAurW6Dp+0KKo343ztm25ntlR8P0GbkryO4OCg3QTh3GhnI3rg29FjtKlfU0tojcO4v+s4RFsLsZiSJf9QrUuiKe1s71neLND7v6WgjwgSw6psdKwXqBqnFbxdEqyoo80Tmk1q1s3lZ4oD8I8adfN1mcw6oQs7oQRE69qjcDh/QeySGRiL2V58ffzUz+4KvHYF/kPQJ5oq3WnJMoq/hAlXkP4SrKC7GBTKRQ9QBwWCTChenCIjf2rGzif+H9JxGvbtpf08nHw5qo x-ms-exchange-antispam-messagedata: 3o5lUCuvp1mmaJ9X672pnyui/9/youHTKxOCtpPJR17Atso52ciYXb/XuosV7Vr63CCtKocPQu8z4CKo6eXGhPfPEZO5ekEmPxejGRo8CtM7tV98p9DFZ0ZuuPi3in9Dr5+rC0fA3/WYgtnLjzU8Wg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 22657b12-dbac-4ef5-67d1-08d7a9800d8e X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2020 14:39:34.2530 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tawDM4LW/d/5TAqGFyoIbkhwD0PT2uTwylSlBRdiqXeaQqzFHnZPAcfGLuf2bCT4yB/7vljHPoUeP7RCY5OIx0ah+TspD1aPIVX6w5WlpB4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3868 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: fix copying the name of the dynflag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ori Kam > Sent: Tuesday, February 4, 2020 1:40 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; orika@mellanox.com; Yigit, Ferruh > ; viacheslavo@mellanox.com > Subject: [PATCH v4] app/testpmd: fix copying the name of the dynflag >=20 > When working with testpmd and setting the dynflag name, we copy the > name given by the cmd to the dynflag name. >=20 > The issue is that the size of the dynflag name is smaller then the string= used > by testpmd. >=20 > This commit solves this issue by checking that the length of the requeste= d > flag name is not too long. >=20 > Coverity issue: 353610 >=20 > Fixes: b57b66a97ebf ("app/testpmd: support mbuf dynamic flag") >=20 > Signed-off-by: Ori Kam Acked-by: Bernard Iremonger