From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 399A4A00C2; Thu, 5 Jan 2023 03:52:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0100400EF; Thu, 5 Jan 2023 03:52:40 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id B71B640041; Thu, 5 Jan 2023 03:52:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672887159; x=1704423159; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/vjPeRdxmwtw1F4DQw5ehkU9FhcueDMQgxaj4sIPQdA=; b=jYWA3mAs4xZRkseekDvTNfMXv2Mz4rlLwOFWdxlYPC8S04CWqDrHSdeD F8Urbhg3P4zsfA3/InWQJZreoGmQ5/s2zja79QvK6iminByMMn6ORAOtj 8jNxozXM3twkFSmu8pOsP0cXN2jUpkUJwG4fEuY33Gtmj9NDeWdRxK5sf pkIEUSQqowtWE9PDzxccmYHMJCLDZf1NZXpQLebPNRk7YZvuaGY4mZNpP WLVvqFobrQhg3AjCixFWSTJAIg/hu7ZmzGcCMRfxHxekDegRVwng2T4k8 ICkqEfcCXiE7OIZqlRZyTWiFc8pmcIErFy7AoUNNDm20IUJmEwU/Y+9By g==; X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="320809568" X-IronPort-AV: E=Sophos;i="5.96,301,1665471600"; d="scan'208";a="320809568" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 18:52:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="687743216" X-IronPort-AV: E=Sophos;i="5.96,301,1665471600"; d="scan'208";a="687743216" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 04 Jan 2023 18:52:37 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 4 Jan 2023 18:52:37 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 4 Jan 2023 18:52:36 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 4 Jan 2023 18:52:36 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 4 Jan 2023 18:52:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lkQEzKX/5ATQPBmkjCp8waW5TST23sWTCO/wUnoRtKSJ+/PqQxwqoP8wthqDQ+pli7mUx+ENbSmRZeg9hSLSdVpjoidkNIt+LPnQYiXBEAMGWOHJyVmgl1P2xln1yjY18SnhKurEcTe8EGQmnqbDTT14Vgg9xdsKz6Gu8Nwdvns/quls9N3uiET4iowOENoUPk6zoXAfuQ8APL8DZ6NgWhqEHNdXR3qeJFPmV3IhWaA6Eo+tKCpHNKw2BLZkTpEW4VtKKIRadLvA1mxe9F+8qDKFgkKlJKMw20/ae5VB2Sn/7c8scXXiEdGRBVefTayxlI9s0MP3QRmKqDGifK71ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ktdEtXPpa4wNZ1FeiqotmR2tApz5aq9fQ2P7gYwASIo=; b=nbcP7Q9TWfHO6DyA1/gCzJeAQuJ24j5TBRhuUpV9Pkxb+llgbvYUc1ee+GSI9Mg2annOeQinDNsKLHgeYXlxe102WoMj57aeyELNe58A0CyTVl2jW7W/Qj96sdR1oQ2pkSgX9206lFLJey4bPipQaHPnQXjrnJ/AL9/1cLckyZq8H1QKnO5ATQhVpnNJYDnn33qa1b0pkBN/pK/i0LGdFD4jerUg1lmgrfSW1CbE8/w5D61M+clayqO44KN2tZJakyKfe9PcKLXp6PMDb0bSnlSLXuEECs93HsBm457vvV4PzY7Ko1ZoDMEZos98c/z4jIJgFz/sLetHCGy1fWq2nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3946.namprd11.prod.outlook.com (2603:10b6:5:19d::13) by DM4PR11MB6119.namprd11.prod.outlook.com (2603:10b6:8:b0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 02:52:28 +0000 Received: from DM6PR11MB3946.namprd11.prod.outlook.com ([fe80::4aa8:cc71:3dea:699a]) by DM6PR11MB3946.namprd11.prod.outlook.com ([fe80::4aa8:cc71:3dea:699a%3]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 02:52:28 +0000 From: "He, ShiyangX" To: =?iso-8859-1?Q?Morten_Br=F8rup?= , "dev@dpdk.org" CC: "Zhou, YidingX" , "stable@dpdk.org" , "Yang, Qiming" , "Wu, Wenjun1" , Remy Horton Subject: RE: [PATCH] net/ixgbe: fix ixgbe firmware version get Thread-Topic: [PATCH] net/ixgbe: fix ixgbe firmware version get Thread-Index: AQHZICOB9j/c3N1LF061vYwvdpegjK6OC6IAgAETXKA= Date: Thu, 5 Jan 2023 02:52:28 +0000 Message-ID: References: <20230104095142.86796-1-shiyangx.he@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D87620@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87620@smartserver.smartshare.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3946:EE_|DM4PR11MB6119:EE_ x-ms-office365-filtering-correlation-id: dadc1274-61b7-46da-9afe-08daeec7e241 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iSrYMH2pAbedEpoKOKmoaoS1T+/w8XzMt2sQNuG0Kic9ffOVaB21onsBryq5sFHxHHVytAEUs6Uqu9mprXMM5hyoxozGOqTMYzPjm9lPmL8w/9u8OXOZjjCKP/ORnpOxyrWINEi+RgZpJypHaaCfqNeWYS3JEAvle5pw5Qy3PcwnUwnLCOliZe1lzWFb8WHhdC058UCuIH5MIuiD16zwky7Pmojbe0bLbwxiBRJujZe7gSM/isrEtOVx01E5s8tHMxQw0loK5hI9Vd4wcHiRzz1LnHRubiDzOf0JSyTohOzpMYOSBEcwRDW4MxU/fSH6/hIhnRVoK28zNcv5mQR2G1owye012eSHNqoWeIB80tfgw19lnvEI06Y299z7Ec7zi//a2L7S2lAbpbGbyqkMu3tRKMben4Lqd4vDYiGs4tvzB6xcj6IpxSu1EC6vCO9nrAgy0vrhkBDNTh7msPKQkbBmmIkXe+Yq7xMgo3/Rnrkt1rgke9kG9PiT0VLOeg1nYGl1ael5r3sB2CunTxLaP2Q51+o10ocb4xcaWFK806LFLT/oRedOvfgHy+Ai+DwbB6BM1P1ZKsAnRGcV42DEu52L+YaffZgtal5VZgtY1CKNIHHswHg+++c1Eq2EPTu9Pt2Q4Ugde+hjo3yWDm5UcwTm2jfpC5FS/K6bxUFCzl3uU/rmstZ++pdF733QG0G+mR7ovRLHiuwrv3gv6NSY+A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3946.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(136003)(376002)(346002)(396003)(366004)(451199015)(83380400001)(66574015)(7696005)(26005)(107886003)(9686003)(55016003)(6506007)(33656002)(86362001)(38070700005)(82960400001)(122000001)(186003)(38100700002)(316002)(4326008)(41300700001)(478600001)(8676002)(2906002)(52536014)(5660300002)(8936002)(71200400001)(76116006)(66476007)(66556008)(66946007)(54906003)(64756008)(110136005)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?a72U+KeC8BVTh1igu0hM0L7Z0BLwue8SvOVRqrzh14ryzh5xJYCo8KCHUu?= =?iso-8859-1?Q?A2sq7L0VycGZoj0sWpKPSiP2wc4LL3ar4A1ogx24AD5ZeSk2j1BzshRt61?= =?iso-8859-1?Q?E18Y9Vuyqfa7WksIqLFdt2DV4mbuSklK03rNr3Z72yIBTpkZln4lCbVMpT?= =?iso-8859-1?Q?2pW18pyLtw48QW88AIDKvFPI4BUJBlcEPFw8CB8kTa10FeXI4hTuelht8E?= =?iso-8859-1?Q?Kc1efLuWcr6fTmVwIVIX8I8cVBIQIbf+2zvACPKByPQ5DfvqPqNghUcd7U?= =?iso-8859-1?Q?TNWsegj47MegpHtBR76cDiRprF8296zotEYgiRupMCwmWLXQ5JEoGeeKud?= =?iso-8859-1?Q?2mKDyo0ojwdj/xAC/GPJpY5QPU5K2Ee/8yNmP8c6EEeqGbuO/BA01QD0U0?= =?iso-8859-1?Q?nBcdalv3Nn9nKVk2D2VUNe9KqNugqaUASJKKTFaUy0CRJfRx3i/HtubQFr?= =?iso-8859-1?Q?UqgZ8RScf4xBbr87b9oEUQ0tz9nvRCYmvd4uoAF8oqmiV6hBAlhsmo5z4e?= =?iso-8859-1?Q?rTm1flJeQ86BnE1CMAlSGwiA+tnCs1N0xFddkqQmTQAD3SHQsG4AURJg3d?= =?iso-8859-1?Q?HPwEFnw6TZPk2ySjcLtYZXlygd0vjLygVgdlYT6X9F7mwiwai2jYJCAsGq?= =?iso-8859-1?Q?j41iqkyeqsx6ycpVhyg+W//2IMAr6ey2Rmzi8jBcNX3/eiJP4ZXaXSaDeT?= =?iso-8859-1?Q?HCTbkp/GMV7453g3obHiKqpxrHnkM3O4bknl1CUjhC/87hDFWZdFdadGgD?= =?iso-8859-1?Q?RSv61/I9SaRdBJOvLVdfbKGMgjLd5/GRUwZ7mXGqWi7eSorr6P/3hQmRZq?= =?iso-8859-1?Q?k/swHtgADMCFoRwdr5Wo4qfDbPxrtU66Xfr1SniYqM8loGVdrJoTCfFtJo?= =?iso-8859-1?Q?NxT7jLsmI9IiRKm2npHqUfVRLG/fLzxgJ2UHXTTEhy8BomI7iHHl6zEyDZ?= =?iso-8859-1?Q?8COcSKGB91YypewBpi+aqHWOmILFVQ79xnNvASr1/YJNt2wA0sopmd8zwF?= =?iso-8859-1?Q?KhIG/aIj3ogoR4XprF9hOf/3h5rhHX6k84z0GoHZG/Tq4Lx6CbIx3H9R/B?= =?iso-8859-1?Q?WVQHDSEvspGpCfVxUVRoCmBxBhQtFy3m1G7smnKNh24tDcyGt27b54jwTM?= =?iso-8859-1?Q?yBchQWzaN8oPvxYLhGJ1LIW3A3XXIKZ77pqp3PZRWrcir3xe4EJnfq5bj0?= =?iso-8859-1?Q?256TQKktngyd2yTTCcf9g6dFhFwDCGIT647qmCEimadVcjxHZzV2mhab0e?= =?iso-8859-1?Q?a4qDPUaEwXVfs+qfzDIA7eHyEofQrOj76UF4zSKYe4woS91FfTvc4dSc9u?= =?iso-8859-1?Q?4NB6w2NVIngprwJw1U2MZZ66joBhB1guL67ywb8eZNuXmlW6C65WKx08rr?= =?iso-8859-1?Q?XxulhrK8+ccdA63RjkEAJC6RnXzF3oWE06lVg57ejpFe1nzKMK+Dxj4YKT?= =?iso-8859-1?Q?iGxD8Z4Y62LIOxT3ClWH4zRx70OSN3RRUZhApYa0ef7uChBnQ/bF0gf0N7?= =?iso-8859-1?Q?ns5ivPn7v4tCDLF+OEHxByHV//Gv5N3s8/H3TXHCvI3w2BRXN3EaoZJoOr?= =?iso-8859-1?Q?FHLTSrvkGEhYtakt337PHObSUZRhVyPhtSm7gc4GiwlT+5ln4r+aIf9gbN?= =?iso-8859-1?Q?gGssdEVLlCtaSgB3iw4kH+54XV4xktB4sz?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3946.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dadc1274-61b7-46da-9afe-08daeec7e241 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 02:52:28.8043 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: avLQ3/IbZWzrRx2wX6SPUsGSbOiyFRS8i1CMx8q7NpUVTCdixQ6ckBCwnOhfGE3/SIbXUnNmpFVovCyVop953g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6119 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >-----Original Message----- >From: Morten Br=F8rup >Sent: Wednesday, January 4, 2023 6:19 PM >To: He, ShiyangX ; dev@dpdk.org >Cc: Zhou, YidingX ; stable@dpdk.org; Yang, Qiming >; Wu, Wenjun1 ; Remy >Horton >Subject: RE: [PATCH] net/ixgbe: fix ixgbe firmware version get > >> From: Shiyang He [mailto:shiyangx.he@intel.com] >> Sent: Wednesday, 4 January 2023 10.52 >> >> The firmware version obtained by dpdk-ethtool is inconsistent with >> that obtained by linux-ethtool. >> >> This commit fixes the issue. >> >> Fixes: 8b0b56574269 ("net/ixgbe: add firmware version get") >> Cc: stable@dpdk.org >> >> Signed-off-by: Shiyang He >> --- >> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >> b/drivers/net/ixgbe/ixgbe_ethdev.c >> index ae9f65b334..012096021e 100644 >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >> @@ -3859,7 +3859,7 @@ ixgbe_fw_version_get(struct rte_eth_dev *dev, >> char *fw_version, size_t fw_size) >> ixgbe_read_eeprom(hw, 0x2e, &eeprom_verh); >> ixgbe_read_eeprom(hw, 0x2d, &eeprom_verl); >> >> - etrack_id =3D (eeprom_verh << 16) | eeprom_verl; >> + etrack_id =3D (eeprom_verl << 16) | eeprom_verh; >> ret =3D snprintf(fw_version, fw_size, "0x%08x", etrack_id); > >This looks wrong, assuming the high-word in 0x2e and the low-word in 0x2d. > >Perhaps the linux ethtool needs to be fixed instead? > >I don't think DPDK should aim for "bug compatibility" with Linux. :-( After following your suggestions, I read the driver source code again,=20 which is implemented as the solution. I will send out V2 patch soon.