From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EC0841BB1; Thu, 2 Feb 2023 18:03:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B590410D7; Thu, 2 Feb 2023 18:03:05 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 9451040693 for ; Thu, 2 Feb 2023 18:03:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675357383; x=1706893383; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+SvzFuGGoJAQRqclWZ5Di1iPbbXslqEgK7nMPpUoGu8=; b=gUIPPYjD6UNFvoy5rTHHLjCgjsekmBEAYjysOeFuhJSkJaZksXVTOHRS jDpzFsG0GKgBMxfV4ba0aqH1Ly8oyzQTwcXD6vRryFL95n8iYkxwIzISN d2PLHLueJ9K4SbiYOivX5PuDBiwvWkd/4B0tXuMV6tXQgpvkG09RZHZYH LkrM93KIoUszkfAgskH5BMp2bA3Enkq5UsotNcmwfC/Q7nAGRAilCK2aS zj21kxrh0NC5zKQyVl/aU77qmFy5uXyyFH//R0nhru1i7hWU81ThQQ7q8 U6j4L4uda60vjGjX1WV6xX/4xZ96cbmrsYgU+AyHuA1yiriY1gYUQ94XF Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="312147540" X-IronPort-AV: E=Sophos;i="5.97,268,1669104000"; d="scan'208";a="312147540" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 09:02:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="839281773" X-IronPort-AV: E=Sophos;i="5.97,268,1669104000"; d="scan'208";a="839281773" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 02 Feb 2023 09:02:16 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 2 Feb 2023 09:02:16 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 2 Feb 2023 09:02:16 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 2 Feb 2023 09:02:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cOvOsyqebC2xH/tOzipsZfJoNu3vlJcNA3UZLtpXP55lBcGWZIZTdxJAcO8UR4iLHDe/IMMJTjCSUNN8T6JOeZNp99wo2uj0Jn6QpRiEM9SXd7qm0gS+74/gF0RWKpo/xZc0QQgmp0Yjg8ygewVBsOW/6knvJEdU0VIvbMb9tQPy16LvfCRDecEbTbmSICv4t73mhPa6s9MY0gMa40bpWXDMYIqR22E3/+z1DaZJGhUDOnkxwJTAWAIMd0X7QmTM2wtyDD+qz+IjZJDg58umWlBvxtwdWnZFeHjk1AgIi5qwAoWrIRc9iLMIKtLNw7icF10gYGtrm0hB3iidhyW9kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EcKRv54e9aAvpN+GAaTsn8YlDZkcVpyLnGmVQe8X5sQ=; b=bi2bcbc13AQzolhdbFgGndcGXGSEfif7MiT15rPDuq3+Lo0ILZlPsfKH1isVWHPOAFv8g1IBweXyTfAII1SUTEFPivAhXCtHd47gSSAVQvcQYVYMj3NbQxLl34Hm54IfzX46SXSqVCKPhWfq+aszGDyPIK3gB2WopzgCFAo/BMnxOlNPo3FRYVEDSgXTBlvpBcjMqIAaYCzF97X3AImX9zUzU/3ZzH/NeBB7JrKddxZsJujhEOcEEoaouH6Rm9EMQHZowsv/aruB+C0JENcxdK/eb4I+6NjQwPeEKlI/6uk/2mqRxD3sJFy38CGlNZ1+p4okLeXWxY+MiDop7WFENQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3995.namprd11.prod.outlook.com (2603:10b6:5:6::12) by SA1PR11MB6759.namprd11.prod.outlook.com (2603:10b6:806:25e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Thu, 2 Feb 2023 17:02:13 +0000 Received: from DM6PR11MB3995.namprd11.prod.outlook.com ([fe80::54a5:a239:8020:9f11]) by DM6PR11MB3995.namprd11.prod.outlook.com ([fe80::54a5:a239:8020:9f11%4]) with mapi id 15.20.6064.023; Thu, 2 Feb 2023 17:02:13 +0000 From: "Koikkara Reeny, Shibin" To: "Richardson, Bruce" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Burakov, Anatoly" , "Loftus, Ciara" Subject: RE: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration Thread-Topic: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration Thread-Index: AQHZD9KLSiNeohomUU6tmdIpuzHyRa6kTBCAgAG80FCAFgKxAIAACAcAgAAcgAA= Date: Thu, 2 Feb 2023 17:02:13 +0000 Message-ID: References: <20221214154102.1521489-1-shibin.koikkara.reeny@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3995:EE_|SA1PR11MB6759:EE_ x-ms-office365-filtering-correlation-id: 522bac4d-807a-4dd8-dff8-08db053f3ae3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BKN+QP0PK18BtbpD6riYt6pLTLEDDQSDeRrdJoQ9dWqeuDidrsWfpgwoVTBLoCnicXdm3mygR+/FAfN8Ja9zKKh2SWbHjmTD5AcRboqexkh5hRRLUMg2GGK88GFn0eteQfrIk4UCDxu0v3+05aoBVYxd8asxx+jr9qRNBh/cp5GJvLGqGciFNfkDiR6b2fwy+nIfnkrm6m7u3pxFsyKth2rNKnQGoceFOSbJOWEFQq80+mQv2CWxX7qsnSVSBu4VX3+Iv5zC8Md2+0q3jgbgjUcr8O54fEMGltGP42X3s4lU1Ulzow9MrIkddF4n533cg8vcB3UL4F3YXFXEMP9r2Bxk5J2kxHHXlk/hffg+s9Qy1ddunub77tD4NbjMDpv1sZPNfYOdc+c+of+R6qjKcM4U/DAYSzRrACQgi5ckJn1iosaYWW6X8m00dp0pOVVXyy3osaoSb+/MFlNSokrHradn2KRQzwSy096AkhvuAe1jSwoAPlmqYeprrAxHq2ig5gsX57oZxhJF3YbVDJSa9s/iMYmkzLjnkDnRq0R8cpXijaLMsyLmtMbyPgkNPbsYzHKBMe4tPfSptmcr3hcxI7YF/4qFDA2rWHePKcO7DPPTaIY/OISa1EUeOnbY7T5qQM1T7eAmXoweA/5NIjIJtGuyppmX+rbnOvLnUqsrY9rUS+UMDfmVTbUCGNTgnK78H+7THuq10seJwLWKNd5nkFZxZWCR5OlvOIFySnhfO7NvdGEjvohdlKQgrwEx+kQGhRoO1u2kdPEIdQLwcPuGlA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3995.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(366004)(396003)(136003)(346002)(39860400002)(451199018)(33656002)(38100700002)(8936002)(64756008)(82960400001)(7696005)(2906002)(9686003)(6506007)(71200400001)(966005)(66446008)(53546011)(186003)(8676002)(66556008)(76116006)(4326008)(41300700001)(107886003)(66476007)(316002)(110136005)(6636002)(52536014)(122000001)(478600001)(83380400001)(86362001)(54906003)(55016003)(26005)(66946007)(38070700005)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MmgfQDqR7Nav0UZG3DmbWItlrjidU5tu3iBpkexfK/kHYhkwYS+X6jc96uH5?= =?us-ascii?Q?EcWPi5l+HNjqRh8qWGX/ZtkeuEbtdhY7zBrfYUJ7SkrrDcY59vN94IvXkxHL?= =?us-ascii?Q?8Xds7nhtGnrvkTnelSHKWxOkF2jCtQ3euw2g0qr2DGzOioHfZZaDWoo3vJgq?= =?us-ascii?Q?6kMdvIG4AA1xRpk526gOuz27rdsCNbzT+FYXAbnwT2celiw7p23yWBmedj67?= =?us-ascii?Q?lga6tcqJ/D8bHaJEB+owBAni3kYN6cexb8j1JIlUDb1QE4BtRiOlHELtm4v8?= =?us-ascii?Q?H8r5Vg5z7if5ABdhk1fMSzexTuSnfqTIGaqJs8lgc0kCsAXik8/aBc7/YsmT?= =?us-ascii?Q?MVpNARztGvTa5vCvbcZOwIlOMAJ0yLbzGvVNsfwNvsqa3EKO4eL5S4zpBEIe?= =?us-ascii?Q?4wG2RwfWF/zrEq6MjB1ba5YnsqyHyYaLMe7pY8YCcNTyIvLpmaLgpowr3XJP?= =?us-ascii?Q?O7OK38uojJxe48UzMV8NLUQCxQ7hpEC9RQlewZgf648n8jNyYnvPHv4uJb7J?= =?us-ascii?Q?bi/P0JzPyRyxEaXM1Eu23gvKUibXgdUD/vaNwcPnTs17NPUa3vr2NXyBjlCD?= =?us-ascii?Q?MnmT04iCIH90qVAPAv+iVNnd/gzRVLI5nyb3sVHXVkoIfNlnzLSYnZ43rRih?= =?us-ascii?Q?RdrSVKi2xi3Kl4x7K1xKPHn/t/9lkgSvR4RDlkQqP38LHJJabRJllGXIwpPk?= =?us-ascii?Q?8zc0ZkWcprY5l6MFZsgP8SLxtC7y7x9uaDadMd2z9d9DCCIJrt6p2J3KipzN?= =?us-ascii?Q?80RhW8J+ZVZ/667YXMsmFoOwFK9Z/3IQ3813ni9+FoP/6/PFwM3HVQ69P5FG?= =?us-ascii?Q?+fO3+fdEsrurdul+xl0oxboQxQQL9h+NVVOj0yhtwC9fcf9ZURUs1OISuQ7X?= =?us-ascii?Q?5V07Vi1HsmC/BqCR9Y3TLAUg/RerDi6JL8RCThfAheJFiizlnnDssoWQ2mTG?= =?us-ascii?Q?outgIFhAMWEAX54m5dKlJ9Y0uBzwnaHEW/M+N56N+aTpOj+l43aBWoVWSIKw?= =?us-ascii?Q?asxa2b4OKlYU8xuoZ2t6Yp3MgF6gZqp9W8gElUv/ZaOzCyeoMxg0r2LfK6Rx?= =?us-ascii?Q?ZO3vnnt0JVzAY65IxWWZttjiAHiEykCduawGp/c/ZblQ6SAc4Ma5lam087pu?= =?us-ascii?Q?zrXJAC2bVp2Qds/MVSg18n3aNAcYbjYS/FwibutgF4bbQektZAq83m8TD8xs?= =?us-ascii?Q?uJpsnz5R34MjxiAUIQbJpTPcxs/ZAf9sHdDy41UrClCjoW/rzx0Cm93XyTL7?= =?us-ascii?Q?AOO7hndp4sJ8tV3IWYz08Q6iJQ/xx+hpq6/em1AXN0ae/JcEeexmOMbFMdbi?= =?us-ascii?Q?q3dw972IDlADWwl1BqWkatRPJNtlL5eiWTc6uR95i0qs/mMSfmtxJIbX8+03?= =?us-ascii?Q?pQuLUs0yjdmRmWTzxnQBZ/h7ULWE1dRSTU49rrwQlMVunsLf36fFF77S9SmD?= =?us-ascii?Q?kxpkNIbBaxVvkS3jLYY1GvHJsHEwZx/xMqsndlzpK23avtx5QpWIupUPl+QE?= =?us-ascii?Q?5nj4mq+dBukXPxoEP0bgNbO87aqMdSi/050u5ZYuKd5qyeM2SRrPvQacKUWS?= =?us-ascii?Q?wQaujoNdqR2cxN1ZZkhEjxJJpC6bdHYwro80CeQeyBc0fUjHCUpGLWCyDb1S?= =?us-ascii?Q?4g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3995.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 522bac4d-807a-4dd8-dff8-08db053f3ae3 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 17:02:13.1523 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Kb9NEt/JcUR3zenA5YPL4LfzltmXWXKEkNa4uzbNJtGMnBGpVhpOf+an7/3iKb7mTFFhWnxS5CalIMbcu4Tl7nR2Z6529KslczNrHySt/8c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6759 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Richardson, Bruce > Sent: Thursday, February 2, 2023 3:19 PM > To: Zhang, Qi Z > Cc: Koikkara Reeny, Shibin ; > dev@dpdk.org; Burakov, Anatoly ; Loftus, > Ciara > Subject: Re: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration >=20 > On Thu, Feb 02, 2023 at 02:49:52PM +0000, Zhang, Qi Z wrote: > > > > > > > -----Original Message----- > > > From: Koikkara Reeny, Shibin > > > Sent: Thursday, January 19, 2023 11:10 PM > > > To: Zhang, Qi Z ; dev@dpdk.org; Burakov, > > > Anatoly ; Richardson, Bruce > > > > > > Cc: Loftus, Ciara > > > Subject: RE: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration > > > > > > > > > > -----Original Message----- > > > > From: Zhang, Qi Z > > > > Sent: Wednesday, January 18, 2023 12:10 PM > > > > To: Koikkara Reeny, Shibin ; > > > > dev@dpdk.org; Burakov, Anatoly ; > > > > Richardson, Bruce > > > > Cc: Loftus, Ciara > > > > Subject: RE: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Koikkara Reeny, Shibin > > > > > Sent: Wednesday, December 14, 2022 11:41 PM > > > > > To: dev@dpdk.org; Burakov, Anatoly ; > > > > > Richardson, Bruce > > > > > Cc: Loftus, Ciara ; Zhang, Qi Z > > > > > ; Koikkara Reeny, Shibin > > > > > > > > > > Subject: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration > > > > > > > > > > Integrate support for the AF_XDP CNI and device plugin [1] so > > > > > that the DPDK AF_XDP PMD can work in an unprivileged container > > > environment. > > > > > Part of the AF_XDP PMD initialization process involves loading > > > > > an eBPF program onto the given netdev. This operation requires > > > > > privileges, which prevents the PMD from being able to work in an > > > > > unprivileged container (without root access). The plugin CNI > > > > > handles the program loading. CNI open Unix Domain Socket (UDS) > > > > > and waits listening for a client to make requests over that UDS. > > > > > The > > > > > client(DPDK) connects and a "handshake" occurs, then the File > > > > > Descriptor which points to the XSKMAP associated with the loaded > > > > > eBPF program is handed over to the client. The client can then > > > > > proceed with creating an AF_XDP socket and inserting the socket > > > > > into the XSKMAP pointed to by the FD received on the > > > > UDS. > > > > > > > > > > A new vdev arg "use_cni" is created to indicate user wishes to > > > > > run the PMD in unprivileged mode and to receive the XSKMAP FD > > > > > from the > > > CNI. > > > > > When this flag is set, the XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD > > > > > libbpf flag should be used when creating the socket, which tells > > > > > libbpf not to load the default libbpf program on the netdev. We > > > > > tell libbpf not to do this because the loading is handled by the > > > > > CNI in this > > > scenario. > > > > > > > > > > [1]: https://github.com/intel/afxdp-plugins-for-kubernetes > > > > > > > > > > Signed-off-by: Shibin Koikkara Reeny > > > > > > > > > > --- > > > > > drivers/net/af_xdp/rte_eth_af_xdp.c | 337 > > > > > +++++++++++++++++++++++++++- > > > > > 1 file changed, 325 insertions(+), 12 deletions(-) > > > > > > > > > > diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c > > > > > b/drivers/net/af_xdp/rte_eth_af_xdp.c > > > > > index b6ec9bf490..196d98ad97 100644 > > > > > --- a/drivers/net/af_xdp/rte_eth_af_xdp.c > > > > > +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c > > > > > @@ -7,6 +7,7 @@ > > > > > #include > > > > > #include > > > > > #include > > > > > +#include > > > > > #include > > > > > #include > > > > > #include > > > > > @@ -81,6 +82,24 @@ RTE_LOG_REGISTER_DEFAULT(af_xdp_logtype, > > > > > NOTICE); > > > > > > > > > > #define ETH_AF_XDP_MP_KEY "afxdp_mp_send_fds" > > > > > > > > > > +#define MAX_LONG_OPT_SZ 64 > > > > > +#define UDS_MAX_FD_NUM 2 > > > > > +#define UDS_MAX_CMD_LEN 64 > > > > > +#define UDS_MAX_CMD_RESP 128 > > > > > +#define UDS_XSK_MAP_FD_MSG "/xsk_map_fd" > > > > > +#define UDS_SOCK "/tmp/afxdp.sock" > > > > > +#define UDS_CONNECT_MSG "/connect" > > > > > +#define UDS_HOST_OK_MSG "/host_ok" > > > > > +#define UDS_HOST_NAK_MSG "/host_nak" > > > > > +#define UDS_VERSION_MSG "/version" > > > > > +#define UDS_XSK_MAP_FD_MSG "/xsk_map_fd" > > > > > +#define UDS_XSK_SOCKET_MSG "/xsk_socket" > > > > > +#define UDS_FD_ACK_MSG "/fd_ack" > > > > > +#define UDS_FD_NAK_MSG "/fd_nak" > > > > > +#define UDS_FIN_MSG "/fin" > > > > > +#define UDS_FIN_ACK_MSG "/fin_ack" > > > > > + > > > > > + > > > > > static int afxdp_dev_count; > > > > > > > > > > /* Message header to synchronize fds via IPC */ @@ -151,6 > > > > > +170,7 @@ struct pmd_internals { > > > > > char prog_path[PATH_MAX]; > > > > > bool custom_prog_configured; > > > > > bool force_copy; > > > > > + bool use_cni; > > > > > struct bpf_map *map; > > > > > > > > > > struct rte_ether_addr eth_addr; @@ -170,6 +190,7 @@ > struct > > > > > pmd_process_private { > > > > > #define ETH_AF_XDP_PROG_ARG "xdp_prog" > > > > > #define ETH_AF_XDP_BUDGET_ARG > > > > "busy_budget" > > > > > #define ETH_AF_XDP_FORCE_COPY_ARG "force_copy" > > > > > +#define ETH_AF_XDP_USE_CNI_ARG "use_cni" > > > > > > > > > > static const char * const valid_arguments[] =3D { > > > > > ETH_AF_XDP_IFACE_ARG, > > > > > @@ -179,8 +200,8 @@ static const char * const valid_arguments[] = =3D { > > > > > ETH_AF_XDP_PROG_ARG, > > > > > ETH_AF_XDP_BUDGET_ARG, > > > > > ETH_AF_XDP_FORCE_COPY_ARG, > > > > > - NULL > > > > > -}; > > > > > + ETH_AF_XDP_USE_CNI_ARG, > > > > > + NULL}; > > > > > > > > > > static const struct rte_eth_link pmd_link =3D { > > > > > .link_speed =3D RTE_ETH_SPEED_NUM_10G, @@ -1129,7 > +1150,8 > > > @@ > > > > > xsk_umem_info *xdp_umem_configure(struct pmd_internals > *internals, > > > > > ret =3D xsk_umem__create(&umem->umem, > base_addr, > > > > umem_size, > > > > > &rxq->fq, &rxq->cq, &usr_config); > > > > > if (ret) { > > > > > - AF_XDP_LOG(ERR, "Failed to create > umem\n"); > > > > > + AF_XDP_LOG(ERR, "Failed to create umem > [%d]: > > > > > [%s]\n", > > > > > + errno, strerror(errno)); > > > > > goto err; > > > > > } > > > > > umem->buffer =3D base_addr; > > > > > @@ -1314,6 +1336,245 @@ configure_preferred_busy_poll(struct > > > > > pkt_rx_queue *rxq) > > > > > return 0; > > > > > } > > > > > > > > > > +static int > > > > > +init_uds_sock(struct sockaddr_un *server) { > > > > > + int sock; > > > > > + > > > > > + sock =3D socket(AF_UNIX, SOCK_SEQPACKET, 0); > > > > > + if (sock < 0) { > > > > > + AF_XDP_LOG(ERR, "Failed to opening stream > socket\n"); > > > > > + return -1; > > > > > + } > > > > > + > > > > > + server->sun_family =3D AF_UNIX; > > > > > + strlcpy(server->sun_path, UDS_SOCK, sizeof(server- > >sun_path)); > > > > > + > > > > > + if (connect(sock, (struct sockaddr *)server, sizeof(struct > > > > > sockaddr_un)) < 0) { > > > > > > > > seems the server address is hard coded as "/tmp/afxdp.sock", is > > > > any spec we follows, or should we parse this as a devargs? > > > > better add some comment or external link that help to explain > > > > this > > > > > > It was already hardcoded in the afxdp-plugins > > > https://github.com/intel/afxdp-plugins-for- > > > kubernetes/blob/main/constants/constants.go . > > > > OK, I saw this has been explained in your new doc patch. > > > > Reviewed-by: Qi Zhang > > > I would suggest the doc patch should be merged into this patch - code and > doc should go together. Please do a v3 with both patches together, thanks= . >=20 > Assuming Qi is ok with it, you can probably keep his ack on the new versi= on. >=20 I have merged the doc patch with code patch together.=20 Patch V3 :http://patches.dpdk.org/project/dpdk/patch/20230202165513.31012-1= -shibin.koikkara.reeny@intel.com/ > /Bruce Regards, Shibin