RE: [PATCH] bus/ifpga: remove useless check while browsing devices

["Xu, Rosen" <rosen.xu@intel.com>]

Hi,

Thanks.

> -----Original Message-----
> From: Maxime Gouin <maxime.gouin@6wind.com>
> Sent: Wednesday, January 05, 2022 18:27
> To: dev@dpdk.org
> Cc: Maxime Gouin <maxime.gouin@6wind.com>; Xu, Rosen
> <rosen.xu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Olivier Matz <olivier.matz@6wind.com>
> Subject: [PATCH] bus/ifpga: remove useless check while browsing devices
> 
> reported by code analysis tool C++test (version 10.4):
> 
> > /build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
> > 67    Condition "afu_dev" is always evaluated to true
> > 81    Condition "afu_dev" is always evaluated to true
> 
> The "for" loop already checks that afu_dev is not NULL.
> 
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> 
> Signed-off-by: Maxime Gouin <maxime.gouin@6wind.com>
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>  drivers/bus/ifpga/ifpga_bus.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
> index cbc680928486..c5c8bbd57219 100644
> --- a/drivers/bus/ifpga/ifpga_bus.c
> +++ b/drivers/bus/ifpga/ifpga_bus.c
> @@ -64,8 +64,7 @@ ifpga_find_afu_dev(const struct rte_rawdev *rdev,
>  	struct rte_afu_device *afu_dev = NULL;
> 
>  	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
> -		if (afu_dev &&
> -			afu_dev->rawdev == rdev &&
> +		if (afu_dev->rawdev == rdev &&
>  			!ifpga_afu_id_cmp(&afu_dev->id, afu_id))
>  			return afu_dev;
>  	}
> @@ -78,8 +77,7 @@ rte_ifpga_find_afu_by_name(const char *name)
>  	struct rte_afu_device *afu_dev = NULL;
> 
>  	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
> -		if (afu_dev &&
> -			!strcmp(afu_dev->device.name, name))
> +		if (!strcmp(afu_dev->device.name, name))
>  			return afu_dev;
>  	}
>  	return NULL;
> --
> 2.30.2

Acked-by: Rosen Xu <rosen.xu@intel.com>