From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFB8141C2C; Tue, 7 Feb 2023 08:16:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEB0941148; Tue, 7 Feb 2023 08:16:39 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 24A9F40EF0 for ; Tue, 7 Feb 2023 08:16:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675754198; x=1707290198; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vRv4eo/0xzz/iRSy+2I+uqVaY2F/eAj+TEtjLflbWnc=; b=HmWCHULrkZU3EddHRT0CTQSs33T8CWouFa3afd13F6e6tHq+rLn5mOUE ZNb24ok250iNr+WswGoPTZQJ6+guvBEhtvWMFa9CDCRExU2CtiH+0R0Xy BGfxTRyy0lW7tmp9HXJRAeKPJqgi6kHHQPq3xYgmL7zAIIjBm3K1uvJlC vSd/oMjCmHKgs7lvYy/15+vBjjA/On6rujXALRdbo7xYKeNXd3kgjDq17 Mi10OJ5vq545Nz35C95h4cMmD6aAXn8HH98LRHwXCuBdncd1cgeRwTzm6 oqSveTpZ94ojRs5LeV2H6hZfYB43zLUwT5a0hgrYl7xl0COxuoFtR8/V3 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="391822537" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="391822537" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 23:16:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="790693053" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="790693053" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 06 Feb 2023 23:16:36 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 23:16:36 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 6 Feb 2023 23:16:36 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 6 Feb 2023 23:16:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KllJ2sD34e7CriLOChk1QnWv0flGhEggpv7DtmJRaQjgbIYF2CaM3vX7kWJPZ1Vbp3JgpQXXdAB8PZZcqWAlOcUkryqt5kwydmPA9s0gYVXJwOzALcsvpRQV9NQNlbggEbYdd2izwR115Y/7wyaQOTz/RwmIx8HAjzMyVp+Tnclr5NqJx5+xnsEa3AAZwnjhHvoeZPDWBjVL3Yt0CHyed/ctKeSIvCxUNDaTGD4D5wst3KyHbLcT8QSlSYEQHI0IFiLkymg7ThL0Vw7iyiY36zV8qKWZCd65v/So0auBv5ZDycxokZCocCndUpISbcUef+GSufJvaoG3FKeKzzbppQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1unP2/VKb7GcZiAvf55wyaicReaauidVJb772ELHRIE=; b=UMAna5Y0PBQ9+/JbKXXXHRkJyutN0/QttqwfJTVvuiJKC7ZSuyR8Zctq+T5bUG0jlap5IFIumn2tR6/CIPOq8eBUJEiMZ27TJ1jQgfrfPqqc1ENlCOIuHfjPhsGMytckDDsDxWEx0KcUPWL+Q69qVyAxxnl1eALh7H+ok2kpuijtkKXQYgk6d7H6idBfjReQuDAAyYZa+ACQFcn2RWkErwtq2hGkPP6PDQClqPH5+9Sw3FQHVt6g6vNnsa2Po+e0cjNLgKJNxM3k6UMxdn3d3WpDprhu4swW/ieo379qugcFf22J68ueATBkdPgMiEq2l22gBIAhHFRMBH1A/3SJgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4252.namprd11.prod.outlook.com (2603:10b6:5:201::26) by MN2PR11MB4551.namprd11.prod.outlook.com (2603:10b6:208:269::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 07:16:34 +0000 Received: from DM6PR11MB4252.namprd11.prod.outlook.com ([fe80::2ea1:b4af:c499:90fd]) by DM6PR11MB4252.namprd11.prod.outlook.com ([fe80::2ea1:b4af:c499:90fd%5]) with mapi id 15.20.6064.027; Tue, 7 Feb 2023 07:16:33 +0000 From: "Xu, Rosen" To: Chengwen Feng , "thomas@monjalon.net" , "ferruh.yigit@amd.com" , "Zhang, Tianfei" , "Huang, Wei" CC: "dev@dpdk.org" Subject: RE: [PATCH 2/2] raw/ifpga/base: fix mmap retcode check fail Thread-Topic: [PATCH 2/2] raw/ifpga/base: fix mmap retcode check fail Thread-Index: AQHZOhocUPc7UJcw90GWVqBfm8fleq7DE/TQ Date: Tue, 7 Feb 2023 07:16:33 +0000 Message-ID: References: <20230206105311.9577-1-fengchengwen@huawei.com> <20230206105311.9577-3-fengchengwen@huawei.com> In-Reply-To: <20230206105311.9577-3-fengchengwen@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4252:EE_|MN2PR11MB4551:EE_ x-ms-office365-filtering-correlation-id: 18c4af0b-5494-49eb-e252-08db08db3e4f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m3tWI7ZCUqgCul3McLEMbm8aASTdqdAX7brU+o3LsaxtyfcxzCjzcWCMyU4QqkJvnFuLxlbl+E8o04qYHFQZ0cIAF7OWJeOio+uexHxiVtG30kHi9mJUq0f2klLKu06B1BUhq8p2TR/ORLEXoduu/9itIHzVxLNKtOV7ZL3eJYWKB0s8v951+W7P3aSp6F6ybld6iWZysWyw7pHKdQVrRvSeJvgC50MDP5iP8pPuPNzuIj/YZ9Je4cJNJThDDBUl5VH7lHp9n0Uf/rinzG/IyRBWXlnWwf6aXAgnreOoU6rsSegRLZPw4YLxkcTRC85zEWJloJLGozXSYuM5RVtl8+h0n/Bw0DSB8pekXwpEk3JW9t5dX9YA/Fw+XEYruBTaPnA29/X6quUNYWgNZaocHbADLsV4LQ4GJzP6YAh9PasMMH1W5TfLpJg7oPF6gPWgFxEkLmbzhCj6pgo3+lhDbYnrfuB2KYFYttzZ7Zb4K1cei76vIPCufO615IfMfC2v3avtQlHy3oYSq2pFBNhWyMmhCl4vmzkR4e7lRCaUffpI9VBFzfQBwI8BAAhqCj3f6eHq5YDdbFY90NgyvPVjM3wIZ9sR4b1Mqm2WE6HMHbhBGTG8OC7ThcC5Fye0hoPR3uN1GLaG5F9KE3YZSNDz8HWeSefWhmYd8B4vLq+CCAkOPJt0oVaXcFAPK3XzGvBfqTuhv5RLa9DRHN1j98Hnjw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4252.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(346002)(376002)(396003)(366004)(39860400002)(451199018)(478600001)(7696005)(316002)(2906002)(71200400001)(33656002)(38100700002)(38070700005)(55016003)(86362001)(6636002)(82960400001)(122000001)(53546011)(66476007)(83380400001)(76116006)(66556008)(8676002)(4326008)(64756008)(66446008)(8936002)(52536014)(110136005)(41300700001)(5660300002)(9686003)(6506007)(66946007)(26005)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lkfQEZNIdXTnqhTtr5ZTQJzhqQ++O/dExvCmrU5QSEgyQMu6lpkh14d3dIee?= =?us-ascii?Q?yhRVXe3jdytnPTOs6tqrEUqEGHfUQtnT82jty9zawj11rf1SyB7ldoSM8orG?= =?us-ascii?Q?OYhlIsYIPsKyLNPclnrrrmhsRkVNnMUvYGApYBNkjXLzwP5Qn006132AWbqU?= =?us-ascii?Q?/fobgOC4kg/l7qvGgbdS7j5muFOaOpQy6sxh7gT02PwwprGKPp7w6gnNaGhY?= =?us-ascii?Q?hzODCSpfihjCNdQcLPuL7QH/Jfy2T6anBzVNrUnDazuKVPEn0zr+3lsy0umR?= =?us-ascii?Q?omDJp2jBrLN0fKwGq7PeMHPSeKDkD3aNVMOMtRdPDR+fHfayOGlbI16i2VEJ?= =?us-ascii?Q?Ts01RALXpmNTdpP2Z3frG/i7Bjm9REJaH63IWq1BPollsZBi1i69FoJ0TpyM?= =?us-ascii?Q?S0jntVGSpowr/41INyJAQUZNn6evFCSefXqMBfPdPOlythul75aybf5uFBrS?= =?us-ascii?Q?8f3Iw5vnUeRUl9NbkgHYmvf860uDX0iUsVI0ri+YQALqEDF1wz5g4TWEqAGA?= =?us-ascii?Q?Thr67dnee36O87YrRtiDClup2icBAx8/RX8TZf63F/nmNntKK4KnAPIlhCDH?= =?us-ascii?Q?391kcLstSn1g8Bo33t6MWKlDFEblPih114j0wzKlozeSsZ2EZR51MY6UQk4s?= =?us-ascii?Q?IOTSzb/g78AyxnxernUA2EG2gequtSH7zEYbsFlaQcgrBAS9Td+Egxnks/E2?= =?us-ascii?Q?ZtecDn1VbS0+wwdQ7t6kN16Yro9V8KvSXTuV2cwEROgTyGL6EYCeCVuIcTpM?= =?us-ascii?Q?H1jAvZKxflOk9lKqqkhEP+g8N4NN2MRvXQLkY2YNM891aShiPXvLt/MHhk+M?= =?us-ascii?Q?IcEFFWsw1wZJhpdPtIrA7cj1ufbletRA+FnzTo9MhFbIrBZnMeHZBV9uHaI9?= =?us-ascii?Q?GT0NOt6DZIhxvE0A8/3qKP1z7uF1b0ayQmYGyF/E81WD8MpM9E3j4+F4H8vJ?= =?us-ascii?Q?J0cb8HFCYwVT/MEE0om8Q6Ssc9v12vFX35ILaUSbNxaFm6bot0oVxzN14S+x?= =?us-ascii?Q?lC3P1p2HYjjWc+9vCnkkNQUilfAT36u4OsWZBLV92WIM+N7W8OEToYeW4TqO?= =?us-ascii?Q?/HeLLwsRUEiFVYSUuVBvF2TRAR8w3kDdX5ov+/G0208gli1j7eKUaiQr1A4y?= =?us-ascii?Q?FGpTFKCqE7JwphkwU4tCkEVBNc28Sg+rdundJ3cv8YbHMs52O271fjiFu3En?= =?us-ascii?Q?ICxFPcetgXidIoOapROxollCZc5plEdmGUGFe+CSXxLNoaJlI9slAk79Er9r?= =?us-ascii?Q?OFZV016thZRq39d/V/xgvo7UrTiTiLBuqhE3np6Rrq1hqfT/rslY1k8MDBuU?= =?us-ascii?Q?4W0q6KESAd8gs++YIx2snLr/tjPJQetKPonzWdPUuQUanQ9Za6sV8g3M8GqL?= =?us-ascii?Q?71uIQSftufFS1brXI/PyvR2naO0VJLKbcmKaYs0gZhSlqWafvSmcTAOsXweF?= =?us-ascii?Q?9NZSb46cNXRknREcTyRM8kiPr2uR4ZnXm9Mi+ZLSiizOzA0QgjxwF4NTCHcf?= =?us-ascii?Q?Szm0BUyakLK0GNsW3KGet9dgZCibzO17pr3qMoc2EzZIzUPJN3Jp3a7laHS3?= =?us-ascii?Q?e3wh0Gbpn+mXUXdwFuCCZlkYHvmaCq6IlQvoZCzT?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4252.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18c4af0b-5494-49eb-e252-08db08db3e4f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2023 07:16:33.9027 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eLj6Z8mdc34+0buuFPfM+3jN1/Gvib2WiRVl8T+4+LYc4nyYBywDzbBvRrsfXXqFXcGaYBkOcxJ6hajxo/yq8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4551 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Chengwen Feng > Sent: Monday, February 6, 2023 6:53 PM > To: thomas@monjalon.net; ferruh.yigit@amd.com; Xu, Rosen > ; Zhang, Tianfei ; Huang, > Wei > Cc: dev@dpdk.org > Subject: [PATCH 2/2] raw/ifpga/base: fix mmap retcode check fail >=20 > The MAP_FAILED should be used to determine whether the mapping is > successful. >=20 > Fixes: e41856b515ce ("raw/ifpga/base: enhance driver reliability in multi= - > process") > Cc: stable@dpdk.org >=20 > Signed-off-by: Chengwen Feng > --- > drivers/raw/ifpga/base/opae_hw_api.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/raw/ifpga/base/opae_hw_api.c > b/drivers/raw/ifpga/base/opae_hw_api.c > index 1117c3e160..6d48d227d6 100644 > --- a/drivers/raw/ifpga/base/opae_hw_api.c > +++ b/drivers/raw/ifpga/base/opae_hw_api.c > @@ -380,7 +380,7 @@ static pthread_mutex_t > *opae_adapter_mutex_open(struct opae_adapter *adapter) > PROT_READ | PROT_WRITE, MAP_SHARED, > shm_id, 0); > adapter->lock =3D (pthread_mutex_t *)ptr; > - if (ptr) { > + if (ptr !=3D MAP_FAILED) { > dev_info(NULL, > "shared memory %s address is %p\n", > shm_name, ptr); > @@ -499,7 +499,7 @@ static void *opae_adapter_shm_alloc(struct > opae_adapter *adapter) > adapter->shm.size =3D size; > adapter->shm.ptr =3D mmap(NULL, size, PROT_READ | > PROT_WRITE, > MAP_SHARED, > shm_id, 0); > - if (adapter->shm.ptr) { > + if (adapter->shm.ptr !=3D MAP_FAILED) { > dev_info(NULL, > "shared memory %s address is %p\n", > shm_name, adapter->shm.ptr); > -- > 2.17.1 It looks good for me. Reviewed-by: Rosen Xu