From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2D68A034E; Mon, 21 Feb 2022 03:46:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7657B4068C; Mon, 21 Feb 2022 03:46:52 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id CB52240395; Mon, 21 Feb 2022 03:46:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645411611; x=1676947611; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=dfqflPYHc9UAFovQA/abnIYgD3OMEjexiQJaQHyyDtk=; b=GIB3c4BaJaL5pgUEsUW0WNBu3ienl4tfY9WTmQzN9zZHkpZLIEzBkAEe vQ7V/Er1CCgjwzYKveQ7fNhPP9GYxu++5bSZGC44fyjIlCVfHedcf/ou7 s6ov6QsHEcF30sH/uu/Wg1rtAsh3hfLBE/B8gCMj/xLeaCEujtwT9xocO 6+UzCGkF3rYzDiUJjZGUqoW0QgoeaekkCy+HtOkAptdsyXk82fbUCNAay wvqEm6XG10/rZFA5hUe09CxC6x8JNmHuXWba55Hnuyn0lsOjNVDOJa4Az D4YuuWHd+a8t2T6+aCc0IRZlNlKSLEODBI1FlUNrXd2b9HWYXaO1czy7o g==; X-IronPort-AV: E=McAfee;i="6200,9189,10264"; a="251175856" X-IronPort-AV: E=Sophos;i="5.88,384,1635231600"; d="scan'208";a="251175856" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2022 18:46:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,384,1635231600"; d="scan'208";a="638400638" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga004.jf.intel.com with ESMTP; 20 Feb 2022 18:46:49 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 20 Feb 2022 18:46:49 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Sun, 20 Feb 2022 18:46:49 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 20 Feb 2022 18:46:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Csa9Kj7VOZ2NOce2kFIbwrv7F7AyvfQkgbg6adPzfHYCI+1EQiWmyqPcTIjMAfT9HQO86SOotuQCdSYNCBvTbegP5UWSy3a/glOVJz76+xBJQdcbLOVOyxBTpl9SOHnvJKXKOrR2U8tWnAiHndNMAU6zzjkjg+YNoE6MwTLCjY2N9/FfdteYwP09QdBk9IqdwKe2bYnsBAj1MTFzZreAkL5AKacuu+Jh5cFq+axmq+e4bF4tP25Rg6ZBNUHVxyRymuHpeHK3o2B9z7DXOmO8Xaj+S7S/W4f91Wa3vnLfMWKr0r3g41jUhe7xGI2GUlAPOywvWXkSlYtA/NNZE51cJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hRtD1E1wnrFXGLg4LGi8zDzWFSx+mPG4u04S96Y0l0I=; b=ISSkTgfvlu28+x6WDtZpbnCVTFtLAyVA/MRY+QcqzJ9Adq6FKAZfmLaEd1RtpxNvpNgMBkYz1fyWtjdtB38MF/moKEe6eHoyvQs1VqQ2c4is74Mrn5/P/VRxfFwL13m+OBPOIPr+fC9y+DYeuj+KrGyBh/zG2BzabaieIwNnk8SWObfAvwP1nv74ysCQCycUE62mVYpKmU5KAxh5JSU1m1JvO92eq6gVWpYdNKOrXQpJ2Io4U20sIzKv0445xjPuGW4OxkysTpOQ5WuKizBypEJruuR+1HshjUUgHaZ8+yzkql9gYDRAXsG/jIjU5IDWwyB0xgZxAP5cHxrvNFM/yQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4252.namprd11.prod.outlook.com (2603:10b6:5:201::26) by CO1PR11MB4787.namprd11.prod.outlook.com (2603:10b6:303:6e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Mon, 21 Feb 2022 02:46:45 +0000 Received: from DM6PR11MB4252.namprd11.prod.outlook.com ([fe80::d0ba:999b:3297:c220]) by DM6PR11MB4252.namprd11.prod.outlook.com ([fe80::d0ba:999b:3297:c220%4]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022 02:46:45 +0000 From: "Xu, Rosen" To: "Huang, Wei" , "dev@dpdk.org" , "Zhang, Qi Z" , "nipun.gupta@nxp.com" , "hemant.agrawal@nxp.com" CC: "stable@dpdk.org" , "Zhang, Tianfei" , "Yigit, Ferruh" Subject: RE: [PATCH v3] raw/ifpga: initialize scalar variable before using Thread-Topic: [PATCH v3] raw/ifpga: initialize scalar variable before using Thread-Index: AQHYJsoSG4bRZU1kzE6N4cMHnVone6ydTOIw Date: Mon, 21 Feb 2022 02:46:45 +0000 Message-ID: References: <20220218032053.266035-1-wei.huang@intel.com> <20220221022019.303075-1-wei.huang@intel.com> In-Reply-To: <20220221022019.303075-1-wei.huang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzY3OTA0NjMtZGE5YS00MGI2LTk5OGUtZTliZDI1NzhiZDNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVXpuNVd1UkphNVUrRjdySzZ4SEVHQVdMK0wzWTdjVkFRbUNlR1dhWlB4TlROa2JDcnlCWDA5ZFwvdnZLOWF3QTMifQ== x-ctpclassification: CTP_NT authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a527c177-90aa-43d7-7db6-08d9f4e46609 x-ms-traffictypediagnostic: CO1PR11MB4787:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GRPlVbMTygs43sQC5Ud/v1ScrV2FYygyT+g7YY0iYj5rHwB6lPXHRf1pATdM+bC8T3Lq6I9TFSoKJrN6L2Bd3uCuWrsbKCB54EIoNiVGlyL/yKbT2ywPuHdewqPX5Fzg34HexpFmpNuPa+Ht5qpUMT40FAFiR9FHzQLOMX5Ap8Amr8yRTa8Ph3pW4ROoFUvu/kmV1sA7KXdcs17M2TkGZsdw+y/0F2qsZLXj3dNCPC5Mc4exxwgnzR54lCuPHXz9InquwGmY5F5FCWy/aYiHkWMM2VJKvx3f7Rxn10F0x28rUn4zhp0if9kQmwjJacUesye1oTt7taMfGlrjkojkxOJkq+caNzCjprekc4o2RyNbTNjKIgIFEXy7KT8XsnHoj68aFSffVH+WEgBLLTKEuO1mOFrpPcIOaedGWWGgk699vzZuMCu+lRkrYvhUxjFKwwqqf/dDZbK0FU2py/01h/BrFRQkUBF6Cx98IIzkWq6hpEh82i1DgTO225APGKAQnx9WqaR+i/EfFkRQQrrzS3BQPZSq3gSnRywdHxcBvGVZPBUnbVAJM4YcQc/m/zGvDLDV2wU/u0h006loZF+xX8EZXXDCCXPP/N8qnmYhZJrv+n5P9MKFLrlMTE4VYoMyIVeMU8nirPk4aLtMxLP8Dvp453j/u9y3nQwsipkw9k8Np+7S5wqGgn2ATLFrrCTvCM2BDXQWCqYVKfJzcQMv9A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4252.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(26005)(186003)(107886003)(8936002)(6506007)(5660300002)(52536014)(71200400001)(33656002)(7696005)(9686003)(508600001)(83380400001)(55016003)(53546011)(76116006)(38070700005)(64756008)(66556008)(4326008)(66446008)(82960400001)(54906003)(66476007)(86362001)(110136005)(2906002)(38100700002)(316002)(122000001)(66946007)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TvsT4q/UYITmoyovb6vn3PNPJkByiw1UbXrrqJEKgAb4gDMK6ge0H3ZG5jhg?= =?us-ascii?Q?iLCfByzrntwkVhTABYGOE63gJ5V8wAYZNJuFF/1qc9qTKmIr5hDtuBSRb/o9?= =?us-ascii?Q?Q3XJJEc0hzF80HBuQWULH+RtQAcTjAvXIpVwmmNst6Xeaay84BT+3ELe3l4L?= =?us-ascii?Q?SKwT2/kdDy1kuGR0/Q6P+UEUBNmuLBMhgyArx+j7BuVv2LKttAPpLZ2Iqlu6?= =?us-ascii?Q?szgCLZQWWsh6EbxGLePka68Q9+1gye8YkTZObafx+9kTtxel+l7ZftBYxOME?= =?us-ascii?Q?xEz6lnbBfBYaygGSIqy2f2UR/VwmZSUxM7xkOQqHGa2ob5R2VO51u5iPqBwN?= =?us-ascii?Q?9G895hov6h0mfqnb4oQ+ow4X7czoesplxXGZHP1NrvBknAtZJUL096n4GNxK?= =?us-ascii?Q?2/iel+rR/BnP32iReG8mnnccU2YUJC7NKbjF5LDWJ1xdtbGWCGj2LokW8N+3?= =?us-ascii?Q?WO6uoXsZZ41LAZ1D4p6rU2mAiEDnzpM2wN3cvUgVeHWUsuuTb2XlNDKq/wst?= =?us-ascii?Q?dGQb9GF5Yu4dBkF09K8h/TVIEmtWpr5SEhKnCn+ndUnWN9T/AxhKUOfQunnk?= =?us-ascii?Q?7DAl4ojx4puejjHtAVA5ti9wVbNQJT8vsJrCJMm3vZpRW92C9xJokvIjVn+s?= =?us-ascii?Q?sRdg7Rh/j64P9lY3cdjs5VF0HML9Nc11EUomiY0JCi3A+3gIMx8elThjaAJ0?= =?us-ascii?Q?rIAPI/6I9cftPofG/Yy6XcDW7hxt13s6R+Oo2SuhG9FakEfrPk9vMO3MvRiB?= =?us-ascii?Q?bUCo7lTgcbKo14iYrzy6k9LIpMHLsvQBv8RJM2ym0I6k/g9glpF/8EE5QFvD?= =?us-ascii?Q?dI9WOCOYdSfxP8jKlNBc1nwht8tlN/kVwFxq1BFJqW8Qtd44DBIcteF2N9RX?= =?us-ascii?Q?L19wp/ehZbgJ2Awx1Q8H+MJ95abm0BTGpBdpcqLxhYf1B+142oHNXl7gATFq?= =?us-ascii?Q?YzeBHk4QtaOWoaPLevPaC6Bv1NS0o7st04tyUtgl3QJcnqrmc4Hz04R4uIJH?= =?us-ascii?Q?bCGsF5Ob7yyVaZEgc5W2ZJPe8pGJZByma/PVoNp9OlewC7tWjrQ14EHn4Ebl?= =?us-ascii?Q?DVXGaiGpX+iK1yDX96l+9I032ymQQ1Hkk/ROnaZmRCuwrd6IcGKuNxt7eEEg?= =?us-ascii?Q?9+QcL/rlcCO7d9WumFYYf5W0jinvpQqUc6IBYSNgcWC+AsjE3y9pJx6jGBzQ?= =?us-ascii?Q?mtUbrz0eOI5iITtUglWUE5VMxEQWTBecUfUcTtLHZWbMf0msyOZdRs+DRtz2?= =?us-ascii?Q?/Tu3cKqaK6z+XpPuhro9jZrimtT0EdZo5/48JCNqSU5zSX+D/YVuTeqTHVNg?= =?us-ascii?Q?YRH2d4HFNILVkTx3CtNo0BCYdoxcL704ba/Tfo+D8UF20As5uQXo9R8ue73Y?= =?us-ascii?Q?diWfkZCjLuv1YL8aoVNXZSTzM/zjbx8yXvVNWHr4o/IoEWmOnQNEikpYmK/b?= =?us-ascii?Q?x6cqenxqOWXBBRKCICpmJrqxysVqaIMFBdi6nnuqICEjB870CLty9X+6M6u6?= =?us-ascii?Q?R99ciqFlkFIvi3f52ZG1rhOymFr+zU5PpPjdMKOh+WIbpigw9hF09+LV58A3?= =?us-ascii?Q?KYTIXMLF3073HCGgHT2TZbWfnFtT8GS2nGBwnSWGyk0DD8Su/qllH5A01Xz/?= =?us-ascii?Q?mg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4252.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a527c177-90aa-43d7-7db6-08d9f4e46609 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2022 02:46:45.0161 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: U8tTyNyDUNNbqmQY+MaiAsty+xA+NDIOZk2uhIsHp/bBYFb2CNQ+uCyIRodw8XIltySuA1IYRtejQxo5g5MLpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4787 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Huang, Wei > Sent: Monday, February 21, 2022 10:20 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > ; nipun.gupta@nxp.com; hemant.agrawal@nxp.com > Cc: stable@dpdk.org; Zhang, Tianfei ; Yigit, Fer= ruh > ; Huang, Wei > Subject: [PATCH v3] raw/ifpga: initialize scalar variable before using >=20 > Scalar variable sub_brg_bdf may be used uninitialized in function > ifpga_rawdev_fill_info(). It is initialized now in this fix. >=20 > Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Huang > --- > v2: add space after comma to meet coding style requirement > --- > v3: refine log > --- > drivers/raw/ifpga/ifpga_rawdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c > b/drivers/raw/ifpga/ifpga_rawdev.c > index b73512d..c133a94 100644 > --- a/drivers/raw/ifpga/ifpga_rawdev.c > +++ b/drivers/raw/ifpga/ifpga_rawdev.c > @@ -216,7 +216,7 @@ static int ifpga_rawdev_fill_info(struct ifpga_rawdev > *ifpga_dev, > char dir[1024] =3D "/sys/devices/"; > char *c; > int ret; > - char sub_brg_bdf[4][16]; > + char sub_brg_bdf[4][16] =3D {{0}, {0}, {0}, {0}}; > int point; > DIR *dp =3D NULL; > struct dirent *entry; > -- > 1.8.3.1 Acked-by: Rosen Xu