From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 276B7A00C3; Mon, 1 Aug 2022 08:54:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F4E542C66; Mon, 1 Aug 2022 08:54:16 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id C92844067B; Mon, 1 Aug 2022 08:54:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659336855; x=1690872855; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=IRzobE34lLDkG6KJhy1HvgGD9jIc+hWexNYnheZm6UU=; b=WMu93avkbn7l0TAe6gtyQvJf6JlybOQ7HWjmwilkYYHNZcdN1WeaKOyK hrChWQUM6yiBmu/lFGHoVXFhlX+zzoPUPVVOMQwGekui1ft58cc8ya+ia HPU3/ocz84JHre/JvSByM2WBP9jLQOKMU7IB8t3+HbFG1FNqyn+Z6IMiI TDcyQUBpSxAm+9vR5GMM2MLfZ9/UStXVMpNYfML0vWFzBQpm2pQM1kv1P LSIlYI6aDF6lhFE/KyV/Z0N+YdA78tFgH6sZJXJ145yMVvOrnnUgl1/i+ wP04de19tgDgJVfLkcM5XZlhYVPb2mQ02HIJZut1YcVDQrgkeLKyKbSx+ w==; X-IronPort-AV: E=McAfee;i="6400,9594,10425"; a="286636914" X-IronPort-AV: E=Sophos;i="5.93,206,1654585200"; d="scan'208";a="286636914" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2022 23:54:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,206,1654585200"; d="scan'208";a="661025069" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 31 Jul 2022 23:54:13 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sun, 31 Jul 2022 23:54:13 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sun, 31 Jul 2022 23:54:12 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Sun, 31 Jul 2022 23:54:12 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Sun, 31 Jul 2022 23:54:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MAC7j00+TjlZrVFUStWLhvs+QZk+MRjyDvdccID9uUfwaNp84FnrEU5nQuLZ7w5tBHeTR0dYunjxLIkLXvlybHaIMAcIpvcAbGnfS9rJzr5XtWouj697IVQQ5/fAH9I1TY441tfJW5OBRWUwd/WT6iO03qBSuwowtFvnoTC0gFAt6p1r7c1aDR+oIeHUC1juE8fv7mC2acmi2OOnxlucXymUlSIkDc5Pycpy4WRhkRrK+qRl0RDajRv8fZ567tzqcKUSZ5rasJKjZbtkiT+qdErtSs8Mj/L3pR3juWwd9PPRtGI3jZyhRiiITqjZe3h3Sj8VAd8EL/oXbR1ZKS0g8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cWyqa8WWYiq8t7kuWDZnG5iSZ21lYjU6XDtt5WZ2PGY=; b=hu6Zzjtc4FZ0M2eGzcewyiJdFfIyQNci9Ne1ZyLI2Z8iq+77c3KWiGrRabD0N8sEOn6K5xG39u8KAvnpcRGD88BdtWKPq5mlj8INv5zmyW8DR9XfJYC1VgORhlbgu734jiC/0x6p9qlhgd9aFyyIi8PsX+GiBUY02ZP4hrpnG9WiGx/2uWb4+w75LpiU3qOvH8ZnYMTcBwjO2Wf+eEP7dD03hkzFQreYuf/BvipK8R7mF5h/6vNZjMoscZW/jDv94Ex9q91B3Pxgbrby0q3m2SO9EichYJI+xTwPgSLncPH8YiP4xujiciehIV9Xyhv/vYMcYjU4RDTOl1ig7IwgDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4348.namprd11.prod.outlook.com (2603:10b6:5:1db::18) by PH8PR11MB6612.namprd11.prod.outlook.com (2603:10b6:510:1cf::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Mon, 1 Aug 2022 06:54:11 +0000 Received: from DM6PR11MB4348.namprd11.prod.outlook.com ([fe80::6983:abe3:d792:ef71]) by DM6PR11MB4348.namprd11.prod.outlook.com ([fe80::6983:abe3:d792:ef71%5]) with mapi id 15.20.5482.016; Mon, 1 Aug 2022 06:54:10 +0000 From: "Jayatheerthan, Jay" To: "Naga Harish K, S V" , "jerinj@marvell.com" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH 2/2] eventdev/eth_tx: fix adapter stop Thread-Topic: [PATCH 2/2] eventdev/eth_tx: fix adapter stop Thread-Index: AQHYoKdxlX1s7slYrU2PRTAVi/svya2ZpZzA Date: Mon, 1 Aug 2022 06:54:10 +0000 Message-ID: References: <20220726042211.1018326-1-s.v.naga.harish.k@intel.com> <20220726042211.1018326-2-s.v.naga.harish.k@intel.com> In-Reply-To: <20220726042211.1018326-2-s.v.naga.harish.k@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08d41318-5124-4aaa-33cb-08da738aa34c x-ms-traffictypediagnostic: PH8PR11MB6612:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q0kEmgSeaC/9CVUAt2q5DOZFnL31rOxLi+1F7nJ3JdvbfXGqq5owtfYj6CZKNeB0IS4DWyE/KmEDZpO6nWu7qn46BLpUF3+2pS9bFHFNhxdiwuPZTFHp+0mB7EA/TMbXvDzFwL+cY/8XFtbDf+93X/UzlBQdCn4aRVqFWaR5+YThvpPl5OaQb9fqP1R4nuTdRywbu/lum3aPzvQtxi5a8M3Nn3fb6aYEPUQbhJ0Kdo21W6FHtCPJdoVspp6/eOIlH1w3EKlJytTNeyMiPLwlSMG9IdkfY6lbPBfO7ZL099frBgpS2pgcYqcX5N9lvCk0RAxVuGETb54H5e/wZe+IiaVz6XYIcQKk2a5A5J/WiIVX+Op7hiuCSzQYXaKNiJm/zZzMCKkK8GH2h0WqfYZnAfXv6HwCgtnlSXgWeiI/H1vq4YNe69W9TMD5myPY7EYD44KJj3Vpu0X179MbWaUVAQxUyFeTA4C/rb7BNfGKAas8gHZbaAJf10tSq43gmSlUP4qoHIazBUd17VSmYGgTSRzBufLpIUcY9JefHhnQCg8KiEzw6OzXdcMqsKIa2ZgK1reOaH47/PXzSQLNxCCUwUBI6IIRvewkszLzaeepFKG4JluINDpQbQc3sLoZeCtqyydcC6fD9iKsoDtJrSL5CLk/fcTkmS5Jckd7KUp0Lje8yt3KTh8TgkzRepM808EenRMwKuSiOmDeu9LThm82qV72oBZvObMLKznVJ7j8IabUtmBLCEhMNM6+zqklwTZra7/LtY7v+qaorWvRlPTnbBi8cAC9q4sd2b+5IZRB8P1fvTIMOsCtqOegP1pHLSzf x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4348.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(136003)(376002)(396003)(366004)(346002)(41300700001)(6506007)(7696005)(53546011)(186003)(9686003)(83380400001)(26005)(38100700002)(38070700005)(82960400001)(122000001)(8936002)(5660300002)(2906002)(55016003)(52536014)(86362001)(71200400001)(316002)(8676002)(33656002)(64756008)(66476007)(76116006)(66556008)(66446008)(4326008)(66946007)(110136005)(478600001)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KqXZfG2Cq4RsFxPRo7BdhjvDl2vM+QIcxOjn1H86XgDg0KhXZ6m+t4aGQPND?= =?us-ascii?Q?7eHZvZ3lMc1OyF0En9DETWbhMUQnUa30rdzmt4FDX/5y+tn5mxyC27doGcY0?= =?us-ascii?Q?3cb4N6U8q+s0Lok8gLA+B4iovvnhzVyirZ3Q+m9tIbnQN5n96fJU5isq/2Lh?= =?us-ascii?Q?4t4BHdW5V4z+zJKjkx0EFJl1p+tsNbdTPpQJQQsDSgNFIP1CyVKPOqMiLj9B?= =?us-ascii?Q?RJ1Q6FfyrT7UR+R2pKripIUjLEnMZC645qYOjukdNDTa0xfkGe/mbPTTRAYr?= =?us-ascii?Q?k9YHJj9bPwPIHQfy6HThaAjeLJmIPw8PhV0aenHsubigPde/iKPEank8Eq88?= =?us-ascii?Q?iJOGP1zTBbR1zdruC+tkedy/f41KkFTebXTioybqj/1BXiXEzGwAdZ91gqmH?= =?us-ascii?Q?qeoI2zAuD75ybkG97EUftsOE0OeqJJ/h6l/af1PDN7LUEePYD5W5jaGA87wQ?= =?us-ascii?Q?JNyblpzuslXvyyfwMnXJOr9ACISq5mK5IH5GaQFSmEyi6Fcu8gcA0T4+pdXc?= =?us-ascii?Q?F9Iq2W7AkXVBwzdNw2HoZrjOZ+UqwVahaIjnH0+uhEzwBdEPYqjiyMEaD0NY?= =?us-ascii?Q?d+70vumkaMTa5zB6y2JvVIa5/r9aLGx6rmJ1S9j+qu0T1H1Pl83PpqPb096a?= =?us-ascii?Q?Nh+bMUh+Dlj8891hDsBhj+rg4rekfM5OAQwX9BjKZFnK5G0qxCWTfsoCUD7s?= =?us-ascii?Q?pYuBJP2hxUPz7DORznWrK71gbrch8Mvr+jLG3bXUH2gxWVnEne/nP2TrXW6/?= =?us-ascii?Q?TYBA8Pke0F/puX8eCS6Xo6p8xFTZBKYg0MwVRzwPquwGn/AZ331Lwmx4FAzR?= =?us-ascii?Q?Shd/sQbnfkMuwO6RK1a966YS13cErbKU+Bpnlcn+hctiA3CTf7AJAhtDWjic?= =?us-ascii?Q?6Btm1mbFq0nX+oRejIGgZY5ePsiWPNlkHZtc5ZBTj52LFEvfnpKQvih+Fnrm?= =?us-ascii?Q?z5wJXymRYSQA40ZiausiOynWFt8FEIV9I3MZwwiZYr4V44dMOfITGnn0R/Y/?= =?us-ascii?Q?pvfsQovNbLEtt+7h1w0N19vZg+rybjNMyVtbgF8CFYynpyCYQ5YDxMr9cyfD?= =?us-ascii?Q?zYfDBYUgKJ8iKvG/Zf5sxuHVwc5WUBxLLqPg/QXp5Q4B03T5ar+32vcB9jmS?= =?us-ascii?Q?7AV9RN7Mss9kMYkvwGbrS+kE0j/EYA4yYh0ddUV46kzUtXKcNBydJkNWuWtB?= =?us-ascii?Q?ugW/1ETPfwsQWaYwAfEPZtInJxV4lmmLmAuhLft0GDrpQqqgtYhGdrewozME?= =?us-ascii?Q?NyVGROyAQjq88y6r+d+An7MBYKKHxOQSjMESNmHchet2e4a0W7X2DFvXFkaP?= =?us-ascii?Q?sl3YWbHrPRmsTxJvDmA59xU24rNlxbQ1wZyR+k+kQn7ZWlOKmSlALa82PAdw?= =?us-ascii?Q?hTGLTpQiFnw7WXLuwU65yj2qqTxt5f4anWHFHSIUG5hQNV0BVw+AUSm63CZF?= =?us-ascii?Q?qe4nctbI3mRyZq6M8xdTOrKA8gJr6IISGUvBEEx/SpthYEaH6q8AT+QctJAL?= =?us-ascii?Q?9bm0k3wVXSuA0rL/OZhiNKFkBL4XFvzOT2qb+Sr0C+4B2dP6iR4MMCQUiama?= =?us-ascii?Q?9udvgNoMthhmaReD8MtsbmBYWCqis06HqE6HBqBgxV0rIjp4ay/GVgCL9Z+Q?= =?us-ascii?Q?LA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4348.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08d41318-5124-4aaa-33cb-08da738aa34c X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2022 06:54:10.8082 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 79SUaVGs+GTRV/IyzGKICMX8dQlmbvTcBDVczUDS2uRPEG3n/kS5RUXnXY/3WZub0NupgxdVht2VqqQ24qJSo0K9L/gUsX0HSY+pvt5Tk2U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6612 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Naga Harish K, S V > Sent: Tuesday, July 26, 2022 9:52 AM > To: Jayatheerthan, Jay ; jerinj@marvell.com > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH 2/2] eventdev/eth_tx: fix adapter stop >=20 > adapter_stop function is stopping the adapter service using > rte_service_runstate_set() api and waiting until > rte_service_may_be_active() api returns stopped state in an > infinite loop. >=20 > This results in hang issues if application calls > rte_service_lcore_stop() before adapter stop. >=20 > remove the state check after setting the service state which > avoids running into hang issues. This also makes tx adapter stop > inline with remaining adapters. >=20 > Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation") > Cc: stable@dpdk.org >=20 > Signed-off-by: Naga Harish K S V > --- > lib/eventdev/rte_event_eth_tx_adapter.c | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_e= vent_eth_tx_adapter.c > index 3251dad61f..41509ba750 100644 > --- a/lib/eventdev/rte_event_eth_tx_adapter.c > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c > @@ -475,10 +475,6 @@ txa_service_ctrl(uint8_t id, int start) > ret =3D rte_service_runstate_set(txa->service_id, start); > rte_spinlock_unlock(&txa->tx_lock); >=20 > - if (ret =3D=3D 0 && !start) { > - while (rte_service_may_be_active(txa->service_id)) > - rte_pause(); > - } > return ret; > } >=20 > -- > 2.23.0 Acked-by: Jay Jayatheerthan