From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E9A6A0032; Tue, 13 Sep 2022 19:02:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9FB64021D; Tue, 13 Sep 2022 19:02:41 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id C8A0440151 for ; Tue, 13 Sep 2022 19:02:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663088560; x=1694624560; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=XMfi/qJTuKsznxnzq1sT6RELQspzn9PHJF6VNWG1AaI=; b=c8Yq8Zr5FJhR+s6hd3XwDGcK65oEXG38mkfqXp8GXWJF0mLDqBZw9940 H2QBeEc/lxnHfOrSXedB6wlaEDPJD8o4Kz4lVvBehvkRm+cun9FyYP19v OKyyBU5a/cZXHHWUBUxuJw1yYHY9eVEwKNcqrPPW0dkI2zaHOxgRwMjhW +XSxPisEIXy/AHhQeczSNL7ROmasV9QTKLENxGQiofpNGVhkIm1obou1v xcgJvJP1PI26XLjpbOaqExcmjvh+LzCX6O9bW8oVZdVIZn4MvO/OjgdeS Y/Y6OX8h860k0gd78zXCKdpl/o2fI3kquW3OW/ckw69IUcEw5AnxqpAYj Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10469"; a="324440662" X-IronPort-AV: E=Sophos;i="5.93,313,1654585200"; d="scan'208";a="324440662" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2022 10:02:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,313,1654585200"; d="scan'208";a="945142031" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 13 Sep 2022 10:02:37 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 13 Sep 2022 10:02:37 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 13 Sep 2022 10:02:36 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 13 Sep 2022 10:02:36 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 13 Sep 2022 10:02:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=US65SVmKmG39e0lIuNQPwN4T/X9+3rKkdzEBjMloCntsaB5cymZG6b4vMJDgJy1Hv1FowlvHR61phO6oO/6zFeUiUkuNzuVCA2DdZdgWgGcYvoImyr8Tgn5RLEeKoGBjKJJFqwQPjV/cjylwUZecwUr12W0w942kums/S8nJhaFub2aIIJnnkF+CZ4OHysTBssNbIJ0MxTpuc+jqW6oyAEcYG4BJO/nh3RAV3UYLUEEHJR55wtXPlSDvtD/Z66E/uVTCln0aqwDLAJTudzUP3b7z67KTwnoPcIVWYquvfUF4kpRWtwLmK+wI2LWQSEpDMQArT0mWyzrhK6HOcZK4Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TzsJ9fKpbn7mf3efEdDKE1PiCHBiCFMNvyePOTx5hCc=; b=JzNkvsNm6n4c/IEtnlwX1oEkjdrVYpOXU99CXtAha19jbLTG8AKvkaI/76uhcIz538Fl+hpPqtHYVhVKOdtgiD+lp8+Y/1bq4hpRgIrpgY0xmpurjsAWRpM8nu6+Ls8vBbMLn2bVjCNGky1vlhXOwRLL2oDx2siRHV5WZPdd8xK/WmNzYZ2jTT9QWJ8K7ZbmsHC2E5jgelkc3X9v0p+u2ypFcO8zDkxXxwfj4i1ONaet8taBHYvO+FQY98oN+WE6ZoMKJaaqgntH21jyFVHOEXzXU63bWKugE9lVjppb8VBLN7rqXzHX2Q0dpfWYBzYM3KRRzzaSXA2gzMyMuYQ/rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4348.namprd11.prod.outlook.com (2603:10b6:5:1db::18) by PH0PR11MB4918.namprd11.prod.outlook.com (2603:10b6:510:31::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Tue, 13 Sep 2022 17:02:28 +0000 Received: from DM6PR11MB4348.namprd11.prod.outlook.com ([fe80::48:7f55:58c5:3343]) by DM6PR11MB4348.namprd11.prod.outlook.com ([fe80::48:7f55:58c5:3343%6]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 17:02:28 +0000 From: "Jayatheerthan, Jay" To: "Kundapura, Ganapati" , "dev@dpdk.org" , "jerinj@marvell.com" CC: "Naga Harish K, S V" Subject: RE: [PATCH v1] eventdev/eth_rx: sub event type gets reset Thread-Topic: [PATCH v1] eventdev/eth_rx: sub event type gets reset Thread-Index: AQHYxz7E+TT8w/73OUGQMjVAZUG8y63dlXhw Date: Tue, 13 Sep 2022 17:02:28 +0000 Message-ID: References: <20220913070205.1108906-1-ganapati.kundapura@intel.com> In-Reply-To: <20220913070205.1108906-1-ganapati.kundapura@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4348:EE_|PH0PR11MB4918:EE_ x-ms-office365-filtering-correlation-id: 88402eac-11ba-4c9d-ad55-08da95a9bd6f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N/ZIX63kx6VFQTyRQtz6UPqAuK5zu+IbFq2tQXfZYOXxQM6b2FfYCxu5LksXJQPR1dIuN00KtpZBlwjhhkvHU9laKc0EnkoEM5WKWlyr43ndkMQ27IRaCy2AJ9+tlrpXHe+8Sb9j7GnYwcYVSRC3VOBg1Kr2CsraNoqYEzr6m2WLCv4EFufsMuzmFuTD+qgwahuwVN9Tuk3gjPSAdyct0FctE8NUS6rI/OEFQ1NWcj677ulyNxdJm/ic34wVb0fk2NXzhpvOS93MxFnzEvi0j+Cpf8n4jTCkiolIPckz0ykRbPyARrHYeaDumUAsjlPKZ73ch9yXuc0abOJQzszCvD0h8vf3Fn1z5qIpxnm17d6CIsz1coYguX0Y3E0h+Aoga+Hzlj6Gb/FrgS7PY08mWTi2kL7XZTem/XzUFMjuJqX+3mx+aQamWHckKaNJq94/SoFchxDLrC9zMLnhl4wOBOvxgPGWtor1vvCXHQXZyGBGMQ4/EQ43d3xDKGfctp7pJ65jy7lNRrpkWYZQ/TM84klJOkL6tSC4b0+x2VcZt1SQc0/5sv0NAYBovC5Vsg+5eJ0BAvLykm1xyPNFvC+9tHWPWPebkNJ+q/Qn98CptDRiyTRmc/AQCRYM3OGgmyByWGHwvp/EcUXUx0aYTqBxe+Y//YhfG86ACVubnv5oLPLjxzzbzeu/oFLNKihEDPvoI//vv7Gz10XkVung5O4L8i1EUt/bXC4kDWQJj+3cVt8CJ5ZwEpvYJFovLaEh4T5aEZb+l8qsOZYfeCM2oNqvlQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4348.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(136003)(39860400002)(346002)(376002)(366004)(451199015)(38100700002)(86362001)(2906002)(8936002)(82960400001)(4326008)(6506007)(26005)(76116006)(5660300002)(8676002)(66946007)(83380400001)(38070700005)(55016003)(7696005)(316002)(478600001)(33656002)(66446008)(52536014)(71200400001)(64756008)(66556008)(107886003)(41300700001)(9686003)(66476007)(53546011)(110136005)(122000001)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0RIcC7FAivv7GKzjl0Ypz3xZ8/O0MsxwUqxKJrbQFztUpVJLglbQke+3NstE?= =?us-ascii?Q?pByv92Td8ueKNfDvQGreLnDolAPaENXigVSr23yCYJQ7EF2VNiuKWa1WRKM4?= =?us-ascii?Q?tprqoVpO4XW/eDI7QY0XlehQE8uiVGYwvasKaaf5eSKcP+oN5dTNCJKg/m68?= =?us-ascii?Q?0Zg0JkOkSKtBU+BCUO2iell8K6hrhFBTTSb0KEr/1MIIQ0nJIZN7JJZ4UMS3?= =?us-ascii?Q?+j5RokVVvqVaINTECutzkdi30EvFDUHi9xiMjT9/lWzexw1/AEKtNiveRP9i?= =?us-ascii?Q?qslyQgqbQgU2WaZ3s3xV5xe/gSAtQpCMtjv8p/WyuY2+YZZiR1PcaNUI1jsh?= =?us-ascii?Q?fTKrRe2NrG3+FksUGYwKHRGLaAAVjt/fjfj7+lSLDSFFsHgFAYxOylzYkAI4?= =?us-ascii?Q?/63gVfDuFCfXwAoHc98OrjMEEJ662sBenq17f9oLiZXpw+8Syx3HdfM4xHg8?= =?us-ascii?Q?6u/7wDuu3kgcqDcHu6XeaQcmE4pDE/fHbQU181h3AfWfVsNL0JKxYq/jgJBl?= =?us-ascii?Q?KHSAv8zfmdxq4jHqpn9oqw7qaQuKz0iHRYsGSBno3xFwqKHzqEbMDJLuNZK4?= =?us-ascii?Q?Yb3hm2dAs8Ha8u2VlG/RkaH4R92aw+rKg3p2uw26EV9dCzhNc6kuVLZ6ieJk?= =?us-ascii?Q?2SVhhqNptpA7FxQ5BI7ZLjcrdrVrOLG6pT/CGOr9IaMgeKeE3POnLeE8DDO2?= =?us-ascii?Q?fXlyigmCCJnKmLB0Mzaq374CsdT//0fxcMnr9bnvd+s+IeZOsJfTiYkSiy2M?= =?us-ascii?Q?7DcSf1YFBi+K3xJu9h9dzsdILxfODrAw0ZzRD8gbAS5ri3jFE+7GqJTbcaDz?= =?us-ascii?Q?K48A1AU5KRarsljRPEHOZvLfbxnSdnJUmwBbI1VEw/jvcBOJFfhyvnt2fFDH?= =?us-ascii?Q?0wJcNb9FdTon+Yt8PguYNDpK5d6XzSuxzU2gEy9LmH3un4c+KZguXv7P41ST?= =?us-ascii?Q?SI9oAt20w89E9XOW4JsmDJM9DcY78OX4vrvoX0LrZV/P4VFLINQ/c7OauhXU?= =?us-ascii?Q?oQYLqI7refQ6JF3eSBBhW4bVqTuqfGbYDTYV1V7qCAS4oZ7MiCtOCUofFsWR?= =?us-ascii?Q?jmLBTsgxYxZ1KIreymeVDHFY0FJ0ir9flwz6IizFeQEeBdAsjWIntvNVDXpA?= =?us-ascii?Q?z45qT/l8o24bNijEKh9OYvaTG6vZV6QuxMeTV/xBAw0O+jBZ+nlmVzAgeuKi?= =?us-ascii?Q?jztI2GEFlsWCFePCHzE8o0FdrYtFwwt0rBxqm1SNIKIlMBqV0Wf2AvsLDUkh?= =?us-ascii?Q?4g7DF82AljHwQzVi6GjFfkKdxFBOLJ/PNUit2FUf07BLrdAxQMTEefky0vYC?= =?us-ascii?Q?2+ibS52EcjnQytyXL25EpAMHaXN2PDyZa3ZFjEB/pH5HSuaPNpRybNLiO3Qp?= =?us-ascii?Q?sPrLfze9HwN5jlP4GNJStf7xgk5Akoz8l4HvQq/bX6326Um35704cjOuVKCA?= =?us-ascii?Q?9fFIoQpbFMYEXpsi1pdaQpKTYrVhdZUd6VzpCry3mJFB5WoGHmE497/XdXLV?= =?us-ascii?Q?igkgLvX0d32r3Xbu8Y0ZPyALbLOuY0k6XwvBlaMfO9R6sd1v8Q7kg546awQb?= =?us-ascii?Q?sw7OuU6jS6Uxyjtdswl0fihMB9YkWOgZS/HuBK9cUzWrl8CjpT33K12L7f62?= =?us-ascii?Q?CA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4348.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88402eac-11ba-4c9d-ad55-08da95a9bd6f X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2022 17:02:28.6102 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: giNhmRrdbgU6OxxeL35FJmmfHTP+RQQJt328RTcDYAM/CwBkNG6NuDEAw4HMLc9t5qD3stCCLO5tS5NViUjJEWalIxekhDyEe7niGkQ2zow= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4918 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kundapura, Ganapati > Sent: Tuesday, September 13, 2022 12:32 PM > To: dev@dpdk.org; jerinj@marvell.com > Cc: Jayatheerthan, Jay ; Naga Harish K, S V = > Subject: [PATCH v1] eventdev/eth_rx: sub event type gets reset >=20 > In rte_event_eth_rx_adapter_queue_add(), sub_event_type of > rte_event structure is reset which is used by the application Just a minor comment - application may or may not use this field. "which ca= n be used" is better suited. Rest looks good. Thanks for posting. With this change, Acked-by: Jay Jayatheerthan > to determine the processing function. >=20 > Removed resetting of rte_event::sub_event_type >=20 > Signed-off-by: Ganapati Kundapura >=20 > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_e= vent_eth_rx_adapter.c > index 64a6add..e42e41c 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -2054,7 +2054,6 @@ rxa_add_queue(struct event_eth_rx_adapter *rx_adapt= er, > qi_ev->event =3D ev->event; > qi_ev->op =3D RTE_EVENT_OP_NEW; > qi_ev->event_type =3D RTE_EVENT_TYPE_ETH_RX_ADAPTER; > - qi_ev->sub_event_type =3D 0; >=20 > if (conf->rx_queue_flags & > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) { > -- > 2.6.4