From: "Yang, SteveX" <stevex.yang@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Yuying" <yuying.zhang@intel.com>,
"Singh, Aman Deep" <aman.deep.singh@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: RE: [PATCH 1/2] net/ice: add module EEPROM ops for ice
Date: Wed, 26 Jan 2022 00:53:31 +0000 [thread overview]
Message-ID: <DM6PR11MB43627C7B8CE3D9FCC5FDE8BAF9209@DM6PR11MB4362.namprd11.prod.outlook.com> (raw)
In-Reply-To: <31531e36-81c2-e6de-62ae-35f0d89c381c@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Tuesday, January 25, 2022 10:49 PM
> To: Yang, SteveX <stevex.yang@intel.com>; dev@dpdk.org
> Cc: Zhang, Yuying <yuying.zhang@intel.com>; Singh, Aman Deep
> <aman.deep.singh@intel.com>; Yang, Qiming <qiming.yang@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: Re: [PATCH 1/2] net/ice: add module EEPROM ops for ice
>
> On 1/20/2022 2:59 AM, Steve Yang wrote:
> > Add new callbacks for eth_dev_ops of ice to get the information and
> > data of plugin module EEPROM.
> >
> > Signed-off-by: Steve Yang<stevex.yang@intel.com>
> > ---
> > drivers/net/ice/ice_ethdev.c | 160
> +++++++++++++++++++++++++++++++++++
> > drivers/net/ice/ice_ethdev.h | 25 ++++++
> > 2 files changed, 185 insertions(+)
>
> In the 'doc/guides/nics/features/ice.ini' file, the "Module EEPROM dump"
> feature already documented as supported, but it is this patch add that
> support.
>
> It looks like documenting "Module EEPROM dump" was mistake [1],
> intention was to document "EEPROM dump" feature.
>
> Steve, can you please send another patch to fix it?
Ok, I'll add "EEPROM dump" line into the ice.ini to fix it within another patch later.
Thanks.
>
>
> [1]
> Fixes: d0dd1c8e1997 ("net/ice: support EEPROM information getting")
>
>
>
> Thanks,
> ferruh
next prev parent reply other threads:[~2022-01-26 0:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 2:59 [PATCH 0/2] " Steve Yang
2022-01-20 2:59 ` [PATCH 1/2] net/ice: " Steve Yang
2022-01-25 1:15 ` Zhang, Qi Z
2022-01-25 14:49 ` Ferruh Yigit
2022-01-26 0:53 ` Yang, SteveX [this message]
2022-01-20 2:59 ` [PATCH 2/2] app/testpmd: fix stack overflow for EEPROM display Steve Yang
2022-02-02 10:00 ` Singh, Aman Deep
2022-02-03 13:15 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB43627C7B8CE3D9FCC5FDE8BAF9209@DM6PR11MB4362.namprd11.prod.outlook.com \
--to=stevex.yang@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).