From: "Wang, Songyi" <songyi.wang@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "Dong, Yao" <yao.dong@intel.com>
Subject: Comments/Doc error for CRYPTODEV of DPDK
Date: Thu, 18 Jan 2024 08:58:14 +0000 [thread overview]
Message-ID: <DM6PR11MB4444EC66205D293200A10ECCFB712@DM6PR11MB4444.namprd11.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1449 bytes --]
Hi maintainer of DPDK,
I've noticed an error on comment of DPDK version 23.11 rte_cryptodev.h: 928-930
/**
* Create a symmetric session mempool.
*
* @param name
* The unique mempool name.
* @param nb_elts
* The number of elements in the mempool.
* @param elt_size
* The size of the element. This value will be ignored if it is smaller than
* the minimum session header size required for the system. For the user who
* want to use the same mempool for sym session and session private data it
* can be the maximum value of all existing devices' private data and session
* header sizes.
* @param cache_size
* The number of per-lcore cache elements
* @param priv_size
* The private data size of each session.
* @param socket_id
* The *socket_id* argument is the socket identifier in the case of
* NUMA. The value can be *SOCKET_ID_ANY* if there is no NUMA
* constraint for the reserved zone.
*
* @return
* - On success return size of the session
* - On failure returns 0
*/
__rte_experimental
struct rte_mempool *
rte_cryptodev_sym_session_pool_create(const char *name, uint32_t nb_elts,
uint32_t elt_size, uint32_t cache_size, uint16_t priv_size,
int socket_id);
But the return value of this function seems to be a pointer to the mempool created or NULL pointer, instead of the mempool size.
Could you please check it?
Thank you and BR,
Songyi
[-- Attachment #2: Type: text/html, Size: 13727 bytes --]
next reply other threads:[~2024-01-19 7:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 8:58 Wang, Songyi [this message]
2024-01-19 7:51 ` David Marchand
2024-01-19 8:08 ` [EXT] " Akhil Goyal
2024-01-19 8:27 ` Akhil Goyal
2024-01-19 8:32 ` Wang, Songyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4444EC66205D293200A10ECCFB712@DM6PR11MB4444.namprd11.prod.outlook.com \
--to=songyi.wang@intel.com \
--cc=dev@dpdk.org \
--cc=yao.dong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).