From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: David Marchand <david.marchand@redhat.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, Chas Williams <chas3@att.com>,
"humin (Q)" <humin29@huawei.com>,
"Yang, LeweiX" <leweix.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test/bonding: fix failures after hiding ethdev internal structures
Date: Sun, 24 Oct 2021 11:37:25 +0000 [thread overview]
Message-ID: <DM6PR11MB44911E8A52F51A0D838887E29A829@DM6PR11MB4491.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8ywgfiWsd4XMJYSOmHiujM-mFa0Y-r508NVMcNMhM=12Q@mail.gmail.com>
Hi David,
> Hello guys,
>
> On Fri, Oct 22, 2021 at 3:27 PM Konstantin Ananyev
> <konstantin.ananyev@intel.com> wrote:
> >
> > link bounding auto-test internally creates emulated ethdev.
> > Some tests change Rx/Tx functions of this emulated device on the fly:
> > by directly modifying rte_eth_dev fields and without doing stop/start
> > for these devices.
> > As now ethdev uses rte_eth_fp_ops[] for fast-path functions, these
> > direct changes doesn't make expected effect.
> > Fix the problem by guarding fast-path functions changes with
> > rte_eth_dev_stop()/rte_eth_dev_start().
> >
> > Fixes: 7a0935239b9e ("ethdev: make fast-path functions to use new flat array")
> >
> > Reported-by: Lewei Yang <leweix.yang@intel.com>
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>
> I suspect there is something broken in
> (bitratestats_autotest|latencystats_autotest|pdump_autotest) tests
> that make use of app/test/sample_packet_forward.* code.
> This code creates a portid from a ring, but I guess this port is not
> properly setup wrt to API.
> It goes unnoticed in CI atm, with tests returning ok.
>
>
> Looking at main branch test in UNH, testlog.txt files are millions of
> lines filled with:
>
> test_packet_forward() line 104: Error sending packet to port 0
> send pkts Failed
>
> or:
>
> tx_pkt_burst for not ready port
>
> There may be more issues, the files are just too huge.
>
>
> Example:
> https://lab.dpdk.org/results/dashboard/results/results-
> uploads/test_runs/1dd418abe77644c18417dcb589e994aa/log_upload_file/2021/10/dpdk_2e437f1cd65e_2021-10-23_22-04-34_NA.zip
>
Sure, I'll have a look next week.
Konstantin
prev parent reply other threads:[~2021-10-24 11:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 13:26 Konstantin Ananyev
2021-10-22 13:47 ` Ferruh Yigit
2021-10-22 14:02 ` Ferruh Yigit
2021-10-22 16:04 ` Ferruh Yigit
2021-10-24 10:39 ` David Marchand
2021-10-24 11:37 ` Ananyev, Konstantin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB44911E8A52F51A0D838887E29A829@DM6PR11MB4491.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=chas3@att.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
--cc=leweix.yang@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).