From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7D10A00C2; Thu, 10 Feb 2022 13:42:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48593411AE; Thu, 10 Feb 2022 13:42:36 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id BDE054013F; Thu, 10 Feb 2022 13:42:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644496955; x=1676032955; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=u+6dr9hNj0dLoV5LOoDuCeSB3TmKd39wM3QBFcrQYn0=; b=NWfIKKjkE14HAxuKIOqvR6LVtm/ptwZaLfINmm3qHMq6oD/tSR8LrnW9 PCIyZDx6cN1CYPfbploWpvRkDKVUmADKuitWwezP5LNYto2EOrb9KF72g DJUJ/SCfFXdDsTWDHwGtzzvB3nXxs9EdbCD9zHJ6HacBsIk38J2N6bVlZ v/WPOkchZ2DM2hn+nr3+9nk2SVCtMxQIGzYJwa0WFHs7gEJqF+RfnRMzS YPeoAdQgHL4jOFhJHmXhQ/EL93tSGjZrrusyI1KY5XwIlmhK0k+uO6rHL 2Q8GWA374eJ4mV0FWHHYBSCHFaR81+83jJ9PU7myVDdvn1ltGiHWZ2u7U g==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="274030488" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="274030488" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 04:42:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="633649924" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 10 Feb 2022 04:42:33 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 04:42:33 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 04:42:33 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 04:42:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KqpJsuOurTKgGQjD95TSGptIyh0wzV+fNPJTtgq4c1OdKmj+bPljsXKU7hJtuyvDxFBuokMbMVBSGMMhp/qtFUNtIHh7JwwjVA0JKMUaRmtrqFaAYr4BGZGp5HYghwAmaDHo/qaGYFVr8dfaNS6V9qDuUxK7OoO8NipPByhKZXIsxgLC9eF4MFZSgMQBm7M17rkHfaep4L6kfnpNNdXceOj0c/fn5Ep5L0ZWXv0jwreiKk2MLVxVT2u6Q9e61UoITjuoS6UUqTbdbcutwH/JlrhjjGLQEzGhhhxb9ZYht7JdzPlaTGn8jZI8uHwsvTkR29RpkB0JF/3OrBdZFZvNNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+nSYsvb776hb0aOJvRe61YQa9uRAUcGB5iHpBD0ZqqA=; b=cEK/JeM2rJLDwURMMxKUuGiE/y+xCHtUqmK2Qd261ObMfFTVdzw1srRoBo7DLguTLljkSIn8ZGbUsI1Hfy0PKNenaSY5GSawfXfKZMaImAm84ih43IveS69cLkGzZk0wE+8G1CfZjyf9e5NojIqwRpmKWuzjxsXmrFNMgQ8z+gcWwsgO+70PF047cNDoVKevr3HCHhHs3uLg7YWgPAol10OBGoPFHEnvH9W4OcdqgfcqvUuxQCbagXIJxbHNPq9AV1iKGHBPtFePALRtzZpPd4QpnJ3ina4GA38RB04VwGq/MiIWbqvPOp9EMasbF0i9dz7WBQ1ByAoY35lOvizyKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by BN9PR11MB5371.namprd11.prod.outlook.com (2603:10b6:408:11c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb 2022 12:42:30 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::8ccc:ed65:78fa:1b07]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::8ccc:ed65:78fa:1b07%4]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022 12:42:30 +0000 From: "Ananyev, Konstantin" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Doherty, Declan" , Akhil Goyal Subject: RE: [PATCH v2 4/7] ipsec: fix missing explicit cast for C++ build Thread-Topic: [PATCH v2 4/7] ipsec: fix missing explicit cast for C++ build Thread-Index: AQHYHnZIwG1M3vL4qEWEsgzmncDeMKyMujQw Date: Thu, 10 Feb 2022 12:42:30 +0000 Message-ID: References: <20220204174209.440207-1-bruce.richardson@intel.com> <20220210120257.585822-1-bruce.richardson@intel.com> <20220210120257.585822-5-bruce.richardson@intel.com> In-Reply-To: <20220210120257.585822-5-bruce.richardson@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dbf6aa8a-9740-4bc5-b8ac-08d9ec92cd4c x-ms-traffictypediagnostic: BN9PR11MB5371:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8kk4qkN59zBKoS3ZVwZSjMjhklXEshKfPEmP9QAZtLSp8ytWf86tAXG9DmAVX+jHpMgFoXxTjSoUd9RvtV4RPKLIxlDmlEOI2Qxp6QVm2xPs8H3MupptDwYq+qE3N6wjTLX1qzowjtuHzLOoVFq6xICUxI1WvXA48qz2ICZj2bmGsG2dEKY7N4hfKzzNY2PRygDGRehJSIAmtOW3NFzstfMwyH3P+yL6xAXgGuKo0iYj1o5obE6YfDSXBVelcCyDe8mItVsZfFIyCqwrnRN0iUsEZVuODEjkAHIuI+9GZHu7/ZV1bAIcJzs/rBrjYgWzHhplbJKVN4nDtwFUe2v4xnOQL8CkDl1m5DdCaVzyp+qg7hUZc1yNqMkQ0HEpmNkAxazFt/+CBD/2MOMdhDfkX2KklH7r7v9wLW78XkaQL/YQBzIQY/++xiiNE43fnE1ji+OJleEJfpimmcVuwVp/vVRcfU6gScTpzLOVGoaYnetvCFvgBIXXUew5tKqQWIsp6H8FsfYkh7XGZJ0DUINDzPmeOZjAkhR2pnoEJPBp+rNJoe+8JaT0I1l4J6mU8vZ/qkWUbSFhBdCjecbZl37yU10v5ZxjDcKzZSSpCZYMW4f5iy8Y93Or87iV5GRvf2YiBtnHdAbV2eyiEJA9u3n1+GvYISamMZUIIVAbouEMTxTaQTe0I3qyRmF3HuwLSCcxVtkfrA59ljs6g66j6OZQZA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(8676002)(4326008)(66946007)(66556008)(64756008)(66446008)(66476007)(52536014)(110136005)(76116006)(122000001)(54906003)(316002)(2906002)(38070700005)(5660300002)(55016003)(8936002)(38100700002)(82960400001)(7696005)(6506007)(9686003)(71200400001)(186003)(26005)(83380400001)(508600001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OkWVqroaBPJpcbnMEfXz49ADq4KtPYqu0IdEYJYDRB9taDe/iXgC3hhMCCYA?= =?us-ascii?Q?BnDliCt2xkW8XnRkRrB34LbaX3hqpnNcTY67Y5pYTdM6y0/wdDD314TR5vXP?= =?us-ascii?Q?IJFgvPc2BCnO+AV1db4eGCSaWXRBBTeXntAEqT9IHSkjv/IFrMf9f+XG2B8V?= =?us-ascii?Q?8ncncNs8q4U1tiH2hupn+aA4NUZIgGedvGIDdvVQg27lT4Nn3jZ/JPUVc6G3?= =?us-ascii?Q?wWOcdy2lVM8JaYRcpbCPoGQPQGnaHE5zJQAA1Hb9335pSMdqtCIIFnAXt6C0?= =?us-ascii?Q?t0LJpTHUN6/hLOyfUWx5wp1Nk4vcg7jku6Vw9HmZKgIq8Lgx4/HfEMOKZuZK?= =?us-ascii?Q?0R95o5FbO56gQ+PBmIV+vPdqlyEgaoq6gRcmI8qiqcmZ8ICOFjQAcJhM8B/B?= =?us-ascii?Q?ielcvXPBZ0eRCccv5vAf1v4L8A3QJgVj3yVuM3P2oesdMP/kcwIO30qQDO/e?= =?us-ascii?Q?mJaPkOnFr2xNhtWHjK2eDkbysPVXgXtylJe7Jl2+p3fh/GUd+btRYYEZy0cz?= =?us-ascii?Q?mIQ1XOaT6/b1xASctAK8DR9u8Ve28q6GJDzefMeGJsFW8BYim5hBIKoD4fts?= =?us-ascii?Q?o8oDZXujvB+ZKLL3hKotLRYJiHKlL31hTfAnDJf5kjipw7kHI4mmX91ApdSm?= =?us-ascii?Q?DO/kRr8ts6ckm/Tz8MT+49PGJhayUP6NFokSzzay9ZkMIYITRfUM4m+zx3+g?= =?us-ascii?Q?evoxT+e9X3OahNuhpzXZdHvAUVOSdUy0t6hyDEufJt+G2dbZEqrEp1jqai1u?= =?us-ascii?Q?EkXmEBPybFQKIkrYOCHHwbLXGyqSiS3W4Yq9/7PEe8OwjR89yzjlmCt2kUTk?= =?us-ascii?Q?KIaZTfhy9AbxFazLeX0Ra67a147WmZoWG4oUAXPyAj8X6fDFbCxaWEjSJbY3?= =?us-ascii?Q?IC8B2IEXiHsGLiNM3ggfzWQQZXEQnlhNGpAeW0ILl3scmG1wxpTw6AMtpzkC?= =?us-ascii?Q?x1xQ7LsKr23WbRNU6G4mr1IHIX4x2VkSlmo7l/XMaH7n+P3xlXoJdRUK6Mag?= =?us-ascii?Q?P05bQJq6emaXYFH7s5je5ALpg5JWHA3yTiyxPfTZGUfs3eoPHwwhg6yX68Lg?= =?us-ascii?Q?Lt4OZXg6gFgqfU3on91wjhL4KFIMlgLzvN1voae5p40gONQDhQr8x8fDkrZQ?= =?us-ascii?Q?079JFsK0bXSSYi0w0Nt5CC9Z7yXow1Y/bCh63abVfzW6it9tL1kE+ZgiY081?= =?us-ascii?Q?NFS2KXLe8OlrxH0fkCTL/TGWh2zT1nxTV7P77mYgYy80AOWJ2L0zwEk63e+P?= =?us-ascii?Q?7EdrY3AGpyt3F80n10217kN44EsCFShKouA2E8z6e9trTHyooi8VfJQGEkzA?= =?us-ascii?Q?iEraNwfwoKba4TNLIqLq2eU/q6Z0MNj9iVyqlDRbwfABlq7AXte2D5lZtKg9?= =?us-ascii?Q?/TRbhoPNLVnahQIk9Do4UW1t4kpVh17nX+hr9gE8xN0WmRqREos0db3CBV35?= =?us-ascii?Q?GX5slHgD4s7SG2A89s+erf2Z+WoH5r9VImrituwLto9bXf30Uh31iQeDcjWf?= =?us-ascii?Q?HRiN9mOBoUlrNjuOOkb4N5o/8y0zDJdyinQa17aNygYCtILvMX5s0RHwZh/V?= =?us-ascii?Q?huG1vqMjWbkFLj2VMkW8ypgWSuIBAdswU8CLfVYL3HJzZ4rssQR4MKleuF+2?= =?us-ascii?Q?jfUqD8eTFBIGrwfCJd67P3/4qgOgEWlbRxY6pS+uFe272+GdMdmzAc5QzXrs?= =?us-ascii?Q?y5oH5A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbf6aa8a-9740-4bc5-b8ac-08d9ec92cd4c X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 12:42:30.2592 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iCggNAwDd/zzm8whe92CCdcXsuzPGqQ6mgHlrOpD3OHYKQGzjbhnp21Sob8cgyr+8EL5TtBpw1IfVAEpeKd6JW/cNstMcq3yY3dp/pTcSH0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5371 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > C++ does not have automatic casting to/from void pointers, so need > explicit cast if header is to be included in C++ code >=20 > Fixes: f901d9c82688 ("ipsec: add helpers to group completed crypto-ops") > Cc: konstantin.ananyev@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Bruce Richardson > --- > lib/ipsec/rte_ipsec_group.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/ipsec/rte_ipsec_group.h b/lib/ipsec/rte_ipsec_group.h > index 60ab297710..62c2bd7217 100644 > --- a/lib/ipsec/rte_ipsec_group.h > +++ b/lib/ipsec/rte_ipsec_group.h > @@ -49,10 +49,10 @@ rte_ipsec_ses_from_crypto(const struct rte_crypto_op = *cop) >=20 > if (cop->sess_type =3D=3D RTE_CRYPTO_OP_SECURITY_SESSION) { > ss =3D cop->sym[0].sec_session; > - return (void *)(uintptr_t)ss->opaque_data; > + return (struct rte_ipsec_session *)(uintptr_t)ss->opaque_data; > } else if (cop->sess_type =3D=3D RTE_CRYPTO_OP_WITH_SESSION) { > cs =3D cop->sym[0].session; > - return (void *)(uintptr_t)cs->opaque_data; > + return (struct rte_ipsec_session *)(uintptr_t)cs->opaque_data; > } > return NULL; > } > -- Acked-by: Konstantin Ananyev > 2.32.0