From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B875A09E4; Thu, 22 Apr 2021 13:29:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7754741D23; Thu, 22 Apr 2021 13:29:12 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id A638541A53 for ; Thu, 22 Apr 2021 13:29:10 +0200 (CEST) IronPort-SDR: uGPJJUEqgcGgGS6G3BA5LFkby6Azc/ZTSrZRwIt9YamFkE3+VhZjAdkq3EfuatUPdnwQ3D/YcS vDQ8N2JF69vg== X-IronPort-AV: E=McAfee;i="6200,9189,9961"; a="195898322" X-IronPort-AV: E=Sophos;i="5.82,242,1613462400"; d="scan'208";a="195898322" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2021 04:29:08 -0700 IronPort-SDR: 1Ra8oefw5fhIwCiqJudHueCNRQyFLgleFGluFrE+1jvbxkQUVcmGXYgFPmC/4J9EpsSHc7q3nb RkVkWNJMWMcA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,242,1613462400"; d="scan'208";a="421342566" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 22 Apr 2021 04:29:08 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 22 Apr 2021 04:29:07 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 22 Apr 2021 04:29:07 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 22 Apr 2021 04:29:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P5ALLgODL4oh7diPBWfoy2NCfnjL6MdS9fah9efsVza3on48CvZpm2mtlZUIsMyMEziDIRjIJ7v+VR0/3Lcijq+jr0CeosNbqxMjA6tyje38ky0SfjBisq4iUBvXQs2Ne6ukTE/vYlu31peHmqtpBp1v0xNhBCe1wdLQs97bC5N0lGF5HgUlEuJKdIsbR9iXy/QzKRST5/pPisw8WtWoeVlplJQ3rAVeSnckjstJ3TP4mc8xxZ8ccYxHUtzB0TFHRdbVaGynYazDTzaiovaCqdQzK6T5esMCrkNxoAVNMH7pWPDFl59N9WMTkkktEV2X6HJDJoPuaqLutxPpjUDRiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8WkDT2xy6vnwS7KjkfyMP711p+VSylJ+1PskMj6usAg=; b=gltmEcMOcD35pKt7DBATWhtyagVa4lMit9NniVi7QzQMcDqN4mt8B+m4TdOLKX/4zes6969AVfO1WMJKQ1d+Hc7nifclALEs+DonT1H6VUN5uTweKPOxfOGhm7u+j8+TTkpchu8K+1zSA8u3XELNzKFYATO6ZM9PnIysBYFtRE6ABA4vpnQ1G1CiEuOX2ZIfVr1PDu9sz/1GtovUuoxYcPZgtPQz1XOkAB03w+tGdHW5itJLynZ42FiXa7UJvkIzpotAyrpvhxHn93gg7GrPzTE97XEPgr2AAxSnz51yosvQvP4N4/VDm9fe2M6IFuj9nIrQcMqwlTizWVV1PzreUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8WkDT2xy6vnwS7KjkfyMP711p+VSylJ+1PskMj6usAg=; b=b0/T2zdTRCNAHlidnHuDABpKrKj+q0rawLwSIEzhRGXupFwGXMQJyTw8ZdApAvkVeVUWOoExn4l4Hiy5ZoUSITip2f7VWbPdtdklfsb0b5GFkeh2n1GbX/Opx1CYLabHFNs6ukM3VGKr+lwrT+193Vuvs0mEduyXeC9BIza+TiI= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM6PR11MB4012.namprd11.prod.outlook.com (2603:10b6:5:6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.19; Thu, 22 Apr 2021 11:29:01 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::15ed:b4f4:540e:ea0c]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::15ed:b4f4:540e:ea0c%7]) with mapi id 15.20.4065.022; Thu, 22 Apr 2021 11:29:01 +0000 From: "Ananyev, Konstantin" To: "Min Hu (Connor)" , "Ananyev, Konstantin" , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [PATCH] bpf: delete meaningless code Thread-Index: AQHXNqJ0nyVe86DFFUqQsZJAWhc106q+2V4ggAAF4YCAAYfmcA== Date: Thu, 22 Apr 2021 11:29:01 +0000 Message-ID: References: <1619004925-58869-1-git-send-email-humin29@huawei.com> <645182d8-0ed4-185f-1f72-c96ae82e34e8@huawei.com> In-Reply-To: <645182d8-0ed4-185f-1f72-c96ae82e34e8@huawei.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.255.184.192] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0e5e9602-0c98-4724-852e-08d90581d41b x-ms-traffictypediagnostic: DM6PR11MB4012: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:192; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c0qzhsF25PEmDYX4k7+v5giN1fwjOjocWA9dRjLp93Wykkjtr5lrgATy7vQ0lxDt5m8gdoBhEEgEvqD3FHnqpHvIsQOIEYWPZ1lm2YR8QP+P7RCisj/7WVFIJ4vXOjmtP1WcxSEbo73DxMiCSgsSGFgHO9ZX+T39HPYYYP5Kv1N6WfJZ1i7sVrlD1lJvCdf6gmUWQLsosUzBb7bU7c60qUBfXvOI8xRXJtQOXFMUqDAPAcDxE1ugbDAkHZ99EFVFwDxjGceHd32YnvKkPX8pTL96kvxfq7Lz3Eb7OX5OUMrulGzkvPQtH34yA1thFH7a9Xf2UKvNN0vDCnXYGDb8xmc58W4lEFE1jYPxjyj2PwEQ4nTpiWJlcMuAMEunMpfJZXbyWroyELCyhIdG47GqpizxZy2zK9PxeTtPouBFN4/Hp6ZMmRLv7ACmrdwVWC2vw3zMyNxCNIj+yMqWOcSUYMUEq77vlI07jDJOEveyWYpdtBEPm1W8YZC2HrrOY8Jhsz4LJsiu6ABMD3qJSiaCl/et+ZNxApZoStD1audCqV45dAzTOAAtaaUR5Skveqgyy2dng+A5WuwmRALMR77YaLmrW1X5JcJ+1XH/bez2Fv8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(396003)(39860400002)(376002)(346002)(366004)(9686003)(33656002)(7696005)(64756008)(186003)(26005)(107886003)(316002)(83380400001)(55016002)(8936002)(8676002)(86362001)(4326008)(71200400001)(55236004)(6506007)(110136005)(478600001)(2906002)(66446008)(38100700002)(66946007)(76116006)(66556008)(5660300002)(66476007)(52536014)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-2022-jp?B?L2FjZHpTM1hJbVJ3NWNyZEp3R1pVUm9nb1BMOEdDazlvem8wcmZSSzJ6?= =?iso-2022-jp?B?dk1tVVk3YmdiZ1lIWjZvNkUvL1ZRZ3FNU0NESm9UN1ZoTWNNaVM3c250?= =?iso-2022-jp?B?TXZET2hRQlQrMnIrYkNpSm54WTl0OGtrWVY1c2V4amdOc1paUzB1aUt6?= =?iso-2022-jp?B?a1pRbnN0WWxKb25DUGhJZE9XanJsc2xjWjJpa2NVSEM1V2NWVnd4cjlV?= =?iso-2022-jp?B?dW1FRUNFNUl0YXYyU21XekRHcjNEOVVYOEdXQkE4RDhhcGZuZU9LZXl3?= =?iso-2022-jp?B?TTE1bVNUakNjVkFrQU9QWmsrK283ZkwrbU13Y2JFOHBwdGhPTXh3RFA5?= =?iso-2022-jp?B?SWZkRU5kYVM1aUVvSTJVaUF6UFRqc2FNZGQzLy9JQlB5Q2hZUkpWWHhV?= =?iso-2022-jp?B?N1hlNWJGNyt1bE5YTk9qVzNBK2NHcDZPVTBERGhFM2dhRTczbHVXYVh4?= =?iso-2022-jp?B?RHZPMk1pWUR1M1JFUFRnVFRWaEdmbEdPL2xTT005Z1ZUWHNxNXFaaVV4?= =?iso-2022-jp?B?QlpBNXMwZ3lNWnc1bE5Bc21sR0pvcjBtbWtRZDg1eTJ2TnZrLzIwZnUv?= =?iso-2022-jp?B?MnNHcVUyWnpUeGNlamZGbXEzbTJPdTgyL0MzSmM5bE1XNG5JUHRtODVZ?= =?iso-2022-jp?B?V01zQXF5MEZMZzFMSGFYQnJQcUxFcXVzejlJQ3ZuNEVZcVVkWWxIVS95?= =?iso-2022-jp?B?Y1MrUTVYUUFRRlRMd3M1dEJ1dTMzZHhWS2liLzJlSHBLd2ZkWGdOUmw5?= =?iso-2022-jp?B?NVNMMnB3N0VMMmtQNjR1RXVINThOa2pqaStENnZqeTZsQ0FQUnV5T3NH?= =?iso-2022-jp?B?dFowUE5uK0MrQzk4SXk1RFZ3Y2ZPM2hNcndGYjdsM0ZYK1hTanZvMzFF?= =?iso-2022-jp?B?N25TMENQUmVUaUh1WXI4emZxYU90c29zV2gzY0Nxc3gyb2dWbHhxOGVP?= =?iso-2022-jp?B?TWtmMUkvRVFSeUhsYjU1NXJtYi80ZnZHM3E3UzlvbFk5bmhuejhzTXkx?= =?iso-2022-jp?B?Z0JsN0dBVFlDL2VEQlNwaWVWMEMwOGRacjhWM3gvY2JLalNDZ09VaG5w?= =?iso-2022-jp?B?Tzd1WEt6S1Jlck13elV4UGcraU9UdUVBTVNHak9meVB6YnRVYy9OQVhN?= =?iso-2022-jp?B?Qmc3QUp1QzczaVZGTW9aMXM2alY1aTlNVkNlTkNKMm13eDRRbXZsVktY?= =?iso-2022-jp?B?TERSVWNHS0Fac3ZKbEVIc09DVGVoTDdoam11K1ErMTlFNE9zbUFRN1Zr?= =?iso-2022-jp?B?UXpQOGI3d3NGMERiRXI4dnNJVnk2R0FacVc1OWZNeXNhYzNUYUpMaDVT?= =?iso-2022-jp?B?UlBqN2hIRXVzSHp1a3pHOUt0em5IZ3l2NmNvclZ6azZ4aThHWUlXWEs2?= =?iso-2022-jp?B?enh6RWNQTlVRRTVTU0FjTExHY0dqRjVTQ0FYMlV6UlM0VXRKTGl5c0Zz?= =?iso-2022-jp?B?Y1QvRHVXZWhwQnFkZGF0RlRnMFNmd3JaTjlESlhseG9VMU1nd2xKWC9p?= =?iso-2022-jp?B?WVlKd2ZmV0p2cmhPYVM5aUZwVmROOGFFTHNnRFY1QlhRVlIybWZIZ2Ji?= =?iso-2022-jp?B?MWhpQ0o5RVhxYWIrL2hZQmVaZm9PWkIrRVpJSFY4UzVzNXdwOWkyOGFK?= =?iso-2022-jp?B?SkU0bmdvRXJwWGcyMHRBR3NkQ2JFWmsvbFlNT3FDWWx4TFF1b2t6Nmtx?= =?iso-2022-jp?B?bU1YZ21lSGpzcGY3ckU5eFc4ZDJIWWMrSkVPanVKVStxY0Z3STZrT1Fv?= =?iso-2022-jp?B?Y0M1d2UzTmtLSkJrWEkxaE9udVlwME12dHlqL2VQd0NkRmUwUXRjbkFN?= =?iso-2022-jp?B?WW0zOHB6Y1BPdjhZRTloOTVmc043RnFpOW9IMEVjWU5FNHMvUGcrRWI0?= =?iso-2022-jp?B?Z3ArcnFET01xZ1VIWm5oRHRhSS9jSnM3R2J4d0ZLSkViVXRBZ3NES2VI?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e5e9602-0c98-4724-852e-08d90581d41b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2021 11:29:01.5919 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j4RbhG/EELvKaJY17vFMdFrMHeJTQuRSWhHtEt/FMaFfmXiRxf7jdRSHYUN/5io2JZBffWsYAdGtg51hR1WJ6OKqFQe4lqs984HR8O4dTC0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4012 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] bpf: delete meaningless code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" =20 >=20 > =1B$B:_=1B(B 2021/4/21 19:43, Ananyev, Konstantin =1B$B >> > >> 'rd->u.max =3D rd->u.max' is meaningless which should be deleted. > >> > >> This patch fixed it. > >> > >> Fixes: 8021917293d0 ("bpf: add extra validation for input BPF program"= ) > >> Cc: stable@dpdk.org > > > > As I remember, I did it on purpose. > > Some old (but still supported) version of clang complained > > about unitialized variable. >=20 > Well, how about like this ? > uint64_t tmp =3D rd->u.max; > if (op =3D=3D BPF_MOD) > tmp =3D RTE_MIN(tmp, tmp - 1); > rd->u.max =3D tmp; Then, I think it should be: tmp =3D RTE_MIN(tmp, rs->u.max - 1); Or just leave things as they are right now. Nothing is broken here. > > > >> Signed-off-by: Min Hu (Connor) > >> --- > >> lib/librte_bpf/bpf_validate.c | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/lib/librte_bpf/bpf_validate.c b/lib/librte_bpf/bpf_valida= te.c > >> index 9214f15..c5ad951 100644 > >> --- a/lib/librte_bpf/bpf_validate.c > >> +++ b/lib/librte_bpf/bpf_validate.c > >> @@ -517,8 +517,6 @@ eval_divmod(uint32_t op, struct bpf_reg_val *rd, s= truct bpf_reg_val *rs, > >> } else { > >> if (op =3D=3D BPF_MOD) > >> rd->u.max =3D RTE_MIN(rd->u.max, rs->u.max - 1); > >> - else > >> - rd->u.max =3D rd->u.max; > >> rd->u.min =3D 0; > >> } > >> > >> -- > >> 2.7.4 > > > > . > >