From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B592A0C4E; Tue, 2 Nov 2021 13:25:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5991B4069F; Tue, 2 Nov 2021 13:25:03 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id BBF6940689 for ; Tue, 2 Nov 2021 13:25:01 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10155"; a="317445121" X-IronPort-AV: E=Sophos;i="5.87,202,1631602800"; d="scan'208";a="317445121" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 05:24:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,202,1631602800"; d="scan'208";a="667092197" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga005.jf.intel.com with ESMTP; 02 Nov 2021 05:24:51 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 05:24:50 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 05:24:48 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 05:24:47 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 05:24:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cD0aI2x+SQzac2xj9zMqatQvMMmo0tf7S9IWcXmI0DycfpNpRE0zrxhoynDBjixzVB3VG5ZXm6YBayS4a4hctWI+iF7bzDUnYVdDf6S7PIyTPfHUHmA8Zz6bqsJ1I2UzTUYvcZIhaS9B4e41/FuzeqBXy68OhfuzBX4gJ5vNkZ5vC8KQy1m5Z1OVTjplB+wPbZSN0NMQOxPMaIBg9HLYzn0nP5xQs87GgwChGsuC5zc+0lKBdMdAdicNwcEYowmoFpfivCJduUX7Iv4XafsNECUwxiUMiNKbSam4nQLJvf7qfSy2+KRN0eI6mtdcKfz60yTrdP9rybdrMuBGxijOYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SoWEyOjvwcdhfkpfs/q1co3T+s9Z4d7uqc2gN8Tz6Gg=; b=SwW55Kw6AH9CSgwJRkUFV5zguwJkp0nMfYwsL6Kzte0g20U5NjuvLmMG92dhEFaIijtQ+rZg5abOpvwREnPpzrSloJt9gtbFFbiuV1YiDLwwT7SAa6mKdEw3dmO2cVNhODutTw2TXiMMN01XwKgR8TJb1jZPWHFXyJzrkbBvK9zpxs8h5YVDSmYk4SijoslEpcE9Fvo6L7G5qt2ixtjgVtsqUZn/GO1LYfSan6aoq/MhQXHTVmoajRjiCqJPiGhupGh4JMRT4QAiklxF272z3ShGQCWIp38terbYdmQttIDGr86+PaxN3xoBgnlxQE+0acjapGR1sNvtAw4RlqGu2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SoWEyOjvwcdhfkpfs/q1co3T+s9Z4d7uqc2gN8Tz6Gg=; b=fnhnTg8+5mdmzNwA1oFV8N5QQAW31+R5N9QPb5M9cUORkLkLNvFL7ZmD5WD4mZEQnlP4HJ/FB5JExLEJVuHpDAQ9njd1TpAEY5s3ck/r6KqVq/gaUUIHSM6lfKJROjoGl8KJU8LTZ5b9m9E5f4Myom42UkfpqL4O3fIg2lymRdQ= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM5PR11MB2041.namprd11.prod.outlook.com (2603:10b6:3:d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Tue, 2 Nov 2021 12:24:43 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::2c0c:5383:f814:3b4e]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::2c0c:5383:f814:3b4e%6]) with mapi id 15.20.4649.019; Tue, 2 Nov 2021 12:24:43 +0000 From: "Ananyev, Konstantin" To: "Richardson, Bruce" CC: Ben Magistro , "dev@dpdk.org" Thread-Topic: [dpdk-dev] Overriding rte_config.h Thread-Index: AQHXzMu96w1iPybAWkKNztL+Glx606vuybQAgAFNvBCAABNzgIAAAhtQ Date: Tue, 2 Nov 2021 12:24:43 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8de4fc69-6e06-40a5-6c18-08d99dfbc028 x-ms-traffictypediagnostic: DM5PR11MB2041: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VC+t1/58A4m/3iS3LGALjbi7KWYdE5tkxhQvWeo23c04uk4cbwmTE+6HVNOW+hpyei0sTfGtoUY2P5qDQiL/VM+lbdOlgPoAE+3wB4klGMe/4pNQXz3oyLRTcxgMNJj9tLpx255939dZYiysSYrcbceCaMXqn/7YoD0Fm32E5RaFJ8FO/UAWQxUjDsKXfgPkrsHdNTSxfOzvDOF+bFi3qyDZKxdWxAYeCBgwjJSAfkT6VdxWxb2+KxI8NFhPMHm+TIKKlUcCDoL9NPnd3SC9UgU26YUv0Bv5/vsIdEMrZ22D6nhDHiONrBgHXqFMQ1b6giwffEv/3XMjz24NSZEj+fSdiuhxU/85i6MxQqPv5ETtl//Vyxc30l8Yx+hktOWp6XShPDjS3YkKfBp5dZd71hWN8pWGQHNTDNNfXEkPL4/mZ3p7SJI9KgBCGEF1ObeHrAZfIcZvesreIuZLc0sQ7ueRT3RJXQCeSnSSa5EsUDu323MaNhFk37F1chuqIeh6RtrlQGq952kYlFDVmfJXvfsdtq4afcCxaIi69SMK5o5kAI8TTJV0K/t9z5yXmXrxHZOhoqkh3ZJl5n/cdTdXvpq8ibwq8BIyVWc5SwIiWE+ajQmt5CHMdziW/pNuDQOCdsNL+C3dQDtI5kDPusMp+1WR/Gndx55B+m4ABcKpVyAcg1w9s7GPqkekkfuF7ZCVWxxyMxGacjc6MpBIKqumEA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(26005)(52536014)(5660300002)(508600001)(2906002)(8936002)(55016002)(86362001)(6862004)(66476007)(8676002)(6506007)(33656002)(55236004)(4326008)(66946007)(64756008)(316002)(54906003)(83380400001)(38100700002)(66556008)(122000001)(76116006)(6636002)(71200400001)(7696005)(82960400001)(38070700005)(9686003)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o1VRUQvrBWXVPoDuOYADtXgWYjrDmQpuvWF6E1AXb1stTXVZf7/vksGw21F0?= =?us-ascii?Q?PH15lGa++tBPl4MPrnRiuKn6DWjXNFoIDNy5naX/A9c97bxixpapuhC9rDDW?= =?us-ascii?Q?LUdKmVEeCnHaKuMozXlRLx9uL9o+2flSuLrlTKPDQr96wH9tP6sKzuO99+qU?= =?us-ascii?Q?2s1jvjxpDiAPaUfvTn8+7j1+3R412K9lohsCeYTULtgKCpp3tLaSuydZBYt4?= =?us-ascii?Q?zhkDD6shJ7KauS00FN8VWRWXYpujlFHpLPWMUMrkhtmjugiCrnkx1TqVC0C5?= =?us-ascii?Q?El5vkurkRLQBUPs3eIDWcqrsG0lbZTAyr366msnME5EoMXRYnTqXGihPJtBW?= =?us-ascii?Q?PjEFelbgO4fzbqlUbFRVqW4dd0vLS9O2Q7LZsignDkk7/jNV41FQ68oPzfV+?= =?us-ascii?Q?Jed98xK2IqBvkGKagvAkvHfoWwLpgzi9lEKENR5GC71C/PSoYxoaNQyCuPZf?= =?us-ascii?Q?4ODtgtC6KhrykHqAQWCkGoOUkpo0u+B29Ji6fLBUJrTYGI3bNtuDFJ1CrI8f?= =?us-ascii?Q?HHSVWKo9FHMF3Oa1h5b2J6+WcwztaOzXBMciY5pq7xivg5nROv1jnNXFbvNF?= =?us-ascii?Q?cV4y34ztjBVj5DfU88YtyzyL+QG65f6yEZ4T6ldrCvBuY0XeiHRnWCc75oI+?= =?us-ascii?Q?bdOioqGhRDWs2gHArQaxjciiTk02oVP8B5s/NBa1xi5MUmR9+LuYuWa74gbs?= =?us-ascii?Q?Lfnr3v1OyWYsaPTENFK8XUYMN/3f6dHmastuE1iJK5/AcObiEHa01uirkhq2?= =?us-ascii?Q?EEEG288IwHUZctv8BUEckPRDjPJJcqUci2vPM6SghNq+0C4ymO0eCMsDhfRt?= =?us-ascii?Q?mEH11AVV54zquF+U6p7U6Kb+zrB68mTNoOajy43F9VgrRxfQ29hB5S2x3kk/?= =?us-ascii?Q?YgNIFa/ed9EnfYT4Zj48k5mkh3Jxl/TS28Cko+11aMASVAfw/mqkx1UzoZ0o?= =?us-ascii?Q?aeZ4Gt/v8AyBoyTq5lsPdHLzdPmfH5T8i7fKbD5yy09BfhyCCgJz+XLIgIHd?= =?us-ascii?Q?pJ82333nPGfYo7f42IJhjiuc0rKFfny6+APUh3ha7wndfBbcsixqL8fBwA+z?= =?us-ascii?Q?P78bdLsE3zvUzK4UJTXhUdV4+OBh7A0RNMncPMojMeb9a339PE2iUPfFjaq6?= =?us-ascii?Q?+U2yUYR9VJSedu+tH4jus9Aw8MFWsFG8CgDsBBKOrNjHq4vzHmucRqSCBw68?= =?us-ascii?Q?sZvJ+q9T2gFkFYAa/jlo6BpP7hsF44FM6DS4iQWl2jE6Dou/UVEFA3FcZ5uL?= =?us-ascii?Q?pJpyhqLykuQHzrGbU7IzBJEf0osL7SH36Emz63UOAQpLdR7FMLlML/gLw6uj?= =?us-ascii?Q?g5gV7fxbr/MK6BQpoUDYLLrxN6Z+8CdJkXKOImyPsHtj4fG/QWw4ygqQfeRn?= =?us-ascii?Q?3+oXSsEUsGdFc0BOM719lDA9a2aaMjyDsxqE5fll8UhgMl+/bbPv4y1JpA26?= =?us-ascii?Q?ZogkrgulzWctkVOdexPjZRh0rUPKGJJsT8okLH6JjAUrGWFgINGZSoI6N2X2?= =?us-ascii?Q?7CngnxwNiPx6aYg2kgp8n76RL9pdU5Sa1aKom+KEUG9EeAeV2dwuZTUF9I6C?= =?us-ascii?Q?kdhylS750bUKxtIZiVEPOtn5s5FGQdVfjwyUZQErLRrn32M5uVThX/ZN78N1?= =?us-ascii?Q?MPFvySryIB5l4Ea+b5E2JmP9CFVzM8GsXSZPbfNZv7B4IiOM2uCzAFYZ5W7t?= =?us-ascii?Q?VRH3rA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8de4fc69-6e06-40a5-6c18-08d99dfbc028 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 12:24:43.4873 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OBXyHShm6R9H5kXOzQy6p7SFJryaGo6yDQ+l79PZVJL2wfKiVXCY+YoNd1VFN9CIYYL32ZebNH+HlcO1Tyu7BgAaKX6dPQj1Wgksa2dTAaM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB2041 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] Overriding rte_config.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > On Fri, Oct 29, 2021 at 09:48:30AM -0400, Ben Magistro wrote: > > > > With the transition to meson, what is the best way to provide custo= m values > > > > to parameters in rte_config.h? When using makefiles, (from memory,= I > > > > think) we used common_base as a template that was copied in as a > > > > replacement for defconfig_x86.... Our current thinking is to apply= a > > > > locally maintained patch so that we can track custom values easier = to the > > > > rte_config.h file unless there is another way to pass in an overrid= den > > > > value. As an example, one of the values we are customizing is > > > > IP_FRAG_MAX_FRAG. > > > > > > > > Cheers, > > > > > > > There is no one defined way for overriding values in rte_config with = the > > > meson build system, as values there are ones that should rarely need = to be > > > overridden. If it's the case that one does need tuning, we generally = want > > > to look to either change the default so it works for everyone, or > > > alternatively look to replace it with a runtime option. > > > > > > In the absense of that, a locally maintained patch may be reasonable.= To > > > what value do you want to change MAX_FRAG? Would it be worth consider= ing as > > > a newer default value in DPDK itself, since the current default is fa= irly > > > low? > > > > That might be an option, with IP_FRAG_MAX_FRAG=3D=3D8 it should be able > > to cover common jumbo frame size (9K) pretty easily. > > As a drawback default reassembly table size will double. >=20 > Maybe not. I'm not an expert in the library, but it seems the basic struc= t > used for tracking the packets and fragments is "struct ip_frag_pkt". Due = to > the other data in the struct and the linked-list overheads, the actual si= ze > increase when doubling MAX_FRAG from 4 to 8 is only 25%. According to gdb > on my debug build it goes from 192B to 256B. Ah yes, you right, struct ip_frag should fit into 16B, key seems the bigges= t one.=20 >=20 > > Even better would be to go a step further and rework lib/ip_frag > > to make it configurable runtime parameter. > > > Agree. However, that's not as quick a fix as just increasing the default > max segs value which could be done immediately if there is consensus on i= t. You mean for 21.11? I don't mind in principle, but would like to know other people thoughts her= e. Another thing - we didn't announce it in advance, and it is definitely an = ABI change.=20